Clear Color Support for TGL Render Decompression
v4 cover Clear Color Support for TGL Render Decompression
Support for Clear Color is contained in the last two patches submitted by Radhakrishna Sripada. The first 8 patches are currently undergoing review/revision changes. The first 8 patches are cherry-picked from the series
https://patchwork.freedesktop.org/series/67078/
Expecting feedback for the last 2 patches. The series is tested with kms_cube and custom Mesa branch by Nanley.
Dhinakaran Pandiyan (8):
drm/framebuffer: Format modifier for Intel Gen-12 render compression drm/i915: Use intel_tile_height() instead of re-implementing drm/i915: Move CCS stride alignment W/A inside
intel_fb_stride_alignment
drm/i915/tgl: Gen-12 render decompression
drm/i915: Extract framebufer CCS offset checks into a function drm/framebuffer: Format modifier for Intel Gen-12 media compression drm/fb: Extend format_info member arrays to handle four planes Gen-12 display can decompress surfaces compressed by the media engine.
Radhakrishna Sripada (2):
drm/framebuffer/tgl: Format modifier for Intel Gen 12 render
compression with Clear Color
drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression
drivers/gpu/drm/i915/display/intel_display.c | 434 ++++++++++++++---- .../drm/i915/display/intel_display_types.h | 5 +- drivers/gpu/drm/i915/display/intel_sprite.c | 70 ++- drivers/gpu/drm/i915/i915_reg.h | 14 + include/drm/drm_fourcc.h | 8 +- include/uapi/drm/drm_fourcc.h | 35 ++ 6 files changed, 452 insertions(+), 114 deletions(-)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 1/10 drm/framebuffer: Format modifier for Intel Gen-12 render compression
From: Dhinakaran Pandiyan <[email protected]>
Gen-12 has a new compression format, add a new modifier to indicate that.
--- include/uapi/drm/drm_fourcc.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/uapi/drm/drm_fourcc.h +11 -0
@@ -410,6 +410,17 @@ extern "C" {#define I915_FORMAT_MOD_Y_TILED_CCS fourcc_mod_code(INTEL, 4)#define I915_FORMAT_MOD_Yf_TILED_CCS fourcc_mod_code(INTEL, 5) +/* +* Intel color control surfaces (CCS) for Gen-12 render compression. +* +* The main surface is Y-tiled and at plane index 0, the CCS is linear and +* at index 1. A 64B CCS cache line corresponds to an area of 4x1 tiles in +* main surface. In other words, 4 bits in CCS map to a main surface cache +* line pair. The main surface pitch is required to be a multiple of four +* Y-tile widths. +*/ +#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS fourcc_mod_code(INTEL, 6) +/* * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks *
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 2/10 drm/i915: Use intel_tile_height() instead of re-implementing
In reply to Radhakrishna SripadaFrom: Dhinakaran Pandiyan <[email protected]>
intel_tile_dims() computes tile height using size and width, when there is already a function to do just that - intel_tile_height()
--- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display.c +1 -1
@@ -1955,7 +1955,7 @@ static void intel_tile_dims(const struct drm_framebuffer *fb, int color_plane,unsigned int cpp = fb->format->cpp[color_plane]; *tile_width = tile_width_bytes / cpp; - *tile_height =intel_tile_size (to_i915 (fb->dev)) / tile_width_bytes; + *tile_height =intel_tile_height (fb, color_plane); }unsigned int
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 3/10 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment
In reply to Radhakrishna SripadaFrom: Dhinakaran Pandiyan <[email protected]>
Easier to read if all the alignment changes are in one place and contained within a function.
--- drivers/gpu/drm/i915/display/intel_display.c | 31 ++++++++++---------- 1 file changed, 16 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +16 -15
@@ -2546,7 +2546,22 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane)else return 64 ; }else { -return intel_tile_width_bytes (fb, color_plane); +u32 tile_width =intel_tile_width_bytes (fb, color_plane); + +/* +* Display WA #0531: skl,bxt,kbl,glk +* +* Render decompression and plane width > 3840 +* combined with horizontal panning requires the +* plane stride to be a multiple of 4. We'll just +* require the entire fb to accommodate that to avoid +* potential runtime errors at plane configuration time. +*/ +if (IS_GEN (dev_priv,9 ) &&is_ccs_modifier (fb->modifier) && + color_plane ==0 && fb->width >3840 ) + tile_width *=4 ; + +return tile_width; } }
@@ -15694,20 +15709,6 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, } stride_alignment =intel_fb_stride_alignment (fb, i); - -/* -* Display WA #0531: skl,bxt,kbl,glk -* -* Render decompression and plane width > 3840 -* combined with horizontal panning requires the -* plane stride to be a multiple of 4. We'll just -* require the entire fb to accommodate that to avoid -* potential runtime errors at plane configuration time. -*/ -if (IS_GEN (dev_priv,9 ) && i ==0 && fb->width >3840 && -is_ccs_modifier (fb->modifier)) - stride_alignment *=4 ; -if (fb->pitches[i] & (stride_alignment -1 )) {DRM_DEBUG_KMS ("plane %d pitch (%d) must be at least %u byte aligned\n" , i, fb->pitches[i], stride_alignment);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 4/10 drm/i915/tgl: Gen-12 render decompression
In reply to Radhakrishna SripadaFrom: Dhinakaran Pandiyan <[email protected]>
Gen-12 display decompression operates on Y-tiled compressed main surface. The CCS is linear and has 4 bits of metadata for each main surface cache line pair, a size ratio of 1:256. Gen-12 display decompression is incompatible with buffers compressed by earlier GPUs, so make use of a new modifier to identify gen-12 compression. Another notable change is that render decompression is supported on all planes except cursor and on all pipes. Start by adding render decompression support for [A,X]BGR888 pixel formats.
v2: Fix checkpatch warnings (Lucas)
v3:
Rebase, disable color clear, styling changes and modify intel_tile_width_bytes and intel_tile_height to handle linear CCS
--- drivers/gpu/drm/i915/display/intel_display.c | 85 ++++++++++++++++---- drivers/gpu/drm/i915/display/intel_sprite.c | 23 ++++-- drivers/gpu/drm/i915/i915_reg.h | 1 + 3 files changed, 84 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +68 -17
@@ -1909,6 +1909,10 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)if (color_plane ==1 )return 128 ;/* fall through */ +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +if (color_plane ==1 ) +return 64 ; +/* fall through */ case I915_FORMAT_MOD_Y_TILED :if (IS_GEN (dev_priv,2 ) ||HAS_128_BYTE_Y_TILING (dev_priv))return 128 ;
@@ -1942,8 +1946,15 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)static unsigned int intel_tile_height (const struct drm_framebuffer *fb,int color_plane) { -return intel_tile_size (to_i915 (fb->dev)) / -intel_tile_width_bytes (fb, color_plane); +switch (fb->modifier) { +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +if (color_plane ==1 ) +return 1 ; +/* fall through */ +default : +return intel_tile_size (to_i915 (fb->dev)) / +intel_tile_width_bytes (fb, color_plane); + } }/* Return the tile dimensions in pixel units */
@@ -2042,6 +2053,8 @@ static unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,if (INTEL_GEN (dev_priv) >=9 )return 256 *1024 ;return 0 ; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +return 16 *1024 ;case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS:case I915_FORMAT_MOD_Y_TILED :
@@ -2238,7 +2251,8 @@ static u32 intel_adjust_tile_offset(int *x, int *y,static bool is_surface_linear (u64 modifier,int color_plane) { -return modifier ==DRM_FORMAT_MOD_LINEAR ; +return modifier ==DRM_FORMAT_MOD_LINEAR || + (modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS && color_plane ==1 ); } static u32 intel_adjust_aligned_offset(int *x, int *y,
@@ -2425,6 +2439,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)return I915_TILING_X ;case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Y_TILED_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :return I915_TILING_Y ;default :return I915_TILING_NONE ;
@@ -2445,7 +2460,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)* us a ratio of one byte in the CCS for each 8x16 pixels in the * main surface. */ -static const struct drm_format_info ccs_formats[] = { +static const struct drm_format_info skl_ccs_formats[] = { { .format =DRM_FORMAT_XRGB8888 , .depth =24 , .num_planes =2 , .cpp = {4 ,1 , }, .hsub =8 , .vsub =16 , }, { .format =DRM_FORMAT_XBGR8888 , .depth =24 , .num_planes =2 ,
@@ -2456,6 +2471,24 @@ static const struct drm_format_info ccs_formats[] = { .cpp = { 4, 1, }, .hsub = 8, .vsub = 16, .has_alpha = true, }, }; +/* +* Gen-12 compression uses 4 bits of CCS data for each cache line pair in the +* main surface. And each 64B CCS cache line represents an area of 4x1 Y-tiles +* in the main surface. With 4 byte pixels and each Y-tile having dimensions of +* 32x32 pixels, the ratio turns out to 1B in the CCS for every 2x32 pixels in +* the main surface. +*/ +static const struct drm_format_info gen12_ccs_formats[] = { + { .format =DRM_FORMAT_XRGB8888 , .depth =24 , .num_planes =2 , + .cpp = {4 ,1 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_XBGR8888 , .depth =24 , .num_planes =2 , + .cpp = {4 ,1 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_ARGB8888 , .depth =32 , .num_planes =2 , + .cpp = {4 ,1 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, + { .format =DRM_FORMAT_ABGR8888 , .depth =32 , .num_planes =2 , + .cpp = {4 ,1 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, +}; +static const struct drm_format_info *lookup_format_info (const struct drm_format_info formats[],int num_formats,u32 format)
@@ -2476,8 +2509,12 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd)switch (cmd->modifier[0 ]) {case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS: -return lookup_format_info (ccs_formats, -ARRAY_SIZE (ccs_formats), +return lookup_format_info (skl_ccs_formats, +ARRAY_SIZE (skl_ccs_formats), + cmd->pixel_format); +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +return lookup_format_info (gen12_ccs_formats, +ARRAY_SIZE (gen12_ccs_formats), cmd->pixel_format);default :return NULL ;
@@ -2486,7 +2523,8 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd)bool is_ccs_modifier (u64 modifier) { -return modifier ==I915_FORMAT_MOD_Y_TILED_CCS || +return modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || + modifier ==I915_FORMAT_MOD_Y_TILED_CCS || modifier == I915_FORMAT_MOD_Yf_TILED_CCS; }
@@ -2531,8 +2569,9 @@ static u32 intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane) {struct drm_i915_private *dev_priv =to_i915 (fb->dev); +u32 tile_width; -if (fb->modifier ==DRM_FORMAT_MOD_LINEAR ) { +if (is_surface_linear (fb->modifier, color_plane)) {u32 max_stride =intel_plane_fb_max_stride (dev_priv, fb->format->format, fb->modifier);
@@ -2541,13 +2580,14 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane)* To make remapping with linear generally feasible * we need the stride to be page aligned. */ -if (fb->pitches[color_plane] > max_stride) +if (fb->pitches[color_plane] > max_stride && !is_ccs_modifier (fb->modifier))return intel_tile_size (dev_priv);else return 64 ; - }else { -u32 tile_width =intel_tile_width_bytes (fb, color_plane); + } + tile_width =intel_tile_width_bytes (fb, color_plane); +if (is_ccs_modifier (fb->modifier) && color_plane ==0 ) {/* * Display WA #0531: skl,bxt,kbl,glk *
@@ -2557,12 +2597,16 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane)* require the entire fb to accommodate that to avoid * potential runtime errors at plane configuration time. */ -if (IS_GEN (dev_priv,9 ) &&is_ccs_modifier (fb->modifier) && - color_plane ==0 && fb->width >3840 ) +if (IS_GEN (dev_priv,9 ) && fb->width >3840 ) + tile_width *=4 ; +/* +* The main surface pitch must be padded to a multiple of four +* tile widths. +*/ +else if (INTEL_GEN (dev_priv) >=12 ) tile_width *=4 ; - -return tile_width; } +return tile_width; }bool intel_plane_can_remap (const struct intel_plane_state *plane_state)
@@ -2671,6 +2715,7 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,int ccs_x, ccs_y;intel_tile_dims (fb, i, &tile_width, &tile_height); + tile_width *= hsub; tile_height *= vsub;
@@ -3963,7 +4008,7 @@ static unsigned int skl_plane_stride_mult(const struct drm_framebuffer *fb,* The stride is either expressed as a multiple of 64 bytes chunks for * linear buffers or in number of tiles for tiled buffers. */ -if (fb->modifier ==DRM_FORMAT_MOD_LINEAR ) +if (is_surface_linear (fb->modifier, color_plane))return 64 ;else if (drm_rotation_90_or_270 (rotation))return intel_tile_height (fb, color_plane);
@@ -4089,6 +4134,10 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)return PLANE_CTL_TILED_Y ;case I915_FORMAT_MOD_Y_TILED_CCS :return PLANE_CTL_TILED_Y |PLANE_CTL_RENDER_DECOMPRESSION_ENABLE ; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +return PLANE_CTL_TILED_Y | +PLANE_CTL_RENDER_DECOMPRESSION_ENABLE | +PLANE_CTL_CLEAR_COLOR_DISABLE ;case I915_FORMAT_MOD_Yf_TILED:return PLANE_CTL_TILED_YF ;case I915_FORMAT_MOD_Yf_TILED_CCS:
@@ -9850,7 +9899,9 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,case PLANE_CTL_TILED_Y : plane_config->tiling =I915_TILING_Y ;if (val &PLANE_CTL_RENDER_DECOMPRESSION_ENABLE ) - fb->modifier =I915_FORMAT_MOD_Y_TILED_CCS ; + fb->modifier =INTEL_GEN (dev_priv) >=12 ? +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +I915_FORMAT_MOD_Y_TILED_CCS ;else fb->modifier =I915_FORMAT_MOD_Y_TILED ;break ;
drivers/gpu/drm/i915/display/intel_sprite.c +15 -8
@@ -535,6 +535,7 @@ skl_program_plane(struct intel_plane *plane,const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;u32 surf_addr = plane_state->color_plane[color_plane].offset;u32 stride =skl_plane_stride (plane_state, color_plane); +u32 aux_dist = plane_state->color_plane[1 ].offset - surf_addr;u32 aux_stride =skl_plane_stride (plane_state,1 );int crtc_x = plane_state->base.dst.x1;int crtc_y = plane_state->base.dst.y1;
@@ -576,8 +577,10 @@ skl_program_plane(struct intel_plane *plane,I915_WRITE_FW (PLANE_STRIDE (pipe, plane_id), stride);I915_WRITE_FW (PLANE_POS (pipe, plane_id), (crtc_y <<16 ) | crtc_x);I915_WRITE_FW (PLANE_SIZE (pipe, plane_id), (src_h <<16 ) | src_w); -I915_WRITE_FW (PLANE_AUX_DIST (pipe, plane_id), - (plane_state->color_plane[1 ].offset - surf_addr) | aux_stride); + +if (INTEL_GEN (dev_priv) <12 ) + aux_dist |= aux_stride; +I915_WRITE_FW (PLANE_AUX_DIST (pipe, plane_id), aux_dist);if (icl_is_hdr_plane (dev_priv, plane_id)) {u32 cus_ctl =0 ;
@@ -1734,7 +1737,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state, (fb->modifier == I915_FORMAT_MOD_Y_TILED || fb->modifier == I915_FORMAT_MOD_Yf_TILED || fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS || - fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS)) { + fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS || + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS)) {DRM_DEBUG_KMS ("Y/Yf tiling not supported in IF-ID mode\n" );return -EINVAL ; }
@@ -2146,7 +2150,8 @@ static const u64 skl_plane_format_modifiers_ccs[] = {DRM_FORMAT_MOD_INVALID }; -static const u64 gen12_plane_format_modifiers_noccs[] = { +static const u64 gen12_plane_format_modifiers_ccs[] = { +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,
@@ -2308,6 +2313,7 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,case DRM_FORMAT_MOD_LINEAR :case I915_FORMAT_MOD_X_TILED :case I915_FORMAT_MOD_Y_TILED : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :break ;default :return false;
@@ -2318,6 +2324,9 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,case DRM_FORMAT_XBGR8888 :case DRM_FORMAT_ARGB8888 :case DRM_FORMAT_ABGR8888 : +if (is_ccs_modifier (modifier)) +return true; +/* fall through */ case DRM_FORMAT_RGB565 :case DRM_FORMAT_XRGB2101010 :case DRM_FORMAT_XBGR2101010 :
@@ -2526,13 +2535,11 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv, formats =skl_get_plane_formats (dev_priv, pipe, plane_id, &num_formats); + plane->has_ccs =skl_plane_has_ccs (dev_priv, pipe, plane_id);if (INTEL_GEN (dev_priv) >=12 ) { -/* TODO: Implement support for gen-12 CCS modifiers */ - plane->has_ccs = false; - modifiers = gen12_plane_format_modifiers_noccs; + modifiers = gen12_plane_format_modifiers_ccs; plane_funcs = &gen12_plane_funcs; }else { - plane->has_ccs =skl_plane_has_ccs (dev_priv, pipe, plane_id);if (plane->has_ccs) modifiers = skl_plane_format_modifiers_ccs;else
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -6702,6 +6702,7 @@ enum {#define PLANE_CTL_YUV422_VYUY (3 << 16)#define PLANE_CTL_RENDER_DECOMPRESSION_ENABLE (1 << 15)#define PLANE_CTL_TRICKLE_FEED_DISABLE (1 << 14) +#define PLANE_CTL_CLEAR_COLOR_DISABLE (1 << 13)/* TGL+ */ #define PLANE_CTL_PLANE_GAMMA_DISABLE (1 << 13)/* Pre-GLK */ #define PLANE_CTL_TILED_MASK (0x7 << 10)#define PLANE_CTL_TILED_LINEAR (0 << 10)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 5/10 drm/i915: Extract framebufer CCS offset checks into a function
In reply to Radhakrishna SripadaFrom: Dhinakaran Pandiyan <[email protected]>
intel_fill_fb_info() has grown quite large and wrapping the offset checks into a separate function makes the loop a bit easier to follow.
--- drivers/gpu/drm/i915/display/intel_display.c | 69 ++++++++++++-------- 1 file changed, 40 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +40 -29
@@ -2677,6 +2677,43 @@ static bool intel_plane_needs_remap(const struct intel_plane_state *plane_state)return stride > max_stride; } +static int +intel_fb_check_ccs_xy (struct drm_framebuffer *fb,int x,int y) +{ +struct intel_framebuffer *intel_fb =to_intel_framebuffer (fb); +int hsub = fb->format->hsub; +int vsub = fb->format->vsub; +int tile_width, tile_height; +int ccs_x, ccs_y; +int main_x, main_y; + +intel_tile_dims (fb,1 , &tile_width, &tile_height); + + tile_width *= hsub; + tile_height *= vsub; + + ccs_x = (x * hsub) % tile_width; + ccs_y = (y * vsub) % tile_height; + main_x = intel_fb->normal[0 ].x % tile_width; + main_y = intel_fb->normal[0 ].y % tile_height; + +/* +* CCS doesn't have its own x/y offset register, so the intra CCS tile +* x/y offsets must match between CCS and the main surface. +*/ +if (main_x != ccs_x || main_y != ccs_y) { +DRM_DEBUG_KMS ("Bad CCS x/y (main %d,%d ccs %d,%d) full (main %d,%d ccs %d,%d)\n" , + main_x, main_y, + ccs_x, ccs_y, + intel_fb->normal[0 ].x, + intel_fb->normal[0 ].y, + x, y); +return -EINVAL ; + } + +return 0 ; +} +static int intel_fill_fb_info (struct drm_i915_private *dev_priv,struct drm_framebuffer *fb)
@@ -2708,35 +2745,9 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv, }if (is_ccs_modifier (fb->modifier) && i ==1 ) { -int hsub = fb->format->hsub; -int vsub = fb->format->vsub; -int tile_width, tile_height; -int main_x, main_y; -int ccs_x, ccs_y; - -intel_tile_dims (fb, i, &tile_width, &tile_height); - - tile_width *= hsub; - tile_height *= vsub; - - ccs_x = (x * hsub) % tile_width; - ccs_y = (y * vsub) % tile_height; - main_x = intel_fb->normal[0 ].x % tile_width; - main_y = intel_fb->normal[0 ].y % tile_height; - -/* -* CCS doesn't have its own x/y offset register, so the intra CCS tile -* x/y offsets must match between CCS and the main surface. -*/ -if (main_x != ccs_x || main_y != ccs_y) { -DRM_DEBUG_KMS ("Bad CCS x/y (main %d,%d ccs %d,%d) full (main %d,%d ccs %d,%d)\n" , - main_x, main_y, - ccs_x, ccs_y, - intel_fb->normal[0 ].x, - intel_fb->normal[0 ].y, - x, y); -return -EINVAL ; - } + ret =intel_fb_check_ccs_xy (fb, x, y); +if (ret) +return ret; }/*
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 6/10 drm/framebuffer: Format modifier for Intel Gen-12 media compression
In reply to Radhakrishna SripadaFrom: Dhinakaran Pandiyan <[email protected]>
Gen-12 display can decompress surfaces compressed by the media engine, add a new modifier as the driver needs to know the surface was compressed by the media or render engine.
--- include/uapi/drm/drm_fourcc.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)
include/uapi/drm/drm_fourcc.h +13 -0
@@ -421,6 +421,19 @@ extern "C" {*/ #define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS fourcc_mod_code(INTEL, 6) +/* +* Intel color control surfaces (CCS) for Gen-12 media compression +* +* The main surface is Y-tiled and at plane index 0, the CCS is linear and +* at index 1. A 64B CCS cache line corresponds to an area of 4x1 tiles in +* main surface. In other words, 4 bits in CCS map to a main surface cache +* line pair. The main surface pitch is required to be a multiple of four +* Y-tile widths. For semi-planar formats like NV12, CCS plane follows the +* Y and UV planes i.e., planes 0 and 2 are used for Y and UV surfaces, +* planes 1 and 3 for the respective CCS. +*/ +#define I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS fourcc_mod_code(INTEL, 7) +/* * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks *
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 7/10 drm/fb: Extend format_info member arrays to handle four planes
In reply to Radhakrishna SripadaFrom: Dhinakaran Pandiyan <[email protected]>
addfb() uAPI has supported four planes for a while now, make format_info compatible with that.
--- include/drm/drm_fourcc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
include/drm/drm_fourcc.h +4 -4
@@ -78,7 +78,7 @@ struct drm_format_info {* triplet @char_per_block, @block_w, @block_h for better * describing the pixel format. */ -u8 cpp[3 ]; +u8 cpp[4 ];/** * @char_per_block:
@@ -104,7 +104,7 @@ struct drm_format_info {* information from their drm_mode_config.get_format_info hook * if they want the core to be validating the pitch. */ -u8 char_per_block[3 ]; +u8 char_per_block[4 ]; };/**
@@ -113,7 +113,7 @@ struct drm_format_info {* Block width in pixels, this is intended to be accessed through * drm_format_info_block_width() */ -u8 block_w[3 ]; +u8 block_w[4 ];/** * @block_h:
@@ -121,7 +121,7 @@ struct drm_format_info {* Block height in pixels, this is intended to be accessed through * drm_format_info_block_height() */ -u8 block_h[3 ]; +u8 block_h[4 ];/** @hsub: Horizontal chroma subsampling factor */ u8 hsub;
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 8/10 Gen-12 display can decompress surfaces compressed by the media engine.
In reply to Radhakrishna SripadaFrom: Dhinakaran Pandiyan <[email protected]>
Detect the modifier corresponding to media compression to enable display decompression for YUV and xRGB packed formats. A new modifier is added so that the driver can distinguish between media and render compressed buffers. Unlike render decompression, plane 6 and plane 7 do not support media decompression.
v2: Fix checkpatch warnings on code style (Lucas)
From DK:
Separate modifier array for planes that cannot decompress media (Ville)
v3: Support planar formats
--- drivers/gpu/drm/i915/display/intel_display.c | 237 +++++++++++++----- .../drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_sprite.c | 44 +++- drivers/gpu/drm/i915/i915_reg.h | 1 + 4 files changed, 220 insertions(+), 64 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +180 -57
@@ -1909,6 +1909,10 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)if (color_plane ==1 )return 128 ;/* fall through */ +case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +if (color_plane ==3 ) +return 64 ; +/* fall through */ case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :if (color_plane ==1 )return 64 ;
@@ -2251,8 +2255,16 @@ static u32 intel_adjust_tile_offset(int *x, int *y,static bool is_surface_linear (u64 modifier,int color_plane) { -return modifier ==DRM_FORMAT_MOD_LINEAR || - (modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS && color_plane ==1 ); +switch (modifier) { +case DRM_FORMAT_MOD_LINEAR : +return true; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +return color_plane ==1 ; +case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +return color_plane ==1 || color_plane ==3 ; +default : +return false; + } } static u32 intel_adjust_aligned_offset(int *x, int *y,
@@ -2440,6 +2452,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :return I915_TILING_Y ;default :return I915_TILING_NONE ;
@@ -2487,6 +2500,10 @@ static const struct drm_format_info gen12_ccs_formats[] = { .cpp = { 4, 1, }, .hsub = 2, .vsub = 32, .has_alpha = true }, { .format = DRM_FORMAT_ABGR8888, .depth = 32, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 2, .vsub = 32, .has_alpha = true }, + { .format = DRM_FORMAT_YUYV, .num_planes = 2, + .cpp = { 2, 1, }, .hsub = 4, .vsub = 32, .is_yuv = true }, + { .format = DRM_FORMAT_NV12, .num_planes = 4, + .cpp = { 1, 1, 2, 1}, .hsub = 2, .vsub = 2, .is_yuv = true }, }; static const struct drm_format_info *
@@ -2524,6 +2541,7 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd)bool is_ccs_modifier (u64 modifier) {return modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || + modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || modifier ==I915_FORMAT_MOD_Y_TILED_CCS || modifier == I915_FORMAT_MOD_Yf_TILED_CCS; }
@@ -2587,7 +2605,7 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane) } tile_width =intel_tile_width_bytes (fb, color_plane); -if (is_ccs_modifier (fb->modifier) && color_plane ==0 ) { +if (is_ccs_modifier (fb->modifier)) {/* * Display WA #0531: skl,bxt,kbl,glk *
@@ -2597,7 +2615,7 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane)* require the entire fb to accommodate that to avoid * potential runtime errors at plane configuration time. */ -if (IS_GEN (dev_priv,9 ) && fb->width >3840 ) +if (IS_GEN (dev_priv,9 ) && color_plane ==0 && fb->width >3840 ) tile_width *=4 ;/* * The main surface pitch must be padded to a multiple of four
@@ -2677,25 +2695,71 @@ static bool intel_plane_needs_remap(const struct intel_plane_state *plane_state)return stride > max_stride; } +static void +intel_fb_plane_get_subsampling (int *hsub,int *vsub,const struct drm_framebuffer *fb,int color_plane) +{ +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ) { +static const struct { +int cpp[4 ]; +int vsub[4 ]; +int hsub[4 ]; + } mc_ccs_subsampling = {.cpp = {1 ,1 ,2 ,1 }, .hsub = {1 ,8 ,2 ,16 }, .vsub = {1 ,32 ,2 ,32 } }; + + *hsub = mc_ccs_subsampling.hsub[color_plane]; + *vsub = mc_ccs_subsampling.vsub[color_plane]; + }else { + *hsub = fb->format->hsub; + *vsub = fb->format->vsub; + } +} + +static void +intel_fb_plane_dims (int *w,int *h,struct drm_framebuffer *fb,int color_plane) +{ +int hsub, vsub; + +intel_fb_plane_get_subsampling (&hsub, &vsub, fb, color_plane); + *w = fb->width / hsub; + *h = fb->height / vsub; +} + +static bool is_ccs_plane (u64 modifier,int color_plane) +{ +if (!is_ccs_modifier (modifier)) +return false; +else if (modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ) +return color_plane ==3 || color_plane ==1 ; +else +return color_plane ==1 ; +} +static int -intel_fb_check_ccs_xy (struct drm_framebuffer *fb,int x,int y) +intel_fb_check_ccs_xy (struct drm_framebuffer *fb,int color_plane,int x,int y) {struct intel_framebuffer *intel_fb =to_intel_framebuffer (fb); -int hsub = fb->format->hsub; -int vsub = fb->format->vsub; +int hsub, vsub; +int hsub_main, vsub_main;int tile_width, tile_height;int ccs_x, ccs_y;int main_x, main_y; -intel_tile_dims (fb,1 , &tile_width, &tile_height); +if (!is_ccs_plane (fb->modifier, color_plane)) +return 0 ; + +intel_tile_dims (fb, color_plane, &tile_width, &tile_height); +intel_fb_plane_get_subsampling (&hsub, &vsub, fb, color_plane); +intel_fb_plane_get_subsampling (&hsub_main, &vsub_main, fb, color_plane -1 ); + + hsub /= hsub_main; + vsub /= vsub_main; tile_width *= hsub; tile_height *= vsub; ccs_x = (x * hsub) % tile_width; ccs_y = (y * vsub) % tile_height; - main_x = intel_fb->normal[0 ].x % tile_width; - main_y = intel_fb->normal[0 ].y % tile_height; + main_x = intel_fb->normal[color_plane -1 ].x % tile_width; + main_y = intel_fb->normal[color_plane -1 ].y % tile_height;/* * CCS doesn't have its own x/y offset register, so the intra CCS tile
@@ -2705,8 +2769,8 @@ intel_fb_check_ccs_xy(struct drm_framebuffer *fb, int x, int y)DRM_DEBUG_KMS ("Bad CCS x/y (main %d,%d ccs %d,%d) full (main %d,%d ccs %d,%d)\n" , main_x, main_y, ccs_x, ccs_y, - intel_fb->normal[0 ].x, - intel_fb->normal[0 ].y, + intel_fb->normal[color_plane -1 ].x, + intel_fb->normal[color_plane -1 ].y, x, y);return -EINVAL ; }
@@ -2734,8 +2798,7 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,int ret; cpp = fb->format->cpp[i]; - width =drm_framebuffer_plane_width (fb->width, fb, i); - height =drm_framebuffer_plane_height (fb->height, fb, i); +intel_fb_plane_dims (&width, &height, fb, i); ret =intel_fb_offset_to_xy (&x, &y, fb, i);if (ret) {
@@ -2744,11 +2807,9 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,return ret; } -if (is_ccs_modifier (fb->modifier) && i ==1 ) { - ret =intel_fb_check_ccs_xy (fb, x, y); -if (ret) -return ret; - } + ret =intel_fb_check_ccs_xy (fb, i, x, y); +if (ret) +return ret;/* * The fence (if used) is aligned to the start of the object
@@ -3360,6 +3421,7 @@ static int skl_max_plane_width(const struct drm_framebuffer *fb,return 5120 ;case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS: +case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :/* FIXME AUX plane? */ case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Yf_TILED:
@@ -3419,16 +3481,18 @@ static int icl_max_plane_height(void) }static bool skl_check_main_ccs_coordinates (struct intel_plane_state *plane_state, -int main_x,int main_y,u32 main_offset) +int main_x,int main_y,u32 main_offset, +int aux_plane) {const struct drm_framebuffer *fb = plane_state->base.fb; -int hsub = fb->format->hsub; -int vsub = fb->format->vsub; -int aux_x = plane_state->color_plane[1 ].x; -int aux_y = plane_state->color_plane[1 ].y; -u32 aux_offset = plane_state->color_plane[1 ].offset; -u32 alignment =intel_surf_alignment (fb,1 ); - +int hsub; +int vsub; +int aux_x = plane_state->color_plane[aux_plane].x; +int aux_y = plane_state->color_plane[aux_plane].y; +u32 aux_offset = plane_state->color_plane[aux_plane].offset; +u32 alignment =intel_surf_alignment (fb, aux_plane); + +intel_fb_plane_get_subsampling (&hsub, &vsub, fb, aux_plane);while (aux_offset >= main_offset && aux_y <= main_y) {int x, y;
@@ -3440,7 +3504,7 @@ static bool skl_check_main_ccs_coordinates(struct intel_plane_state *plane_state x = aux_x / hsub; y = aux_y / vsub; - aux_offset =intel_plane_adjust_aligned_offset (&x, &y, plane_state,1 , + aux_offset =intel_plane_adjust_aligned_offset (&x, &y, plane_state, aux_plane, aux_offset, aux_offset - alignment); aux_x = x * hsub + aux_x % hsub; aux_y = y * vsub + aux_y % vsub;
@@ -3449,9 +3513,9 @@ static bool skl_check_main_ccs_coordinates(struct intel_plane_state *plane_stateif (aux_x != main_x || aux_y != main_y)return false; - plane_state->color_plane[1 ].offset = aux_offset; - plane_state->color_plane[1 ].x = aux_x; - plane_state->color_plane[1 ].y = aux_y; + plane_state->color_plane[aux_plane].offset = aux_offset; + plane_state->color_plane[aux_plane].x = aux_x; + plane_state->color_plane[aux_plane].y = aux_y;return true; }
@@ -3525,7 +3589,7 @@ static int skl_check_main_surface(struct intel_plane_state *plane_state)* they match with the main surface x/y offsets. */ if (is_ccs_modifier (fb->modifier)) { -while (!skl_check_main_ccs_coordinates (plane_state, x, y, offset)) { +while (!skl_check_main_ccs_coordinates (plane_state, x, y, offset,1 )) {if (offset ==0 )break ;
@@ -3558,7 +3622,8 @@ static int skl_check_nv12_aux_surface(struct intel_plane_state *plane_state) {const struct drm_framebuffer *fb = plane_state->base.fb;unsigned int rotation = plane_state->base.rotation; -int max_width =skl_max_plane_width (fb,1 , rotation); +int uv =is_ccs_modifier (fb->modifier) ?2 :1 ; +int max_width =skl_max_plane_width (fb, uv, rotation);int max_height =4096 ;int x = plane_state->base.src.x1 >>17 ;int y = plane_state->base.src.y1 >>17 ;
@@ -3566,8 +3631,8 @@ static int skl_check_nv12_aux_surface(struct intel_plane_state *plane_state)int h =drm_rect_height (&plane_state->base.src) >>17 ;u32 offset; -intel_add_fb_offsets (&x, &y, plane_state,1 ); - offset =intel_plane_compute_aligned_offset (&x, &y, plane_state,1 ); +intel_add_fb_offsets (&x, &y, plane_state, uv); + offset =intel_plane_compute_aligned_offset (&x, &y, plane_state, uv);/* FIXME not quite sure how/if these apply to the chroma plane */ if (w > max_width || h > max_height) {
@@ -3576,9 +3641,41 @@ static int skl_check_nv12_aux_surface(struct intel_plane_state *plane_state)return -EINVAL ; } - plane_state->color_plane[1 ].offset = offset; - plane_state->color_plane[1 ].x = x; - plane_state->color_plane[1 ].y = y; +if (is_ccs_modifier (fb->modifier)) { +int aux_offset = plane_state->color_plane[3 ].offset; +int alignment =intel_surf_alignment (fb, uv); + +if (offset > aux_offset) { +int hsub, vsub; +int main_x = x, main_y = y; + +intel_fb_plane_get_subsampling (&hsub, &vsub, fb, uv); + x = main_x / hsub; + y = main_y / vsub; + offset =intel_plane_adjust_aligned_offset (&x, &y, plane_state, uv, + offset, + aux_offset & ~(alignment -1 )); + x = x * hsub + main_x % hsub; + y = y * vsub + main_y % vsub; + } + +while (!skl_check_main_ccs_coordinates (plane_state, x, y, offset,3 )) { +if (offset ==0 ) +break ; + + offset =intel_plane_adjust_aligned_offset (&x, &y, plane_state, uv, + offset, offset - alignment); + } + +if (x != plane_state->color_plane[3 ].x || y != plane_state->color_plane[3 ].y) { +DRM_DEBUG_KMS ("Unable to find suitable display surface offset due to CCS\n" ); +return -EINVAL ; + } + } + + plane_state->color_plane[uv].offset = offset; + plane_state->color_plane[uv].x = x; + plane_state->color_plane[uv].y = y;return 0 ; }
@@ -3588,19 +3685,30 @@ static int skl_check_ccs_aux_surface(struct intel_plane_state *plane_state)const struct drm_framebuffer *fb = plane_state->base.fb;int src_x = plane_state->base.src.x1 >>16 ;int src_y = plane_state->base.src.y1 >>16 ; -int hsub = fb->format->hsub; -int vsub = fb->format->vsub; -int x = src_x / hsub; -int y = src_y / vsub;u32 offset; +int ccs; -intel_add_fb_offsets (&x, &y, plane_state,1 ); - offset =intel_plane_compute_aligned_offset (&x, &y, plane_state,1 ); - plane_state->color_plane[1 ].offset = offset; - plane_state->color_plane[1 ].x = x * hsub + src_x % hsub; - plane_state->color_plane[1 ].y = y * vsub + src_y % vsub; +for (ccs =1 ; ccs < fb->format->num_planes; ccs +=2 ) { +int hsub, vsub; +int main_hsub, main_vsub; +int x, y; + +intel_fb_plane_get_subsampling (&hsub, &vsub, fb, ccs); +intel_fb_plane_get_subsampling (&main_hsub, &main_vsub, fb, ccs -1 ); + hsub /= main_hsub; + vsub /= main_vsub; + x = src_x / hsub; + y = src_y / vsub; + +intel_add_fb_offsets (&x, &y, plane_state, ccs); + offset =intel_plane_compute_aligned_offset (&x, &y, + plane_state, ccs); + plane_state->color_plane[ccs].offset = offset; + plane_state->color_plane[ccs].x = x * hsub + src_x % hsub; + plane_state->color_plane[ccs].y = y * vsub + src_y % vsub; + }return 0 ; }
@@ -3608,6 +3716,7 @@ int skl_check_plane_surface(struct intel_plane_state *plane_state) {const struct drm_framebuffer *fb = plane_state->base.fb;int ret; +bool needs_aux = false; ret =intel_plane_compute_gtt (plane_state);if (ret)
@@ -3617,21 +3726,31 @@ int skl_check_plane_surface(struct intel_plane_state *plane_state)return 0 ;/* -* Handle the AUX surface first since -* the main surface setup depends on it. +* Handle the AUX surface first since the main surface setup depends on +* it. */ -if (drm_format_info_is_yuv_semiplanar (fb->format)) { - ret =skl_check_nv12_aux_surface (plane_state); +if (is_ccs_modifier (fb->modifier)) { + needs_aux = true; + ret =skl_check_ccs_aux_surface (plane_state);if (ret)return ret; - }else if (is_ccs_modifier (fb->modifier)) { - ret =skl_check_ccs_aux_surface (plane_state); + } + +if (drm_format_info_is_yuv_semiplanar (fb->format)) { + needs_aux = true; + ret =skl_check_nv12_aux_surface (plane_state);if (ret)return ret; - }else { - plane_state->color_plane[1 ].offset = ~0xfff ; - plane_state->color_plane[1 ].x =0 ; - plane_state->color_plane[1 ].y =0 ; + } + +if (!needs_aux) { +int i; + +for (i =1 ; i < fb->format->num_planes; i++) { + plane_state->color_plane[i].offset = ~0xfff ; + plane_state->color_plane[i].x =0 ; + plane_state->color_plane[i].y =0 ; + } } ret =skl_check_main_surface (plane_state);
@@ -4149,6 +4268,8 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)return PLANE_CTL_TILED_Y |PLANE_CTL_RENDER_DECOMPRESSION_ENABLE |PLANE_CTL_CLEAR_COLOR_DISABLE ; +case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +return PLANE_CTL_TILED_Y |PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE ;case I915_FORMAT_MOD_Yf_TILED:return PLANE_CTL_TILED_YF ;case I915_FORMAT_MOD_Yf_TILED_CCS:
@@ -9913,6 +10034,8 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc, fb->modifier =INTEL_GEN (dev_priv) >=12 ?I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :I915_FORMAT_MOD_Y_TILED_CCS ; + else if (val & PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE) + fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS; else fb->modifier = I915_FORMAT_MOD_Y_TILED;break ;
drivers/gpu/drm/i915/display/intel_display_types.h +1 -1
@@ -530,7 +530,7 @@ struct intel_plane_state {*/ u32 stride;int x, y; - } color_plane[2 ]; + } color_plane[4 ];/* plane control register */ u32 ctl;
drivers/gpu/drm/i915/display/intel_sprite.c +38 -6
89 lines not on this page · raw message
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -6710,6 +6710,7 @@ enum {#define PLANE_CTL_TILED_Y (4 << 10)#define PLANE_CTL_TILED_YF (5 << 10)#define PLANE_CTL_FLIP_HORIZONTAL (1 << 8) +#define PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE (1 << 4)/* TGL+ */ #define PLANE_CTL_ALPHA_MASK (0x3 << 4)/* Pre-GLK */ #define PLANE_CTL_ALPHA_DISABLE (0 << 4)#define PLANE_CTL_ALPHA_SW_PREMULTIPLY (2 << 4)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 9/10 drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color
In reply to Radhakrishna SripadaGen12 display can decompress surfaces compressed by render engine with Clear Color, add a new modifier as the driver needs to know the surface was compressed by render engine.
V2: Description changes as suggested by Rafael.
V3: Mention the Clear Color size of 64 bits in the comments(DK)
--- include/uapi/drm/drm_fourcc.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/uapi/drm/drm_fourcc.h +11 -0
@@ -434,6 +434,17 @@ extern "C" {*/ #define I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS fourcc_mod_code(INTEL, 7) +/* +* Intel color control surfaces Clear Color(CCS_CC) for Gen-12 render compression. +* +* The main surface is Y-tiled and is at plane index 0 whereas CCS_CC is linear +* and at index 1. The clear color is stored at index 2, and the pitch should +* be ignored. The size of clear color should be 64 bits. A CCS_CC cache line +* corresponds to an area of 4x1 tiles in the main surface. The main surface +* pitch is required to be a multiple of 4 tile widths. +*/ +#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8) +/* * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks *
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 9/10 drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color
Gen12 display can decompress surfaces compressed by render engine with Clear Color, add a new modifier as the driver needs to know the surface was compressed by render engine.
V2: Description changes as suggested by Rafael.
V3: Mention the Clear Color size of 64 bits in the comments(DK)
v4: Fix trailing whitespaces
--- include/uapi/drm/drm_fourcc.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/uapi/drm/drm_fourcc.h +11 -0
@@ -434,6 +434,17 @@ extern "C" {*/ #define I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS fourcc_mod_code(INTEL, 7) +/* +* Intel color control surfaces Clear Color(CCS_CC) for Gen-12 render compression. +* +* The main surface is Y-tiled and is at plane index 0 whereas CCS_CC is linear +* and at index 1. The clear color is stored at index 2, and the pitch should +* be ignored. The size of clear color should be 64 bits. A CCS_CC cache line +* corresponds to an area of 4x1 tiles in the main surface. The main surface +* pitch is required to be a multiple of 4 tile widths. +*/ +#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8) +/* * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks *
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 9/10 drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color
Gen12 display can decompress surfaces compressed by render engine with Clear Color, add a new modifier as the driver needs to know the surface was compressed by render engine.
V2: Description changes as suggested by Rafael.
V3: Mention the Clear Color size of 64 bits in the comments(DK)
v4: Fix trailing whitespaces
v5: Explain Clear Color in the documentation.
--- include/uapi/drm/drm_fourcc.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
include/uapi/drm/drm_fourcc.h +18 -0
@@ -434,6 +434,24 @@ extern "C" {*/ #define I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS fourcc_mod_code(INTEL, 7) +/* +* Intel color control surfaces Clear Color(CCS_CC) for Gen-12 render compression. +* +* The main surface is Y-tiled and is at plane index 0 whereas CCS_CC is linear +* and at index 1. The clear color is stored at index 2, and the pitch should +* be ignored. The clear color structure is 256 bits. The first 128 bits represents +* Raw Clear Color Red, Green, Blue and Alpha color each represented by 32 bits. +* The raw clear color is consumed by the 3d engine and generates the converted +* clear color of size 64 bits. The first 32 bits store the Lower Converted Clear +* Color value and the next 32 bits store the Higher Converted Clear Color value +* when applicable. The Converted Clear Color values are consumed by the DE. The +* last 64 bits are used to store Color Discard Enable and Depth Clear Value Valid +* which are ignored by the DE. A CCS_CC cache line corresponds to an area of 4x1 +* tiles in the main surface. The main surface pitch is required to be a multiple +* of 4 tile widths. +*/ +#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8) +/* * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks *
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v5 09/10] drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color
Hi RK,
Quoted 30 lines
-----Original Message-----
From: Sripada, Radhakrishna <[email protected]>
Sent: Tuesday, October 22, 2019 5:09 PM
To: [email protected]
Cc: Sripada, Radhakrishna <[email protected]>; Ville Syrjala <[email protected]>; Pandiyan, Dhinakaran <[email protected]>; Kondapally, Kalyan <[email protected]>; Antognolli, Rafael <[email protected]>; Chery, Nanley G <[email protected]>
Subject: [PATCH v5 09/10] drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear ColorGen12 display can decompress surfaces compressed by render engine with Clear Color, add a new modifier as the driver needs to know the surface was compressed by render engine.
V2: Description changes as suggested by Rafael.
V3: Mention the Clear Color size of 64 bits in the comments(DK)
v4: Fix trailing whitespaces
v5: Explain Clear Color in the documentation.Cc Ville Syrjala <[email protected]>Cc Dhinakaran Pandiyan <[email protected]>Cc Kalyan Kondapally <[email protected]>Cc Rafael Antognolli <[email protected]>Cc Nanley Chery <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- include/uapi/drm/drm_fourcc.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)include/uapi/drm/drm_fourcc.h +0
-0
include/uapi/drm/drm_fourcc.h extern "C" { · line 438
Quoted 5 lines
include/uapi/drm/drm_fourcc.h +2
-0@@ -434,6 +434,24 @@ extern "C" {*/ #define I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS fourcc_mod_code(INTEL, 7) +/* +* Intel color control surfaces Clear Color(CCS_CC) for Gen-12 render compression.
A couple nit-picks here:
- It's not clear to me why "clear color" is capitalized but "color control surfaces" is not.
- It also isn't clear why "surfaces" is plural here but singular in the Y_TILED_CCS comment.
- A space is missing between "Color" and "(CCS_CC)".
- Perhaps insert a "with" between "color control surface" and "clear color"?
include/uapi/drm/drm_fourcc.h extern "C" { · line 441
Quoted 3 lines
include/uapi/drm/drm_fourcc.h +3
-0+* +* The main surface is Y-tiled and is at plane index 0 whereas CCS_CC is linear +* and at index 1. The clear color is stored at index 2, and the pitch should
I thought "CCS_CC" would be referring to the CCS with clear color, not the CCS by itself. I can't find this term in the BSpec. Perhaps we shouldn't create a new one here to avoid confusion?
-Nanley
Quoted 20 lines
include/uapi/drm/drm_fourcc.h +13
-0+* be ignored. The clear color structure is 256 bits. The first 128 bits represents +* Raw Clear Color Red, Green, Blue and Alpha color each represented by 32 bits. +* The raw clear color is consumed by the 3d engine and generates the converted +* clear color of size 64 bits. The first 32 bits store the Lower Converted Clear +* Color value and the next 32 bits store the Higher Converted Clear Color value +* when applicable. The Converted Clear Color values are consumed by the DE. The +* last 64 bits are used to store Color Discard Enable and Depth Clear Value Valid +* which are ignored by the DE. A CCS_CC cache line corresponds to an area of 4x1 +* tiles in the main surface. The main surface pitch is required to be a multiple +* of 4 tile widths. +*/ +#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8) +/* * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks * Signature · 1 line
2.20.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 10/10 drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression
In reply to Radhakrishna SripadaRender Decompression is supported with Y-Tiled main surface. The CCS is linear and has 4 bits of data for each main surface cache line pair, a ratio of 1:256. Additional Clear Color information is passed from the user-space through an offset in the GEM BO. Add a new modifier to identify and parse new Clear Color information and extend Gen12 render decompression functionality to the newly added modifier.
v2: Fix has_alpha flag for modifiers, omit CC modifier during initial
plane config(Matt). Fix Lookup error.
v3: Fix the panic while running kms_cube
v4: Add alignment check and reuse the comments for ge12_ccs_formats(Matt)
v5: Fix typos and wrap comments(Matt)
--- drivers/gpu/drm/i915/display/intel_display.c | 52 +++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 3 ++ drivers/gpu/drm/i915/display/intel_sprite.c | 11 +++- drivers/gpu/drm/i915/i915_reg.h | 12 +++++ 4 files changed, 77 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display.c +52 -0
@@ -1944,6 +1944,10 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)if (color_plane ==1 )return 64 ;/* fall through */ +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +if (color_plane ==1 || color_plane ==2 ) +return 64 ; +/* fall through */ case I915_FORMAT_MOD_Y_TILED :if (IS_GEN (dev_priv,2 ) ||HAS_128_BYTE_Y_TILING (dev_priv))return 128 ;
@@ -2085,6 +2089,7 @@ static unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,return 256 *1024 ;return 0 ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return 16 *1024 ;case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS:
@@ -2287,6 +2292,8 @@ static bool is_surface_linear(u64 modifier, int color_plane)return true;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :return color_plane ==1 ; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return color_plane ==1 || color_plane ==2 ;case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :return color_plane ==1 || color_plane ==3 ;default :
@@ -2480,6 +2487,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return I915_TILING_Y ;default :return I915_TILING_NONE ;
@@ -2533,6 +2541,21 @@ static const struct drm_format_info gen12_ccs_formats[] = { .cpp = { 1, 1, 2, 1}, .hsub = 2, .vsub = 2, .is_yuv = true }, }; +/* +* Same as gen12_ccs_formats[] above, but with additional surface used +* to pass Clear Color information in plane 2 with 64 bits of data. +*/ +static const struct drm_format_info gen12_ccs_cc_formats[] = { + { .format =DRM_FORMAT_XRGB8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_XBGR8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_ARGB8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, + { .format =DRM_FORMAT_ABGR8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, +}; +static const struct drm_format_info *lookup_format_info (const struct drm_format_info formats[],int num_formats,u32 format)
@@ -2560,6 +2583,10 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd)return lookup_format_info (gen12_ccs_formats,ARRAY_SIZE (gen12_ccs_formats), cmd->pixel_format); +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return lookup_format_info (gen12_ccs_cc_formats, +ARRAY_SIZE (gen12_ccs_cc_formats), + cmd->pixel_format);default :return NULL ; }
@@ -2569,6 +2596,7 @@ bool is_ccs_modifier(u64 modifier) {return modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC || modifier ==I915_FORMAT_MOD_Y_TILED_CCS || modifier == I915_FORMAT_MOD_Yf_TILED_CCS; }
@@ -2756,6 +2784,8 @@ static bool is_ccs_plane(u64 modifier, int color_plane)return false; else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS) return color_plane == 3 || color_plane == 1; + else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC) + return color_plane == 1 || color_plane == 2; else return color_plane == 1; }
@@ -2824,6 +2854,18 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,int x, y;int ret; +/* +* Plane 2 of Render Compression with Clear Color fb modifier +* is consumed by the driver and not passed to DE. Skip the +* arithmetic related to alignment and offset calculation. +*/ +if (i ==2 && fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +if (IS_ALIGNED (fb->offsets[2 ],PAGE_SIZE )) +continue ; +else +return -EINVAL ; + } + cpp = fb->format->cpp[i];intel_fb_plane_dims (&width, &height, fb, i);
@@ -4341,6 +4383,7 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED :return PLANE_CTL_TILED_Y ;case I915_FORMAT_MOD_Y_TILED_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return PLANE_CTL_TILED_Y |PLANE_CTL_RENDER_DECOMPRESSION_ENABLE ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : return PLANE_CTL_TILED_Y |
@@ -15212,6 +15255,15 @@ static int intel_plane_pin_fb(struct intel_plane_state *plane_state) plane_state->vma = vma; +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +u32 *ccaddr =kmap_atomic (i915_gem_object_get_page (intel_fb_obj (fb), + fb->offsets[2 ] >>PAGE_SHIFT )); + + plane_state->ccval = ((u64)*(ccaddr +CC_VAL_HIGHER_OFFSET ) <<32 ) + | *(ccaddr +CC_VAL_LOWER_OFFSET ); +kunmap_atomic (ccaddr); + } +return 0 ; }
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -587,6 +587,9 @@ struct intel_plane_state {u32 planar_slave;struct drm_intel_sprite_colorkey ckey; + +/* Clear Color Value */ +u64 ccval; };struct intel_initial_plane_config {
drivers/gpu/drm/i915/display/intel_sprite.c +10 -1
@@ -596,6 +596,7 @@ skl_program_plane(struct intel_plane *plane,u32 plane_color_ctl =0 ;unsigned long irqflags;u32 keymsk, keymax; +u64 ccval = plane_state->ccval; plane_ctl |=skl_plane_ctl_crtc (crtc_state);
@@ -656,6 +657,10 @@ skl_program_plane(struct intel_plane *plane,if (fb->format->is_yuv &&icl_is_hdr_plane (dev_priv, plane_id))icl_program_input_csc (plane, crtc_state, plane_state); +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) +intel_uncore_write64_fw (&dev_priv->uncore, +PLANE_CC_VAL (pipe, plane_id), ccval); +skl_write_plane_wm (plane, crtc_state);I915_WRITE_FW (PLANE_KEYVAL (pipe, plane_id), key->min_value);
@@ -2115,7 +2120,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state, fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || - fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS)) { + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)) {DRM_DEBUG_KMS ("Y/Yf tiling not supported in IF-ID mode\n" );return -EINVAL ; }
@@ -2554,6 +2560,7 @@ static const u64 skl_plane_format_modifiers_ccs[] = {static const u64 gen12_plane_format_modifiers_mc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ,I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,
@@ -2562,6 +2569,7 @@ static const u64 gen12_plane_format_modifiers_mc_ccs[] = {static const u64 gen12_plane_format_modifiers_rc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,
@@ -2737,6 +2745,7 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,case I915_FORMAT_MOD_X_TILED :case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :break ;default :return false;
drivers/gpu/drm/i915/i915_reg.h +12 -0
@@ -6753,6 +6753,8 @@ enum {#define _PLANE_KEYMAX_1_A 0x701a0#define _PLANE_KEYMAX_2_A 0x702a0#define PLANE_KEYMAX_ALPHA (a) ((a) << 24) +#define _PLANE_CC_VAL_1_A 0x701b4 +#define _PLANE_CC_VAL_2_A 0x702b4#define _PLANE_AUX_DIST_1_A 0x701c0#define _PLANE_AUX_DIST_2_A 0x702c0#define _PLANE_AUX_OFFSET_1_A 0x701c4
@@ -6792,6 +6794,16 @@ enum {#define _PLANE_NV12_BUF_CFG_1_A 0x70278#define _PLANE_NV12_BUF_CFG_2_A 0x70378 +#define _PLANE_CC_VAL_1_B 0x711b4 +#define _PLANE_CC_VAL_2_B 0x712b4 +#define _PLANE_CC_VAL_1 (pipe) _PIPE(pipe, _PLANE_CC_VAL_1_A, _PLANE_CC_VAL_1_B) +#define _PLANE_CC_VAL_2 (pipe) _PIPE(pipe, _PLANE_CC_VAL_2_A, _PLANE_CC_VAL_2_B) +#define PLANE_CC_VAL (pipe, plane) \ + _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe)) + +#define CC_VAL_LOWER_OFFSET 4 +#define CC_VAL_HIGHER_OFFSET 5 +/* Input CSC Register Definitions */ #define _PLANE_INPUT_CSC_RY_GY_1_A 0x701E0#define _PLANE_INPUT_CSC_RY_GY_2_A 0x702E0
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 10/10 drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression
In reply to Radhakrishna SripadaRender Decompression is supported with Y-Tiled main surface. The CCS is linear and has 4 bits of data for each main surface cache line pair, a ratio of 1:256. Additional Clear Color information is passed from the user-space through an offset in the GEM BO. Add a new modifier to identify and parse new Clear Color information and extend Gen12 render decompression functionality to the newly added modifier.
v2: Fix has_alpha flag for modifiers, omit CC modifier during initial
plane config(Matt). Fix Lookup error.
v3: Fix the panic while running kms_cube
v4: Add alignment check and reuse the comments for ge12_ccs_formats(Matt)
--- drivers/gpu/drm/i915/display/intel_display.c | 52 +++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 3 ++ drivers/gpu/drm/i915/display/intel_sprite.c | 11 +++- drivers/gpu/drm/i915/i915_reg.h | 12 +++++ 4 files changed, 77 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display.c +52 -0
@@ -1917,6 +1917,10 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)if (color_plane ==1 )return 64 ;/* fall through */ +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +if (color_plane ==1 || color_plane ==2 ) +return 64 ; +/* fall through */ case I915_FORMAT_MOD_Y_TILED :if (IS_GEN (dev_priv,2 ) ||HAS_128_BYTE_Y_TILING (dev_priv))return 128 ;
@@ -2058,6 +2062,7 @@ static unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,return 256 *1024 ;return 0 ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return 16 *1024 ;case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS:
@@ -2260,6 +2265,8 @@ static bool is_surface_linear(u64 modifier, int color_plane)return true;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :return color_plane ==1 ; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return color_plane ==1 || color_plane ==2 ;case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :return color_plane ==1 || color_plane ==3 ;default :
@@ -2453,6 +2460,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return I915_TILING_Y ;default :return I915_TILING_NONE ;
@@ -2506,6 +2514,21 @@ static const struct drm_format_info gen12_ccs_formats[] = { .cpp = { 1, 1, 2, 1}, .hsub = 2, .vsub = 2, .is_yuv = true }, }; +/* +* Same as gen12_ccs_formats[] above, but with additional surface used +* top pass Clear Color information in plane 2 with 64 bits of data. +*/ +static const struct drm_format_info gen12_ccs_cc_formats[] = { + { .format =DRM_FORMAT_XRGB8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_XBGR8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_ARGB8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, + { .format =DRM_FORMAT_ABGR8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, +}; +static const struct drm_format_info *lookup_format_info (const struct drm_format_info formats[],int num_formats,u32 format)
@@ -2533,6 +2556,10 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd)return lookup_format_info (gen12_ccs_formats,ARRAY_SIZE (gen12_ccs_formats), cmd->pixel_format); +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return lookup_format_info (gen12_ccs_cc_formats, +ARRAY_SIZE (gen12_ccs_cc_formats), + cmd->pixel_format);default :return NULL ; }
@@ -2542,6 +2569,7 @@ bool is_ccs_modifier(u64 modifier) {return modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC || modifier ==I915_FORMAT_MOD_Y_TILED_CCS || modifier == I915_FORMAT_MOD_Yf_TILED_CCS; }
@@ -2729,6 +2757,8 @@ static bool is_ccs_plane(u64 modifier, int color_plane)return false; else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS) return color_plane == 3 || color_plane == 1; + else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC) + return color_plane == 1 || color_plane == 2; else return color_plane == 1; }
@@ -2797,6 +2827,18 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,int x, y;int ret; +/* +* Plane 2 of Render Compression with Clear Color fb modifier is consumed +* by the driver and not passed to DE. Skip the arithmetic related to +* alignment and offset calculation. +*/ +if (i ==2 && fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +if (IS_ALIGNED (fb->offsets[2 ],PAGE_SIZE )) +continue ; +else +return -EINVAL ; + } + cpp = fb->format->cpp[i];intel_fb_plane_dims (&width, &height, fb, i);
@@ -4263,6 +4305,7 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED :return PLANE_CTL_TILED_Y ;case I915_FORMAT_MOD_Y_TILED_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return PLANE_CTL_TILED_Y |PLANE_CTL_RENDER_DECOMPRESSION_ENABLE ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : return PLANE_CTL_TILED_Y |
@@ -14586,6 +14629,15 @@ static int intel_plane_pin_fb(struct intel_plane_state *plane_state) plane_state->vma = vma; +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +u32 *ccaddr =kmap_atomic (i915_gem_object_get_page (intel_fb_obj (fb), + fb->offsets[2 ] >>PAGE_SHIFT )); + + plane_state->ccval = ((u64)*(ccaddr +CC_VAL_HIGHER_OFFSET ) <<32 ) + | *(ccaddr +CC_VAL_LOWER_OFFSET ); +kunmap_atomic (ccaddr); + } +return 0 ; }
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -579,6 +579,9 @@ struct intel_plane_state {u32 planar_slave;struct drm_intel_sprite_colorkey ckey; + +/* Clear Color Value */ +u64 ccval; };struct intel_initial_plane_config {
drivers/gpu/drm/i915/display/intel_sprite.c +10 -1
@@ -549,6 +549,7 @@ skl_program_plane(struct intel_plane *plane,u32 plane_color_ctl =0 ;unsigned long irqflags;u32 keymsk, keymax; +u64 ccval = plane_state->ccval; plane_ctl |=skl_plane_ctl_crtc (crtc_state);
@@ -609,6 +610,10 @@ skl_program_plane(struct intel_plane *plane,if (fb->format->is_yuv &&icl_is_hdr_plane (dev_priv, plane_id))icl_program_input_csc (plane, crtc_state, plane_state); +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) +intel_uncore_write64_fw (&dev_priv->uncore, +PLANE_CC_VAL (pipe, plane_id), ccval); +skl_write_plane_wm (plane, crtc_state);I915_WRITE_FW (PLANE_KEYVAL (pipe, plane_id), key->min_value);
@@ -1739,7 +1744,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state, fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || - fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS)) { + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)) {DRM_DEBUG_KMS ("Y/Yf tiling not supported in IF-ID mode\n" );return -EINVAL ; }
@@ -2154,6 +2160,7 @@ static const u64 skl_plane_format_modifiers_ccs[] = {static const u64 gen12_plane_format_modifiers_mc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ,I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,
@@ -2162,6 +2169,7 @@ static const u64 gen12_plane_format_modifiers_mc_ccs[] = {static const u64 gen12_plane_format_modifiers_rc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,
@@ -2335,6 +2343,7 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,case I915_FORMAT_MOD_X_TILED :case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :break ;default :return false;
drivers/gpu/drm/i915/i915_reg.h +12 -0
@@ -6743,6 +6743,8 @@ enum {#define _PLANE_KEYMAX_1_A 0x701a0#define _PLANE_KEYMAX_2_A 0x702a0#define PLANE_KEYMAX_ALPHA (a) ((a) << 24) +#define _PLANE_CC_VAL_1_A 0x701b4 +#define _PLANE_CC_VAL_2_A 0x702b4#define _PLANE_AUX_DIST_1_A 0x701c0#define _PLANE_AUX_DIST_2_A 0x702c0#define _PLANE_AUX_OFFSET_1_A 0x701c4
@@ -6782,6 +6784,16 @@ enum {#define _PLANE_NV12_BUF_CFG_1_A 0x70278#define _PLANE_NV12_BUF_CFG_2_A 0x70378 +#define _PLANE_CC_VAL_1_B 0x711b4 +#define _PLANE_CC_VAL_2_B 0x712b4 +#define _PLANE_CC_VAL_1 (pipe) _PIPE(pipe, _PLANE_CC_VAL_1_A, _PLANE_CC_VAL_1_B) +#define _PLANE_CC_VAL_2 (pipe) _PIPE(pipe, _PLANE_CC_VAL_2_A, _PLANE_CC_VAL_2_B) +#define PLANE_CC_VAL (pipe, plane) \ + _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe)) + +#define CC_VAL_LOWER_OFFSET 4 +#define CC_VAL_HIGHER_OFFSET 5 +/* Input CSC Register Definitions */ #define _PLANE_INPUT_CSC_RY_GY_1_A 0x701E0#define _PLANE_INPUT_CSC_RY_GY_2_A 0x702E0
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4 10/10] drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression
Quoted 12 lines · Radhakrishna Sripada
Render Decompression is supported with Y-Tiled main surface. The CCS is linear and has 4 bits of data for each main surface cache line pair, a ratio of 1:256. Additional Clear Color information is passed from the user-space through an offset in the GEM BO. Add a new modifier to identify and parse new Clear Color information and extend Gen12 render decompression functionality to the newly added modifier.
v2: Fix
has_alphaflag for modifiers, omit CC modifier during initial
plane config(Matt). Fix Lookup error.
v3: Fix the panic while runningkms_cube
v4: Add alignment check and reuse the comments forge12_ccs_formats(Matt)
Quoted 7 lines
Cc Dhinakaran Pandiyan <[email protected]>Cc Ville Syrjala <[email protected]>Cc Shashank Sharma <[email protected]>Cc Rafael Antognolli <[email protected]>Cc Matt Roper <[email protected]>Cc Nanley G Chery <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
One minor typo and one documentation suggestion, but aside from fixing those this patch looks good to me:
The previous patch that adds the modifier looks fine to me too, but I figure we should leave it to whoever is working on the corresponding userspace code to ack/rb that one.
Matt
Quoted 48 lines
--- drivers/gpu/drm/i915/display/intel_display.c | 52 +++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 3 ++ drivers/gpu/drm/i915/display/intel_sprite.c | 11 +++- drivers/gpu/drm/i915/i915_reg.h | 12 +++++ 4 files changed, 77 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display.c +8
-0@@ -1917,6 +1917,10 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)if (color_plane ==1 )return 64 ;/* fall through */ +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +if (color_plane ==1 || color_plane ==2 ) +return 64 ; +/* fall through */ case I915_FORMAT_MOD_Y_TILED :if (IS_GEN (dev_priv,2 ) ||HAS_128_BYTE_Y_TILING (dev_priv))return 128 ;@@ -2058,6 +2062,7 @@ static unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,return 256 *1024 ;return 0 ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return 16 *1024 ;case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS:@@ -2260,6 +2265,8 @@ static bool is_surface_linear(u64 modifier, int color_plane)return true;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :return color_plane ==1 ; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return color_plane ==1 || color_plane ==2 ;case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :return color_plane ==1 || color_plane ==3 ;default :@@ -2453,6 +2460,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return I915_TILING_Y ;default :return I915_TILING_NONE ;
drivers/gpu/drm/i915/display/intel_display.c static const struct drm_format_info gen12_ccs_formats[] = { · line 2519
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +3
-0@@ -2506,6 +2514,21 @@ static const struct drm_format_info gen12_ccs_formats[] = { .cpp = { 1, 1, 2, 1}, .hsub = 2, .vsub = 2, .is_yuv = true }, }; +/* +* Same as gen12_ccs_formats[] above, but with additional surface used +* top pass Clear Color information in plane 2 with 64 bits of data.
s/top/to
Quoted 44 lines
drivers/gpu/drm/i915/display/intel_display.c +19
-0+*/ +static const struct drm_format_info gen12_ccs_cc_formats[] = { + { .format =DRM_FORMAT_XRGB8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_XBGR8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_ARGB8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, + { .format =DRM_FORMAT_ABGR8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, +}; +static const struct drm_format_info *lookup_format_info (const struct drm_format_info formats[],int num_formats,u32 format)@@ -2533,6 +2556,10 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd)return lookup_format_info (gen12_ccs_formats,ARRAY_SIZE (gen12_ccs_formats), cmd->pixel_format); +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return lookup_format_info (gen12_ccs_cc_formats, +ARRAY_SIZE (gen12_ccs_cc_formats), + cmd->pixel_format);default :return NULL ; }@@ -2542,6 +2569,7 @@ bool is_ccs_modifier(u64 modifier) {return modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC || modifier ==I915_FORMAT_MOD_Y_TILED_CCS || modifier == I915_FORMAT_MOD_Yf_TILED_CCS; }@@ -2729,6 +2757,8 @@ static bool is_ccs_plane(u64 modifier, int color_plane)return false; else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS) return color_plane == 3 || color_plane == 1; + else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC) + return color_plane == 1 || color_plane == 2; else return color_plane == 1; }
drivers/gpu/drm/i915/display/intel_display.c intel_fill_fb_info(struct drm_i915_private *dev_priv, · line 2832
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +3
-0@@ -2797,6 +2827,18 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,int x, y;int ret; +/* +* Plane 2 of Render Compression with Clear Color fb modifier is consumed +* by the driver and not passed to DE. Skip the arithmetic related to
These comment lines are >80 characters and should be re-wrapped.
Quoted 21 lines
drivers/gpu/drm/i915/display/intel_display.c +10
-0+* alignment and offset calculation. +*/ +if (i ==2 && fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +if (IS_ALIGNED (fb->offsets[2 ],PAGE_SIZE )) +continue ; +else +return -EINVAL ; + } + cpp = fb->format->cpp[i];intel_fb_plane_dims (&width, &height, fb, i);@@ -4263,6 +4305,7 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED :return PLANE_CTL_TILED_Y ;case I915_FORMAT_MOD_Y_TILED_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return PLANE_CTL_TILED_Y |PLANE_CTL_RENDER_DECOMPRESSION_ENABLE ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : return PLANE_CTL_TILED_Y |
drivers/gpu/drm/i915/display/intel_display.c static int intel_plane_pin_fb(struct intel_plane_state *plane_state) · line 14637
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display.c +6
-0@@ -14586,6 +14629,15 @@ static int intel_plane_pin_fb(struct intel_plane_state *plane_state) plane_state->vma = vma; +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +u32 *ccaddr =kmap_atomic (i915_gem_object_get_page (intel_fb_obj (fb), + fb->offsets[2 ] >>PAGE_SHIFT )); + + plane_state->ccval = ((u64)*(ccaddr +CC_VAL_HIGHER_OFFSET ) <<32 ) + | *(ccaddr +CC_VAL_LOWER_OFFSET );
I think it would be good to document what the expected format is, either through comments and/or through a structure definition that describes the exact layout. As you mentioned before, some of the bytes provided by the render engine aren't used by the display engine, so a more formal description of the layout would make this easier to understand.
Quoted 110 lines
drivers/gpu/drm/i915/display/intel_display.c +3
-0+kunmap_atomic (ccaddr); + } +return 0 ; }drivers/gpu/drm/i915/display/intel_display_types.h +3
-0@@ -579,6 +579,9 @@ struct intel_plane_state {u32 planar_slave;struct drm_intel_sprite_colorkey ckey; + +/* Clear Color Value */ +u64 ccval; };struct intel_initial_plane_config {drivers/gpu/drm/i915/display/intel_sprite.c +10
-1@@ -549,6 +549,7 @@ skl_program_plane(struct intel_plane *plane,u32 plane_color_ctl =0 ;unsigned long irqflags;u32 keymsk, keymax; +u64 ccval = plane_state->ccval; plane_ctl |=skl_plane_ctl_crtc (crtc_state);@@ -609,6 +610,10 @@ skl_program_plane(struct intel_plane *plane,if (fb->format->is_yuv &&icl_is_hdr_plane (dev_priv, plane_id))icl_program_input_csc (plane, crtc_state, plane_state); +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) +intel_uncore_write64_fw (&dev_priv->uncore, +PLANE_CC_VAL (pipe, plane_id), ccval); +skl_write_plane_wm (plane, crtc_state);I915_WRITE_FW (PLANE_KEYVAL (pipe, plane_id), key->min_value);@@ -1739,7 +1744,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state, fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || - fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS)) { + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)) {DRM_DEBUG_KMS ("Y/Yf tiling not supported in IF-ID mode\n" );return -EINVAL ; }@@ -2154,6 +2160,7 @@ static const u64 skl_plane_format_modifiers_ccs[] = {static const u64 gen12_plane_format_modifiers_mc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ,I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,@@ -2162,6 +2169,7 @@ static const u64 gen12_plane_format_modifiers_mc_ccs[] = {static const u64 gen12_plane_format_modifiers_rc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,@@ -2335,6 +2343,7 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,case I915_FORMAT_MOD_X_TILED :case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :break ;default :return false;drivers/gpu/drm/i915/i915_reg.h +12
-0@@ -6743,6 +6743,8 @@ enum {#define _PLANE_KEYMAX_1_A 0x701a0#define _PLANE_KEYMAX_2_A 0x702a0#define PLANE_KEYMAX_ALPHA (a) ((a) << 24) +#define _PLANE_CC_VAL_1_A 0x701b4 +#define _PLANE_CC_VAL_2_A 0x702b4#define _PLANE_AUX_DIST_1_A 0x701c0#define _PLANE_AUX_DIST_2_A 0x702c0#define _PLANE_AUX_OFFSET_1_A 0x701c4@@ -6782,6 +6784,16 @@ enum {#define _PLANE_NV12_BUF_CFG_1_A 0x70278#define _PLANE_NV12_BUF_CFG_2_A 0x70378 +#define _PLANE_CC_VAL_1_B 0x711b4 +#define _PLANE_CC_VAL_2_B 0x712b4 +#define _PLANE_CC_VAL_1 (pipe) _PIPE(pipe, _PLANE_CC_VAL_1_A, _PLANE_CC_VAL_1_B) +#define _PLANE_CC_VAL_2 (pipe) _PIPE(pipe, _PLANE_CC_VAL_2_A, _PLANE_CC_VAL_2_B) +#define PLANE_CC_VAL (pipe, plane) \ + _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe)) + +#define CC_VAL_LOWER_OFFSET 4 +#define CC_VAL_HIGHER_OFFSET 5 +/* Input CSC Register Definitions */ #define _PLANE_INPUT_CSC_RY_GY_1_A 0x701E0#define _PLANE_INPUT_CSC_RY_GY_2_A 0x702E0Signature · 1 line
2.20.1
Signature · 9 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4 10/10] drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression
Hi Matt,
Quoted 33 lines
-----Original Message-----
From: Roper, Matthew D
Sent: Tuesday, October 22, 2019 11:15 AM
To: Sripada, Radhakrishna <[email protected]>
Cc: [email protected]; Pandiyan, Dhinakaran <[email protected]>; Syrjala, Ville <[email protected]>; Sharma, Shashank <[email protected]>; Antognolli, Rafael <[email protected]>; Chery, Nanley G <[email protected]>
Subject: Re: [PATCH v4 10/10] drm/i915/tgl: Add Clear Color supoort for TGL Render DecompressionQuoted 13 lines · Radhakrishna Sripada
Render Decompression is supported with Y-Tiled main surface. The CCS is linear and has 4 bits of data for each main surface cache line pair, a ratio of 1:256. Additional Clear Color information is passed from the user-space through an offset in the GEM BO. Add a new modifier to identify and parse new Clear Color information and extend Gen12 render decompression functionality to the newly added modifier.
v2: Fix
has_alphaflag for modifiers, omit CC modifier during initial
plane config(Matt). Fix Lookup error.
v3: Fix the panic while runningkms_cube
v4: Add alignment check and reuse the comments forge12_ccs_formats(Matt)Quoted 7 lines
Cc Dhinakaran Pandiyan <[email protected]>Cc Ville Syrjala <[email protected]>Cc Shashank Sharma <[email protected]>Cc Rafael Antognolli <[email protected]>Cc Matt Roper <[email protected]>Cc Nanley G Chery <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
Quoted 5 lines
One minor typo and one documentation suggestion, but aside from fixing those this patch looks good to me:
Reviewed-by Matt Roper <[email protected]>
Thanks for the review.
Quoted 63 lines
The previous patch that adds the modifier looks fine to me too, but I figure we should leave it to whoever is working on the corresponding userspace code to ack/rb that one.
Matt
drivers/gpu/drm/i915/display/intel_display.c intel_tile_width_bytes(const struct
Quoted 13 lines
--- drivers/gpu/drm/i915/display/intel_display.c | 52 +++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 3 ++ drivers/gpu/drm/i915/display/intel_sprite.c | 11 +++- drivers/gpu/drm/i915/i915_reg.h | 12 +++++ 4 files changed, 77 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display.c +0
-0@@ -1917,6 +1917,10 @@ intel_tile_width_bytes(const struct
drm_framebuffer*fb, intcolor_plane)drivers/gpu/drm/i915/display/intel_display.c intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display.c +4
-0if (color_plane ==1 )return 64 ;/* fall through */ +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +if (color_plane ==1 || color_plane ==2 ) +return 64 ; +/* fall through */ case I915_FORMAT_MOD_Y_TILED : if (IS_GEN(dev_priv, 2) ||
HAS_128_BYTE_Y_TILING(dev_priv))drivers/gpu/drm/i915/display/intel_display.c static unsigned int intel_surf_alignment(const
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_display.c +0
-0return 128 ;@@ -2058,6 +2062,7 @@ static unsigned int intel_surf_alignment(conststruct
drm_framebuffer*fb,drivers/gpu/drm/i915/display/intel_display.c static bool is_surface_linear(u64 modifier, int
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0return 256 *1024 ;return 0 ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return 16 *1024 ;case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS:@@ -2260,6 +2265,8 @@ static bool is_surface_linear(u64 modifier, int
color_plane)drivers/gpu/drm/i915/display/intel_display.c static unsigned int
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display.c +2
-0return true;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :return color_plane ==1 ; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return color_plane ==1 || color_plane ==2 ;case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :return color_plane ==1 || color_plane ==3 ;default :@@ -2453,6 +2460,7 @@ static unsigned int
intel_fb_modifier_to_tiling(u64 fb_modifier)drivers/gpu/drm/i915/display/intel_display.c static const struct drm_format_info
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return I915_TILING_Y ;default :return I915_TILING_NONE ;@@ -2506,6 +2514,21 @@ static const struct drm_format_infogen12_ccs_formats[] = {
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display.c static const struct drm_format_info gen12_ccs_formats[] = { · line 2519
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +4
-0.cpp = { 1, 1, 2, 1}, .hsub = 2, .vsub = 2, .is_yuv = true }, }; +/* +* Same as gen12_ccs_formats[] above, but with additional surface +used +* top pass Clear Color information in plane 2 with 64 bits of data. s/top/to
Oops will fix it.
Quoted 94 lines
drivers/gpu/drm/i915/display/intel_display.c intel_get_format_info(const struct
Quoted 17 lines
drivers/gpu/drm/i915/display/intel_display.c +12
-0+*/ +static const struct drm_format_info gen12_ccs_cc_formats[] = { + { .format =DRM_FORMAT_XRGB8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_XBGR8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_ARGB8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, + { .format =DRM_FORMAT_ABGR8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, +}; +static const struct drm_format_info *lookup_format_info (const struct drm_format_info formats[],int num_formats,u32 format)@@ -2533,6 +2556,10 @@ intel_get_format_info(const struct
drm_mode_fb_cmd2*cmd)Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display.c +4
-0return lookup_format_info (gen12_ccs_formats,ARRAY_SIZE (gen12_ccs_formats), cmd->pixel_format); +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return lookup_format_info (gen12_ccs_cc_formats, +ARRAY_SIZE (gen12_ccs_cc_formats), + cmd->pixel_format);default :return NULL ; }drivers/gpu/drm/i915/display/intel_display.c bool is_ccs_modifier(u64 modifier) {
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display.c +3
-0@@ -2542,6 +2569,7 @@ bool is_ccs_modifier(u64 modifier) {return modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC || modifier ==I915_FORMAT_MOD_Y_TILED_CCS || modifier == I915_FORMAT_MOD_Yf_TILED_CCS; } @@ -2729,6 +2757,8 @@ static bool is_ccs_plane(u64 modifier, int color_plane) return false; else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS) return color_plane == 3 || color_plane == 1; + else if (modifier ==
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)drivers/gpu/drm/i915/display/intel_display.c intel_fill_fb_info(struct drm_i915_private
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0+return color_plane ==1 || color_plane ==2 ; else return color_plane == 1; }@@ -2797,6 +2827,18 @@ intel_fill_fb_info(struct drm_i915_private
*dev_priv,drivers/gpu/drm/i915/display/intel_display.c intel_fill_fb_info(struct drm_i915_private *dev_priv,
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +2
-0int x, y;int ret; +/* +* Plane 2 of Render Compression with Clear Color fb modifier is consumed
drivers/gpu/drm/i915/display/intel_display.c intel_fill_fb_info(struct drm_i915_private · line 2832
Quoted 1 line
drivers/gpu/drm/i915/display/intel_display.c +1
-0+* by the driver and not passed to DE. Skip the arithmetic related
drivers/gpu/drm/i915/display/intel_display.c intel_fill_fb_info(struct drm_i915_private · line 2833
Quoted 1 line
drivers/gpu/drm/i915/display/intel_display.c +1
-0+toThese comment lines are >80 characters and should be re-wrapped.
drivers/gpu/drm/i915/display/intel_display.c intel_fill_fb_info(struct drm_i915_private *dev_priv,
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display.c +3
-0+* alignment and offset calculation. +*/ + if (i == 2 && fb->modifier ==
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC) {Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display.c +6
-0+if (IS_ALIGNED (fb->offsets[2 ],PAGE_SIZE )) +continue ; +else +return -EINVAL ; + } + cpp = fb->format->cpp[i];intel_fb_plane_dims (&width, &height, fb, i);drivers/gpu/drm/i915/display/intel_display.c static u32 skl_plane_ctl_tiling(u64 fb_modifier) · line 4309
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0@@ -4263,6 +4305,7 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED :return PLANE_CTL_TILED_Y ;case I915_FORMAT_MOD_Y_TILED_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : return PLANE_CTL_TILED_Y |
PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;drivers/gpu/drm/i915/display/intel_display.c static int intel_plane_pin_fb(struct · line 14633
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display.c +1
-0case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : return PLANE_CTL_TILED_Y |@@ -14586,6 +14629,15 @@ static int intel_plane_pin_fb(struct intel_plane_state *plane_state) plane_state->vma = vma; + if (fb->modifier ==
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC) {drivers/gpu/drm/i915/display/intel_display.c static int intel_plane_pin_fb(struct · line 14634
Quoted 1 line
drivers/gpu/drm/i915/display/intel_display.c +1
-0+ u32 *ccaddr =kmap_atomic(i915_gem_object_get_page(intel_fb_obj(fb),
drivers/gpu/drm/i915/display/intel_display.c static int intel_plane_pin_fb(struct · line 14638
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +3
-0+ fb- offsets[2] >> PAGE_SHIFT)); + + plane_state->ccval = ((u64)*(ccaddr +
CC_VAL_HIGHER_OFFSET) << 32)
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_display.c static int intel_plane_pin_fb(struct intel_plane_state *plane_state) · line 14637
Quoted 1 line
drivers/gpu/drm/i915/display/intel_display.c +1
-0+ | *(ccaddr + CC_VAL_LOWER_OFFSET);I think it would be good to document what the expected format is, either through comments and/or through a structure definition that describes the exact layout. As you mentioned before, some of the bytes provided by the render engine aren't used by the display engine, so a more formal description of the layout would make this easier to understand.
Documenting this in the previous patch would be the right place. So that The description of the Color format is available at the modifier declaration.
Thanks,
Radhakrishna(RK) Sripada
Quoted 125 lines
Quoted 36 lines
drivers/gpu/drm/i915/display/intel_display.c +3
-0+kunmap_atomic (ccaddr); + } +return 0 ;}
drivers/gpu/drm/i915/display/intel_display_types.h +3
-0@@ -579,6 +579,9 @@ struct intel_plane_state {u32 planar_slave;struct drm_intel_sprite_colorkey ckey; + +/* Clear Color Value */ +u64 ccval; };struct intel_initial_plane_config {drivers/gpu/drm/i915/display/intel_sprite.c +1
-0@@ -549,6 +549,7 @@ skl_program_plane(struct intel_plane *plane,u32 plane_color_ctl =0 ;unsigned long irqflags;u32 keymsk, keymax; +u64 ccval = plane_state->ccval; plane_ctl |=skl_plane_ctl_crtc (crtc_state);drivers/gpu/drm/i915/display/intel_sprite.c skl_program_plane(struct intel_plane *plane, · line 613
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1
-0@@ -609,6 +610,10 @@ skl_program_plane(struct intel_plane *plane,if (fb->format->is_yuv &&icl_is_hdr_plane (dev_priv, plane_id))icl_program_input_csc (plane, crtc_state, plane_state); + if (fb->modifier ==
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)drivers/gpu/drm/i915/display/intel_sprite.c skl_program_plane(struct intel_plane *plane, · line 615
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_sprite.c +2
-0+ intel_uncore_write64_fw(&dev_priv->uncore, + PLANE_CC_VAL(pipe, plane_id),ccval);
drivers/gpu/drm/i915/display/intel_sprite.c skl_program_plane(struct intel_plane *plane, · line 619
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1
-0+skl_write_plane_wm (plane, crtc_state);I915_WRITE_FW (PLANE_KEYVAL (pipe, plane_id), key->min_value);@@
Quoted 1 line
-1739,7 +1744,8 @@ static int skl_plane_check_fb(const struct
intel_crtc_state*crtc_state,drivers/gpu/drm/i915/display/intel_sprite.c static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_sprite.c +2
-1fb->modifier ==I915_FORMAT_MOD_Y_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS || fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || - fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS)) { + fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + fb->modifier ==
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)) {Quoted 1 line
DRM_DEBUG_KMS("Y/Yf tiling not supported in IF-ID
mode\n");
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_sprite.c +0
-0return -EINVAL ; }@@ -2154,6 +2160,7 @@ static const u64skl_plane_format_modifiers_ccs[] = { static const u64
gen12_plane_format_modifiers_mc_ccs[] = {
drivers/gpu/drm/i915/display/intel_sprite.c static bool
Quoted 16 lines
drivers/gpu/drm/i915/display/intel_sprite.c +2
-0I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ,I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED , DRM_FORMAT_MOD_LINEAR,@@ -2162,6 +2169,7 @@ static const u64 gen12_plane_format_modifiers_mc_ccs[] = {static const u64 gen12_plane_format_modifiers_rc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,drivers/gpu/drm/i915/display/intel_sprite.c +0
-0DRM_FORMAT_MOD_LINEAR,@@ -2335,6 +2343,7 @@ static boolgen12_plane_format_mod_supported(struct
drm_plane*_plane,Quoted 22 lines
drivers/gpu/drm/i915/display/intel_sprite.c +1
-0case I915_FORMAT_MOD_X_TILED :case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :break ;default :return false;(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hindex5fad9cb35979..d8883ad99a67100644drivers/gpu/drm/i915/i915_reg.h +2
-0@@ -6743,6 +6743,8 @@ enum {#define _PLANE_KEYMAX_1_A 0x701a0#define _PLANE_KEYMAX_2_A 0x702a0#define PLANE_KEYMAX_ALPHA (a) ((a) << 24) +#define _PLANE_CC_VAL_1_A 0x701b4 +#define _PLANE_CC_VAL_2_A 0x702b4#define _PLANE_AUX_DIST_1_A 0x701c0#define _PLANE_AUX_DIST_2_A 0x702c0#define _PLANE_AUX_OFFSET_1_A 0x701c4drivers/gpu/drm/i915/i915_reg.h enum { · line 6789
Quoted 6 lines
drivers/gpu/drm/i915/i915_reg.h +3
-0@@ -6782,6 +6784,16 @@ enum {#define _PLANE_NV12_BUF_CFG_1_A 0x70278#define _PLANE_NV12_BUF_CFG_2_A 0x70378 +#define _PLANE_CC_VAL_1_B 0x711b4 +#define _PLANE_CC_VAL_2_B 0x712b4 +#define _PLANE_CC_VAL_1 (pipe) _PIPE(pipe, _PLANE_CC_VAL_1_A,
_PLANE_CC_VAL_1_B)drivers/gpu/drm/i915/i915_reg.h enum { · line 6790
Quoted 1 line
drivers/gpu/drm/i915/i915_reg.h +1
-0+#define _PLANE_CC_VAL_2 (pipe) _PIPE(pipe, _PLANE_CC_VAL_2_A,
_PLANE_CC_VAL_2_B)drivers/gpu/drm/i915/i915_reg.h enum { · line 6792
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+#define PLANE_CC_VAL (pipe, plane) \ + _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe),
_PLANE_CC_VAL_2(pipe))Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h +4
-1+ +#define CC_VAL_LOWER_OFFSET 4 +#define CC_VAL_HIGHER_OFFSET 5 +/* Input CSC Register Definitions */ #define _PLANE_INPUT_CSC_RY_GY_1_A 0x701E0#define _PLANE_INPUT_CSC_RY_GY_2_A 0x702E0 --2.20.1
Quoted 8 lines
Quoted 1 line
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 10/10 drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression
In reply to Radhakrishna SripadaRender Decompression is supported with Y-Tiled main surface. The CCS is linear and has 4 bits of data for each main surface cache line pair, a ratio of 1:256. Additional Clear Color information is passed from the user-space through an offset in the GEM BO. Add a new modifier to identify and parse new Clear Color information and extend Gen12 render decompression functionality to the newly added modifier.
v2: Fix has_alpha flag for modifiers, omit CC modifier during initial
plane config(Matt). Fix Lookup error.
v3: Fix the panic while running kms_cube
v4: Add alignment check and reuse the comments for ge12_ccs_formats(Matt)
v5: Fix typos and wrap comments(Matt)
--- drivers/gpu/drm/i915/display/intel_display.c | 52 +++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 3 ++ drivers/gpu/drm/i915/display/intel_sprite.c | 11 +++- drivers/gpu/drm/i915/i915_reg.h | 12 +++++ 4 files changed, 77 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display.c +52 -0
@@ -1931,6 +1931,10 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)if (color_plane ==1 )return 64 ;/* fall through */ +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +if (color_plane ==1 || color_plane ==2 ) +return 64 ; +/* fall through */ case I915_FORMAT_MOD_Y_TILED :if (IS_GEN (dev_priv,2 ) ||HAS_128_BYTE_Y_TILING (dev_priv))return 128 ;
@@ -2072,6 +2076,7 @@ static unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,return 256 *1024 ;return 0 ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return 16 *1024 ;case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Yf_TILED_CCS:
@@ -2274,6 +2279,8 @@ static bool is_surface_linear(u64 modifier, int color_plane)return true;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :return color_plane ==1 ; +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return color_plane ==1 || color_plane ==2 ;case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :return color_plane ==1 || color_plane ==3 ;default :
@@ -2467,6 +2474,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return I915_TILING_Y ;default :return I915_TILING_NONE ;
@@ -2520,6 +2528,21 @@ static const struct drm_format_info gen12_ccs_formats[] = { .cpp = { 1, 1, 2, 1}, .hsub = 2, .vsub = 2, .is_yuv = true }, }; +/* +* Same as gen12_ccs_formats[] above, but with additional surface used +* to pass Clear Color information in plane 2 with 64 bits of data. +*/ +static const struct drm_format_info gen12_ccs_cc_formats[] = { + { .format =DRM_FORMAT_XRGB8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_XBGR8888 , .depth =24 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , }, + { .format =DRM_FORMAT_ARGB8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, + { .format =DRM_FORMAT_ABGR8888 , .depth =32 , .num_planes =3 , + .cpp = {4 ,1 ,0 , }, .hsub =2 , .vsub =32 , .has_alpha = true }, +}; +static const struct drm_format_info *lookup_format_info (const struct drm_format_info formats[],int num_formats,u32 format)
@@ -2547,6 +2570,10 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd)return lookup_format_info (gen12_ccs_formats,ARRAY_SIZE (gen12_ccs_formats), cmd->pixel_format); +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : +return lookup_format_info (gen12_ccs_cc_formats, +ARRAY_SIZE (gen12_ccs_cc_formats), + cmd->pixel_format);default :return NULL ; }
@@ -2556,6 +2583,7 @@ bool is_ccs_modifier(u64 modifier) {return modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC || modifier ==I915_FORMAT_MOD_Y_TILED_CCS || modifier == I915_FORMAT_MOD_Yf_TILED_CCS; }
@@ -2743,6 +2771,8 @@ static bool is_ccs_plane(u64 modifier, int color_plane)return false; else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS) return color_plane == 3 || color_plane == 1; + else if (modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC) + return color_plane == 1 || color_plane == 2; else return color_plane == 1; }
@@ -2811,6 +2841,18 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,int x, y;int ret; +/* +* Plane 2 of Render Compression with Clear Color fb modifier +* is consumed by the driver and not passed to DE. Skip the +* arithmetic related to alignment and offset calculation. +*/ +if (i ==2 && fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +if (IS_ALIGNED (fb->offsets[2 ],PAGE_SIZE )) +continue ; +else +return -EINVAL ; + } + cpp = fb->format->cpp[i];intel_fb_plane_dims (&width, &height, fb, i);
@@ -4269,6 +4311,7 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)case I915_FORMAT_MOD_Y_TILED :return PLANE_CTL_TILED_Y ;case I915_FORMAT_MOD_Y_TILED_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :return PLANE_CTL_TILED_Y |PLANE_CTL_RENDER_DECOMPRESSION_ENABLE ;case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : return PLANE_CTL_TILED_Y |
@@ -15048,6 +15091,15 @@ static int intel_plane_pin_fb(struct intel_plane_state *plane_state) plane_state->vma = vma; +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) { +u32 *ccaddr =kmap_atomic (i915_gem_object_get_page (intel_fb_obj (fb), + fb->offsets[2 ] >>PAGE_SHIFT )); + + plane_state->ccval = ((u64)*(ccaddr +CC_VAL_HIGHER_OFFSET ) <<32 ) + | *(ccaddr +CC_VAL_LOWER_OFFSET ); +kunmap_atomic (ccaddr); + } +return 0 ; }
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -579,6 +579,9 @@ struct intel_plane_state {u32 planar_slave;struct drm_intel_sprite_colorkey ckey; + +/* Clear Color Value */ +u64 ccval; };struct intel_initial_plane_config {
drivers/gpu/drm/i915/display/intel_sprite.c +10 -1
@@ -547,6 +547,7 @@ skl_program_plane(struct intel_plane *plane,u32 plane_color_ctl =0 ;unsigned long irqflags;u32 keymsk, keymax; +u64 ccval = plane_state->ccval; plane_ctl |=skl_plane_ctl_crtc (crtc_state);
@@ -607,6 +608,10 @@ skl_program_plane(struct intel_plane *plane,if (fb->format->is_yuv &&icl_is_hdr_plane (dev_priv, plane_id))icl_program_input_csc (plane, crtc_state, plane_state); +if (fb->modifier ==I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ) +intel_uncore_write64_fw (&dev_priv->uncore, +PLANE_CC_VAL (pipe, plane_id), ccval); +skl_write_plane_wm (plane, crtc_state);I915_WRITE_FW (PLANE_KEYVAL (pipe, plane_id), key->min_value);
@@ -1737,7 +1742,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state, fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS || fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS || - fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS)) { + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS || + fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)) {DRM_DEBUG_KMS ("Y/Yf tiling not supported in IF-ID mode\n" );return -EINVAL ; }
@@ -2152,6 +2158,7 @@ static const u64 skl_plane_format_modifiers_ccs[] = {static const u64 gen12_plane_format_modifiers_mc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ,I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,
@@ -2160,6 +2167,7 @@ static const u64 gen12_plane_format_modifiers_mc_ccs[] = {static const u64 gen12_plane_format_modifiers_rc_ccs[] = {I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS , +I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ,I915_FORMAT_MOD_Y_TILED ,I915_FORMAT_MOD_X_TILED ,DRM_FORMAT_MOD_LINEAR ,
@@ -2333,6 +2341,7 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,case I915_FORMAT_MOD_X_TILED :case I915_FORMAT_MOD_Y_TILED :case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : +case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC :break ;default :return false;
drivers/gpu/drm/i915/i915_reg.h +12 -0
@@ -6750,6 +6750,8 @@ enum {#define _PLANE_KEYMAX_1_A 0x701a0#define _PLANE_KEYMAX_2_A 0x702a0#define PLANE_KEYMAX_ALPHA (a) ((a) << 24) +#define _PLANE_CC_VAL_1_A 0x701b4 +#define _PLANE_CC_VAL_2_A 0x702b4#define _PLANE_AUX_DIST_1_A 0x701c0#define _PLANE_AUX_DIST_2_A 0x702c0#define _PLANE_AUX_OFFSET_1_A 0x701c4
@@ -6789,6 +6791,16 @@ enum {#define _PLANE_NV12_BUF_CFG_1_A 0x70278#define _PLANE_NV12_BUF_CFG_2_A 0x70378 +#define _PLANE_CC_VAL_1_B 0x711b4 +#define _PLANE_CC_VAL_2_B 0x712b4 +#define _PLANE_CC_VAL_1 (pipe) _PIPE(pipe, _PLANE_CC_VAL_1_A, _PLANE_CC_VAL_1_B) +#define _PLANE_CC_VAL_2 (pipe) _PIPE(pipe, _PLANE_CC_VAL_2_A, _PLANE_CC_VAL_2_B) +#define PLANE_CC_VAL (pipe, plane) \ + _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe)) + +#define CC_VAL_LOWER_OFFSET 4 +#define CC_VAL_HIGHER_OFFSET 5 +/* Input CSC Register Definitions */ #define _PLANE_INPUT_CSC_RY_GY_1_A 0x701E0#define _PLANE_INPUT_CSC_RY_GY_2_A 0x702E0
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev4)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev4)
URL : https://patchwork.freedesktop.org/series/66814/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 5b2a67fc7d74 drm/framebuffer: Format modifier for Intel Gen-12 render compression 7ae892f52e6b drm/i915: Use intel_tile_height() instead of re-implementing 6e151153d384 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment fe009ce2a753 drm/i915/tgl: Gen-12 render decompression 922c0f17cfcb drm/i915: Extract framebufer CCS offset checks into a function 3e0c8644766c drm/framebuffer: Format modifier for Intel Gen-12 media compression e81ef5974cd9 drm/fb: Extend format_info member arrays to handle four planes 6af18a7bd390 Gen-12 display can decompress surfaces compressed by the media engine. -:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #13: compressed buffers. Unlike render decompression, plane 6 and plane 7 do not
-:113: WARNING:LONG_LINE: line over 100 characters
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:2699:
+intel_fb_plane_get_subsampling(int *hsub, int *vsub, const struct drm_framebuffer *fb, int color_plane)
-:120: WARNING:LONG_LINE: line over 100 characters #120: FILE: drivers/gpu/drm/i915/display/intel_display.c:2706:
+ } mc_ccs_subsampling = {.cpp = {1, 1, 2, 1}, .hsub = {1, 8, 2, 16}, .vsub = {1, 32, 2, 32} };
total: 0 errors, 3 warnings, 0 checks, 509 lines checked0a4f1ab7678c drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7:
Gen12 display can decompress surfaces compressed by render engine with Clear Color, add
-:33: ERROR:TRAILING_WHITESPACE: trailing whitespace
#33: FILE: include/uapi/drm/drm_fourcc.h:442:
+ * be ignored. The size of clear color should be 64 bits. A CCS_CC cache line $
-:34: ERROR:TRAILING_WHITESPACE: trailing whitespace
#34: FILE: include/uapi/drm/drm_fourcc.h:443:
+ * corresponds to an area of 4x1 tiles in the main surface. The main surface $
total: 2 errors, 1 warnings, 0 checks, 17 lines checkedcb25ebee96c9 drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression -:252: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #252: FILE: drivers/gpu/drm/i915/i915_reg.h:6791:
+#define PLANE_CC_VAL(pipe, plane) \
+ _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe))
total: 0 errors, 0 warnings, 1 checks, 198 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Clear Color Support for TGL Render Decompression (rev4)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev4)
URL : https://patchwork.freedesktop.org/series/66814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7091 -> Patchwork_14802
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14802/index.html
Known issues
------------
Here are the changes found in Patchwork_14802 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-apl-guc: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-apl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14802/fi-apl-guc/igt@[email protected]
* igt@gem_ctx_switch@rcs0:
- fi-icl-u2: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-icl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14802/fi-icl-u2/igt@[email protected]
* igt@gem_mmap_gtt@basic-copy:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14802/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-read-no-prefault:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14802/fi-icl-u3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
Participating hosts (52 -> 45)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-icl-guc fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7091 -> Patchwork_14802
CI-20190529: 20190529
CI_DRM_7091: d88a66d195bcf71e6e05db07ba79c9fab5651f22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14802: cb25ebee96c966a74afdf8e23a4004a82757e32d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
cb25ebee96c9 drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression 0a4f1ab7678c drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color 6af18a7bd390 Gen-12 display can decompress surfaces compressed by the media engine. e81ef5974cd9 drm/fb: Extend format_info member arrays to handle four planes 3e0c8644766c drm/framebuffer: Format modifier for Intel Gen-12 media compression 922c0f17cfcb drm/i915: Extract framebufer CCS offset checks into a function fe009ce2a753 drm/i915/tgl: Gen-12 render decompression6e151153d384 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment 7ae892f52e6b drm/i915: Use intel_tile_height() instead of re-implementing 5b2a67fc7d74 drm/framebuffer: Format modifier for Intel Gen-12 render compression
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14802/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev5)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev5)
URL : https://patchwork.freedesktop.org/series/66814/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip e84d0c20bec1 drm/framebuffer: Format modifier for Intel Gen-12 render compression 46a58f5e2541 drm/i915: Use intel_tile_height() instead of re-implementing 43b42e53f492 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment 150111127386 drm/i915/tgl: Gen-12 render decompression 8be18fc5f18e drm/i915: Extract framebufer CCS offset checks into a function e9aab6479891 drm/framebuffer: Format modifier for Intel Gen-12 media compression b4947111fb56 drm/fb: Extend format_info member arrays to handle four planes 0f52b8eef612 Gen-12 display can decompress surfaces compressed by the media engine. -:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #13: compressed buffers. Unlike render decompression, plane 6 and plane 7 do not
-:113: WARNING:LONG_LINE: line over 100 characters
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:2699:
+intel_fb_plane_get_subsampling(int *hsub, int *vsub, const struct drm_framebuffer *fb, int color_plane)
-:120: WARNING:LONG_LINE: line over 100 characters #120: FILE: drivers/gpu/drm/i915/display/intel_display.c:2706:
+ } mc_ccs_subsampling = {.cpp = {1, 1, 2, 1}, .hsub = {1, 8, 2, 16}, .vsub = {1, 32, 2, 32} };
total: 0 errors, 3 warnings, 0 checks, 509 lines checked71d0a02d234b drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7:
Gen12 display can decompress surfaces compressed by render engine with Clear Color, add
total: 0 errors, 1 warnings, 0 checks, 17 lines checked4f8d40fcc90f drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression -:252: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #252: FILE: drivers/gpu/drm/i915/i915_reg.h:6791:
+#define PLANE_CC_VAL(pipe, plane) \
+ _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe))
total: 0 errors, 0 warnings, 1 checks, 198 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Clear Color Support for TGL Render Decompression (rev5)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev5)
URL : https://patchwork.freedesktop.org/series/66814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7091 -> Patchwork_14803
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14803:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_module_load@reload-with-fault-injection:
- {fi-tgl-u}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-tgl-u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/fi-tgl-u/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14803 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_render_linear_blits@basic:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/fi-icl-u3/igt@[email protected]
* igt@i915_selftest@live_hangcheck:
- fi-bsw-n3050: [PASS][5] -> [DMESG-FAIL][6] ([fdo# 111537])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-bsw-n3050/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/fi-bsw-n3050/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#111045] / [fdo#111096])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-read-no-prefault:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/fi-icl-u3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111537]: https://bugs.freedesktop.org/show_bug.cgi?id= 111537 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
Participating hosts (52 -> 46)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7091 -> Patchwork_14803
CI-20190529: 20190529
CI_DRM_7091: d88a66d195bcf71e6e05db07ba79c9fab5651f22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14803: 4f8d40fcc90f255c3f838505ca7a2316ae8ab367 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4f8d40fcc90f drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression 71d0a02d234b drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color 0f52b8eef612 Gen-12 display can decompress surfaces compressed by the media engine. b4947111fb56 drm/fb: Extend format_info member arrays to handle four planes e9aab6479891 drm/framebuffer: Format modifier for Intel Gen-12 media compression 8be18fc5f18e drm/i915: Extract framebufer CCS offset checks into a function 150111127386 drm/i915/tgl: Gen-12 render decompression43b42e53f492 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment 46a58f5e2541 drm/i915: Use intel_tile_height() instead of re-implementing e84d0c20bec1 drm/framebuffer: Format modifier for Intel Gen-12 render compression
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Clear Color Support for TGL Render Decompression (rev5)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev5)
URL : https://patchwork.freedesktop.org/series/66814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7091_full -> Patchwork_14803_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14803_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-f:
- {shard-tglb}: NOTRUN -> [SKIP][1] +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-tglb2/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-c-planes:
- {shard-tglb}: NOTRUN -> [FAIL][2] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-tglb7/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14803_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb2/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-iclb: [PASS][5] -> [DMESG-WARN][6] ([fdo#111764])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb3/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-snb: [PASS][7] -> [FAIL][8] ([fdo#109661])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-snb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-snb1/igt@[email protected]
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#111325]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb2/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-snb4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-snb2/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-hsw5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-hsw6/igt@[email protected]
* igt@i915_pm_rpm@gem-mmap-gtt:
- shard-iclb: [PASS][15] -> [INCOMPLETE][16] ([fdo#107713] / [fdo#108840])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb1/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: [PASS][17] -> [FAIL][18] ([fdo#103355])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-hsw8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-hsw8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-apl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-apl5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-skl9/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-skl5/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103166])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb5/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb7/igt@[email protected]
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb6/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: [PASS][29] -> [FAIL][30] ([fdo#109016]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-glk4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-glk2/igt@[email protected]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: [PASS][31] -> [FAIL][32] ([fdo#109016]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-kbl7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-kbl1/igt@[email protected]
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#109016]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb2/igt@[email protected]
* igt@kms_setmode@basic:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#99912])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-skl2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-skl5/igt@[email protected]
* igt@perf_pmu@rc6-runtime-pm:
- shard-iclb: [PASS][37] -> [INCOMPLETE][38] ([fdo#107713])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb1/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109276]) +21 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb3/igt@[email protected]
* igt@prime_mmap_coherency@read:
- shard-snb: [PASS][41] -> [INCOMPLETE][42] ([fdo#105411])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-snb2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-snb7/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-snb: [FAIL][43] ([fdo#109661]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-snb2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-snb1/igt@[email protected]
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [SKIP][45] ([fdo#111325]) -> [PASS][46] +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [SKIP][47] ([fdo#109276]) -> [PASS][48] +12 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb4/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [INCOMPLETE][49] ([fdo#103359] / [fdo#108686] / [k.org#198133]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-glk4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-glk5/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-snb6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-snb5/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-hsw8/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-hsw7/igt@[email protected]
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [DMESG-FAIL][55] ([fdo#111991]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-hsw8/igt@i915_selftest@live_hangcheck.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-hsw7/igt@i915_selftest@live_hangcheck.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-skl: [DMESG-WARN][57] ([fdo#106107]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-skl2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-skl5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][59] ([fdo#103167]) -> [PASS][60] +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
- shard-iclb: [INCOMPLETE][61] ([fdo#106978] / [fdo#107713]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb7/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb1/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][63] ([fdo#108566]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-apl4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-apl7/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][67] ([fdo#99912]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-apl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-apl5/igt@[email protected]
* igt@prime_busy@wait-hang-blt:
- shard-apl: [INCOMPLETE][69] ([fdo#103927]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-apl2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-apl6/igt@[email protected]
#### Warnings ####
* igt@gem_mocs_settings@mocs-rc6-bsd2:
- shard-iclb: [SKIP][71] ([fdo#109276]) -> [FAIL][72] ([fdo#111330])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb1/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][73] ([fdo#107724]) -> [SKIP][74] ([fdo#109349])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-iclb2/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-iclb6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-apl: [INCOMPLETE][75] ([fdo#103927]) -> [DMESG-WARN][76] ([fdo#108566])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7091/shard-apl6/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/shard-apl4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7091 -> Patchwork_14803
CI-20190529: 20190529
CI_DRM_7091: d88a66d195bcf71e6e05db07ba79c9fab5651f22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14803: 4f8d40fcc90f255c3f838505ca7a2316ae8ab367 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14803/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev7)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev7)
URL : https://patchwork.freedesktop.org/series/66814/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip ad3f8ef792a4 drm/framebuffer: Format modifier for Intel Gen-12 render compression 8130c8f3c633 drm/i915: Use intel_tile_height() instead of re-implementing 0513f8dd0e4f drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment aa26ffc536ed drm/i915/tgl: Gen-12 render decompression 3a4093bd96ef drm/i915: Extract framebufer CCS offset checks into a function 130bad161a5f drm/framebuffer: Format modifier for Intel Gen-12 media compression 5f5914ce2a12 drm/fb: Extend format_info member arrays to handle four planes 791ce575f45a Gen-12 display can decompress surfaces compressed by the media engine. -:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #13: compressed buffers. Unlike render decompression, plane 6 and plane 7 do not
-:113: WARNING:LONG_LINE: line over 100 characters
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:2713:
+intel_fb_plane_get_subsampling(int *hsub, int *vsub, const struct drm_framebuffer *fb, int color_plane)
-:120: WARNING:LONG_LINE: line over 100 characters #120: FILE: drivers/gpu/drm/i915/display/intel_display.c:2720:
+ } mc_ccs_subsampling = {.cpp = {1, 1, 2, 1}, .hsub = {1, 8, 2, 16}, .vsub = {1, 32, 2, 32} };
total: 0 errors, 3 warnings, 0 checks, 509 lines checked471c649e8d20 drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7:
Gen12 display can decompress surfaces compressed by render engine with Clear Color, add
total: 0 errors, 1 warnings, 0 checks, 24 lines checked4530a97a79f2 drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression -:253: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #253: FILE: drivers/gpu/drm/i915/i915_reg.h:6798:
+#define PLANE_CC_VAL(pipe, plane) \
+ _MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe))
total: 0 errors, 0 warnings, 1 checks, 198 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Clear Color Support for TGL Render Decompression (rev7)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev7)
URL : https://patchwork.freedesktop.org/series/66814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7155 -> Patchwork_14937
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14937:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live_gem:
- {fi-tgl-u}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/fi-tgl-u/igt@i915_selftest@live_gem.html
Known issues
------------
Here are the changes found in Patchwork_14937 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-write-read:
- fi-icl-u3: [PASS][2] -> [DMESG-WARN][3] ([fdo#107724]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@gem_flink_basic@basic:
- fi-icl-u3: [DMESG-WARN][4] ([fdo#107724] / [fdo#112052 ]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/fi-icl-u3/igt@[email protected]
* igt@gem_sync@basic-many-each:
- {fi-tgl-u}: [INCOMPLETE][6] ([fdo#111880]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-tgl-u/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/fi-tgl-u/igt@[email protected]
* igt@vgem_basic@setversion:
- fi-icl-u3: [DMESG-WARN][8] ([fdo#107724]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/fi-icl-u3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
[fdo#112052 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112052
[fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
Participating hosts (52 -> 43)
------------------------------
Additional (1): fi-bxt-dsi
Missing (10): fi-icl-u4 fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus fi-cml-u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7155 -> Patchwork_14937
CI-20190529: 20190529
CI_DRM_7155: 87aff128f9bafd90854e4691c3afcdf7a0e61ce2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5235: da9abbab69be80dd00812a4607a4ea2dffcc4544 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14937: 4530a97a79f21b2d24a9c0a8750524d8f6b9d34b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4530a97a79f2 drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression 471c649e8d20 drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color 791ce575f45a Gen-12 display can decompress surfaces compressed by the media engine. 5f5914ce2a12 drm/fb: Extend format_info member arrays to handle four planes 130bad161a5f drm/framebuffer: Format modifier for Intel Gen-12 media compression 3a4093bd96ef drm/i915: Extract framebufer CCS offset checks into a function aa26ffc536ed drm/i915/tgl: Gen-12 render decompression0513f8dd0e4f drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment 8130c8f3c633 drm/i915: Use intel_tile_height() instead of re-implementing ad3f8ef792a4 drm/framebuffer: Format modifier for Intel Gen-12 render compression
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Clear Color Support for TGL Render Decompression (rev7)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: Clear Color Support for TGL Render Decompression (rev7)
URL : https://patchwork.freedesktop.org/series/66814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14937_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14937_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- {shard-tglb}: [PASS][1] -> [FAIL][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-tglb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-tglb3/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-d-planes:
- {shard-tglb}: NOTRUN -> [FAIL][3] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-tglb3/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14937_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#109276] / [fdo#112080]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb4/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb7/igt@[email protected]
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276]) +16 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#111325]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb8/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb1/igt@[email protected]
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][10] -> [FAIL][11] ([fdo#112037])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-snb1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-snb4/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-snb: [PASS][12] -> [DMESG-WARN][13] ([fdo#111870])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-snb7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-snb6/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [PASS][14] -> [DMESG-WARN][15] ([fdo#111870])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-hsw1/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-hsw5/igt@[email protected]
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [PASS][16] -> [DMESG-WARN][17] ([fdo#105763] / [fdo#106538])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-glk2/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-glk8/igt@[email protected]
* igt@kms_busy@basic-flip-c:
- shard-skl: [PASS][18] -> [DMESG-WARN][19] ([fdo#106107])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-skl3/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-skl8/igt@[email protected]
* igt@kms_busy@extended-pageflip-hang-oldfb-render-a:
- shard-iclb: [PASS][20] -> [INCOMPLETE][21] ([fdo#107713])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb3/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][22] -> [INCOMPLETE][23] ([fdo#103665])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-kbl3/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-kbl1/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-apl: [PASS][24] -> [INCOMPLETE][25] ([fdo#103927])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-apl4/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-apl4/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][26] -> [INCOMPLETE][27] ([fdo#103540])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-hsw1/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-hsw2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][28] -> [FAIL][29] ([fdo#103167]) +4 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb5/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][30] -> [DMESG-WARN][31] ([fdo#103313])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-kbl6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-kbl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#108145])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-skl9/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-skl5/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#109441])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: [PASS][36] -> [FAIL][37] ([fdo#109016]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-glk8/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-glk6/igt@[email protected]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: [PASS][38] -> [FAIL][39] ([fdo#109016]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-kbl1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-kbl7/igt@[email protected]
- shard-iclb: [PASS][40] -> [FAIL][41] ([fdo#109016]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb8/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][42] -> [DMESG-WARN][43] ([fdo#108566]) +6 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-apl4/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-apl4/igt@[email protected]
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][44] -> [SKIP][45] ([fdo#112080]) +7 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb4/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb3/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-dirty-switch:
- shard-iclb: [SKIP][46] ([fdo#109276] / [fdo#112080]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb7/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb4/igt@[email protected]
* igt@gem_ctx_isolation@vecs0-s3:
- shard-kbl: [INCOMPLETE][48] ([fdo#103665]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-kbl4/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-kbl2/igt@[email protected]
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][50] ([fdo#110841]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb2/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb5/igt@[email protected]
* igt@gem_ctx_switch@vcs1-heavy-queue:
- shard-iclb: [SKIP][52] ([fdo#112080]) -> [PASS][53] +11 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb8/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][54] ([fdo#111325]) -> [PASS][55] +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb2/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb5/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][56] ([fdo#111870]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-snb5/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-snb6/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][58] ([fdo#111870]) -> [PASS][59] +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-hsw6/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-hsw1/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-apl: [INCOMPLETE][60] ([fdo#103927]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-apl3/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-apl3/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][62] ([fdo#108566]) -> [PASS][63] +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-apl7/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-apl3/igt@[email protected]
- {shard-tglb}: [INCOMPLETE][64] ([fdo#111832] / [fdo#111850]) -> [PASS][65] +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-tglb1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-tglb6/igt@[email protected]
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][66] ([fdo#110548]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb2/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb8/igt@[email protected]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: [SKIP][68] ([fdo#109271]) -> [PASS][69] +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-snb6/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-snb4/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-iclb: [INCOMPLETE][70] ([fdo#107713]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb1/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb5/igt@[email protected]
* igt@kms_flip@dpms-vs-vblank-race:
- shard-glk: [FAIL][72] ([fdo#111609]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-glk2/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-glk8/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][74] ([fdo#105363]) -> [PASS][75] +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-glk1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-glk2/igt@[email protected]
* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-skl: [FAIL][76] ([fdo#107931] / [fdo#108303]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-skl3/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-skl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt:
- shard-iclb: [FAIL][78] ([fdo#103167]) -> [PASS][79] +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb5/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][80] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-tglb5/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-tglb8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
- {shard-tglb}: [FAIL][82] ([fdo#103167]) -> [PASS][83] +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][84] ([fdo#109441]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][86] ([fdo#99912]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-glk4/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-glk2/igt@[email protected]
* igt@perf@short-reads:
- shard-glk: [TIMEOUT][88] ([fdo#103183]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-glk9/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-glk1/igt@[email protected]
* igt@perf_pmu@busy-start-vecs0:
- {shard-tglb}: [INCOMPLETE][90] ([fdo#111747]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-tglb6/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-tglb7/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][92] ([fdo#109276]) -> [PASS][93] +15 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb8/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb2/igt@[email protected]
#### Warnings ####
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [SKIP][94] ([fdo#109276]) -> [FAIL][95] ([fdo#111330])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb5/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb1/igt@[email protected]
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][96] ([fdo#111330]) -> [SKIP][97] ([fdo#109276])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/shard-iclb2/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/shard-iclb5/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103183]: https://bugs.freedesktop.org/show_bug.cgi?id=103183
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14937/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx