Skip to contentSkip to conversation

drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

PATCH RESEND In review Fabio Estevam 4 participants 6 messages Oct 15, 2019 – Nov 12, 2019 4 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

Booting the adreno driver on a imx53 board leads to the following error message:

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.

---

 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +1 -1
index 0783e4b5486a..5d7bdb4c83cc 100644
@@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
 
 	node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
 	if (!node) {
-		DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
+		DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
 		return -ENXIO;
 	}
 
Signature · 6 lines
2.17.1

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

A message that is not in the archive (sent off-list or not yet received): 20191015134012.15165-1-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 10 lines · Fabio Estevam

Booting the adreno driver on a imx53 board leads to the following error message:

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.

Seems reasonable. Reviewed-by: Jeffrey Hugo <[email protected]>

Quoted 21 lines

---

 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +1 -2
index 0783e4b5486a..5d7bdb4c83cc 100644
@@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
 
        node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
        if (!node) {
-               DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
+               DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
                return -ENXIO;
        }
 
--

2.17.1

Quoted 4 lines

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

A message that is not in the archive (sent off-list or not yet received): CAOCk7NpoGA8VmTXSk96VxVtGU2yFs0+n8wyBeQkvwR8HZSOCRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw

Hi Rob,

Quoted 6 lines · Jeffrey Hugo
Quoted 4 lines · Fabio Estevam

Booting the adreno driver on a imx53 board leads to the following error message:

Quoted 8 lines
Quoted 6 lines

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.

Seems reasonable. Reviewed-by: Jeffrey Hugo <[email protected]>

Any comments, please?

Just wanted to get rid of this misleading error message on i.MX5.

Thanks
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw
Quoted 14 lines · Fabio Estevam

Hi Rob,

Quoted 11 lines · Jeffrey Hugo
Quoted 9 lines · Fabio Estevam

Booting the adreno driver on a imx53 board leads to the following error message:

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Seems reasonable. Reviewed-by: Jeffrey Hugo <[email protected]>

Any comments, please?

Just wanted to get rid of this misleading error message on i.MX5.

I'm good with this. This really should only be around for compatibility with downstream device tree files which should mean nothing for I.MX5.

Jordan

Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

A message that is not in the archive (sent off-list or not yet received): 20191101145209.GA16446-p/[email protected]

A message that is not in the archive (sent off-list or not yet received): CAOMZO5ADoav=-6ZMn-C=7UA0Fz96BVyitSYeAsn+kxf8HBzZ2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#9 lore raw
Quoted 9 lines · Fabio Estevam

Hi Jordan,

Quoted 3 lines · Jordan Crouse

I'm good with this. This really should only be around for compatibility with downstream device tree files which should mean nothing for I.MX5.

May I resend it with your Reviewed-by tag?

Of course.

Jordan

Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno