drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
Subsystems (3)
PATCH RESEND 1/1 drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
Booting the adreno driver on a imx53 board leads to the following error message:
adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +1 -1
@@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev) node =of_get_compatible_child (dev->of_node,"qcom,gpu-pwrlevels" );if (!node) { -DRM_DEV_ERROR (dev,"Could not find the GPU powerlevels\n" ); +DRM_DEV_DEBUG (dev,"Could not find the GPU powerlevels\n" );return -ENXIO ; }
Signature · 6 lines
2.17.1 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 10 lines · Fabio Estevam
Booting the adreno driver on a imx53 board leads to the following error message:
adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.
Signed-off-by Fabio Estevam <[email protected]>
Seems reasonable. Reviewed-by: Jeffrey Hugo <[email protected]>
Quoted 21 lines
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/adreno/adreno_gpu.c +1
-2@@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev) node =of_get_compatible_child (dev->of_node,"qcom,gpu-pwrlevels" );if (!node) { -DRM_DEV_ERROR (dev,"Could not find the GPU powerlevels\n" ); +DRM_DEV_DEBUG (dev,"Could not find the GPU powerlevels\n" );return -ENXIO ; } --2.17.1
Quoted 4 lines
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Hi Rob,
Quoted 6 lines · Jeffrey Hugo
Quoted 4 lines · Fabio Estevam
Booting the adreno driver on a imx53 board leads to the following error message:
Quoted 8 lines
Quoted 6 lines
adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.
Signed-off-by Fabio Estevam <[email protected]>Seems reasonable. Reviewed-by: Jeffrey Hugo <[email protected]>
Any comments, please?
Just wanted to get rid of this misleading error message on i.MX5.
Thanks
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 14 lines · Fabio Estevam
Hi Rob,
Quoted 11 lines · Jeffrey Hugo
Quoted 9 lines · Fabio Estevam
Booting the adreno driver on a imx53 board leads to the following error message:
adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Fabio Estevam <[email protected]>Seems reasonable. Reviewed-by: Jeffrey Hugo <[email protected]>
Any comments, please?
Just wanted to get rid of this misleading error message on i.MX5.
I'm good with this. This really should only be around for compatibility with downstream device tree files which should mean nothing for I.MX5.
Jordan
Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Jordan,
Quoted 3 lines · Jordan Crouse
I'm good with this. This really should only be around for compatibility with downstream device tree files which should mean nothing for I.MX5.
May I resend it with your Reviewed-by tag?
Thanks
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 9 lines · Fabio Estevam
Hi Jordan,
Quoted 3 lines · Jordan Crouse
I'm good with this. This really should only be around for compatibility with downstream device tree files which should mean nothing for I.MX5.
May I resend it with your Reviewed-by tag?
Of course.
Jordan
Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno