s390x/cpumodel: Add missing visit_free
PATCH 1/1 s390x/cpumodel: Add missing visit_free
Beata Michalska noticed this missing visit_free() while reviewing arm's implementation of qmp_query_cpu_model_expansion(), which is modeled off this s390x implementation.
--- target/s390x/cpu_models.c | 1 + 1 file changed, 1 insertion(+)
target/s390x/cpu_models.c +1 -0
@@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, visitor =qobject_input_visitor_new (info->props);visit_start_struct (visitor,NULL ,NULL ,0 , errp);if (*errp) { +visit_free (visitor);object_unref (obj);return ; }
Signature · 1 line
2.21.0
Quoted 3 lines · Andrew Jones
Beata Michalska noticed this missing
visit_free()while reviewing arm's implementation ofqmp_query_cpu_model_expansion(), which is modeled off this s390x implementation.
Nice to see ARM support getting added.
Quoted 12 lines
Signed-off-by Andrew Jones <[email protected]>--- target/s390x/cpu_models.c | 1 + 1 file changed, 1 insertion(+)target/s390x/cpu_models.c +0
-0
target/s390x/cpu_models.c static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, · line 521
Quoted 7 lines
target/s390x/cpu_models.c +1
-0@@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, visitor =qobject_input_visitor_new (info->props);visit_start_struct (visitor,NULL ,NULL ,0 , errp);if (*errp) { +visit_free (visitor);object_unref (obj);return ; }
Right, thanks
Signature · 3 lines
Thanks, David / dhildenb
Cornelia Huck
AppliedQuoted 14 lines · On Wed, 16 Oct 2019 16:54:34 +0200 Andrew Jones <[email protected]> wrote:
Beata Michalska noticed this missing
visit_free()while reviewing arm's implementation ofqmp_query_cpu_model_expansion(), which is modeled off this s390x implementation.Signed-off-by Andrew Jones <[email protected]>--- target/s390x/cpu_models.c | 1 + 1 file changed, 1 insertion(+)target/s390x/cpu_models.c +0
-0
target/s390x/cpu_models.c static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, · line 521
Quoted 7 lines
target/s390x/cpu_models.c +1
-0@@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, visitor =qobject_input_visitor_new (info->props);visit_start_struct (visitor,NULL ,NULL ,0 , errp);if (*errp) { +visit_free (visitor);object_unref (obj);return ; }
Thanks, applied.