Initialise thermal framework and cpufreq earlier during boot
Subsystems (5)
v2 cover Initialise thermal framework and cpufreq earlier during boot
Changes since v1:
- Completely get rid of netlink support in the thermal framework.
- This changes the early init patch to a single line - change to core_initcall. Changed authorship of patch since it is nothing like the original. Lina, let me know if you feel otherwise.
- I've tested to make sure that the qcom-cpufreq-hw driver continues to work correctly as a module so this won't impact Android's GKI plans.
- Collected Acks
Device boot needs to be as fast as possible while keeping under the thermal envelope. Now that thermal framework is built-in to the kernel, we can initialize it earlier to enable thermal mitigation during boot.
We also need the cpufreq HW drivers to be initialised earlier to act as the cooling devices. This series only converts over the qcom-hw driver to initialize earlier but can be extended to other platforms as well.
Amit Kucheria (5):
thermal: Initialize thermal subsystem earlier
cpufreq: Initialise the governors in core_initcall
cpufreq: Initialize cpufreq-dt driver earlier
clk: qcom: Initialise clock drivers earlier
cpufreq: qcom-hw: Move driver initialisation earlier
drivers/clk/qcom/clk-rpmh.c | 2 +- drivers/clk/qcom/gcc-qcs404.c | 2 +- drivers/clk/qcom/gcc-sdm845.c | 2 +- drivers/cpufreq/cpufreq-dt-platdev.c | 2 +- drivers/cpufreq/cpufreq_conservative.c | 2 +- drivers/cpufreq/cpufreq_ondemand.c | 2 +- drivers/cpufreq/cpufreq_performance.c | 2 +- drivers/cpufreq/cpufreq_powersave.c | 2 +- drivers/cpufreq/cpufreq_userspace.c | 2 +- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- drivers/thermal/thermal_core.c | 3 ++- 11 files changed, 12 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/5 thermal: Initialize thermal subsystem earlier
Now that the thermal framework is built-in, in order to facilitate thermal mitigation as early as possible in the boot cycle, move the thermal framework initialization to core_initcall.
--- drivers/thermal/thermal_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/thermal/thermal_core.c +2 -1
@@ -1537,4 +1537,5 @@ static int __init thermal_init(void)mutex_destroy (&poweroff_lock);return result; } -fs_initcall (thermal_init); + +core_initcall (thermal_init);
Signature · 1 line
2.17.1
PATCH v2 2/5 cpufreq: Initialise the governors in core_initcall
In reply to Amit KucheriaInitialise the cpufreq governors earlier to allow for earlier performance control during the boot process.
--- drivers/cpufreq/cpufreq_conservative.c | 2 +- drivers/cpufreq/cpufreq_ondemand.c | 2 +- drivers/cpufreq/cpufreq_performance.c | 2 +- drivers/cpufreq/cpufreq_powersave.c | 2 +- drivers/cpufreq/cpufreq_userspace.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
drivers/cpufreq/cpufreq_conservative.c +1 -1
@@ -346,7 +346,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) return CPU_FREQ_GOV_CONSERVATIVE; } -fs_initcall (cpufreq_gov_dbs_init); +core_initcall (cpufreq_gov_dbs_init);#else module_init (cpufreq_gov_dbs_init);#endif
drivers/cpufreq/cpufreq_ondemand.c +1 -1
@@ -483,7 +483,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) return CPU_FREQ_GOV_ONDEMAND; } -fs_initcall (cpufreq_gov_dbs_init); +core_initcall (cpufreq_gov_dbs_init);#else module_init (cpufreq_gov_dbs_init);#endif
drivers/cpufreq/cpufreq_performance.c +1 -1
@@ -50,5 +50,5 @@ MODULE_AUTHOR("Dominik Brodowski <[email protected]>");MODULE_DESCRIPTION ("CPUfreq policy governor 'performance'" );MODULE_LICENSE ("GPL" ); -fs_initcall (cpufreq_gov_performance_init); +core_initcall (cpufreq_gov_performance_init);module_exit (cpufreq_gov_performance_exit);
drivers/cpufreq/cpufreq_powersave.c +1 -1
@@ -43,7 +43,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) return &cpufreq_gov_powersave; } -fs_initcall (cpufreq_gov_powersave_init); +core_initcall (cpufreq_gov_powersave_init);#else module_init (cpufreq_gov_powersave_init);#endif
drivers/cpufreq/cpufreq_userspace.c +1 -1
@@ -147,7 +147,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) return &cpufreq_gov_userspace; } -fs_initcall (cpufreq_gov_userspace_init); +core_initcall (cpufreq_gov_userspace_init);#else module_init (cpufreq_gov_userspace_init);#endif
Signature · 1 line
2.17.1
PATCH v2 3/5 cpufreq: Initialize cpufreq-dt driver earlier
In reply to Amit KucheriaThis allows HW drivers that depend on cpufreq-dt to initialise earlier.
--- drivers/cpufreq/cpufreq-dt-platdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/cpufreq-dt-platdev.c +1 -1
@@ -180,4 +180,4 @@ static int __init cpufreq_dt_platdev_init(void)-1 , data, sizeof(struct cpufreq_dt_platform_data))); } -device_initcall (cpufreq_dt_platdev_init); +core_initcall (cpufreq_dt_platdev_init);
Signature · 1 line
2.17.1
PATCH v2 4/5 clk: qcom: Initialise clock drivers earlier
In reply to Amit KucheriaInitialise the clock drivers on sdm845 and qcs404 in core_initcall so we can have earlier access to cpufreq during booting.
--- drivers/clk/qcom/clk-rpmh.c | 2 +- drivers/clk/qcom/gcc-qcs404.c | 2 +- drivers/clk/qcom/gcc-sdm845.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/clk/qcom/clk-rpmh.c +1 -1
@@ -487,7 +487,7 @@ static int __init clk_rpmh_init(void) {return platform_driver_register (&clk_rpmh_driver); } -subsys_initcall (clk_rpmh_init); +core_initcall (clk_rpmh_init); static void __exit clk_rpmh_exit(void) {
drivers/clk/qcom/gcc-qcs404.c +1 -1
@@ -2855,7 +2855,7 @@ static int __init gcc_qcs404_init(void) {return platform_driver_register (&gcc_qcs404_driver); } -subsys_initcall (gcc_qcs404_init); +core_initcall (gcc_qcs404_init); static void __exit gcc_qcs404_exit(void) {
drivers/clk/qcom/gcc-sdm845.c +1 -1
@@ -3628,7 +3628,7 @@ static int __init gcc_sdm845_init(void) {return platform_driver_register (&gcc_sdm845_driver); } -subsys_initcall (gcc_sdm845_init); +core_initcall (gcc_sdm845_init); static void __exit gcc_sdm845_exit(void) {
Signature · 1 line
2.17.1
Re: [PATCH v2 4/5] clk: qcom: Initialise clock drivers earlier
Quoting Amit Kucheria (2019-10-17 03:30:53)
Quoted 5 lines
Initialise the clock drivers on sdm845 and qcs404 in
core_initcallso we can have earlier access to cpufreq during booting.Signed-off-by Amit Kucheria <[email protected]>---
Makes me sad though.
PATCH v2 5/5 cpufreq: qcom-hw: Move driver initialisation earlier
In reply to Amit KucheriaAllow qcom-hw driver to initialise right after the cpufreq and thermal subsystems are initialised in core_initcall so we get earlier access to thermal mitigation.
--- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/qcom-cpufreq-hw.c +1 -1
@@ -334,7 +334,7 @@ static int __init qcom_cpufreq_hw_init(void) {return platform_driver_register (&qcom_cpufreq_hw_driver); } -device_initcall (qcom_cpufreq_hw_init); +postcore_initcall (qcom_cpufreq_hw_init); static void __exit qcom_cpufreq_hw_exit(void) {
Signature · 1 line
2.17.1
This is embarassing. I generated this series incorrectly. It is missing a patch removing netlink support. v3 coming right up.
Sorry for the noise.
Quoted 41 lines · Amit Kucheria
Changes since v1:
- Completely get rid of netlink support in the thermal framework.
- This changes the early init patch to a single line - change tocore_initcall. Changed authorship of patch since it is nothing like the original. Lina, let me know if you feel otherwise.
- I've tested to make sure that the qcom-cpufreq-hw driver continues to work correctly as a module so this won't impact Android's GKI plans.
- Collected AcksDevice boot needs to be as fast as possible while keeping under the thermal envelope. Now that thermal framework is built-in to the kernel, we can initialize it earlier to enable thermal mitigation during boot.
We also need the cpufreq HW drivers to be initialised earlier to act as the cooling devices. This series only converts over the qcom-hw driver to initialize earlier but can be extended to other platforms as well.
Amit Kucheria (5):
thermal: Initialize thermal subsystem earlier
cpufreq: Initialise the governors incore_initcall
cpufreq: Initialize cpufreq-dt driver earlier
clk: qcom: Initialise clock drivers earlier
cpufreq: qcom-hw: Move driver initialisation earlierdrivers/clk/qcom/clk-rpmh.c | 2 +- drivers/clk/qcom/gcc-qcs404.c | 2 +- drivers/clk/qcom/gcc-sdm845.c | 2 +- drivers/cpufreq/cpufreq-dt-platdev.c | 2 +- drivers/cpufreq/cpufreq_conservative.c | 2 +- drivers/cpufreq/cpufreq_ondemand.c | 2 +- drivers/cpufreq/cpufreq_performance.c | 2 +- drivers/cpufreq/cpufreq_powersave.c | 2 +- drivers/cpufreq/cpufreq_userspace.c | 2 +- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- drivers/thermal/thermal_core.c | 3 ++- 11 files changed, 12 insertions(+), 11 deletions(-)--
2.17.1