xen/netback: fix error path of xenvif_connect_data()
Subsystems (4)
PATCH 1/1 xen/netback: fix error path of xenvif_connect_data()
xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get().
Remove the superfluous module_put().
Fixes 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
Cc <[email protected]> # 3.12
Signed-off-by Juergen Gross <[email protected]>
Reviewed-by Paul Durrant <[email protected]>
--- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/xen-netback/interface.c +0 -1
@@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,xenvif_unmap_frontend_data_rings (queue);netif_napi_del (&queue->napi); err: -module_put (THIS_MODULE );return err; }
Signature · 1 line
2.16.4
Quoted 9 lines · Juergen Gross
xenvif_connect_data()callsmodule_put()in case of error. This is wrong as there is no relatedmodule_get().Remove the superfluous
module_put().Fixes 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")Cc <[email protected]> # 3.12Signed-off-by Juergen Gross <[email protected]>Reviewed-by Paul Durrant <[email protected]>
Reviewed-by Wei Liu <[email protected]>
Quoted 19 lines
--- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-)drivers/net/xen-netback/interface.c +0
-1@@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,xenvif_unmap_frontend_data_rings (queue);netif_napi_del (&queue->napi); err: -module_put (THIS_MODULE );return err; }Signature · 1 line
2.16.4
David Miller
maintainerFrom: Juergen Gross <[email protected]>
Date: Fri, 18 Oct 2019 09:45:49 +0200
Quoted 8 lines
xenvif_connect_data()callsmodule_put()in case of error. This is wrong as there is no relatedmodule_get().Remove the superfluous
module_put().Fixes 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")Signed-off-by Juergen Gross <[email protected]>Reviewed-by Paul Durrant <[email protected]>
Applied and queued up for -stable.