Skip to contentSkip to conversation

xen/netback: fix error path of xenvif_connect_data()

PATCH In review Juergen Gross 3 participants 3 messages Oct 18, 2019 – Oct 19, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/netback: fix error path of xenvif_connect_data()

xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get().

Remove the superfluous module_put().

Fixes 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
Cc <[email protected]> # 3.12
---
 drivers/net/xen-netback/interface.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/xen-netback/interface.c +0 -1
index 240f762b3749..103ed00775eb 100644
@@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,
 	xenvif_unmap_frontend_data_rings(queue);
 	netif_napi_del(&queue->napi);
 err:
-	module_put(THIS_MODULE);
 	return err;
 }
 
Signature · 1 line
2.16.4
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Juergen Gross

xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get().

Remove the superfluous module_put().

Fixes 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
Cc <[email protected]> # 3.12
Quoted 19 lines
---
 drivers/net/xen-netback/interface.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/xen-netback/interface.c +0 -1
index 240f762b3749..103ed00775eb 100644
@@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,
 	xenvif_unmap_frontend_data_rings(queue);
 	netif_napi_del(&queue->napi);
 err:
-	module_put(THIS_MODULE);
 	return err;
 }
 
Signature · 1 line
2.16.4
maintainer
#2 lore raw
In reply to Juergen Gross

From: Juergen Gross <[email protected]>
Date: Fri, 18 Oct 2019 09:45:49 +0200

Quoted 8 lines

xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get().

Remove the superfluous module_put().

Fixes 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")

Applied and queued up for -stable.