Skip to contentSkip to conversation

tools/configure

PATCH In review K. Kahurani 2 participants 3 messages Oct 23, 2019

lore
Share & tools
lore
#0 lore raw

cover tools/configure

This patch fixes or tries to fix an issue in the configure scripts whereby the script will choke on systems that do not have a default python executable and subsequently give a garbage error message.

Now that Python 2 is being phased out, it should be expected that some systems, at the very least do have a default Python executable.

K. Kahurani (1):
tools/configure: remove redundancy

 tools/configure | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Signature · 7 lines
2.17.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw

PATCH 1/1 tools/configure: remove redundancy

This piece of code is redundant and results in a garbage error message on systems that do not have a default python executable.

---
 tools/configure | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tools/configure +1 -3
index 82947ad..a1f36d1 100755
@@ -6931,10 +6931,8 @@ fi
 if echo "$PYTHON" | grep -q "^/"; then :
 
 else
-  PYTHON=`type -p "$PYTHON"`
+  PYTHONPATH=`type -p "$PYTHON"`
 fi
-PYTHONPATH=$PYTHON
-PYTHON=`basename $PYTHONPATH`
 
 # Extract the first word of "$PYTHON", so it can be a program name with args.
 set dummy $PYTHON; ac_word=$2
Signature · 7 lines
2.17.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#2 lore raw

Re: [Xen-devel] [PATCH 1/1] tools/configure: remove redundancy

tools/configure

Quoted 12 lines · K. Kahurani

This piece of code is redundant and results in a garbage error message on systems that do not have a default python executable.

---
 tools/configure | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tools/configure +0 -0
index 82947ad..a1f36d1 100755

configure script is a generated file, you should edit tools/configure.ac instead (and then generate tools/configure out of it). You may also want to look at this commit for reasoning of the current code shape:
https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=9caed751db9110c785fd6b1def89d808baa1d907;hp=88339ae94f4309888eae81a6cceac9577a319d7e

Signature · 5 lines
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel