drm: use DIV_ROUND_UP helper macro for calculations
Subsystems (2)
PATCH 1/1 drm: use DIV_ROUND_UP helper macro for calculations
Replace open coded divisor calculations with the DIV_ROUND_UP kernel macro for better readability.
Issue found using coccinelle:
@@
expression n,d;
@@
(
- ((n + d - 1) / d)
+ DIV_ROUND_UP(n,d)
|
- ((n + (d - 1)) / d)
+ DIV_ROUND_UP(n,d)
)
--- drivers/gpu/drm/drm_agpsupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_agpsupport.c +2 -2
@@ -212,7 +212,7 @@ int drm_agp_alloc(struct drm_device *dev, struct drm_agp_buffer *request)if (!entry)return -ENOMEM ; - pages = (request->size +PAGE_SIZE -1 ) /PAGE_SIZE ; + pages =DIV_ROUND_UP (request->size,PAGE_SIZE ); type = (u32 ) request->type; memory =agp_allocate_memory (dev->agp->bridge, pages, type);if (!memory) {
@@ -325,7 +325,7 @@ int drm_agp_bind(struct drm_device *dev, struct drm_agp_binding *request) entry =drm_agp_lookup_entry (dev, request->handle);if (!entry || entry->bound)return -EINVAL ; - page = (request->offset +PAGE_SIZE -1 ) /PAGE_SIZE ; + page =DIV_ROUND_UP (request->offset,PAGE_SIZE ); retcode =drm_bind_agp (entry->memory, page);if (retcode)return retcode;
Signature · 1 line
2.23.0
Quoted 14 lines · Wambui Karuga
Replace open coded divisor calculations with the
DIV_ROUND_UPkernel macro for better readability.
Issue found using coccinelle:
@@
expression n,d;
@@
(
- ((n + d - 1) / d)
+DIV_ROUND_UP(n,d)
|
- ((n + (d - 1)) / d)
+DIV_ROUND_UP(n,d)
)
Quoted 1 line
Signed-off-by Wambui Karuga <[email protected]>
Quoted 34 lines
--- drivers/gpu/drm/drm_agpsupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_agpsupport.c +2
-3@@ -212,7 +212,7 @@ int drm_agp_alloc(struct drm_device *dev, struct drm_agp_buffer *request)if (!entry)return -ENOMEM ; - pages = (request->size +PAGE_SIZE -1 ) /PAGE_SIZE ; + pages =DIV_ROUND_UP (request->size,PAGE_SIZE ); type = (u32 ) request->type; memory =agp_allocate_memory (dev->agp->bridge, pages, type);if (!memory) {@@ -325,7 +325,7 @@ int drm_agp_bind(struct drm_device *dev, struct drm_agp_binding *request) entry =drm_agp_lookup_entry (dev, request->handle);if (!entry || entry->bound)return -EINVAL ; - page = (request->offset +PAGE_SIZE -1 ) /PAGE_SIZE ; + page =DIV_ROUND_UP (request->offset,PAGE_SIZE ); retcode =drm_bind_agp (entry->memory, page);if (retcode)return retcode; --2.23.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025094907.3582-1-wambui.karugax%40gmail.com.
Daniel Vetter
AppliedQuoted 18 lines · Julia Lawall
Quoted 14 lines · Wambui Karuga
Replace open coded divisor calculations with the
DIV_ROUND_UPkernel macro for better readability.
Issue found using coccinelle:
@@
expression n,d;
@@
(
- ((n + d - 1) / d)
+DIV_ROUND_UP(n,d)
|
- ((n + (d - 1)) / d)
+DIV_ROUND_UP(n,d)
)
Quoted 3 lines
Quoted 1 line
Signed-off-by Wambui Karuga <[email protected]>Acked-by Julia Lawall <[email protected]>
Applied to drm-misc-next, thanks for your patch.
-Daniel
Quoted 36 lines
Quoted 36 lines
--- drivers/gpu/drm/drm_agpsupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_agpsupport.c +2
-3@@ -212,7 +212,7 @@ int drm_agp_alloc(struct drm_device *dev, struct drm_agp_buffer *request)if (!entry)return -ENOMEM ; - pages = (request->size +PAGE_SIZE -1 ) /PAGE_SIZE ; + pages =DIV_ROUND_UP (request->size,PAGE_SIZE ); type = (u32 ) request->type; memory =agp_allocate_memory (dev->agp->bridge, pages, type);if (!memory) {@@ -325,7 +325,7 @@ int drm_agp_bind(struct drm_device *dev, struct drm_agp_binding *request) entry =drm_agp_lookup_entry (dev, request->handle);if (!entry || entry->bound)return -EINVAL ; - page = (request->offset +PAGE_SIZE -1 ) /PAGE_SIZE ; + page =DIV_ROUND_UP (request->offset,PAGE_SIZE ); retcode =drm_bind_agp (entry->memory, page);if (retcode)return retcode; --2.23.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025094907.3582-1-wambui.karugax%40gmail.com.
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch