Skip to contentSkip to conversation

dt-bindings: add vendor prefix for logic technologies limited

PATCH Superseded Marcel Ziswiler 4 participants 8 messages Oct 27, 2019 – Jan 19, 2020

Subsystems (4)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 dt-bindings: add vendor prefix for logic technologies limited

From: Marcel Ziswiler <[email protected]>

Add vendor prefix for Logic Technologies Limited [1] which is a Chinese display manufacturer e.g. distributed by German Endrich Bauelemente Vertriebs GmbH [2].

[1] https://logictechno.com/contact-us/
[2] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- Added Philippe's reviewed-by.
- Added Rob's acked-by.

 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 9a8495e39c5b..94aea715d4e2 100644
@@ -543,6 +543,8 @@ patternProperties:
     description: Linear Technology Corporation
   "^logicpd,.*":
     description: Logic PD, Inc.
+  "^logictechno,.*":
+    description: Logic Technologies Limited
   "^longcheer,.*":
     description: Longcheer Technology (Shanghai) Co., Ltd.
   "^lsi,.*":
Signature · 1 line
2.21.0
#1 lore raw

PATCH v2 2/3 drm/panel: simple: add display timings for logic technologies displays

From: Marcel Ziswiler <[email protected]>

Add display timings for the following 3 display panels manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display 10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs GmbH [4].

[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- Added Philippe's reviewed-by.

 drivers/gpu/drm/panel/panel-simple.c | 65 ++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +65 -0
index 5d487686d25c..546770116096 100644
@@ -2047,6 +2047,62 @@ static const struct panel_desc lg_lp129qe = {
 	},
 };
 
+static const struct display_timing logictechno_lt161010_2nh_timing = {
+	.pixelclock = { 26400000, 33300000, 46800000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 16, 210, 354 },
+	.hback_porch = { 46, 46, 46 },
+	.hsync_len = { 1, 20, 40 },
+	.vactive = { 480, 480, 480 },
+	.vfront_porch = { 7, 22, 147 },
+	.vback_porch = { 23, 23, 23 },
+	.vsync_len = { 1, 10, 20 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		 DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc logictechno_lt161010_2nh = {
+	.timings = &logictechno_lt161010_2nh_timing,
+	.num_timings = 1,
+	.size = {
+		.width = 154,
+		.height = 86,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
+		     DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+		     DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+};
+
+static const struct display_timing logictechno_lt170410_2whc_timing = {
+	.pixelclock = { 68900000, 71100000, 7340000 },
+	.hactive = { 1280, 1280, 1280 },
+	.hfront_porch = { 23, 60, 71 },
+	.hback_porch = { 23, 60, 71 },
+	.hsync_len = { 15, 40, 47 },
+	.vactive = { 800, 800, 800 },
+	.vfront_porch = { 5, 7, 10 },
+	.vback_porch = { 5, 7, 10 },
+	.vsync_len = { 6, 9, 12 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		 DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc logictechno_lt170410_2whc = {
+	.timings = &logictechno_lt170410_2whc_timing,
+	.num_timings = 1,
+	.size = {
+		.width = 217,
+		.height = 136,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
+		     DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+		     DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+};
+
 static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
 	.clock = 30400,
 	.hdisplay = 800,
@@ -3287,6 +3343,15 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "lg,lp129qe",
 		.data = &lg_lp129qe,
+	}, {
+		.compatible = "logictechno,lt161010-2nhc",
+		.data = &logictechno_lt161010_2nh,
+	}, {
+		.compatible = "logictechno,lt161010-2nhr",
+		.data = &logictechno_lt161010_2nh,
+	}, {
+		.compatible = "logictechno,lt170410-2whc",
+		.data = &logictechno_lt170410_2whc,
 	}, {
 		.compatible = "mitsubishi,aa070mc01-ca1",
 		.data = &mitsubishi_aa070mc01,
Signature · 1 line
2.21.0
#2 lore raw

PATCH v2 3/3 dt-bindings: display: panel: add bindings for logic technologies displays

In reply to Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add bindings for the following 3 previously added display panels manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display 10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs GmbH [4].

[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.

 .../panel/logictechno,lt161010-2nhc.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt161010-2nhr.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt170410-2whc.yaml      | 44 +++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml new file +44 -0
new file mode 100644
index 000000000000..0dfe94d38a47
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/logictechno,lt161010-2nhc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic Technologies LT161010-2NHC 7" WVGA TFT Cap Touch Module
+
+maintainers:
+  - Marcel Ziswiler <[email protected]>
+  - Thierry Reding <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: logictechno,lt161010-2nhc
+
+  power-supply: true
+  enable-gpios: true
+  backlight: true
+  port: true
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    panel_rgb: panel {
+      compatible = "logictechno,lt161010-2nhc";
+      backlight = <&backlight>;
+      power-supply = <&reg_3v3>;
+
+      port {
+        panel_in_rgb: endpoint {
+          remote-endpoint = <&controller_out_rgb>;
+        };
+      };
+    };
+
+...
Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml new file +44 -0

44 lines not on this page · raw message

Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml new file +44 -0

44 lines not on this page · raw message

Signature · 1 line
2.21.0
maintainer Reviewed-by on v2 3/3
#3 lore raw

Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays

Quoted 27 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add bindings for the following 3 previously added display panels manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display 10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs GmbH [4].

[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.

Quoted 7 lines
 .../panel/logictechno,lt161010-2nhc.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt161010-2nhr.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt170410-2whc.yaml      | 44 +++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml

I would just put these into 1 document as the compatible is the only difference. Either way:

Rob

#4 lore raw

Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays

Sorry, just noticed that this has not gone through yet.

Quoted 54 lines · Rob Herring
Quoted 50 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add bindings for the following 3 previously added display panels manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs
GmbH [4].

[1]
https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2]
https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3]
https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4]
https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.

 .../panel/logictechno,lt161010-2nhc.yaml      | 44
+++++++++++++++++++
 .../panel/logictechno,lt161010-2nhr.yaml      | 44
+++++++++++++++++++
 .../panel/logictechno,lt170410-2whc.yaml      | 44
+++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/display/panel/logictechno,lt16101
0-2nhc.yaml
 create mode 100644
Documentation/devicetree/bindings/display/panel/logictechno,lt16101
0-2nhr.yaml
 create mode 100644
Quoted 2 lines

Documentation/devicetree/bindings/display/panel/logictechno,lt17041 0-2whc.yaml

Quoted 2 lines

I would just put these into 1 document as the compatible is the only difference.

No, not quite just the compatible are different as the first and last panel feature capacitive touch while the middle one is resistive and the first two panels are parallel RGB ones while the last one is an LVDS panel.

Quoted 5 lines

Either way:

Rob

#5 lore raw

Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays

Hi Marcel.

Quoted 57 lines · Marcel Ziswiler

Sorry, just noticed that this has not gone through yet.

Quoted 54 lines · Rob Herring
Quoted 52 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add bindings for the following 3 previously added display panels manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs
GmbH [4].

[1]
https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2]
https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3]
https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4]
https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.

 .../panel/logictechno,lt161010-2nhc.yaml      | 44
+++++++++++++++++++
 .../panel/logictechno,lt161010-2nhr.yaml      | 44
+++++++++++++++++++
 .../panel/logictechno,lt170410-2whc.yaml      | 44
+++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/display/panel/logictechno,lt16101
0-2nhc.yaml
 create mode 100644
Documentation/devicetree/bindings/display/panel/logictechno,lt16101
0-2nhr.yaml
 create mode 100644

Documentation/devicetree/bindings/display/panel/logictechno,lt17041 0-2whc.yaml

Quoted 7 lines
Quoted 2 lines

I would just put these into 1 document as the compatible is the only difference.

No, not quite just the compatible are different as the first and last panel feature capacitive touch while the middle one is resistive and the first two panels are parallel RGB ones while the last one is an LVDS panel.

We have recently introduced panel-simple.yaml.
This is for dumb panels - where some of your panels could be candidates. Please see the file in drm-misc-next, which is also where we will apply you patch in the end.
So base the patch on drm-misc-next so we do not get conflicts when applying.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#6 lore raw

Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays

In reply to Marcel Ziswiler
Quoted 41 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add bindings for the following 3 previously added display panels manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display 10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs GmbH [4].

[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.

 .../panel/logictechno,lt161010-2nhc.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt161010-2nhr.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt170410-2whc.yaml      | 44 +++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml new file +0 -0
new file mode 100644
index 000000000000..0dfe94d38a47

Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml line 1

Quoted 1 line
Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml new file +1 -0
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0

Except the license for new bindings should be:

(GPL-2.0-only OR BSD-2-Clause)

Rob

#7 lore raw

Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays

Quoted 70 lines · Rob Herring
Quoted 65 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add bindings for the following 3 previously added display panels manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs
GmbH [4].

[1]
https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2]
https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3]
https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4]
https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

---

Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.

 .../panel/logictechno,lt161010-2nhc.yaml      | 44
+++++++++++++++++++
 .../panel/logictechno,lt161010-2nhr.yaml      | 44
+++++++++++++++++++
 .../panel/logictechno,lt170410-2whc.yaml      | 44
+++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/display/panel/logictechno,lt16101
0-2nhc.yaml
 create mode 100644
Documentation/devicetree/bindings/display/panel/logictechno,lt16101
0-2nhr.yaml
 create mode 100644

Documentation/devicetree/bindings/display/panel/logictechno,lt17041 0-2whc.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161 010-2nhc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161 010-2nhc.yaml
new file mode 100644
index 000000000000..0dfe94d38a47
--- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/logictechno,lt161 010-2nhc.yaml

Review line 1

Quoted 1 line
(quoted diff) +1 -0
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0

Except the license for new bindings should be:

Quoted 1 line

(GPL-2.0-only OR BSD-2-Clause)

OK, will send a v3 shortly.

Quoted 1 line

Rob