dt-bindings: add vendor prefix for logic technologies limited
Subsystems (4)
PATCH v3 1/3 dt-bindings: add vendor prefix for logic technologies limited
From: Marcel Ziswiler <[email protected]>
Add vendor prefix for Logic Technologies Limited [1] which is a Chinese display manufacturer e.g. distributed by German Endrich Bauelemente Vertriebs GmbH [2].
[1] https://logictechno.com/contact-us/
[2] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
---
Changes in v3: None
Changes in v2:
- Added Philippe's reviewed-by.
- Added Rob's acked-by.
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -549,6 +549,8 @@ patternProperties: description: Linear Technology Corporation "^logicpd,.*": description: Logic PD, Inc. + "^logictechno,.*": + description: Logic Technologies Limited "^longcheer,.*": description: Longcheer Technology (Shanghai) Co., Ltd. "^lsi,.*":
Signature · 1 line
2.24.1
PATCH v3 2/3 drm/panel: simple: add display timings for logic technologies displays
From: Marcel Ziswiler <[email protected]>
Add display timings for the following 3 display panels manufactured by Logic Technologies Limited:
- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display 10.1" LVDS [3]
Those panels may also be distributed by Endrich Bauelemente Vertriebs GmbH [4].
[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
---
Changes in v3:
- Fix typo in pixelclock frequency for lt170410_2whc as recently discovered by Philippe.
Changes in v2:
- Added Philippe's reviewed-by.
drivers/gpu/drm/panel/panel-simple.c | 65 ++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +65 -0
@@ -2107,6 +2107,62 @@ static const struct panel_desc lg_lp129qe = { }, }; +static const struct display_timing logictechno_lt161010_2nh_timing = { + .pixelclock = {26400000 ,33300000 ,46800000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {16 ,210 ,354 }, + .hback_porch = {46 ,46 ,46 }, + .hsync_len = {1 ,20 ,40 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {7 ,22 ,147 }, + .vback_porch = {23 ,23 ,23 }, + .vsync_len = {1 ,10 ,20 }, + .flags =DISPLAY_FLAGS_HSYNC_LOW |DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_POSEDGE | +DISPLAY_FLAGS_SYNC_POSEDGE , +}; + +static const struct panel_desc logictechno_lt161010_2nh = { + .timings = &logictechno_lt161010_2nh_timing, + .num_timings =1 , + .size = { + .width =154 , + .height =86 , + }, + .bus_format =MEDIA_BUS_FMT_RGB666_1X18 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH | +DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | +DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE , +}; + +static const struct display_timing logictechno_lt170410_2whc_timing = { + .pixelclock = {68900000 ,71100000 ,73400000 }, + .hactive = {1280 ,1280 ,1280 }, + .hfront_porch = {23 ,60 ,71 }, + .hback_porch = {23 ,60 ,71 }, + .hsync_len = {15 ,40 ,47 }, + .vactive = {800 ,800 ,800 }, + .vfront_porch = {5 ,7 ,10 }, + .vback_porch = {5 ,7 ,10 }, + .vsync_len = {6 ,9 ,12 }, + .flags =DISPLAY_FLAGS_HSYNC_LOW |DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_POSEDGE | +DISPLAY_FLAGS_SYNC_POSEDGE , +}; + +static const struct panel_desc logictechno_lt170410_2whc = { + .timings = &logictechno_lt170410_2whc_timing, + .num_timings =1 , + .size = { + .width =217 , + .height =136 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X7X4_SPWG , + .bus_flags =DRM_BUS_FLAG_DE_HIGH | +DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | +DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE , +}; +static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .clock =30400 , .hdisplay =800 ,
@@ -3417,6 +3473,15 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "logicpd,type28", .data = &logicpd_type_28, + }, { + .compatible = "logictechno,lt161010-2nhc", + .data = &logictechno_lt161010_2nh, + }, { + .compatible = "logictechno,lt161010-2nhr", + .data = &logictechno_lt161010_2nh, + }, { + .compatible = "logictechno,lt170410-2whc", + .data = &logictechno_lt170410_2whc, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01,
Signature · 1 line
2.24.1
Re: [PATCH v3 2/3] drm/panel: simple: add display timings for logic technologies displays
Hi Marcel.
Quoted 60 lines · Marcel Ziswiler
From: Marcel Ziswiler <[email protected]>
Add display timings for the following 3 display panels manufactured by Logic Technologies Limited:
- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display 10.1" LVDS [3]Those panels may also be distributed by Endrich Bauelemente Vertriebs GmbH [4].
[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30Signed-off-by Marcel Ziswiler <[email protected]>Reviewed-by Philippe Schenker <[email protected]>---
Changes in v3:
- Fix typo in pixelclock frequency forlt170410_2whcas recently discovered by Philippe.Changes in v2:
- Added Philippe's reviewed-by.drivers/gpu/drm/panel/panel-simple.c | 65 ++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+)drivers/gpu/drm/panel/panel-simple.c +17
-0@@ -2107,6 +2107,62 @@ static const struct panel_desc lg_lp129qe = { }, }; +static const struct display_timing logictechno_lt161010_2nh_timing = { + .pixelclock = {26400000 ,33300000 ,46800000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {16 ,210 ,354 }, + .hback_porch = {46 ,46 ,46 }, + .hsync_len = {1 ,20 ,40 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {7 ,22 ,147 }, + .vback_porch = {23 ,23 ,23 }, + .vsync_len = {1 ,10 ,20 }, + .flags =DISPLAY_FLAGS_HSYNC_LOW |DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_POSEDGE | +DISPLAY_FLAGS_SYNC_POSEDGE , +}; + +static const struct panel_desc logictechno_lt161010_2nh = { + .timings = &logictechno_lt161010_2nh_timing,
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc lg_lp129qe = { · line 2136
Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+ .num_timings = 1, + .size = { + .width = 154, + .height = 86, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, + .bus_flags =DRM_BUS_FLAG_DE_HIGH | +DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, +};
connector_type needs to be specified for all panels. This is something we have added recently and is today mandatory for new panel-simple panels.
Also please re-order so we add bindings before we driver support for the panels. This makes checkpatch (and me) more happy.
Ohh, and bonus points for using display_timing and specifying min,typ,max values.
Sam
Quoted 50 lines
drivers/gpu/drm/panel/panel-simple.c +38
-0+ +static const struct display_timing logictechno_lt170410_2whc_timing = { + .pixelclock = {68900000 ,71100000 ,73400000 }, + .hactive = {1280 ,1280 ,1280 }, + .hfront_porch = {23 ,60 ,71 }, + .hback_porch = {23 ,60 ,71 }, + .hsync_len = {15 ,40 ,47 }, + .vactive = {800 ,800 ,800 }, + .vfront_porch = {5 ,7 ,10 }, + .vback_porch = {5 ,7 ,10 }, + .vsync_len = {6 ,9 ,12 }, + .flags =DISPLAY_FLAGS_HSYNC_LOW |DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_POSEDGE | +DISPLAY_FLAGS_SYNC_POSEDGE , +}; + +static const struct panel_desc logictechno_lt170410_2whc = { + .timings = &logictechno_lt170410_2whc_timing, + .num_timings =1 , + .size = { + .width =217 , + .height =136 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X7X4_SPWG , + .bus_flags =DRM_BUS_FLAG_DE_HIGH | +DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | +DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE , +}; +static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .clock =30400 , .hdisplay =800 ,@@ -3417,6 +3473,15 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "logicpd,type28", .data = &logicpd_type_28, + }, { + .compatible = "logictechno,lt161010-2nhc", + .data = &logictechno_lt161010_2nh, + }, { + .compatible = "logictechno,lt161010-2nhr", + .data = &logictechno_lt161010_2nh, + }, { + .compatible = "logictechno,lt170410-2whc", + .data = &logictechno_lt170410_2whc, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01,Signature · 1 line
2.24.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 2/3] drm/panel: simple: add display timings for logic technologies displays
Hi Sam
Quoted 82 lines · Sam Ravnborg
Hi Marcel.
Quoted 79 lines · Marcel Ziswiler
From: Marcel Ziswiler <[email protected]>
Add display timings for the following 3 display panels manufactured by
Logic Technologies Limited:- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
10.1" LVDS [3]Those panels may also be distributed by Endrich Bauelemente Vertriebs
GmbH [4].[1]
https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2]
https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3]
https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4]
https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30Signed-off-by Marcel Ziswiler <[email protected]>Reviewed-by Philippe Schenker <[email protected]>---
Changes in v3:
- Fix typo in pixelclock frequency forlt170410_2whcas recently discovered by Philippe.Changes in v2:
- Added Philippe's reviewed-by.drivers/gpu/drm/panel/panel-simple.c | 65 ++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+)drivers/gpu/drm/panel/panel-simple.c +12
-0@@ -2107,6 +2107,62 @@ static const struct panel_desc lg_lp129qe = { }, }; +static const struct display_timing logictechno_lt161010_2nh_timing = { + .pixelclock = {26400000 ,33300000 ,46800000 }, + .hactive = {800 ,800 ,800 }, + .hfront_porch = {16 ,210 ,354 }, + .hback_porch = {46 ,46 ,46 }, + .hsync_len = {1 ,20 ,40 }, + .vactive = {480 ,480 ,480 }, + .vfront_porch = {7 ,22 ,147 }, + .vback_porch = {23 ,23 ,23 }, + .vsync_len = {1 ,10 ,20 }, + .flags =DISPLAY_FLAGS_HSYNC_LOW |DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_POSEDGE |
drivers/gpu/drm/panel/panel-simple.c +10
-0+ DISPLAY_FLAGS_SYNC_POSEDGE, +}; + +static const struct panel_desc logictechno_lt161010_2nh = { + .timings = &logictechno_lt161010_2nh_timing, + .num_timings =1 , + .size = { + .width =154 , + .height =86 , + },
Quoted 8 lines
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc lg_lp129qe = { · line 2136
Quoted 5 lines
drivers/gpu/drm/panel/panel-simple.c +5
-0+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18, + .bus_flags =DRM_BUS_FLAG_DE_HIGH | +DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, +};
connector_typeneeds to be specified for all panels. This is something we have added recently and is today mandatory for new panel-simple panels.
Sorry, forgot about that one. Will add it in v4.
Quoted 3 lines
Also please re-order so we add bindings before we driver support for the panels.
This makes checkpatch (and me) more happy.
Not that my checkpatch would warn me about that but kinda makes sense.
Quoted 2 lines
Ohh, and bonus points for using
display_timingand specifying min,typ,max values.
Thanks, man.
Quoted 1 line
Sam
Cheers
Marcel
Quoted 53 lines
Quoted 53 lines
drivers/gpu/drm/panel/panel-simple.c +2
-0+ +static const struct display_timing
logictechno_lt170410_2whc_timing= {drivers/gpu/drm/panel/panel-simple.c +11
-0+ .pixelclock = { 68900000, 71100000, 73400000 }, + .hactive = { 1280, 1280, 1280 }, + .hfront_porch = { 23, 60, 71 }, + .hback_porch = { 23, 60, 71 }, + .hsync_len = { 15, 40, 47 }, + .vactive = { 800, 800, 800 }, + .vfront_porch = { 5, 7, 10 }, + .vback_porch = { 5, 7, 10 }, + .vsync_len = { 6, 9, 12 }, + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | +DISPLAY_FLAGS_DE_HIGH |DISPLAY_FLAGS_PIXDATA_POSEDGE |
drivers/gpu/drm/panel/panel-simple.c +25
-0+ DISPLAY_FLAGS_SYNC_POSEDGE, +}; + +static const struct panel_desc logictechno_lt170410_2whc = { + .timings = &logictechno_lt170410_2whc_timing, + .num_timings =1 , + .size = { + .width =217 , + .height =136 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X7X4_SPWG , + .bus_flags =DRM_BUS_FLAG_DE_HIGH | +DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | +DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE , +}; +static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .clock =30400 , .hdisplay =800 ,@@ -3417,6 +3473,15 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "logicpd,type28", .data = &logicpd_type_28, + }, { + .compatible = "logictechno,lt161010-2nhc", + .data = &logictechno_lt161010_2nh, + }, { + .compatible = "logictechno,lt161010-2nhr", + .data = &logictechno_lt161010_2nh, + }, { + .compatible = "logictechno,lt170410-2whc", + .data = &logictechno_lt170410_2whc, }, { .compatible = "mitsubishi,aa070mc01-ca1",.data =
&mitsubishi_aa070mc01,Signature · 1 line
2.24.1
PATCH v3 3/3 dt-bindings: panel-simple: add bindings for logic technologies displays
In reply to Marcel ZiswilerFrom: Marcel Ziswiler <[email protected]>
Add bindings for the following 3 previously added display panels manufactured by Logic Technologies Limited:
- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display 10.1" LVDS [3]
Those panels may also be distributed by Endrich Bauelemente Vertriebs GmbH [4].
[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
---
Changes in v3:
- Add it to recently introduced panel-simple.yaml instead as suggested by Sam.
Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.
.../devicetree/bindings/display/panel/panel-simple.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +6 -0
@@ -41,6 +41,12 @@ properties: - frida,frd350h54004 # GiantPlus GPM940B0 3.0" QVGA TFT LCD panel - giantplus,gpm940b0 + # Logic Technologies LT161010-2NHC 7" WVGA TFT Cap Touch Module + - logictechno,lt161010-2nhc + # Logic Technologies LT161010-2NHR 7" WVGA TFT Resistive Touch Module + - logictechno,lt161010-2nhr + # Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Mod. + - logictechno,lt170410-2whc # Satoz SAT050AT40H12R2 5.0" WVGA TFT LCD panel - satoz,sat050at40h12r2 # Sharp LS020B1DD01D 2.0" HQVGA TFT LCD panel
Signature · 1 line
2.24.1