Skip to contentSkip to conversation

dyndbg: prefer declarative init in caller, to memset in callee

PATCH In review Jim Cromie 1 participant 1 message Oct 29, 2019

Subsystems (2)
lore
Share & tools
lore

Jim Cromie

author maintainer
#0 lore raw

PATCH 14/16 dyndbg: prefer declarative init in caller, to memset in callee

drop memset in ddebug_parse_query, instead initialize the stack variable in the caller.

---
 lib/dynamic_debug.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
lib/dynamic_debug.c +1 -2
index c6273fabe52c..4369afeb52f0 100644
@@ -358,7 +358,6 @@ static int ddebug_parse_query(char *words[], int nwords,
 		pr_err("expecting pairs of match-spec <value>\n");
 		return -EINVAL;
 	}
-	memset(query, 0, sizeof(*query));
 
 	if (modname)
 		/* support $modname.dyndbg=<multiple queries> */
@@ -479,7 +478,7 @@ static int ddebug_exec_query(char *query_string, const char *modname)
 {
 	struct flagsettings mods = {};
 	struct flagsettings filter = {};
-	struct ddebug_query query;
+	struct ddebug_query query = {};
 #define MAXWORDS 9
 	int nwords, nfound;
 	char *words[MAXWORDS];
Signature · 1 line
2.21.0