dyndbg: prefer declarative init in caller, to memset in callee
Subsystems (2)
Jim Cromie
maintainerPATCH 14/16 dyndbg: prefer declarative init in caller, to memset in callee
drop memset in ddebug_parse_query, instead initialize the stack variable in the caller.
Signed-off-by Jim Cromie <[email protected]>
--- lib/dynamic_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
lib/dynamic_debug.c +1 -2
@@ -358,7 +358,6 @@ static int ddebug_parse_query(char *words[], int nwords,pr_err ("expecting pairs of match-spec <value>\n" );return -EINVAL ; } -memset (query,0 ,sizeof (*query));if (modname)/* support $modname.dyndbg=<multiple queries> */
@@ -479,7 +478,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) {struct flagsettings mods = {};struct flagsettings filter = {}; -struct ddebug_query query; +struct ddebug_query query = {};#define MAXWORDS 9int nwords, nfound;char *words[MAXWORDS ];
Signature · 1 line
2.21.0