Skip to contentSkip to conversation

remove unnecessary ifdef TARGET_RISCV64

PATCH In review [email protected] 2 participants 3 messages Oct 30, 2019 – Nov 2, 2019 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove unnecessary ifdef TARGET_RISCV64

From: "hiroyuki.obinata" <[email protected]>

---
 target/riscv/translate.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
target/riscv/translate.c +1 -3
index adeddb85f6..5c4dd21a98 100644
@@ -64,12 +64,10 @@ static const int tcg_memop_lookup[8] = {
     [0] = MO_SB,
     [1] = MO_TESW,
     [2] = MO_TESL,
+    [3] = MO_TEQ,
     [4] = MO_UB,
     [5] = MO_TEUW,
-#ifdef TARGET_RISCV64
-    [3] = MO_TEQ,
     [6] = MO_TEUL,
-#endif
 };
 #endif
 
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · On Tue, 29 Oct 2019 17:23:18 PDT (-0700), [email protected] wrote:

From: "hiroyuki.obinata" <[email protected]>

---
 target/riscv/translate.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
target/riscv/translate.c +0 -0
index adeddb85f6..5c4dd21a98 100644
@@ -64,12 +64,10 @@ static const int tcg_memop_lookup[8] = {
     [0] = MO_SB,
     [1] = MO_TESW,

target/riscv/translate.c static const int tcg_memop_lookup[8] = { · line 72

Quoted 10 lines
target/riscv/translate.c +1 -3
     [2] = MO_TESL,
+    [3] = MO_TEQ,
     [4] = MO_UB,
     [5] = MO_TEUW,
-#ifdef TARGET_RISCV64
-    [3] = MO_TEQ,
     [6] = MO_TEUL,
-#endif
 };
 #endif

This is a non-functional change (the code in question was already wrapped in an "#ifdef TARGET_RISCV64", so this internal one was redundant), so I'm happy to include it during the soft freeze.

I've added this to the queue for my next PR.

#2 lore raw

Thanks!

2019年11月2日(土) 1:58 Palmer Dabbelt <[email protected]>:

Quoted 37 lines
Quoted 14 lines · On Tue, 29 Oct 2019 17:23:18 PDT (-0700), [email protected] wrote:

From: "hiroyuki.obinata" <[email protected]>

---
 target/riscv/translate.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
target/riscv/translate.c +0 -0
index adeddb85f6..5c4dd21a98 100644
@@ -64,12 +64,10 @@ static const int tcg_memop_lookup[8] = {
     [0] = MO_SB,
     [1] = MO_TESW,

target/riscv/translate.c static const int tcg_memop_lookup[8] = { · line 72

Quoted 10 lines
target/riscv/translate.c +1 -3
     [2] = MO_TESL,
+    [3] = MO_TEQ,
     [4] = MO_UB,
     [5] = MO_TEUW,
-#ifdef TARGET_RISCV64
-    [3] = MO_TEQ,
     [6] = MO_TEUL,
-#endif
 };
 #endif

This is a non-functional change (the code in question was already wrapped in an
"#ifdef TARGET_RISCV64", so this internal one was redundant), so I'm happy to
include it during the soft freeze.

I've added this to the queue for my next PR.