crypto: fix memdup.cocci warnings
PATCH 1/1 crypto: fix memdup.cocci warnings
From: kbuild test robot <[email protected]>
Use kmemdup rather than duplicating its implementation
Generated by: scripts/coccinelle/api/memdup.cocci
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 298b4c604008025b134bc6fccbc4018449945d60 commit: f08fcced6d0017c39cb6eccb571290867119d049 [154/163] crypto: allwinner - Add sun8i-ss cryptographic offloader
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
Please take the patch only if it's a positive warning. Thanks!
sun8i-ss-cipher.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c +2 -4
@@ -398,10 +398,9 @@ int sun8i_ss_aes_setkey(struct crypto_skkfree (op->key); } op->keylen = keylen; - op->key =kmalloc (keylen,GFP_KERNEL |GFP_DMA ); + op->key =kmemdup (key, keylen,GFP_KERNEL |GFP_DMA );if (!op->key)return -ENOMEM ; -memcpy (op->key, key, keylen);crypto_sync_skcipher_clear_flags (op->fallback_tfm,CRYPTO_TFM_REQ_MASK );crypto_sync_skcipher_set_flags (op->fallback_tfm, tfm->base.crt_flags &CRYPTO_TFM_REQ_MASK );
@@ -426,10 +425,9 @@ int sun8i_ss_des3_setkey(struct crypto_skfree (op->key); } op->keylen = keylen; - op->key =kmalloc (keylen,GFP_KERNEL |GFP_DMA ); + op->key =kmemdup (key, keylen,GFP_KERNEL |GFP_DMA );if (!op->key)return -ENOMEM ; -memcpy (op->key, key, keylen);crypto_sync_skcipher_clear_flags (op->fallback_tfm,CRYPTO_TFM_REQ_MASK );crypto_sync_skcipher_set_flags (op->fallback_tfm, tfm->base.crt_flags &CRYPTO_TFM_REQ_MASK );
Corentin Labbe
maintainerQuoted 11 lines · Julia Lawall
From: kbuild test robot <[email protected]>
Use kmemdup rather than duplicating its implementation
Generated by:
scripts/coccinelle/api/memdup.cocciFixes f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloader")CC Corentin Labbe <[email protected]>Signed-off-by kbuild test robot <[email protected]>Signed-off-by Julia Lawall <[email protected]>---
Corentin Labbe <[email protected]>
Thanks
Herbert Xu
maintainerQuoted 15 lines · Julia Lawall
From: kbuild test robot <[email protected]>
Use kmemdup rather than duplicating its implementation
Generated by:
scripts/coccinelle/api/memdup.cocciFixes f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloader")CC Corentin Labbe <[email protected]>Signed-off-by kbuild test robot <[email protected]>Signed-off-by Julia Lawall <[email protected]>---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 298b4c604008025b134bc6fccbc4018449945d60 commit: f08fcced6d0017c39cb6eccb571290867119d049 [154/163] crypto: allwinner - Add sun8i-ss cryptographic offloader
Quoted 7 lines
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours agoPlease take the patch only if it's a positive warning. Thanks!
sun8i-ss-cipher.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt