bpf: offload: unlock on error in bpf_offload_dev_create()
Subsystems (4)
PATCH 1/1 bpf: offload: unlock on error in bpf_offload_dev_create()
We need to drop the bpf_devs_lock on error before returning.
Fixes 9fd7c5559165 ("bpf: offload: aggregate offloads per-device")
Signed-off-by Dan Carpenter <[email protected]>
---
Static analysis. Not tested.
kernel/bpf/offload.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/bpf/offload.c +3 -1
@@ -678,8 +678,10 @@ bpf_offload_dev_create(const struct bpf_prog_offload_ops *ops, void *priv)down_write (&bpf_devs_lock);if (!offdevs_inited) { err =rhashtable_init (&offdevs, &offdevs_params); -if (err) +if (err) { +up_write (&bpf_devs_lock);return ERR_PTR (err); + } offdevs_inited = true; }up_write (&bpf_devs_lock);
Signature · 1 line
2.20.1
Quoted 4 lines · Dan Carpenter
We need to drop the
bpf_devs_lockon error before returning.Fixes 9fd7c5559165 ("bpf: offload: aggregate offloads per-device")Signed-off-by Dan Carpenter <[email protected]>
Acked-by Jakub Kicinski <[email protected]>
Quoted 4 lines · Dan Carpenter
We need to drop the
bpf_devs_lockon error before returning.Fixes 9fd7c5559165 ("bpf: offload: aggregate offloads per-device")Signed-off-by Dan Carpenter <[email protected]>
Applied, thanks!