Skip to contentSkip to conversation

bpf: offload: unlock on error in bpf_offload_dev_create()

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 4, 2019 – Nov 6, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf: offload: unlock on error in bpf_offload_dev_create()

We need to drop the bpf_devs_lock on error before returning.

Fixes 9fd7c5559165 ("bpf: offload: aggregate offloads per-device")

---
Static analysis. Not tested.

 kernel/bpf/offload.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/bpf/offload.c +3 -1
index ba635209ae9a..5b9da0954a27 100644
@@ -678,8 +678,10 @@ bpf_offload_dev_create(const struct bpf_prog_offload_ops *ops, void *priv)
 	down_write(&bpf_devs_lock);
 	if (!offdevs_inited) {
 		err = rhashtable_init(&offdevs, &offdevs_params);
-		if (err)
+		if (err) {
+			up_write(&bpf_devs_lock);
 			return ERR_PTR(err);
+		}
 		offdevs_inited = true;
 	}
 	up_write(&bpf_devs_lock);
Signature · 1 line
2.20.1