Optimize perf stat for large number of events/cpus
[v4: Address review feedback as far as possible.
Fix bug with unsorted CPUs specified by user.]
This patch kit optimizes perf stat for a large number of events on systems with many CPUs and PMUs.
Some profiling shows that the most overhead is doing IPIs to all the target CPUs. We can optimize this by using sched_setaffinity to set the affinity to a target CPU once and then doing the perf operation for all events on that CPU. This requires some restructuring, but cuts the set up time quite a bit.
In theory we could go further by parallelizing these setups too, but that would be much more complicated and for now just batching it per CPU seems to be sufficient. At some point with many more cores parallelization or a better bulk perf setup API might be needed though.
In addition perf does a lot of redundant /sys accesses with many PMUs, which can be also expensve. This is also optimized.
On a large test case (>700 events with many weak groups) on a 94 CPU system I go from
real 0m8.607s
user 0m0.550s
sys 0m8.041s
to
real 0m3.269s
user 0m0.760s
sys 0m1.694s
so shaving ~6 seconds of system time, at slightly more cost in perf stat itself. On a 4 socket system with the savings are more dramatic:
real 0m15.641s
user 0m0.873s
sys 0m14.729s
to
real 0m4.493s
user 0m1.578s
sys 0m2.444s
so 11s difference in the user visible set up time.
Also available in
git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc perf/stat-scale-7
v1: Initial post.
v2: Rebase. Fix some minor issues.
v3: Rebase. Address review feedback. Fix one minor issue
v4: Modified based on review feedback. Now it maintains all_cpus per evlist. There is still a need for cpu_index iteration to get the correct index for indexing the file descriptors. Fix bug with unsorted cpu maps, now they are always sorted. Some cleanups and refactoring.
-Andi
PATCH v4 1/9 perf pmu: Use file system cache to optimize sysfs access
From: Andi Kleen <[email protected]>
pmu.c does a lot of redundant /sys accesses while parsing aliases and probing for PMUs. On large systems with a lot of PMUs this can get expensive (>2s):
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
27.25 1.227847 8 160888 16976 openat 26.42 1.190481 7 164224 164077 stat
Add a cache to remember if specific file names exist or don't exist, which eliminates most of this overhead.
Also optimize some stat() calls to be slightly cheaper access()
Resulting in:
0.18 0.004166 2 1851 305 open 0.08 0.001970 2 829 622 access
---
v2: Use single lookup function as API (Jiri)
--- tools/perf/util/Build | 1 + tools/perf/util/fncache.c | 63 +++++++++++++++++++++++++++++++++++++++ tools/perf/util/fncache.h | 7 +++++ tools/perf/util/pmu.c | 34 +++++++-------------- tools/perf/util/srccode.c | 9 +----- 5 files changed, 83 insertions(+), 31 deletions(-) create mode 100644 tools/perf/util/fncache.c create mode 100644 tools/perf/util/fncache.h
tools/perf/util/Build +1 -0
@@ -48,6 +48,7 @@ perf-y += header.o perf-y += callchain.o perf-y += values.o perf-y += debug.o +perf-y += fncache.o perf-y += machine.o perf-y += map.o perf-y += pstack.o
tools/perf/util/fncache.c new file +63 -0
63 lines not on this page · raw message
tools/perf/util/fncache.h new file +7 -0
@@ -0,0 +1,7 @@ +#ifndef _FCACHE_H +#define _FCACHE_H 1 + +unsigned shash (const unsigned char *s); +bool file_available (const char *name); + +#endif
tools/perf/util/pmu.c +11 -23
@@ -24,6 +24,7 @@#include "pmu-events/pmu-events.h" #include "string2.h" #include "strbuf.h" +#include "fncache.h" struct perf_pmu_format {char *name;
@@ -82,7 +83,6 @@ int perf_pmu__format_parse(char *dir, struct list_head *head)*/ static int pmu_format (const char *name,struct list_head *format) { -struct stat st;char path[PATH_MAX ];const char *sysfs =sysfs__mountpoint ();
@@ -92,8 +92,8 @@ static int pmu_format(const char *name, struct list_head *format)snprintf (path,PATH_MAX ,"%s" EVENT_SOURCE_DEVICE_PATH "%s/format" , sysfs, name); -if (stat (path, &st) <0 ) -return 0 ;/* no error if format does not exist */ +if (!file_available (path)) +return 0 ;if (perf_pmu__format_parse (path, format))return -1 ;
@@ -475,7 +475,6 @@ static int pmu_aliases_parse(char *dir, struct list_head *head)*/ static int pmu_aliases (const char *name,struct list_head *head) { -struct stat st;char path[PATH_MAX ];const char *sysfs =sysfs__mountpoint ();
@@ -485,8 +484,8 @@ static int pmu_aliases(const char *name, struct list_head *head)snprintf (path,PATH_MAX ,"%s/bus/event_source/devices/%s/events" , sysfs, name); -if (stat (path, &st) <0 ) -return 0 ;/* no error if 'events' does not exist */ +if (!file_available (path)) +return 0 ;if (pmu_aliases_parse (path, head))return -1 ;
@@ -525,7 +524,6 @@ static int pmu_alias_terms(struct perf_pmu_alias *alias,*/ static int pmu_type (const char *name,__u32 *type) { -struct stat st;char path[PATH_MAX ];FILE *file;int ret =0 ;
@@ -537,7 +535,7 @@ static int pmu_type(const char *name, __u32 *type)snprintf (path,PATH_MAX ,"%s" EVENT_SOURCE_DEVICE_PATH "%s/type" , sysfs, name); -if (stat (path, &st) <0 ) +if (access (path,R_OK ) <0 )return -1 ; file =fopen (path,"r" );
@@ -628,14 +626,11 @@ static struct perf_cpu_map *pmu_cpumask(const char *name)static bool pmu_is_uncore (const char *name) {char path[PATH_MAX ]; -struct perf_cpu_map *cpus; -const char *sysfs =sysfs__mountpoint (); +const char *sysfs; + sysfs =sysfs__mountpoint ();snprintf (path,PATH_MAX ,CPUS_TEMPLATE_UNCORE , sysfs, name); - cpus =__pmu_cpumask (path); -perf_cpu_map__put (cpus); - -return !!cpus; +return file_available (path); }/*
@@ -645,7 +640,6 @@ static bool pmu_is_uncore(const char *name)*/ static int is_arm_pmu_core (const char *name) { -struct stat st;char path[PATH_MAX ];const char *sysfs =sysfs__mountpoint ();
@@ -655,10 +649,7 @@ static int is_arm_pmu_core(const char *name)/* Look for cpu sysfs (specific to arm) */ scnprintf (path,PATH_MAX ,"%s/bus/event_source/devices/%s/cpus" , sysfs, name); -if (stat (path, &st) ==0 ) -return 1 ; - -return 0 ; +return file_available (path); }static char *perf_pmu__getcpuid (struct perf_pmu *pmu)
@@ -1528,7 +1519,6 @@ bool pmu_have_event(const char *pname, const char *name)static FILE *perf_pmu__open_file (struct perf_pmu *pmu,const char *name) { -struct stat st;char path[PATH_MAX ];const char *sysfs;
@@ -1538,10 +1528,8 @@ static FILE *perf_pmu__open_file(struct perf_pmu *pmu, const char *name)snprintf (path,PATH_MAX ,"%s" EVENT_SOURCE_DEVICE_PATH "%s/%s" , sysfs, pmu->name, name); - -if (stat (path, &st) <0 ) +if (!file_available (path))return NULL ; -return fopen (path,"r" ); }
tools/perf/util/srccode.c +1 -8
@@ -16,6 +16,7 @@#include "srccode.h" #include "debug.h" #include <internal/lib.h> // page_size +#include "fncache.h" #define MAXSRCCACHE (32*1024*1024)#define MAXSRCFILES 64
@@ -36,14 +37,6 @@ static LIST_HEAD(srcfile_list);static long map_total_sz;static int num_srcfiles; -static unsigned shash (unsigned char *s) -{ -unsigned h =0 ; -while (*s) - h =65599 * h + *s++; -return h ^ (h >>16 ); -} -static int countlines (char *map,int maplen) {int numl;
Signature · 1 line
2.23.0
PATCH v4 2/9 perf affinity: Add infrastructure to save/restore affinity
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
The kernel perf subsystem has to IPI to the target CPU for many operations. On systems with many CPUs and when managing many events the overhead can be dominated by lots of IPIs.
An alternative is to set up CPU affinity in the perf tool, then set up all the events for that CPU, and then move on to the next CPU.
Add some affinity management infrastructure to enable such a model. Used in followon patches.
---
v2: Use linux/bitmap.h functions.
--- tools/perf/util/Build | 1 + tools/perf/util/affinity.c | 72 ++++++++++++++++++++++++++++++++++++++ tools/perf/util/affinity.h | 15 ++++++++ 3 files changed, 88 insertions(+) create mode 100644 tools/perf/util/affinity.c create mode 100644 tools/perf/util/affinity.h
tools/perf/util/Build +1 -0
@@ -76,6 +76,7 @@ perf-y += sort.o perf-y += hist.o perf-y += util.o perf-y += cpumap.o +perf-y += affinity.o perf-y += cputopo.o perf-y += cgroup.o perf-y += target.o
tools/perf/util/affinity.c new file +72 -0
72 lines not on this page · raw message
tools/perf/util/affinity.h new file +15 -0
@@ -0,0 +1,15 @@ +// SPDX-License-Identifier: GPL-2.0 +#ifndef AFFINITY_H +#define AFFINITY_H 1 + +struct affinity { +unsigned long *orig_cpus; +unsigned long *sched_cpus; +bool changed; +}; + +void affinity__cleanup (struct affinity *a); +void affinity__set (struct affinity *a,int cpu); +int affinity__setup (struct affinity *a); + +#endif
Signature · 1 line
2.23.0
PATCH v4 3/9 perf evlist: Maintain evlist->all_cpus
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Maintain a cpumap in the evlist that is the union of all the cpus of the events.
This needs a cpumap merge operation. To make the merge operation work efficiently maintain the cpumap in a sorted state.
The sorting is also needed for the affinity loop changes later.
--- tools/perf/lib/cpumap.c | 42 ++++++++++++++++++++++++ tools/perf/lib/evlist.c | 1 + tools/perf/lib/include/internal/evlist.h | 1 + tools/perf/lib/include/perf/cpumap.h | 2 ++ 4 files changed, 46 insertions(+)
tools/perf/lib/cpumap.c +42 -0
@@ -68,6 +68,11 @@ static struct perf_cpu_map *cpu_map__default_new(void)return cpus; } +static int cmp_int (const void *a,const void *b) +{ +return *(const int *)a - *(const int *)b; +} +static struct perf_cpu_map *cpu_map__trim_new (int nr_cpus,int *tmp_cpus) {size_t payload_size = nr_cpus *sizeof (int );
@@ -76,6 +81,7 @@ static struct perf_cpu_map *cpu_map__trim_new(int nr_cpus, int *tmp_cpus)if (cpus !=NULL ) { cpus->nr = nr_cpus;memcpy (cpus->map, tmp_cpus, payload_size); +qsort (cpus->map, nr_cpus,sizeof (int ), cmp_int);refcount_set (&cpus->refcnt,1 ); }
@@ -272,3 +278,39 @@ int perf_cpu_map__max(struct perf_cpu_map *map)return max; } + +struct perf_cpu_map *perf_cpu_map__update (struct perf_cpu_map *orig, +struct perf_cpu_map *other) +{ +int *tmp_cpus; +int tmp_len; +int i, j, k; +struct perf_cpu_map *merged; + +if (!orig) { +perf_cpu_map__get (other); +return other; + } +if (orig->nr == other->nr && + !memcmp (orig->map, other->map, orig->nr *sizeof (int ))) +return orig; + tmp_len = orig->nr + other->nr; + tmp_cpus =malloc (tmp_len *sizeof (int )); +if (!tmp_cpus) +return NULL ; + i = j = k =0 ; +while (i < orig->nr && j < other->nr) { +if (orig->map[i] <= other->map[j]) + tmp_cpus[k++] = orig->map[i++]; +else + tmp_cpus[k++] = other->map[j++]; + } +while (i < orig->nr) + tmp_cpus[k++] = orig->map[i++]; +while (j < other->nr) + tmp_cpus[k++] = other->map[j++]; +assert (k < tmp_len); + merged =cpu_map__trim_new (k, tmp_cpus); +free (tmp_cpus); +return merged; +}
tools/perf/lib/evlist.c +1 -0
@@ -54,6 +54,7 @@ static void __perf_evlist__propagate_maps(struct perf_evlist *evlist,perf_thread_map__put (evsel->threads); evsel->threads =perf_thread_map__get (evlist->threads); + evlist->all_cpus =perf_cpu_map__update (evlist->all_cpus, evsel->cpus); }static void perf_evlist__propagate_maps (struct perf_evlist *evlist)
tools/perf/lib/include/internal/evlist.h +1 -0
@@ -18,6 +18,7 @@ struct perf_evlist {int nr_entries;bool has_user_cpus;struct perf_cpu_map *cpus; +struct perf_cpu_map *all_cpus;struct perf_thread_map *threads;int nr_mmaps;size_t mmap_len;
tools/perf/lib/include/perf/cpumap.h +2 -0
@@ -12,6 +12,8 @@ LIBPERF_API struct perf_cpu_map *perf_cpu_map__dummy_new(void); LIBPERF_API struct perf_cpu_map *perf_cpu_map__new(const char *cpu_list); LIBPERF_API struct perf_cpu_map *perf_cpu_map__read(FILE *file); LIBPERF_API struct perf_cpu_map *perf_cpu_map__get(struct perf_cpu_map *map); +LIBPERF_API struct perf_cpu_map *perf_cpu_map__update(struct perf_cpu_map *orig, +struct perf_cpu_map *other); LIBPERF_API void perf_cpu_map__put(struct perf_cpu_map *map); LIBPERF_API int perf_cpu_map__cpu(const struct perf_cpu_map *cpus, int idx); LIBPERF_API int perf_cpu_map__nr(const struct perf_cpu_map *cpus);
Signature · 1 line
2.23.0
Re: [PATCH v4 3/9] perf evlist: Maintain evlist->all_cpus
Quoted 35 lines · Andi Kleen
From: Andi Kleen <[email protected]>
Maintain a cpumap in the evlist that is the union of all the cpus of the events.
This needs a cpumap merge operation. To make the merge operation work efficiently maintain the cpumap in a sorted state.
The sorting is also needed for the affinity loop changes later.
Signed-off-by Andi Kleen <[email protected]>--- tools/perf/lib/cpumap.c | 42 ++++++++++++++++++++++++ tools/perf/lib/evlist.c | 1 + tools/perf/lib/include/internal/evlist.h | 1 + tools/perf/lib/include/perf/cpumap.h | 2 ++ 4 files changed, 46 insertions(+)tools/perf/lib/cpumap.c +5
-0@@ -68,6 +68,11 @@ static struct perf_cpu_map *cpu_map__default_new(void)return cpus; } +static int cmp_int (const void *a,const void *b) +{ +return *(const int *)a - *(const int *)b; +} +static struct perf_cpu_map *cpu_map__trim_new (int nr_cpus,int *tmp_cpus) {size_t payload_size = nr_cpus *sizeof (int );
tools/perf/lib/cpumap.c static struct perf_cpu_map *cpu_map__trim_new(int nr_cpus, int *tmp_cpus) · line 86
Quoted 6 lines
tools/perf/lib/cpumap.c +1
-0@@ -76,6 +81,7 @@ static struct perf_cpu_map *cpu_map__trim_new(int nr_cpus, int *tmp_cpus)if (cpus !=NULL ) { cpus->nr = nr_cpus;memcpy (cpus->map, tmp_cpus, payload_size); +qsort (cpus->map, nr_cpus,sizeof (int ), cmp_int);refcount_set (&cpus->refcnt,1 ); }
please move the sort into separate change
tools/perf/lib/cpumap.c int perf_cpu_map__max(struct perf_cpu_map *map) · line 284
Quoted 9 lines
tools/perf/lib/cpumap.c +4
-0@@ -272,3 +278,39 @@ int perf_cpu_map__max(struct perf_cpu_map *map)return max; } + +struct perf_cpu_map *perf_cpu_map__update (struct perf_cpu_map *orig, +struct perf_cpu_map *other) +{
it's more like perf_cpu_map__merge, right?
Quoted 22 lines
tools/perf/lib/cpumap.c +22
-0+int *tmp_cpus; +int tmp_len; +int i, j, k; +struct perf_cpu_map *merged; + +if (!orig) { +perf_cpu_map__get (other); +return other; + } +if (orig->nr == other->nr && + !memcmp (orig->map, other->map, orig->nr *sizeof (int ))) +return orig; + tmp_len = orig->nr + other->nr; + tmp_cpus =malloc (tmp_len *sizeof (int )); +if (!tmp_cpus) +return NULL ; + i = j = k =0 ; +while (i < orig->nr && j < other->nr) { +if (orig->map[i] <= other->map[j]) + tmp_cpus[k++] = orig->map[i++]; +else + tmp_cpus[k++] = other->map[j++];
tools/perf/lib/cpumap.c int perf_cpu_map__max(struct perf_cpu_map *map) · line 316
Quoted 10 lines
tools/perf/lib/cpumap.c +10
-0+ } +while (i < orig->nr) + tmp_cpus[k++] = orig->map[i++]; +while (j < other->nr) + tmp_cpus[k++] = other->map[j++]; +assert (k < tmp_len); + merged =cpu_map__trim_new (k, tmp_cpus); +free (tmp_cpus); +return merged; +}
this is great function for automated test, please add
thanks,
jirka
PATCH v4 4/9 perf evsel: Add iterator to iterate over events ordered by CPU
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Add some common code that is needed to iterate over all events in CPU order. Used in followon patches
---
v2: Add cpumap__for_each_cpu macro to factor out some common code
v3: Drop cpumap__for_each_cpu macro again, replace with evlist__for_each_cpu Add new evlist__for_each_cpu
Don't compute cpus nir in cpu_index iterator init, just use all_cpus
--- tools/perf/util/cpumap.h | 1 + tools/perf/util/evlist.c | 28 ++++++++++++++++++++++++++++ tools/perf/util/evlist.h | 7 +++++++ tools/perf/util/evsel.h | 1 + 4 files changed, 37 insertions(+)
tools/perf/util/cpumap.h +1 -0
@@ -60,4 +60,5 @@ int cpu_map__build_map(struct perf_cpu_map *cpus, struct perf_cpu_map **res,int cpu_map__cpu (struct perf_cpu_map *cpus,int idx);bool cpu_map__has (struct perf_cpu_map *cpus,int cpu); +#endif /* __PERF_CPUMAP_H */
tools/perf/util/evlist.c +28 -0
@@ -342,6 +342,34 @@ static int perf_evlist__nr_threads(struct evlist *evlist,return perf_thread_map__nr (evlist->core.threads); } +void evlist__cpu_iter_start (struct evlist *evlist) +{ +struct evsel *pos; + +/* +* Reset the per evsel cpu_index. This is needed because +* each evsel's cpumap may have a different index space, +* and some operations need the index to modify +* the FD xyarray (e.g. open, close) +*/ +evlist__for_each_entry (evlist, pos) + pos->cpu_index =0 ; +} + +bool evlist__cpu_iter_skip (struct evsel *ev,int cpu) +{ +if (ev->cpu_index >= ev->core.cpus->nr) +return true; +if (cpu >=0 && ev->core.cpus->map[ev->cpu_index] != cpu) +return true; +return false; +} + +void evlist__cpu_iter_next (struct evsel *ev) +{ + ev->cpu_index++; +} +void evlist__disable (struct evlist *evlist) {struct evsel *pos;
tools/perf/util/evlist.h +7 -0
@@ -333,9 +333,16 @@ void perf_evlist__to_front(struct evlist *evlist,#define evlist__for_each_entry_safe (evlist, tmp, evsel) \ __evlist__for_each_entry_safe(&(evlist)->core.entries, tmp, evsel) +#define evlist__for_each_cpu (evlist, index, cpu) \ + perf_cpu_map__for_each_cpu (cpu, index, (evlist)->core.all_cpus) +void perf_evlist__set_tracking_event (struct evlist *evlist,struct evsel *tracking_evsel); +void evlist__cpu_iter_start (struct evlist *evlist); +bool evlist__cpu_iter_skip (struct evsel *ev,int cpu); +void evlist__cpu_iter_next (struct evsel *ev); +struct evsel *perf_evlist__find_evsel_by_str (struct evlist *evlist,const char *str);
tools/perf/util/evsel.h +1 -0
@@ -95,6 +95,7 @@ struct evsel {bool collect_stat;bool weak_group;bool percore; +int cpu_index;const char *pmu_name;struct {perf_evsel__sb_cb_t *cb;
Signature · 1 line
2.23.0
PATCH v4 5/9 perf stat: Use affinity for closing file descriptors
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Closing a perf fd can also trigger an IPI to the target CPU. Use the same affinity technique as we use for reading/enabling events to closing to optimize the CPU transitions.
Before on a large test case with 94 CPUs:
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
32.56 3.085463 50 61483 close
After:
10.54 0.735704 11 61485 close
---
v2: Use new iterator macros
v3: Use new iterator macros
Add missing affinity__cleanup
--- tools/perf/lib/evsel.c | 27 +++++++++++++++++++++------ tools/perf/lib/include/perf/evsel.h | 1 + tools/perf/util/evlist.c | 29 +++++++++++++++++++++++++++-- tools/perf/util/evsel.h | 1 + 4 files changed, 50 insertions(+), 8 deletions(-)
tools/perf/lib/evsel.c +21 -6
@@ -114,16 +114,23 @@ int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus,return err; } +static void perf_evsel__close_fd_cpu (struct perf_evsel *evsel,int cpu) +{ +int thread; + +for (thread =0 ; thread <xyarray__max_y (evsel->fd); ++thread) { +if (FD (evsel, cpu, thread) >=0 ) +close (FD (evsel, cpu, thread)); +FD (evsel, cpu, thread) =-1 ; + } +} +void perf_evsel__close_fd (struct perf_evsel *evsel) { -int cpu, thread; +int cpu;for (cpu =0 ; cpu <xyarray__max_x (evsel->fd); cpu++) -for (thread =0 ; thread <xyarray__max_y (evsel->fd); ++thread) { -if (FD (evsel, cpu, thread) >=0 ) -close (FD (evsel, cpu, thread)); -FD (evsel, cpu, thread) =-1 ; - } +perf_evsel__close_fd_cpu (evsel, cpu); }void perf_evsel__free_fd (struct perf_evsel *evsel)
@@ -141,6 +148,14 @@ void perf_evsel__close(struct perf_evsel *evsel)perf_evsel__free_fd (evsel); } +void perf_evsel__close_cpu (struct perf_evsel *evsel,int cpu) +{ +if (evsel->fd ==NULL ) +return ; + +perf_evsel__close_fd_cpu (evsel, cpu); +} +int perf_evsel__read_size (struct perf_evsel *evsel) {u64 read_format = evsel->attr.read_format;
tools/perf/lib/include/perf/evsel.h +1 -0
@@ -26,6 +26,7 @@ LIBPERF_API void perf_evsel__delete(struct perf_evsel *evsel); LIBPERF_API int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus,struct perf_thread_map *threads); LIBPERF_API void perf_evsel__close(struct perf_evsel *evsel); +LIBPERF_API void perf_evsel__close_cpu(struct perf_evsel *evsel, int cpu); LIBPERF_API int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread,struct perf_counts_values *count); LIBPERF_API int perf_evsel__enable(struct perf_evsel *evsel);
tools/perf/util/evlist.c +27 -2
@@ -18,6 +18,7 @@#include "debug.h" #include "units.h" #include <internal/lib.h> // page_size +#include "affinity.h" #include "../perf.h" #include "asm/bug.h" #include "bpf-event.h"
@@ -1165,9 +1166,33 @@ void perf_evlist__set_selected(struct evlist *evlist,void evlist__close (struct evlist *evlist) {struct evsel *evsel; +struct affinity affinity; +int cpu, i; -evlist__for_each_entry_reverse (evlist, evsel) -evsel__close (evsel); +if (!evlist->core.cpus) { +evlist__for_each_entry_reverse (evlist, evsel) +evsel__close (evsel); +return ; + } + +if (affinity__setup (&affinity) <0 ) +return ; +evlist__cpu_iter_start (evlist); + evlist__for_each_cpu (evlist, i, cpu) { +affinity__set (&affinity, cpu); + +evlist__for_each_entry_reverse (evlist, evsel) { +if (evlist__cpu_iter_skip (evsel, cpu)) +continue ; +perf_evsel__close_cpu (&evsel->core, evsel->cpu_index); +evlist__cpu_iter_next (evsel); + } + } +affinity__cleanup (&affinity); +evlist__for_each_entry_reverse (evlist, evsel) { +perf_evsel__free_fd (&evsel->core); +perf_evsel__free_id (&evsel->core); + } }static int perf_evlist__create_syswide_maps (struct evlist *evlist)
tools/perf/util/evsel.h +1 -0
@@ -391,4 +391,5 @@ static inline bool evsel__has_callchain(const struct evsel *evsel)struct perf_env *perf_evsel__env (struct evsel *evsel);int perf_evsel__store_ids (struct evsel *evsel,struct evlist *evlist); +#endif /* __PERF_EVSEL_H */
Signature · 1 line
2.23.0
Re: [PATCH v4 5/9] perf stat: Use affinity for closing file descriptors
On Mon, Nov 04, 2019 at 04:25:18PM -0800, Andi Kleen wrote:
SNIP
Quoted 30 lines
tools/perf/util/evlist.c +12
-2@@ -18,6 +18,7 @@#include "debug.h" #include "units.h" #include <internal/lib.h> // page_size +#include "affinity.h" #include "../perf.h" #include "asm/bug.h" #include "bpf-event.h" @@ -1165,9 +1166,33 @@ void perf_evlist__set_selected(struct evlist *evlist,void evlist__close (struct evlist *evlist) {struct evsel *evsel; +struct affinity affinity; +int cpu, i; -evlist__for_each_entry_reverse (evlist, evsel) -evsel__close (evsel); +if (!evlist->core.cpus) { +evlist__for_each_entry_reverse (evlist, evsel) +evsel__close (evsel); +return ; + } + +if (affinity__setup (&affinity) <0 ) +return ; +evlist__cpu_iter_start (evlist);
tools/perf/util/evlist.c void perf_evlist__set_selected(struct evlist *evlist, · line 1190
Quoted 10 lines
tools/perf/util/evlist.c +10
-0+ evlist__for_each_cpu (evlist, i, cpu) { +affinity__set (&affinity, cpu); + +evlist__for_each_entry_reverse (evlist, evsel) { +if (evlist__cpu_iter_skip (evsel, cpu)) +continue ; +perf_evsel__close_cpu (&evsel->core, evsel->cpu_index); +evlist__cpu_iter_next (evsel); + } + }
looks much better, how about we make it even more compact from above patern, like:
affinity__setup
evlist__cpu_iter(evlist, i, cpu) {
affinity__set(&affinity, cpu);
evlist__for_each_entry_reverse(evlist, evsel) {
if (evsel__cpu_iter_skip(evsel, cpu))
continue;
perf_evsel__close_cpu(&evsel->core, evsel->cpu_iter);
}
}
affinity__cleanupwhere:
- evlist__cpu_iter would call evlist__cpu_iter_start
- evlist__cpu_iter_skip could increment evsel->cpu_index in false case so there's no need to have evlist__cpu_iter_next
- rename evsel->cpu_index to evsel->cpu_iter
- renamse evlist__cpu_iter_skip to evsel__cpu_iter_skip
jirka
Re: [PATCH v4 5/9] perf stat: Use affinity for closing file descriptors
In reply to Andi KleenOn Mon, Nov 04, 2019 at 04:25:18PM -0800, Andi Kleen wrote:
SNIP
Quoted 43 lines
--- tools/perf/lib/evsel.c | 27 +++++++++++++++++++++------ tools/perf/lib/include/perf/evsel.h | 1 + tools/perf/util/evlist.c | 29 +++++++++++++++++++++++++++-- tools/perf/util/evsel.h | 1 + 4 files changed, 50 insertions(+), 8 deletions(-)tools/perf/lib/evsel.c +13
-6@@ -114,16 +114,23 @@ int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus,return err; } +static void perf_evsel__close_fd_cpu (struct perf_evsel *evsel,int cpu) +{ +int thread; + +for (thread =0 ; thread <xyarray__max_y (evsel->fd); ++thread) { +if (FD (evsel, cpu, thread) >=0 ) +close (FD (evsel, cpu, thread)); +FD (evsel, cpu, thread) =-1 ; + } +} +void perf_evsel__close_fd (struct perf_evsel *evsel) { -int cpu, thread; +int cpu;for (cpu =0 ; cpu <xyarray__max_x (evsel->fd); cpu++) -for (thread =0 ; thread <xyarray__max_y (evsel->fd); ++thread) { -if (FD (evsel, cpu, thread) >=0 ) -close (FD (evsel, cpu, thread)); -FD (evsel, cpu, thread) =-1 ; - } +perf_evsel__close_fd_cpu (evsel, cpu); }void perf_evsel__free_fd (struct perf_evsel *evsel)@@ -141,6 +148,14 @@ void perf_evsel__close(struct perf_evsel *evsel)perf_evsel__free_fd (evsel);
tools/perf/lib/evsel.c void perf_evsel__close(struct perf_evsel *evsel) · line 158
Quoted 10 lines
tools/perf/lib/evsel.c +8
-0} +void perf_evsel__close_cpu (struct perf_evsel *evsel,int cpu) +{ +if (evsel->fd ==NULL ) +return ; + +perf_evsel__close_fd_cpu (evsel, cpu); +} +
please move the perf_evsel__close_cpu addition into separate patch
thanks,
jirka
PATCH v4 6/9 perf stat: Factor out open error handling
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Factor out the open error handling into a separate function. This is useful for followon patches who need to duplicate this.
No behavior change intended.
--- tools/perf/builtin-stat.c | 100 +++++++++++++++++++++++--------------- 1 file changed, 60 insertions(+), 40 deletions(-)
tools/perf/builtin-stat.c +60 -40
@@ -420,6 +420,57 @@ static bool is_target_alive(struct target *_target,return false; } +enum counter_recovery { +COUNTER_SKIP , +COUNTER_RETRY , +COUNTER_FATAL , +}; + +static enum counter_recovery stat_handle_error (struct evsel *counter) +{ +char msg[BUFSIZ ]; +/* +* PPC returns ENXIO for HW counters until 2.6.37 +* (behavior changed with commit b0a873e). +*/ +if (errno ==EINVAL || errno ==ENOSYS || + errno ==ENOENT || errno ==EOPNOTSUPP || + errno ==ENXIO ) { +if (verbose >0 ) +ui__warning ("%s event is not supported by the kernel.\n" , +perf_evsel__name (counter)); + counter->supported = false; + +if ((counter->leader != counter) || + !(counter->leader->core.nr_members >1 )) +return COUNTER_SKIP ; + }else if (perf_evsel__fallback (counter, errno, msg,sizeof (msg))) { +if (verbose >0 ) +ui__warning ("%s\n" , msg); +return COUNTER_RETRY ; + }else if (target__has_per_thread (&target) && + evsel_list->core.threads && + evsel_list->core.threads->err_thread !=-1 ) { +/* +* For global --per-thread case, skip current +* error thread. +*/ +if (!thread_map__remove (evsel_list->core.threads, + evsel_list->core.threads->err_thread)) { + evsel_list->core.threads->err_thread =-1 ; +return COUNTER_RETRY ; + } + } + +perf_evsel__open_strerror (counter, &target, + errno, msg,sizeof (msg)); +ui__error ("%s\n" , msg); + +if (child_pid !=-1 ) +kill (child_pid,SIGTERM ); +return COUNTER_FATAL ; +} +static int __run_perf_stat (int argc,const char **argv,int run_idx) {int interval = stat_config.interval;
@@ -469,47 +520,16 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx) goto try_again; } -/* -* PPC returns ENXIO for HW counters until 2.6.37 -* (behavior changed with commit b0a873e). -*/ -if (errno ==EINVAL || errno ==ENOSYS || - errno ==ENOENT || errno ==EOPNOTSUPP || - errno ==ENXIO ) { -if (verbose >0 ) -ui__warning ("%s event is not supported by the kernel.\n" , -perf_evsel__name (counter)); - counter->supported = false; - -if ((counter->leader != counter) || - !(counter->leader->core.nr_members >1 )) -continue ; - }else if (perf_evsel__fallback (counter, errno, msg,sizeof (msg))) { -if (verbose >0 ) -ui__warning ("%s\n" , msg); - goto try_again; - }else if (target__has_per_thread (&target) && - evsel_list->core.threads && - evsel_list->core.threads->err_thread !=-1 ) { -/* -* For global --per-thread case, skip current -* error thread. -*/ -if (!thread_map__remove (evsel_list->core.threads, - evsel_list->core.threads->err_thread)) { - evsel_list->core.threads->err_thread =-1 ; - goto try_again; - } +switch (stat_handle_error (counter)) { +case COUNTER_FATAL : +return -1 ; +case COUNTER_RETRY : + goto try_again; +case COUNTER_SKIP : +continue ; +default : +break ; } - -perf_evsel__open_strerror (counter, &target, - errno, msg,sizeof (msg)); -ui__error ("%s\n" , msg); - -if (child_pid !=-1 ) -kill (child_pid,SIGTERM ); - -return -1 ; } counter->supported = true;
Signature · 1 line
2.23.0
Re: [PATCH v4 6/9] perf stat: Factor out open error handling
On Mon, Nov 04, 2019 at 04:25:19PM -0800, Andi Kleen wrote:
SNIP
Quoted 34 lines
tools/perf/builtin-stat.c +0
-31goto try_again; } -/* -* PPC returns ENXIO for HW counters until 2.6.37 -* (behavior changed with commit b0a873e). -*/ -if (errno ==EINVAL || errno ==ENOSYS || - errno ==ENOENT || errno ==EOPNOTSUPP || - errno ==ENXIO ) { -if (verbose >0 ) -ui__warning ("%s event is not supported by the kernel.\n" , -perf_evsel__name (counter)); - counter->supported = false; - -if ((counter->leader != counter) || - !(counter->leader->core.nr_members >1 )) -continue ; - }else if (perf_evsel__fallback (counter, errno, msg,sizeof (msg))) { -if (verbose >0 ) -ui__warning ("%s\n" , msg); - goto try_again; - }else if (target__has_per_thread (&target) && - evsel_list->core.threads && - evsel_list->core.threads->err_thread !=-1 ) { -/* -* For global --per-thread case, skip current -* error thread. -*/ -if (!thread_map__remove (evsel_list->core.threads, - evsel_list->core.threads->err_thread)) { - evsel_list->core.threads->err_thread =-1 ; - goto try_again; - }
tools/perf/builtin-stat.c static int __run_perf_stat(int argc, const char **argv, int run_idx) · line 532
Quoted 10 lines
tools/perf/builtin-stat.c +9
-0+switch (stat_handle_error (counter)) { +case COUNTER_FATAL : +return -1 ; +case COUNTER_RETRY : + goto try_again; +case COUNTER_SKIP : +continue ; +default : +break ; }
great, looks good, thanks
jirka
Quoted 15 lines
tools/perf/builtin-stat.c +0
-9- -perf_evsel__open_strerror (counter, &target, - errno, msg,sizeof (msg)); -ui__error ("%s\n" , msg); - -if (child_pid !=-1 ) -kill (child_pid,SIGTERM ); - -return -1 ; } counter->supported = true;Signature · 2 lines
-- 2.23.0
PATCH v4 7/9 perf stat: Use affinity for opening events
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Restructure the event opening in perf stat to cycle through the events by CPU after setting affinity to that CPU. This eliminates IPI overhead in the perf API.
We have to loop through the CPU in the outter builtin-stat code instead of leaving that to low level functions.
It has to change the weak group fallback strategy slightly. Since we cannot easily undo the opens for other CPUs move the weak group retry to a separate loop.
Before with a large test case with 94 CPUs:
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
42.75 4.050910 67 60046 110 perf_event_open
After:
26.86 0.944396 16 58069 110 perf_event_open
(the number changes slightly because the weak group retries work differently and the test case relies on weak groups)
---
v2: Use new iterator macros.
Fix bug that caused unnecessary retry for errored events. Add extra assert to check assumption that cpumaps are always subsets v3:
Use new iterator macros
Factored out code movement for error handling.
--- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-stat.c | 122 ++++++++++++++++++++++++++++----- tools/perf/tests/event-times.c | 4 +- tools/perf/util/evlist.c | 6 +- tools/perf/util/evlist.h | 3 +- tools/perf/util/evsel.c | 18 +++-- tools/perf/util/evsel.h | 5 +- tools/perf/util/stat.c | 5 +- tools/perf/util/stat.h | 3 +- 9 files changed, 134 insertions(+), 34 deletions(-)
tools/perf/builtin-record.c +1 -1
@@ -776,7 +776,7 @@ static int record__open(struct record *rec)if ((errno ==EINVAL || errno ==EBADF ) && pos->leader != pos && pos->weak_group) { - pos =perf_evlist__reset_weak_group (evlist, pos); + pos =perf_evlist__reset_weak_group (evlist, pos, true); goto try_again; } rc = -errno;
tools/perf/builtin-stat.c +103 -19
151 lines not on this page · raw message
tools/perf/tests/event-times.c +2 -2
@@ -125,7 +125,7 @@ static int attach__cpu_disabled(struct evlist *evlist) evsel->core.attr.disabled =1 ; - err =perf_evsel__open_per_cpu (evsel, cpus); + err =perf_evsel__open_per_cpu (evsel, cpus,-1 );if (err) {if (err == -EACCES )return TEST_SKIP ;
@@ -152,7 +152,7 @@ static int attach__cpu_enabled(struct evlist *evlist)return -1 ; } - err =perf_evsel__open_per_cpu (evsel, cpus); + err =perf_evsel__open_per_cpu (evsel, cpus,-1 );if (err == -EACCES )return TEST_SKIP ;
tools/perf/util/evlist.c +4 -2
@@ -1630,7 +1630,8 @@ void perf_evlist__force_leader(struct evlist *evlist) }struct evsel *perf_evlist__reset_weak_group (struct evlist *evsel_list, -struct evsel *evsel) +struct evsel *evsel, +bool close) {struct evsel *c2, *leader;bool is_open = true;
@@ -1647,10 +1648,11 @@ struct evsel *perf_evlist__reset_weak_group(struct evlist *evsel_list,if (c2 == evsel) is_open = false;if (c2->leader == leader) { -if (is_open) +if (is_open && close)perf_evsel__close (&c2->core); c2->leader = c2; c2->core.nr_members =0 ; + c2->reset_group = true; } }return leader;
tools/perf/util/evlist.h +2 -1
@@ -354,5 +354,6 @@ bool perf_evlist__exclude_kernel(struct evlist *evlist);void perf_evlist__force_leader (struct evlist *evlist);struct evsel *perf_evlist__reset_weak_group (struct evlist *evlist, -struct evsel *evsel); +struct evsel *evsel, +bool close);#endif /* __PERF_EVLIST_H */
tools/perf/util/evsel.c +13 -5
@@ -1569,8 +1569,9 @@ static int perf_event_open(struct evsel *evsel,return fd; } -int evsel__open (struct evsel *evsel,struct perf_cpu_map *cpus, -struct perf_thread_map *threads) +static int evsel__open_cpu (struct evsel *evsel,struct perf_cpu_map *cpus, +struct perf_thread_map *threads, +int start_cpu,int end_cpu) {int cpu, thread, nthreads;unsigned long flags =PERF_FLAG_FD_CLOEXEC ;
@@ -1647,7 +1648,7 @@ int evsel__open(struct evsel *evsel, struct perf_cpu_map *cpus,display_attr (&evsel->core.attr); -for (cpu =0 ; cpu < cpus->nr; cpu++) { +for (cpu = start_cpu; cpu < end_cpu; cpu++) {for (thread =0 ; thread < nthreads; thread++) {int fd, group_fd;
@@ -1825,6 +1826,12 @@ int evsel__open(struct evsel *evsel, struct perf_cpu_map *cpus,return err; } +int evsel__open (struct evsel *evsel,struct perf_cpu_map *cpus, +struct perf_thread_map *threads) +{ +return evsel__open_cpu (evsel, cpus, threads,0 , cpus ? cpus->nr :1 ); +} +void evsel__close (struct evsel *evsel) {perf_evsel__close (&evsel->core);
@@ -1832,9 +1839,10 @@ void evsel__close(struct evsel *evsel) }int perf_evsel__open_per_cpu (struct evsel *evsel, -struct perf_cpu_map *cpus) +struct perf_cpu_map *cpus, +int cpu) { -return evsel__open (evsel, cpus,NULL ); +return evsel__open_cpu (evsel, cpus,NULL , cpu, cpu +1 ); } int perf_evsel__open_per_thread(struct evsel *evsel,
tools/perf/util/evsel.h +4 -1
@@ -94,6 +94,8 @@ struct evsel {struct evsel *metric_leader;bool collect_stat;bool weak_group; +bool reset_group; +bool errored;bool percore;int cpu_index;const char *pmu_name;
@@ -223,7 +225,8 @@ int evsel__enable(struct evsel *evsel);int evsel__disable (struct evsel *evsel);int perf_evsel__open_per_cpu (struct evsel *evsel, -struct perf_cpu_map *cpus); +struct perf_cpu_map *cpus, +int cpu);int perf_evsel__open_per_thread (struct evsel *evsel,struct perf_thread_map *threads); int evsel__open(struct evsel *evsel, struct perf_cpu_map *cpus,
tools/perf/util/stat.c +3 -2
@@ -463,7 +463,8 @@ size_t perf_event__fprintf_stat_config(union perf_event *event, FILE *fp)int create_perf_stat_counter (struct evsel *evsel,struct perf_stat_config *config, -struct target *target) +struct target *target, +int cpu) {struct perf_event_attr *attr = &evsel->core.attr;struct evsel *leader = evsel->leader;
@@ -517,7 +518,7 @@ int create_perf_stat_counter(struct evsel *evsel, }if (target__has_cpu (target) && !target__has_per_thread (target)) -return perf_evsel__open_per_cpu (evsel,evsel__cpus (evsel)); +return perf_evsel__open_per_cpu (evsel,evsel__cpus (evsel), cpu);return perf_evsel__open_per_thread (evsel, evsel->core.threads); }
tools/perf/util/stat.h +2 -1
@@ -213,7 +213,8 @@ size_t perf_event__fprintf_stat_config(union perf_event *event, FILE *fp);int create_perf_stat_counter (struct evsel *evsel,struct perf_stat_config *config, -struct target *target); +struct target *target, +int cpu); void perf_evlist__print_counters(struct evlist *evlist, struct perf_stat_config *config,
Signature · 1 line
2.23.0
Re: [PATCH v4 7/9] perf stat: Use affinity for opening events
On Mon, Nov 04, 2019 at 04:25:20PM -0800, Andi Kleen wrote:
SNIP
Quoted 23 lines
tools/perf/util/evsel.c +5
-2+} +void evsel__close (struct evsel *evsel) {perf_evsel__close (&evsel->core);@@ -1832,9 +1839,10 @@ void evsel__close(struct evsel *evsel) }int perf_evsel__open_per_cpu (struct evsel *evsel, -struct perf_cpu_map *cpus) +struct perf_cpu_map *cpus, +int cpu) { -return evsel__open (evsel, cpus,NULL ); +return evsel__open_cpu (evsel, cpus,NULL , cpu, cpu +1 ); } int perf_evsel__open_per_thread(struct evsel *evsel,tools/perf/util/evsel.h +0
-0
tools/perf/util/evsel.h struct evsel { · line 98
Quoted 5 lines
tools/perf/util/evsel.h +2
-0@@ -94,6 +94,8 @@ struct evsel {struct evsel *metric_leader;bool collect_stat;bool weak_group; +bool reset_group; +bool errored;
would be great to move some of the changes into separate patches, it seems all related to new code, but would ease up the review like these 2 bools above or adding cpu to create_perf_stat_counter and adding evsel__open_cpu funtion and related changes
thanks,
jirka
PATCH v4 8/9 perf stat: Use affinity for reading
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Restructure event reading to use affinity to minimize the number of IPIs needed.
Before on a large test case with 94 CPUs:
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
3.16 0.106079 4 22082 read
After:
3.43 0.081295 3 22082 read
---
v2: Use new iterator macros
v3: Use new iterator macros
--- tools/perf/builtin-stat.c | 96 ++++++++++++++++++++++----------------- tools/perf/util/evsel.h | 1 + 2 files changed, 56 insertions(+), 41 deletions(-)
tools/perf/builtin-stat.c +55 -41
@@ -266,15 +266,10 @@ static int read_single_counter(struct evsel *counter, int cpu,* Read out the results of a single counter: * do not aggregate counts across CPUs in system-wide mode */ -static int read_counter (struct evsel *counter,struct timespec *rs) +static int read_counter (struct evsel *counter,struct timespec *rs,int cpu) {int nthreads =perf_thread_map__nr (evsel_list->core.threads); -int ncpus, cpu, thread; - -if (target__has_cpu (&target) && !target__has_per_thread (&target)) - ncpus =perf_evsel__nr_cpus (counter); -else - ncpus =1 ; +int thread;if (!counter->supported)return -ENOENT ;
@@ -283,40 +278,38 @@ static int read_counter(struct evsel *counter, struct timespec *rs) nthreads =1 ;for (thread =0 ; thread < nthreads; thread++) { -for (cpu =0 ; cpu < ncpus; cpu++) { -struct perf_counts_values *count; - - count =perf_counts (counter->counts, cpu, thread); - -/* -* The leader's group read loads data into its group members -* (via perf_evsel__read_counter) and sets threir count->loaded. -*/ -if (!perf_counts__is_loaded (counter->counts, cpu, thread) && -read_single_counter (counter, cpu, thread, rs)) { - counter->counts->scaled =-1 ; -perf_counts (counter->counts, cpu, thread)->ena =0 ; -perf_counts (counter->counts, cpu, thread)->run =0 ; -return -1 ; - } +struct perf_counts_values *count; -perf_counts__set_loaded (counter->counts, cpu, thread, false); + count =perf_counts (counter->counts, cpu, thread); -if (STAT_RECORD ) { -if (perf_evsel__write_stat_event (counter, cpu, thread, count)) { -pr_err ("failed to write stat event\n" ); -return -1 ; - } - } +/* +* The leader's group read loads data into its group members +* (via perf_evsel__read_counter) and sets threir count->loaded. +*/ +if (!perf_counts__is_loaded (counter->counts, cpu, thread) && +read_single_counter (counter, cpu, thread, rs)) { + counter->counts->scaled =-1 ; +perf_counts (counter->counts, cpu, thread)->ena =0 ; +perf_counts (counter->counts, cpu, thread)->run =0 ; +return -1 ; + } -if (verbose >1 ) { -fprintf (stat_config.output, -"%s: %d: %" PRIu64" %" PRIu64" %" PRIu64"\n" , -perf_evsel__name (counter), - cpu, - count->val, count->ena, count->run); +perf_counts__set_loaded (counter->counts, cpu, thread, false); + +if (STAT_RECORD ) { +if (perf_evsel__write_stat_event (counter, cpu, thread, count)) { +pr_err ("failed to write stat event\n" ); +return -1 ; } } + +if (verbose >1 ) { +fprintf (stat_config.output, +"%s: %d: %" PRIu64" %" PRIu64" %" PRIu64"\n" , +perf_evsel__name (counter), + cpu, + count->val, count->ena, count->run); + } }return 0 ;
@@ -325,15 +318,36 @@ static int read_counter(struct evsel *counter, struct timespec *rs)static void read_counters (struct timespec *rs) {struct evsel *counter; -int ret; +struct affinity affinity; +int i, ncpus, cpu; + +if (affinity__setup (&affinity) <0 ) +return ; + + ncpus = evsel_list->core.all_cpus->nr; +if (!(target__has_cpu (&target) && !target__has_per_thread (&target))) + ncpus =1 ; +evlist__cpu_iter_start (evsel_list); + evlist__for_each_cpu (evsel_list, i, cpu) { +if (i >= ncpus) +break ; +affinity__set (&affinity, cpu); + +evlist__for_each_entry (evsel_list, counter) { +if (evlist__cpu_iter_skip (counter, cpu)) +continue ; + counter->err =read_counter (counter, rs, counter->cpu_index); +evlist__cpu_iter_next (counter); + } + } +affinity__cleanup (&affinity);evlist__for_each_entry (evsel_list, counter) { - ret =read_counter (counter, rs); -if (ret) +if (counter->err)pr_debug ("failed to read counter %s\n" , counter->name); - -if (ret ==0 &&perf_stat_process_counter (&stat_config, counter)) +if (counter->err ==0 &&perf_stat_process_counter (&stat_config, counter))pr_warning ("failed to process counter %s\n" , counter->name); + counter->err =0 ; } }
tools/perf/util/evsel.h +1 -0
@@ -86,6 +86,7 @@ struct evsel {struct list_head config_terms;struct bpf_object *bpf_obj;int bpf_fd; +int err;bool auto_merge_stats;bool merged_stat;const char * metric_expr;
Signature · 1 line
2.23.0
PATCH v4 9/9 perf stat: Use affinity for enabling/disabling events
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Restructure event enabling/disabling to use affinity, which minimizes the number of IPIs needed.
Before on a large test case with 94 CPUs:
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
54.65 1.899986 22 84812 660 ioctl
after:
39.21 0.930451 10 84796 644 ioctl
---
v2: Use new iterator macros
v3: Use new iterator macros
--- tools/perf/lib/evsel.c | 49 +++++++++++++++++++++-------- tools/perf/lib/include/perf/evsel.h | 2 ++ tools/perf/util/evlist.c | 46 ++++++++++++++++++++++++--- tools/perf/util/evsel.c | 13 ++++++++ tools/perf/util/evsel.h | 2 ++ 5 files changed, 94 insertions(+), 18 deletions(-)
tools/perf/lib/evsel.c +36 -13
@@ -198,38 +198,61 @@ int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread, }static int perf_evsel__run_ioctl (struct perf_evsel *evsel, -int ioc,void *arg) +int ioc,void *arg, +int cpu) { -int cpu, thread; +int thread; -for (cpu =0 ; cpu <xyarray__max_x (evsel->fd); cpu++) { -for (thread =0 ; thread <xyarray__max_y (evsel->fd); thread++) { -int fd =FD (evsel, cpu, thread), - err =ioctl (fd, ioc, arg); +for (thread =0 ; thread <xyarray__max_y (evsel->fd); thread++) { +int fd =FD (evsel, cpu, thread), + err =ioctl (fd, ioc, arg); -if (err) -return err; - } +if (err) +return err; }return 0 ; } +int perf_evsel__enable_cpu (struct perf_evsel *evsel,int cpu) +{ +return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_ENABLE ,0 , cpu); +} +int perf_evsel__enable (struct perf_evsel *evsel) { -return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_ENABLE ,0 ); +int i; +int err =0 ; + +for (i =0 ; i < evsel->cpus->nr && !err; i++) + err =perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_ENABLE ,0 , i); +return err; +} + +int perf_evsel__disable_cpu (struct perf_evsel *evsel,int cpu) +{ +return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_DISABLE ,0 , cpu); }int perf_evsel__disable (struct perf_evsel *evsel) { -return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_DISABLE ,0 ); +int i; +int err =0 ; + +for (i =0 ; i < evsel->cpus->nr && !err; i++) + err =perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_DISABLE ,0 , i); +return err; }int perf_evsel__apply_filter (struct perf_evsel *evsel,const char *filter) { -return perf_evsel__run_ioctl (evsel, +int err =0 , i; + +for (i =0 ; i < evsel->cpus->nr && !err; i++) + err =perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_SET_FILTER , - (void *)filter); + (void *)filter, i); +return err; }struct perf_cpu_map *perf_evsel__cpus (struct perf_evsel *evsel)
tools/perf/lib/include/perf/evsel.h +2 -0
@@ -30,7 +30,9 @@ LIBPERF_API void perf_evsel__close_cpu(struct perf_evsel *evsel, int cpu); LIBPERF_API int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread,struct perf_counts_values *count); LIBPERF_API int perf_evsel__enable(struct perf_evsel *evsel); +LIBPERF_API int perf_evsel__enable_cpu(struct perf_evsel *evsel, int cpu); LIBPERF_API int perf_evsel__disable(struct perf_evsel *evsel); +LIBPERF_API int perf_evsel__disable_cpu(struct perf_evsel *evsel, int cpu); LIBPERF_API struct perf_cpu_map *perf_evsel__cpus(struct perf_evsel *evsel); LIBPERF_API struct perf_thread_map *perf_evsel__threads(struct perf_evsel *evsel); LIBPERF_API struct perf_event_attr *perf_evsel__attr(struct perf_evsel *evsel);
tools/perf/util/evlist.c +41 -5
67 lines not on this page · raw message
tools/perf/util/evsel.c +13 -0
@@ -1205,13 +1205,26 @@ int perf_evsel__append_addr_filter(struct evsel *evsel, const char *filter)return perf_evsel__append_filter (evsel,"%s,%s" , filter); } +/* Caller has to clear disabled after going through all CPUs. */ +int evsel__enable_cpu (struct evsel *evsel,int cpu) +{ +int err =perf_evsel__enable_cpu (&evsel->core, cpu); +return err; +} +int evsel__enable (struct evsel *evsel) {int err =perf_evsel__enable (&evsel->core);if (!err) evsel->disabled = false; +return err; +} +/* Caller has to set disabled after going through all CPUs. */ +int evsel__disable_cpu (struct evsel *evsel,int cpu) +{ +int err =perf_evsel__disable_cpu (&evsel->core, cpu);return err; }
tools/perf/util/evsel.h +2 -0
@@ -222,8 +222,10 @@ int perf_evsel__set_filter(struct evsel *evsel, const char *filter);int perf_evsel__append_tp_filter (struct evsel *evsel,const char *filter);int perf_evsel__append_addr_filter (struct evsel *evsel,const char *filter); +int evsel__enable_cpu (struct evsel *evsel,int cpu);int evsel__enable (struct evsel *evsel);int evsel__disable (struct evsel *evsel); +int evsel__disable_cpu (struct evsel *evsel,int cpu); int perf_evsel__open_per_cpu(struct evsel *evsel, struct perf_cpu_map *cpus,
Signature · 1 line
2.23.0
Re: [PATCH v4 9/9] perf stat: Use affinity for enabling/disabling events
On Mon, Nov 04, 2019 at 04:25:22PM -0800, Andi Kleen wrote:
SNIP
Quoted 62 lines
}
static int perf_evsel__run_ioctl(struct
perf_evsel*evsel,tools/perf/lib/evsel.c +30
-11- int ioc, void *arg) + int ioc, void *arg, + int cpu) { - int cpu, thread; + int thread; -for (cpu =0 ; cpu <xyarray__max_x (evsel->fd); cpu++) { -for (thread =0 ; thread <xyarray__max_y (evsel->fd); thread++) { -int fd =FD (evsel, cpu, thread), - err =ioctl (fd, ioc, arg); +for (thread =0 ; thread <xyarray__max_y (evsel->fd); thread++) { +int fd =FD (evsel, cpu, thread), + err =ioctl (fd, ioc, arg); -if (err) -return err; - } +if (err) +return err; }return 0 ; } +int perf_evsel__enable_cpu (struct perf_evsel *evsel,int cpu) +{ +return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_ENABLE ,0 , cpu); +} +int perf_evsel__enable (struct perf_evsel *evsel) { -return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_ENABLE ,0 ); +int i; +int err =0 ; + +for (i =0 ; i < evsel->cpus->nr && !err; i++) + err =perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_ENABLE ,0 , i); +return err; +} + +int perf_evsel__disable_cpu (struct perf_evsel *evsel,int cpu) +{ +return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_DISABLE ,0 , cpu); }int perf_evsel__disable (struct perf_evsel *evsel) { -return perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_DISABLE ,0 ); +int i; +int err =0 ; + +for (i =0 ; i < evsel->cpus->nr && !err; i++) + err =perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_DISABLE ,0 , i); +return err; }int perf_evsel__apply_filter (struct perf_evsel *evsel,const char *filter) {
tools/perf/lib/evsel.c int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread, · line 256
Quoted 10 lines
tools/perf/lib/evsel.c +6
-2-return perf_evsel__run_ioctl (evsel, +int err =0 , i; + +for (i =0 ; i < evsel->cpus->nr && !err; i++) + err =perf_evsel__run_ioctl (evsel,PERF_EVENT_IOC_SET_FILTER , - (void *)filter); + (void *)filter, i); +return err; }
please move the new function additions to separate patches
thanks,
jirka