sfc: trace_xdp_exception on XDP failure
Subsystems (4)
PATCH v2 1/1 sfc: trace_xdp_exception on XDP failure
The sfc driver can drop packets processed with XDP, notably when running out of buffer space on XDP_TX, or returning an unknown XDP action. This increments the rx_xdp_bad_drops ethtool counter.
Call trace_xdp_exception everywhere rx_xdp_bad_drops is incremented, except for fragmented RX packets as the XDP program hasn't run yet. This allows it to easily be monitored from userspace.
This mirrors the behavior of other drivers.
---
Changes since v1:
- Removed trace_xdp_exception from receive fragements check, as XDP program hasn't been run yet
drivers/net/ethernet/sfc/rx.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/sfc/rx.c +3 -0
@@ -724,6 +724,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel,netif_err (efx, rx_err, efx->net_dev,"XDP TX failed (%d)\n" , err); channel->n_rx_xdp_bad_drops++; +trace_xdp_exception (efx->net_dev, xdp_prog, xdp_act); }else { channel->n_rx_xdp_tx++; }
@@ -737,6 +738,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel,netif_err (efx, rx_err, efx->net_dev,"XDP redirect failed (%d)\n" , err); channel->n_rx_xdp_bad_drops++; +trace_xdp_exception (efx->net_dev, xdp_prog, xdp_act); }else { channel->n_rx_xdp_redirect++; }
@@ -746,6 +748,7 @@ static bool efx_do_xdp(struct efx_nic *efx, struct efx_channel *channel,bpf_warn_invalid_xdp_action (xdp_act);efx_free_rx_buffers (rx_queue, rx_buf,1 ); channel->n_rx_xdp_bad_drops++; +trace_xdp_exception (efx->net_dev, xdp_prog, xdp_act);break ;case XDP_ABORTED :
Signature · 1 line
2.24.0.rc2
Quoted 11 lines · Arthur Fabre
The sfc driver can drop packets processed with XDP, notably when running out of buffer space on
XDP_TX, or returning an unknown XDP action. This increments therx_xdp_bad_dropsethtool counter.Call
trace_xdp_exceptioneverywhererx_xdp_bad_dropsis incremented, except for fragmented RX packets as the XDP program hasn't run yet. This allows it to easily be monitored from userspace.This mirrors the behavior of other drivers.
Signed-off-by Arthur Fabre <[email protected]>
From: Arthur Fabre <[email protected]>
Date: Tue, 12 Nov 2019 15:36:01 +0000
Quoted 11 lines
The sfc driver can drop packets processed with XDP, notably when running out of buffer space on
XDP_TX, or returning an unknown XDP action. This increments therx_xdp_bad_dropsethtool counter.Call
trace_xdp_exceptioneverywhererx_xdp_bad_dropsis incremented, except for fragmented RX packets as the XDP program hasn't run yet. This allows it to easily be monitored from userspace.This mirrors the behavior of other drivers.
Signed-off-by Arthur Fabre <[email protected]>
Applied.