Skip to contentSkip to conversation

ARM: dts: ls1021a: define and use external interrupt lines

PATCH Applied Rasmus Villemoes 5 participants 7 messages Nov 14, 2019 – Dec 4, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: dts: ls1021a: define and use external interrupt lines

A device tree binding documentation as well as a driver implementing support for the external interrupt lines on the ls1021a has been merged into irqchip-next, so will very likely appear in v5.5. See

87cd38dfd9e6 dt/bindings: Add bindings for Layerscape external irqs 0dcd9f872769 irqchip: Add support for Layerscape external interrupt lines

present in next-20191114.

These patches simply add the extirq node to the ls1021a.dtsi and make use of it on the LS1021A-TSN board. I hope these can be picked up so they also land in v5.5, so we don't have to wait a full extra release cycle.

v2: fix interrupt type in 2/2 (s/IRQ_TYPE_EDGE_FALLING/IRQ_TYPE_LEVEL_LOW/).

Rasmus Villemoes (1):
ARM: dts: ls1021a: add node describing external interrupt lines

Vladimir Oltean (1):
ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs

 arch/arm/boot/dts/ls1021a-tsn.dts |  4 ++++
 arch/arm/boot/dts/ls1021a.dtsi    | 19 +++++++++++++++++++
 2 files changed, 23 insertions(+)
Signature · 1 line
2.23.0
#1 lore raw

PATCH v2 1/2 ARM: dts: ls1021a: add node describing external interrupt lines

This adds a node describing the six external interrupt lines IRQ0-IRQ5 with configurable polarity.

---
 arch/arm/boot/dts/ls1021a.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
arch/arm/boot/dts/ls1021a.dtsi +19 -0
index 2f6977ada447..0855b1fe98e0 100644
@@ -216,6 +216,25 @@
 			compatible = "fsl,ls1021a-scfg", "syscon";
 			reg = <0x0 0x1570000 0x0 0x10000>;
 			big-endian;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0x0 0x0 0x1570000 0x10000>;
+
+			extirq: interrupt-controller@1ac {
+				compatible = "fsl,ls1021a-extirq";
+				#interrupt-cells = <2>;
+				#address-cells = <0>;
+				interrupt-controller;
+				reg = <0x1ac 4>;
+				interrupt-map =
+					<0 0 &gic GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
+					<1 0 &gic GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
+					<2 0 &gic GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>,
+					<3 0 &gic GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>,
+					<4 0 &gic GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>,
+					<5 0 &gic GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
+				interrupt-map-mask = <0xffffffff 0x0>;
+			};
 		};
 
 		crypto: crypto@1700000 {
Signature · 1 line
2.23.0
#2 lore raw

PATCH v2 2/2 ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs

In reply to Rasmus Villemoes

From: Vladimir Oltean <[email protected]>

On the LS1021A-TSN board, the 2 Atheros AR8031 PHYs for eth0 and eth1 have interrupt lines connected to the shared IRQ2_B LS1021A pin.

Switching to interrupts offloads the PHY library from the task of polling the MDIO status and AN registers (1, 4, 5) every second.

Unfortunately, the BCM5464R quad PHY connected to the switch does not appear to have an interrupt line routed to the SoC.

---
 arch/arm/boot/dts/ls1021a-tsn.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/ls1021a-tsn.dts +4 -0
index 5b7689094b70..9d8f0c2a8aba 100644
@@ -203,11 +203,15 @@
 	/* AR8031 */
 	sgmii_phy1: ethernet-phy@1 {
 		reg = <0x1>;
+		/* SGMII1_PHY_INT_B: connected to IRQ2, active low */
+		interrupts-extended = <&extirq 2 IRQ_TYPE_LEVEL_LOW>;
 	};
 
 	/* AR8031 */
 	sgmii_phy2: ethernet-phy@2 {
 		reg = <0x2>;
+		/* SGMII2_PHY_INT_B: connected to IRQ2, active low */
+		interrupts-extended = <&extirq 2 IRQ_TYPE_LEVEL_LOW>;
 	};
 
 	/* BCM5464 quad PHY */
Signature · 1 line
2.23.0
Reviewed-by on v2 2/2
#3 lore raw

Re: [PATCH v2 2/2] ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs

Quoted 5 lines · Rasmus Villemoes

From: Vladimir Oltean <[email protected]>

On the LS1021A-TSN board, the 2 Atheros AR8031 PHYs for eth0 and eth1 have interrupt lines connected to the shared IRQ2_B LS1021A pin.

Quoted 8 lines

Switching to interrupts offloads the PHY library from the task of polling the MDIO status and AN registers (1, 4, 5) every second.

Unfortunately, the BCM5464R quad PHY connected to the switch does not appear to have an interrupt line routed to the SoC.

Andrew

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#4 lore raw
In reply to Rasmus Villemoes

From: Rasmus Villemoes <[email protected]>
Date: Thu, 14 Nov 2019 12:02:51 +0100

Quoted 7 lines

A device tree binding documentation as well as a driver implementing support for the external interrupt lines on the ls1021a has been merged into irqchip-next, so will very likely appear in v5.5. See

87cd38dfd9e6 dt/bindings: Add bindings for Layerscape external irqs 0dcd9f872769 irqchip: Add support for Layerscape external interrupt lines

Quoted 8 lines

present in next-20191114.

These patches simply add the extirq node to the ls1021a.dtsi and make use of it on the LS1021A-TSN board. I hope these can be picked up so they also land in v5.5, so we don't have to wait a full extra release cycle.

v2: fix interrupt type in 2/2 (s/IRQ_TYPE_EDGE_FALLING/IRQ_TYPE_LEVEL_LOW/).

I am assuming this will go via an ARM tree.

#5 lore raw
Quoted 13 lines · David Miller

From: Rasmus Villemoes <[email protected]>
Date: Thu, 14 Nov 2019 12:02:51 +0100

Quoted 9 lines

A device tree binding documentation as well as a driver implementing support for the external interrupt lines on the ls1021a has been merged into irqchip-next, so will very likely appear in v5.5. See

87cd38dfd9e6 dt/bindings: Add bindings for Layerscape external irqs 0dcd9f872769 irqchip: Add support for Layerscape external interrupt lines

present in next-20191114.

Quoted 8 lines
Quoted 6 lines

These patches simply add the extirq node to the ls1021a.dtsi and make use of it on the LS1021A-TSN board. I hope these can be picked up so they also land in v5.5, so we don't have to wait a full extra release cycle.

v2: fix interrupt type in 2/2 (s/IRQ_TYPE_EDGE_FALLING/IRQ_TYPE_LEVEL_LOW/).

I am assuming this will go via an ARM tree.

Yes, of course, they are for Shawn. Netdev and Andrew was copied for patch 2/2 (an SGMII PHY interrupt).

Regards,
-Vladimir

Applied
#6 lore raw
In reply to Rasmus Villemoes
Quoted 7 lines · Rasmus Villemoes

A device tree binding documentation as well as a driver implementing support for the external interrupt lines on the ls1021a has been merged into irqchip-next, so will very likely appear in v5.5. See

87cd38dfd9e6 dt/bindings: Add bindings for Layerscape external irqs 0dcd9f872769 irqchip: Add support for Layerscape external interrupt lines

Quoted 6 lines

present in next-20191114.

These patches simply add the extirq node to the ls1021a.dtsi and make use of it on the LS1021A-TSN board. I hope these can be picked up so they also land in v5.5, so we don't have to wait a full extra release cycle.

Sorry. I usually send queued patches around -rc6 timeline to my arm-soc maintainers. Patches coming later than that will be scheduled for the next release unless critical fixes.

Quoted 8 lines

v2: fix interrupt type in 2/2 (s/IRQ_TYPE_EDGE_FALLING/IRQ_TYPE_LEVEL_LOW/).

Rasmus Villemoes (1):
ARM: dts: ls1021a: add node describing external interrupt lines

Vladimir Oltean (1):
ARM: dts: ls1021a-tsn: Use interrupts for the SGMII PHYs

Applied both, thanks.