Skip to contentSkip to conversation

dp83640: Reject requests to enable time stamping on both edges.

PATCH In review Richard Cochran 1 participant 1 message Nov 14, 2019

Subsystems (4)
lore
Share & tools
lore

Richard Cochran

author maintainer
#0 lore raw

PATCH 10/13 dp83640: Reject requests to enable time stamping on both edges.

This driver enables rising edge or falling edge, but not both, and so this patch validates that the request contains only one of the two edges.

---
 drivers/net/phy/dp83640.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/phy/dp83640.c +7 -0
index 3bba2bea3a88..8f241b57fcf6 100644
@@ -475,6 +475,13 @@ static int ptp_dp83640_enable(struct ptp_clock_info *ptp,
 					PTP_FALLING_EDGE |
 					PTP_STRICT_FLAGS))
 			return -EOPNOTSUPP;
+
+		/* Reject requests to enable time stamping on both edges. */
+		if ((rq->extts.flags & PTP_STRICT_FLAGS) &&
+		    (rq->extts.flags & PTP_ENABLE_FEATURE) &&
+		    (rq->extts.flags & PTP_EXTTS_EDGES) == PTP_EXTTS_EDGES)
+			return -EOPNOTSUPP;
+
 		index = rq->extts.index;
 		if (index >= N_EXT_TS)
 			return -EINVAL;
Signature · 1 line
2.20.1