Skip to content

ptp: Validate the ancillary ioctl flags more carefully.

Richard Cochran intel-wired-lan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ptp: Validate requests to enable time stamping of external signals.drivers/ptp/ptp_chardev.c include/uapi/linux/ptp_clock.h+14 -53 replies
2/13net: reject PTP periodic output requests with unsupported flagsdrivers/net/ethernet/broadcom/tg3.c drivers/net/ethernet/intel/igb/igb_ptp.c drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +4 more+27 -02 replies
3/13mv88e6xxx: reject unsupported external timestamp flagsdrivers/net/dsa/mv88e6xxx/ptp.c+6 -01 reply
4/13dp83640: reject unsupported external timestamp flagsdrivers/net/phy/dp83640.c+5 -00 replies
5/13igb: reject unsupported external timestamp flagsdrivers/net/ethernet/intel/igb/igb_ptp.c+6 -00 replies
6/13mlx5: reject unsupported external timestamp flagsdrivers/net/ethernet/mellanox/mlx5/core/lib/clock.c+6 -03 replies
7/13renesas: reject unsupported external timestamp flagsdrivers/net/ethernet/renesas/ravb_ptp.c+6 -00 replies
8/13ptp: Introduce strict checking of external time stamp options.drivers/net/dsa/mv88e6xxx/ptp.c drivers/net/ethernet/intel/igb/igb_ptp.c drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +4 more+15 -63 replies
9/13mv88e6xxx: Reject requests to enable time stamping on both edges.drivers/net/dsa/mv88e6xxx/ptp.c+6 -00 replies
10/13dp83640: Reject requests to enable time stamping on both edges.drivers/net/phy/dp83640.c+7 -00 replies
11/13igb: Reject requests that fail to enable time stamping on both edges.drivers/net/ethernet/intel/igb/igb_ptp.c+6 -00 replies
12/13mlx5: Reject requests to enable time stamping on both edges.drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c+6 -01 reply
13/13ptp: Extend the test program to check the external time stamp flags.tools/testing/selftests/ptp/testptp.c+51 -20 replies

Reviews trailers per patch

6 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAaron BrownRichard CochranSergei ShtylyovJacob KellerSaeed Mahameed
SeriesA-b
1/13
2/13T-b R-b
3/13R-b
4/13R-b
5/13T-b
6/13R-b R-b
7/13R-b R-b
8/13
9/13
10/13
11/13
12/13R-b
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH net 00/13] ptp: Validate the ancillary ioctl flags more carefully.

The flags passed to the ioctls for periodic output signals and time stamping of external signals were never checked, and thus formed a useless ABI inadvertently. More recently, a version 2 of the ioctls was introduced in order make the flags meaningful. This series tightens up the checks on the new ioctl flags.

- Patch 1 ensures at least one edge flag is set for the new ioctl.
- Patches 2-7 are Jacob's recent checks, picking up the tags.
- Patch 8 introduces a "strict" flag for passing to the drivers when the new ioctl is used.
- Patches 9-12 implement the "strict" checking in the drivers.
- Patch 13 extends the test program to exercise combinations of flags.

Jacob Keller (6):
net: reject PTP periodic output requests with unsupported flags
mv88e6xxx: reject unsupported external timestamp flags
dp83640: reject unsupported external timestamp flags
igb: reject unsupported external timestamp flags
mlx5: reject unsupported external timestamp flags
renesas: reject unsupported external timestamp flags

Richard Cochran (7):
ptp: Validate requests to enable time stamping of external signals.
ptp: Introduce strict checking of external time stamp options.
mv88e6xxx: Reject requests to enable time stamping on both edges.
dp83640: Reject requests to enable time stamping on both edges.
igb: Reject requests that fail to enable time stamping on both edges.
mlx5: Reject requests to enable time stamping on both edges.
ptp: Extend the test program to check the external time stamp flags.

 drivers/net/dsa/mv88e6xxx/ptp.c               | 13 +++++
 drivers/net/ethernet/broadcom/tg3.c           |  4 ++
 drivers/net/ethernet/intel/igb/igb_ptp.c      | 17 ++++++
 .../ethernet/mellanox/mlx5/core/lib/clock.c   | 17 ++++++
 drivers/net/ethernet/microchip/lan743x_ptp.c  |  4 ++
 drivers/net/ethernet/renesas/ravb_ptp.c       | 11 ++++
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  |  4 ++
 drivers/net/phy/dp83640.c                     | 16 ++++++
 drivers/ptp/ptp_chardev.c                     | 20 +++++--
 include/uapi/linux/ptp_clock.h                |  5 +-
 tools/testing/selftests/ptp/testptp.c         | 53 ++++++++++++++++++-
 11 files changed, 156 insertions(+), 8 deletions(-)
Signature · 1 line
2.20.1