mlx5: Reject requests to enable time stamping on both edges.
Subsystems (3)
PATCH 12/13 mlx5: Reject requests to enable time stamping on both edges.
This driver enables rising edge or falling edge, but not both, and so this patch validates that the request contains only one of the two edges.
Signed-off-by Richard Cochran <[email protected]>
--- drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +6 -0
@@ -243,6 +243,12 @@ static int mlx5_extts_configure(struct ptp_clock_info *ptp, PTP_STRICT_FLAGS))return -EOPNOTSUPP ; +/* Reject requests to enable time stamping on both edges. */ +if ((rq->extts.flags &PTP_STRICT_FLAGS ) && + (rq->extts.flags &PTP_ENABLE_FEATURE ) && + (rq->extts.flags &PTP_EXTTS_EDGES ) ==PTP_EXTTS_EDGES ) +return -EOPNOTSUPP ; +if (rq->extts.index >= clock->ptp_info.n_pins)return -EINVAL ;
Signature · 1 line
2.20.1
Quoted 18 lines · Richard Cochran
This driver enables rising edge or falling edge, but not both, and so this patch validates that the request contains only one of the two edges.
Signed-off-by Richard Cochran <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +0
-0@@ -243,6 +243,12 @@ static int mlx5_extts_configure(structptp_clock_info *ptp, PTP_STRICT_FLAGS))
drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c static int mlx5_extts_configure(struct · line 254
Quoted 10 lines
drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +6
-0return -EOPNOTSUPP ; +/* Reject requests to enable time stamping on both edges. */ +if ((rq->extts.flags &PTP_STRICT_FLAGS ) && + (rq->extts.flags &PTP_ENABLE_FEATURE ) && + (rq->extts.flags &PTP_EXTTS_EDGES ) ==PTP_EXTTS_EDGES ) +return -EOPNOTSUPP ; +if (rq->extts.index >= clock->ptp_info.n_pins)return -EINVAL ;
Reviewed-by Saeed Mahameed <[email protected]>