Skip to contentSkip to conversation

igb: Reject requests that fail to enable time stamping on both edges.

PATCH In review Richard Cochran 1 participant 1 message Nov 14, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 11/13 igb: Reject requests that fail to enable time stamping on both edges.

This hardware always time stamps rising and falling edges, and so this patch validates that the request does contains both edges.

---
 drivers/net/ethernet/intel/igb/igb_ptp.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/intel/igb/igb_ptp.c +6 -0
index 3fd60715bca7..c39e921757ba 100644
@@ -528,6 +528,12 @@ static int igb_ptp_feature_enable_i210(struct ptp_clock_info *ptp,
 					PTP_STRICT_FLAGS))
 			return -EOPNOTSUPP;
 
+		/* Reject requests failing to enable both edges. */
+		if ((rq->extts.flags & PTP_STRICT_FLAGS) &&
+		    (rq->extts.flags & PTP_ENABLE_FEATURE) &&
+		    (rq->extts.flags & PTP_EXTTS_EDGES) != PTP_EXTTS_EDGES)
+			return -EOPNOTSUPP;
+
 		if (on) {
 			pin = ptp_find_pin(igb->ptp_clock, PTP_PF_EXTTS,
 					   rq->extts.index);
Signature · 1 line
2.20.1