Skip to contentSkip to conversation

drm/amd/display: Modify comments to match the code

PATCH Superseded Zhan Liu 1 participant 1 message Nov 15, 2019

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Zhan Liu

author
#0 lore raw

PATCH 1/1 drm/amd/display: Modify comments to match the code

[Why]
This line of code was modified. However, the comment was remaining unchanged.

[How]
Change "200ms" to "3000ms", which matches the code. Also add another line of comment, which tells people where the value came from.

---
 drivers/gpu/drm/amd/display/dc/dc_helper.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dc_helper.c +5 -1
index 8da4576e2908..4973d50c4fb9 100644
@@ -485,7 +485,11 @@ void generic_reg_wait(const struct dc_context *ctx,
 		return;
 	}
 
-	/* something is terribly wrong if time out is > 200ms. (5Hz) */
+	/* 
+	 * Something is terribly wrong if time out is > 3000ms.
+	 * 3000ms is defined by SMU timeout value.
+	 *
+	 */
 	ASSERT(delay_between_poll_us * time_out_num_tries <= 3000000);
 
 	for (i = 0; i <= time_out_num_tries; i++) {
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx