Skip to contentSkip to conversation

net: macb: add missed tasklet_kill

PATCH Superseded Chuhong Yuan 2 participants 3 messages Nov 16, 2019 – Nov 17, 2019

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: macb: add missed tasklet_kill

This driver forgets to kill tasklet in remove.
Add the call to fix it.

---
Changes in v2:
- Rebase on net-next.

 drivers/net/ethernet/cadence/macb_main.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/cadence/macb_main.c +1 -0
index 8fc2e21f0bb1..7bf86b84b143 100644
@@ -4418,6 +4418,7 @@ static int macb_remove(struct platform_device *pdev)
 
 	if (dev) {
 		bp = netdev_priv(dev);
+		tasklet_kill(&bp->hresp_err_tasklet);
 		mdiobus_unregister(bp->mii_bus);
 		mdiobus_free(bp->mii_bus);
 
Signature · 1 line
2.24.0
maintainer
#1 lore raw

From: Chuhong Yuan <[email protected]>
Date: Sat, 16 Nov 2019 22:23:10 +0800

Quoted 7 lines

This driver forgets to kill tasklet in remove.
Add the call to fix it.

---
Changes in v2:
- Rebase on net-next.

Does this bug exist in mainline? Then this bug fix should target 'net'.

You must also provide an appropriate Fixes: tag which indicates the commit which introduced this bug.

Thank you.

#2 lore raw
Quoted 7 lines · David Miller

From: Chuhong Yuan <[email protected]>
Date: Sat, 16 Nov 2019 22:23:10 +0800

Quoted 3 lines

This driver forgets to kill tasklet in remove.
Add the call to fix it.

Quoted 7 lines
Quoted 4 lines

---
Changes in v2:
- Rebase on net-next.

Does this bug exist in mainline? Then this bug fix should target 'net'.

This bug exists in mainline but this file has been modified in net-next, so the line number is a little different.

Quoted 4 lines

You must also provide an appropriate Fixes: tag which indicates the commit which introduced this bug.

Thank you.