net: macb: add missed tasklet_kill
Subsystems (3)
PATCH v2 1/1 net: macb: add missed tasklet_kill
This driver forgets to kill tasklet in remove.
Add the call to fix it.
---
Changes in v2:
- Rebase on net-next.
drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/cadence/macb_main.c +1 -0
@@ -4418,6 +4418,7 @@ static int macb_remove(struct platform_device *pdev)if (dev) { bp =netdev_priv (dev); +tasklet_kill (&bp->hresp_err_tasklet);mdiobus_unregister (bp->mii_bus);mdiobus_free (bp->mii_bus);
Signature · 1 line
2.24.0
David Miller
maintainerFrom: Chuhong Yuan <[email protected]>
Date: Sat, 16 Nov 2019 22:23:10 +0800
Quoted 7 lines
This driver forgets to kill tasklet in remove.
Add the call to fix it.Signed-off-by Chuhong Yuan <[email protected]>---
Changes in v2:
- Rebase on net-next.
Does this bug exist in mainline? Then this bug fix should target 'net'.
You must also provide an appropriate Fixes: tag which indicates the commit which introduced this bug.
Thank you.
Quoted 7 lines · David Miller
From: Chuhong Yuan <[email protected]>
Date: Sat, 16 Nov 2019 22:23:10 +0800Quoted 3 lines
This driver forgets to kill tasklet in remove.
Add the call to fix it.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Chuhong Yuan <[email protected]>---
Changes in v2:
- Rebase on net-next.Does this bug exist in mainline? Then this bug fix should target 'net'.
This bug exists in mainline but this file has been modified in net-next, so the line number is a little different.
Quoted 4 lines
You must also provide an appropriate Fixes: tag which indicates the commit which introduced this bug.
Thank you.