Skip to contentSkip to conversation

net: macb: add missed tasklet_kill

PATCH In review Chuhong Yuan 2 participants 2 messages Nov 28, 2019 – Nov 29, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 net: macb: add missed tasklet_kill

This driver forgets to kill tasklet in remove.
Add the call to fix it.

Fixes 032dc41ba6e2 ("net: macb: Handle HRESP error")

---
Changes in v4:
- Put tasklet_kill after unregister_netdev to ensure IRQs are disabled when killing tasklet.

 drivers/net/ethernet/cadence/macb_main.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/cadence/macb_main.c +1 -0
index d5ae2e1e0b0e..9c767ee252ac 100644
@@ -4422,6 +4422,7 @@ static int macb_remove(struct platform_device *pdev)
 		mdiobus_free(bp->mii_bus);
 
 		unregister_netdev(dev);
+		tasklet_kill(&bp->hresp_err_tasklet);
 		pm_runtime_disable(&pdev->dev);
 		pm_runtime_dont_use_autosuspend(&pdev->dev);
 		if (!pm_runtime_suspended(&pdev->dev)) {
Signature · 1 line
2.24.0
maintainer
#1 lore raw

From: Chuhong Yuan <[email protected]>
Date: Thu, 28 Nov 2019 10:00:21 +0800

Quoted 9 lines

This driver forgets to kill tasklet in remove.
Add the call to fix it.

Fixes 032dc41ba6e2 ("net: macb: Handle HRESP error")

---
Changes in v4:
- Put tasklet_kill after unregister_netdev to ensure IRQs are disabled when killing tasklet.

Applied and queued up for -stable, thanks.