Skip to contentSkip to conversation

virtio-net: add missing articles for new hdr_len feature

PATCH In review Cornelia Huck 3 participants 3 messages Nov 20, 2019 – Nov 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 virtio-net: add missing articles for new hdr_len feature

And tweak a sentence slightly.

---

v1->v2:
- add one more tweak [Stefan]

Note: I have not added definite articles to the feature description; _all_ features for virtio-net are described in that way, and we should add them in one go should we decide to change that.

---
content.tex | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
content.tex +3 -3
index 5d3f865956aa..fc59eea95716 100644
@@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
   \begin{itemize}
   \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
     \field{hdr_len} indicates the header length that needs to be replicated
-    for each packet. It's a number of bytes from beginning of the packet
-    to beginning of the transport payload.
+    for each packet. It's the number of bytes from the beginning of the packet
+    to the beginning of the transport payload.
     Otherwise, if the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
     \field{hdr_len} is a hint to the device as to how much of the header
     needs to be kept to copy into each packet, usually set to the
@@ -3217,7 +3217,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
 
 	\begin{note}
 	Caution should be taken by the implementation so as to prevent
-	malicious driver from attacking the device by setting incorrect hdr_len.
+	a malicious driver from attacking the device by setting an incorrect hdr_len.
 	\end{note}
 
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
Signature · 18 lines
2.21.0


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Cornelia Huck

And tweak a sentence slightly.

---

v1->v2:
- add one more tweak [Stefan]

Quoted 7 lines

Note: I have not added definite articles to the feature description; _all_ features for virtio-net are described in that way, and we should add them in one go should we decide to change that.

---
content.tex | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
#2 lore raw
In reply to Cornelia Huck
Quoted 4 lines · Cornelia Huck

And tweak a sentence slightly.

Thanks! Can you pls add a link to this as a comment to the hdr_len github issue? This way I will remember to pick it up.

Quoted 39 lines

---

v1->v2:
- add one more tweak [Stefan]

Note: I have not added definite articles to the feature description; _all_ features for virtio-net are described in that way, and we should add them in one go should we decide to change that.

---
content.tex | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
content.tex +3 -3
index 5d3f865956aa..fc59eea95716 100644
@@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
   \begin{itemize}
   \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
     \field{hdr_len} indicates the header length that needs to be replicated
-    for each packet. It's a number of bytes from beginning of the packet
-    to beginning of the transport payload.
+    for each packet. It's the number of bytes from the beginning of the packet
+    to the beginning of the transport payload.
     Otherwise, if the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
     \field{hdr_len} is a hint to the device as to how much of the header
     needs to be kept to copy into each packet, usually set to the
@@ -3217,7 +3217,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
 
 	\begin{note}
 	Caution should be taken by the implementation so as to prevent
-	malicious driver from attacking the device by setting incorrect hdr_len.
+	a malicious driver from attacking the device by setting an incorrect hdr_len.
 	\end{note}
 
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
Signature · 1 line
2.21.0

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/