Skip to contentSkip to conversation

virtio-net: add missing articles for new hdr_len feature

PATCH Superseded Cornelia Huck 3 participants 4 messages Nov 20, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-net: add missing articles for new hdr_len feature

---

Note: I have not added definite articles to the feature description; _all_ features for virtio-net are described in that way, and we should add them in one go should we decide to change that.

---
 content.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
content.tex +3 -3
index 5d3f865956aa..452763bbbbc4 100644
@@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
   \begin{itemize}
   \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
     \field{hdr_len} indicates the header length that needs to be replicated
-    for each packet. It's a number of bytes from beginning of the packet
-    to beginning of the transport payload.
+    for each packet. It's a number of bytes from the beginning of the packet
+    to the beginning of the transport payload.
     Otherwise, if the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
     \field{hdr_len} is a hint to the device as to how much of the header
     needs to be kept to copy into each packet, usually set to the
@@ -3217,7 +3217,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
 
 	\begin{note}
 	Caution should be taken by the implementation so as to prevent
-	malicious driver from attacking the device by setting incorrect hdr_len.
+	a malicious driver from attacking the device by setting an incorrect hdr_len.
 	\end{note}
 
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
Signature · 18 lines
2.21.0


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Cornelia Huck

---

Note: I have not added definite articles to the feature description; _all_ features for virtio-net are described in that way, and we should add them in one go should we decide to change that.

---
 content.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
content.tex +0 -0
index 5d3f865956aa..452763bbbbc4 100644

content.tex \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De · line 3104

Quoted 7 lines
content.tex +2 -2
@@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
   \begin{itemize}
   \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
     \field{hdr_len} indicates the header length that needs to be replicated
-    for each packet. It's a number of bytes from beginning of the packet
-    to beginning of the transport payload.
+    for each packet. It's a number of bytes from the beginning of the packet
+    to the beginning of the transport payload.

Another opportunity to tweak the text:
s/a number of bytes/the number of bytes/ is slightly clearer

#2 lore raw
Quoted 28 lines · Stefan Hajnoczi
Quoted 16 lines · Cornelia Huck

---

Note: I have not added definite articles to the feature description; _all_ features for virtio-net are described in that way, and we should add them in one go should we decide to change that.

---
 content.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
content.tex +0 -0
index 5d3f865956aa..452763bbbbc4 100644

content.tex \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De · line 3104

Quoted 7 lines
content.tex +2 -2
@@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
   \begin{itemize}
   \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
     \field{hdr_len} indicates the header length that needs to be replicated
-    for each packet. It's a number of bytes from beginning of the packet
-    to beginning of the transport payload.
+    for each packet. It's a number of bytes from the beginning of the packet
+    to the beginning of the transport payload.

Another opportunity to tweak the text:
s/a number of bytes/the number of bytes/ is slightly clearer

Quoted 1 line

Post a patch? Or are you asking Cornelia to integrate that into hers?

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#3 lore raw
Quoted 29 lines · On Wed, 20 Nov 2019 06:16:21 -0500 "Michael S. Tsirkin" <[email protected]> wrote:
Quoted 28 lines · Stefan Hajnoczi
Quoted 16 lines · Cornelia Huck

---

Note: I have not added definite articles to the feature description; _all_ features for virtio-net are described in that way, and we should add them in one go should we decide to change that.

---
 content.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
content.tex +0 -0
index 5d3f865956aa..452763bbbbc4 100644

content.tex \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De · line 3104

Quoted 7 lines
content.tex +2 -2
@@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
   \begin{itemize}
   \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
     \field{hdr_len} indicates the header length that needs to be replicated
-    for each packet. It's a number of bytes from beginning of the packet
-    to beginning of the transport payload.
+    for each packet. It's a number of bytes from the beginning of the packet
+    to the beginning of the transport payload.  

Another opportunity to tweak the text:
s/a number of bytes/the number of bytes/ is slightly clearer

Quoted 4 lines
Quoted 1 line

Post a patch? Or are you asking Cornelia to integrate that into hers?

That tweak makes sense; I'll send a v2.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/