Skip to contentSkip to conversation

ARM: dts: rockchip: Add missing cpu operating points for rk3288-tinker

PATCH In review Jack Chen 3 participants 3 messages Dec 2, 2019 – Dec 13, 2019

Subsystems (2)
lore
Share & tools
lore

Jack Chen

author
#0 lore raw

PATCH 1/1 ARM: dts: rockchip: Add missing cpu operating points for rk3288-tinker

From: Jack Chen <[email protected]>

The Tinker Board / S devices use a special chip variant called rk3288-c and use different operating points with a higher max frequency.

So add the missing operating points for Tinker Board / S devices, also increase the vdd_cpu regulator-max-microvolt to 1400000 uV so that the cpu can operate at 1.8 GHz.

---
 arch/arm/boot/dts/rk3288-tinker.dtsi | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
arch/arm/boot/dts/rk3288-tinker.dtsi +12 -1
index 81e4e953d4a4..09e83b3d5e7d 100644
@@ -113,6 +113,17 @@
 	cpu0-supply = <&vdd_cpu>;
 };
 
+&cpu_opp_table {
+	opp-1704000000 {
+		opp-hz = /bits/ 64 <1704000000>;
+		opp-microvolt = <1350000>;
+	};
+	opp-1800000000 {
+		opp-hz = /bits/ 64 <1800000000>;
+		opp-microvolt = <1400000>;
+	};
+};
+
 &gmac {
 	assigned-clocks = <&cru SCLK_MAC>;
 	assigned-clock-parents = <&ext_gmac>;
@@ -175,7 +186,7 @@
 				regulator-always-on;
 				regulator-boot-on;
 				regulator-min-microvolt = <750000>;
-				regulator-max-microvolt = <1350000>;
+				regulator-max-microvolt = <1400000>;
 				regulator-name = "vdd_arm";
 				regulator-ramp-delay = <6000>;
 				regulator-state-mem {
Signature · 1 line
2.24.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Jack,

Quoted 10 lines · Jack Chen

From: Jack Chen <[email protected]>

The Tinker Board / S devices use a special chip variant called rk3288-c and use different operating points with a higher max frequency.

So add the missing operating points for Tinker Board / S devices, also increase the vdd_cpu regulator-max-microvolt to 1400000 uV so that the cpu can operate at 1.8 GHz.

This patch looks good to me,

Thanks,
- Kever

Quoted 35 lines
---
  arch/arm/boot/dts/rk3288-tinker.dtsi | 13 ++++++++++++-
  1 file changed, 12 insertions(+), 1 deletion(-)
arch/arm/boot/dts/rk3288-tinker.dtsi +12 -1
index 81e4e953d4a4..09e83b3d5e7d 100644
@@ -113,6 +113,17 @@
  	cpu0-supply = <&vdd_cpu>;
  };
 
+&cpu_opp_table {
+	opp-1704000000 {
+		opp-hz = /bits/ 64 <1704000000>;
+		opp-microvolt = <1350000>;
+	};
+	opp-1800000000 {
+		opp-hz = /bits/ 64 <1800000000>;
+		opp-microvolt = <1400000>;
+	};
+};
+
  &gmac {
  	assigned-clocks = <&cru SCLK_MAC>;
  	assigned-clock-parents = <&ext_gmac>;
@@ -175,7 +186,7 @@
  				regulator-always-on;
  				regulator-boot-on;
  				regulator-min-microvolt = <750000>;
-				regulator-max-microvolt = <1350000>;
+				regulator-max-microvolt = <1400000>;
  				regulator-name = "vdd_arm";
  				regulator-ramp-delay = <6000>;
  				regulator-state-mem {
maintainer
#2 lore raw
In reply to Jack Chen

Am Montag, 2. Dezember 2019, 16:35:40 CET schrieb Jack Chen:

Quoted 10 lines

From: Jack Chen <[email protected]>

The Tinker Board / S devices use a special chip variant called rk3288-c and use different operating points with a higher max frequency.

So add the missing operating points for Tinker Board / S devices, also increase the vdd_cpu regulator-max-microvolt to 1400000 uV so that the cpu can operate at 1.8 GHz.

applied for 5.6

Thanks
Heiko