kunit: testing kunit: Bug fix in test_run_timeout function
PATCH v2 1/1 kunit: testing kunit: Bug fix in test_run_timeout function
Assert in test_run_timeout was not updated with the build_dir argument and caused the following error:
AssertionError: Expected call: run_kernel(timeout=3453) Actual call: run_kernel(build_dir=None, timeout=3453)
Needed to update kunit_tool_test to reflect this fix
https://lkml.org/lkml/2019/9/6/351
--- tools/testing/kunit/kunit_tool_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/kunit/kunit_tool_test.py +1 -1
@@ -199,7 +199,7 @@ class KUnitMainTest(unittest.TestCase): timeout = 3453 kunit.main(['run', '--timeout', str(timeout)], self.linux_source_mock) assert self.linux_source_mock.build_reconfig.call_count == 1 - self.linux_source_mock.run_kernel.assert_called_once_with(timeout=timeout) + self.linux_source_mock.run_kernel.assert_called_once_with(build_dir=None, timeout=timeout) self.print_mock.assert_any_call(StrContains('Testing complete.')) if __name__ == '__main__':
Signature · 1 line
2.24.0.393.g34dc348eaf-goog
Quoted 11 lines · Heidi Fahim
Assert in
test_run_timeoutwas not updated with thebuild_dirargument and caused the following error:
AssertionError: Expected call:run_kernel(timeout=3453)Actual call:run_kernel(build_dir=None, timeout=3453)Needed to update
kunit_tool_testto reflect this fix
https://lkml.org/lkml/2019/9/6/351Signed-off-by Heidi Fahim <[email protected]>Reviewed-by SeongJae Park <[email protected]>
Heidi, thanks for taking care of this!
Shuah, can we make sure to get this in as a v5.5 fix?