kunit: testing kunit: Bug fix in test_run_timeout function
PATCH 1/1 kunit: testing kunit: Bug fix in test_run_timeout function
Assert in test_run_timeout was not updated with the build_dir argument and caused the following error:
AssertionError: Expected call: run_kernel(timeout=3453) Actual call: run_kernel(build_dir=None, timeout=3453)
Needed to update kunit_tool_test to reflect this fix
https://lkml.org/lkml/2019/9/6/3
--- tools/testing/kunit/kunit_tool_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/kunit/kunit_tool_test.py +1 -1
@@ -199,7 +199,7 @@ class KUnitMainTest(unittest.TestCase): timeout = 3453 kunit.main(['run', '--timeout', str(timeout)], self.linux_source_mock) assert self.linux_source_mock.build_reconfig.call_count == 1 - self.linux_source_mock.run_kernel.assert_called_once_with(timeout=timeout) + self.linux_source_mock.run_kernel.assert_called_once_with(build_dir=None, timeout=timeout) self.print_mock.assert_any_call(StrContains('Testing complete.')) if __name__ == '__main__':
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog
Quoted 8 lines · Heidi Fahim
Assert in
test_run_timeoutwas not updated with thebuild_dirargument and caused the following error:
AssertionError: Expected call:run_kernel(timeout=3453)Actual call:run_kernel(build_dir=None, timeout=3453)Needed to update
kunit_tool_testto reflect this fix
https://lkml.org/lkml/2019/9/6/3
Wrong url, here is the correct link to the fix that caused this bug:
https://lkml.org/lkml/2019/9/6/351
SeongJae Park
Reviewed-byQuoted 8 lines · Heidi Fahim
Quoted 6 lines · Heidi Fahim
Assert in
test_run_timeoutwas not updated with thebuild_dirargument and caused the following error:
AssertionError: Expected call:run_kernel(timeout=3453)Actual call:run_kernel(build_dir=None, timeout=3453)
Quoted 5 lines
Quoted 2 lines
Needed to update
kunit_tool_testto reflect this fix
https://lkml.org/lkml/2019/9/6/3Wrong url, here is the correct link to the fix that caused this bug:
https://lkml.org/lkml/2019/9/6/351
Thanks,
SeongJae Park
Quoted 11 lines · Heidi Fahim
Assert in
test_run_timeoutwas not updated with thebuild_dirargument and caused the following error:
AssertionError: Expected call:run_kernel(timeout=3453)Actual call:run_kernel(build_dir=None, timeout=3453)Needed to update
kunit_tool_testto reflect this fix
https://lkml.org/lkml/2019/9/6/3Signed-off-by Heidi Fahim <[email protected]>Change-Id I6f161c72c6a5f071a4dc31582ba08b91974502ce
Change-Id should not be used on LKML patches. Did you run checkpatch?