drm/i915: eDP DPCD aux backlight fixes
cover drm/i915: eDP DPCD aux backlight fixes
I recently got a ThinkPad X1 Extreme 2nd Generation for fixing some issues on, and noticed that out of the box the backlight doesn't work. Along the way of fixing that, I found a few issues with how i915 handles DPCD AUX backlight control and fixed them. Now I've got working backlight controls, hooray!
Note that this patch series also enables DPCD aux backlight control by default based on what the VBT tells us.
Lyude Paul (5):
drm/i915: Fix eDP DPCD aux max backlight calculations drm/i915: Assume 100% brightness when not in DPCD control mode drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() drm/i915: Auto detect DPCD backlight support by default drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED
panel
drivers/gpu/drm/drm_dp_helper.c | 4 + .../drm/i915/display/intel_display_types.h | 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 167 ++++++++++++------ drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- include/drm/drm_dp_helper.h | 8 + 6 files changed, 134 insertions(+), 52 deletions(-)
Signature · 1 line
2.21.0
PATCH 1/5 drm/i915: Fix eDP DPCD aux max backlight calculations
Max backlight value for the panel was being calculated using byte count i.e. 0xffff if 2 bytes are supported for backlight brightness and 0xff if 1 byte is supported. However, EDP_PWMGEN_BIT_COUNT determines the number of active control bits used for the brightness setting. Thus, even if the panel uses 2 byte setting, it might not use all the control bits. Thus, max backlight should be set based on the value of EDP_PWMGEN_BIT_COUNT instead of assuming 65535 or 255.
Additionally, EDP_PWMGEN_BIT_COUNT was being updated based on the VBT frequency which results in a different max backlight value. Thus, setting of EDP_PWMGEN_BIT_COUNT is moved to setup phase instead of enable so that max backlight can be calculated correctly. Only the frequency divider is set during the enable phase using the value of EDP_PWMGEN_BIT_COUNT.
This is based off the original patch series from Furquan Shaikh <[email protected]>:
https://patchwork.freedesktop.org/patch/317255/?series=62326&rev=3
Changes since original patch:
* Remove unused intel_dp variable in intel_dp_aux_setup_backlight()
* Fix checkpatch issues
* Make sure that we rewrite the pwmgen bit count whenever we bring the panel out of D3 mode
--- .../drm/i915/display/intel_display_types.h | 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 139 ++++++++++++------ 2 files changed, 95 insertions(+), 47 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -214,6 +214,9 @@ struct intel_panel {u8 controller;/* bxt+ only */ struct pwm_device *pwm; +/* DPCD backlight */ +u8 pwmgen_bit_count; +struct backlight_device *device;/* Connector and platform specific backlight functions */
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +92 -47
185 lines not on this page · raw message
Signature · 6 lines
2.21.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [1/5] drm/i915: Fix eDP DPCD aux max backlight calculations
Quoted 516 lines · Lyude Paul
Max backlight value for the panel was being calculated using byte count i.e.
0xffffif 2 bytes are supported for backlight brightness and0xffif 1 byte is supported. However,EDP_PWMGEN_BIT_COUNTdetermines the number of active control bits used for the brightness setting. Thus, even if the panel uses 2 byte setting, it might not use all the control bits. Thus, max backlight should be set based on the value ofEDP_PWMGEN_BIT_COUNTinstead of assuming 65535 or 255.Additionally,
EDP_PWMGEN_BIT_COUNTwas being updated based on the VBT frequency which results in a different max backlight value. Thus, setting ofEDP_PWMGEN_BIT_COUNTis moved to setup phase instead of enable so that max backlight can be calculated correctly. Only the frequency divider is set during the enable phase using the value ofEDP_PWMGEN_BIT_COUNT.This is based off the original patch series from Furquan Shaikh <[email protected]>:
https://patchwork.freedesktop.org/patch/317255/?series=62326&rev=3
Changes since original patch:
* Remove unusedintel_dpvariable inintel_dp_aux_setup_backlight()
* Fix checkpatch issues
* Make sure that we rewrite the pwmgen bit count whenever we bring the panel out of D3 modeCc Furquan Shaikh <[email protected]>Signed-off-by Lyude Paul <[email protected]>--- .../drm/i915/display/intel_display_types.h | 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 139 ++++++++++++------ 2 files changed, 95 insertions(+), 47 deletions(-)drivers/gpu/drm/i915/display/intel_display_types.h +3
-0@@ -214,6 +214,9 @@ struct intel_panel {u8 controller;/* bxt+ only */ struct pwm_device *pwm; +/* DPCD backlight */ +u8 pwmgen_bit_count; +struct backlight_device *device;/* Connector and platform specific backlight functions */ drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +92
-47@@ -111,61 +111,28 @@ static bool intel_dp_aux_set_pwm_freq(struct intel_connector *connector) {struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base); -int freq, fxp, fxp_min, fxp_max, fxp_actual, f =1 ; -u8 pn, pn_min, pn_max; +const u8 pn = connector->panel.backlight.pwmgen_bit_count; +int freq, fxp, f, fxp_actual, fxp_min, fxp_max; -/* Find desired value of (F x P) -* Note that, if F x P is out of supported range, the maximum value or -* minimum value will applied automatically. So no need to check that. -*/ freq = dev_priv->vbt.backlight.pwm_freq_hz; -DRM_DEBUG_KMS ("VBT defined backlight frequency %u Hz\n" , freq);if (!freq) {DRM_DEBUG_KMS ("Use panel default backlight frequency\n" );return false; } fxp =DIV_ROUND_CLOSEST (KHz (DP_EDP_BACKLIGHT_FREQ_BASE_KHZ ), freq); + f =clamp (DIV_ROUND_CLOSEST (fxp,1 << pn),1 ,255 ); + fxp_actual = f << pn; -/* Use highest possible value of Pn for more granularity of brightness -* adjustment while satifying the conditions below. -* - Pn is in the range of Pn_min and Pn_max -* - F is in the range of 1 and 255 -* - FxP is within 25% of desired value. -* Note: 25% is arbitrary value and may need some tweak. -*/ -if (drm_dp_dpcd_readb (&intel_dp->aux, -DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN , &pn_min) !=1 ) { -DRM_DEBUG_KMS ("Failed to read pwmgen bit count cap min\n" ); -return false; - } -if (drm_dp_dpcd_readb (&intel_dp->aux, -DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX , &pn_max) !=1 ) { -DRM_DEBUG_KMS ("Failed to read pwmgen bit count cap max\n" ); -return false; - } - pn_min &=DP_EDP_PWMGEN_BIT_COUNT_MASK ; - pn_max &=DP_EDP_PWMGEN_BIT_COUNT_MASK ; - +/* Ensure frequency is within 25% of desired value */ fxp_min =DIV_ROUND_CLOSEST (fxp *3 ,4 ); fxp_max =DIV_ROUND_CLOSEST (fxp *5 ,4 ); -if (fxp_min < (1 << pn_min) || (255 << pn_max) < fxp_max) { -DRM_DEBUG_KMS ("VBT defined backlight frequency out of range\n" ); -return false; - } - -for (pn = pn_max; pn >= pn_min; pn--) { - f =clamp (DIV_ROUND_CLOSEST (fxp,1 << pn),1 ,255 ); - fxp_actual = f << pn; -if (fxp_min <= fxp_actual && fxp_actual <= fxp_max) -break ; - } -if (drm_dp_dpcd_writeb (&intel_dp->aux, -DP_EDP_PWMGEN_BIT_COUNT , pn) <0 ) { -DRM_DEBUG_KMS ("Failed to write aux pwmgen bit count\n" ); +if (fxp_min > fxp_actual || fxp_actual > fxp_max) { +DRM_DEBUG_KMS ("Actual frequency out of range\n" );return false; } +if (drm_dp_dpcd_writeb (&intel_dp->aux,DP_EDP_BACKLIGHT_FREQ_SET , (u8 ) f) <0 ) {DRM_DEBUG_KMS ("Failed to write aux backlight freq\n" );@@ -178,6 +145,7 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st const struct drm_connector_state *conn_state) {struct intel_connector *connector =to_intel_connector (conn_state->connector); +struct intel_panel *panel = &connector->panel;struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base);u8 dpcd_buf, new_dpcd_buf, edp_backlight_mode;@@ -197,6 +165,12 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_stcase DP_EDP_BACKLIGHT_CONTROL_MODE_PRODUCT : new_dpcd_buf &= ~DP_EDP_BACKLIGHT_CONTROL_MODE_MASK ; new_dpcd_buf |=DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD ; + +if (drm_dp_dpcd_writeb (&intel_dp->aux, +DP_EDP_PWMGEN_BIT_COUNT , + panel->backlight.pwmgen_bit_count) <0 ) +DRM_DEBUG_KMS ("Failed to write aux pwmgen bit count\n" ); +break ;/* Do nothing when it is already DPCD mode */ @@ -225,20 +199,91 @@ static void intel_dp_aux_disable_backlight(const struct drm_connector_state *oldset_aux_backlight_enable (enc_to_intel_dp (old_conn_state->best_encoder), false); } +static u32 intel_dp_aux_calc_max_backlight (struct intel_connector *connector) +{ +struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); +struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base); +struct intel_panel *panel = &connector->panel; +u32 max_backlight =0 ; +int freq, fxp, fxp_min, fxp_max, fxp_actual, f =1 ; +u8 pn, pn_min, pn_max; + +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_EDP_PWMGEN_BIT_COUNT , &pn)) { + pn &=DP_EDP_PWMGEN_BIT_COUNT_MASK ; + max_backlight = (1 << pn) -1 ; + } + +/* Find desired value of (F x P) +* Note that, if F x P is out of supported range, the maximum value or +* minimum value will applied automatically. So no need to check that. +*/ + freq = dev_priv->vbt.backlight.pwm_freq_hz; +DRM_DEBUG_KMS ("VBT defined backlight frequency %u Hz\n" , freq); +if (!freq) { +DRM_DEBUG_KMS ("Use panel default backlight frequency\n" ); +return max_backlight; + } + + fxp =DIV_ROUND_CLOSEST (KHz (DP_EDP_BACKLIGHT_FREQ_BASE_KHZ ), freq); + +/* Use highest possible value of Pn for more granularity of brightness +* adjustment while satifying the conditions below. +* - Pn is in the range of Pn_min and Pn_max +* - F is in the range of 1 and 255 +* - FxP is within 25% of desired value. +* Note: 25% is arbitrary value and may need some tweak. +*/ +if (drm_dp_dpcd_readb (&intel_dp->aux, +DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN , &pn_min) !=1 ) { +DRM_DEBUG_KMS ("Failed to read pwmgen bit count cap min\n" ); +return max_backlight; + } +if (drm_dp_dpcd_readb (&intel_dp->aux, +DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX , &pn_max) !=1 ) { +DRM_DEBUG_KMS ("Failed to read pwmgen bit count cap max\n" ); +return max_backlight; + } + pn_min &=DP_EDP_PWMGEN_BIT_COUNT_MASK ; + pn_max &=DP_EDP_PWMGEN_BIT_COUNT_MASK ; + + fxp_min =DIV_ROUND_CLOSEST (fxp *3 ,4 ); + fxp_max =DIV_ROUND_CLOSEST (fxp *5 ,4 ); +if (fxp_min < (1 << pn_min) || (255 << pn_max) < fxp_max) { +DRM_DEBUG_KMS ("VBT defined backlight frequency out of range\n" ); +return max_backlight; + } + +for (pn = pn_max; pn >= pn_min; pn--) { + f =clamp (DIV_ROUND_CLOSEST (fxp,1 << pn),1 ,255 ); + fxp_actual = f << pn; +if (fxp_min <= fxp_actual && fxp_actual <= fxp_max) +break ; + } + +DRM_DEBUG_KMS ("Using eDP pwmgen bit count of %d\n" , pn); +if (drm_dp_dpcd_writeb (&intel_dp->aux, +DP_EDP_PWMGEN_BIT_COUNT , pn) <0 ) { +DRM_DEBUG_KMS ("Failed to write aux pwmgen bit count\n" ); +return max_backlight; + } + panel->backlight.pwmgen_bit_count = pn; + + max_backlight = (1 << pn) -1 ; + +return max_backlight; +} +static int intel_dp_aux_setup_backlight (struct intel_connector *connector,enum pipe pipe) { -struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base);struct intel_panel *panel = &connector->panel; -if (intel_dp->edp_dpcd[2 ] &DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT ) - panel->backlight.max =0xFFFF ; -else - panel->backlight.max =0xFF ; + panel->backlight.max =intel_dp_aux_calc_max_backlight (connector); +if (!panel->backlight.max) +return -ENODEV ; panel->backlight.min =0 ; panel->backlight.level =intel_dp_aux_get_backlight (connector); - panel->backlight.enabled = panel->backlight.level !=0 ;return 0 ;From patchwork Tue Dec 3 22:42:35 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [v2] drm/i915: Assume 100% brightness when not in DPCD control mode
From: Lyude Paul <[email protected]>
X-Patchwork-Id: 343592
Message-Id: <[email protected]>
To: [email protected]
Cc: David Airlie <[email protected]>, [email protected],
[email protected]
Date: Tue, 3 Dec 2019 17:42:35 -0500Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed in the first place.
This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd Generation, where the default value in these registers is always 0 on boot despite the fact the panel runs at max brightness by default. Getting the initial brightness value correct here is important as well, since the panel on this laptop doesn't behave well if it's ever put into DPCD control mode while the brightness level is programmed to 0.
So, let's fix this by checking what the current backlight control mode is before reading the brightness level. If it's in DPCD control mode, we return the programmed brightness level. Otherwise we assume 100% brightness and return the highest possible brightness level. This also prevents us from accidentally programming a brightness level of 0.
This is one of the many fixes that gets backlight controls working on the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen.
Changes since v1:
* s/DP_EDP_DISPLAY_CONTROL_REGISTER/DP_EDP_BACKLIGHT_MODE_SET_REGISTER/
- JaniSigned-off-by Lyude Paul <[email protected]>--- .../drm/i915/display/intel_dp_aux_backlight.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +17
-0@@ -59,8 +59,25 @@ static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) {struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base);u8 read_val[2 ] = {0x0 }; +u8 mode_reg;u16 level =0 ; +if (drm_dp_dpcd_readb (&intel_dp->aux, +DP_EDP_BACKLIGHT_MODE_SET_REGISTER , + &mode_reg) !=1 ) { +DRM_DEBUG_KMS ("Failed to read the DPCD register 0x%x\n" , +DP_EDP_BACKLIGHT_MODE_SET_REGISTER ); +return 0 ; + } + +/* +* If we're not in DPCD control mode yet, the programmed brightness +* value is meaningless and we should assume max brightness +*/ +if ((mode_reg &DP_EDP_BACKLIGHT_CONTROL_MODE_MASK ) != +DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD ) +return connector->panel.backlight.max; +if (drm_dp_dpcd_read (&intel_dp->aux,DP_EDP_BACKLIGHT_BRIGHTNESS_MSB , &read_val,sizeof (read_val)) <0 ) { DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",From patchwork Fri Nov 22 23:16:01 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [3/5] drm/i915: Fix DPCD register order inintel_dp_aux_enable_backlight()
From: Lyude Paul <[email protected]>
X-Patchwork-Id: 342164
Message-Id: <[email protected]>
To: [email protected]
Cc: David Airlie <[email protected]>, [email protected],
[email protected]
Date: Fri, 22 Nov 2019 18:16:01 -0500For eDP panels, it appears it's expected that so long as the panel is in DPCD control mode that the brightness value is never set to 0. Instead, if the desired effect is to set the panel's backlight to 0 we're expected to simply turn off the backlight through the
DP_EDP_DISPLAY_CONTROL_REGISTER.We already do the latter correctly in
intel_dp_aux_disable_backlight(). But, we make the mistake of writing the DPCD registers in the wrong order when enabling the backlight inintel_dp_aux_enable_backlight()since we currently enable the backlight throughDP_EDP_DISPLAY_CONTROL_REGISTERbefore writing the brightness level. On the X1 Extreme 2nd Generation, this appears to have the potential of confusing the panel in such a way that further attempts to set the brightness don't actually change the backlight as expected and leave it off. Presumably, this happens because the incorrect register writing order briefly leaves the panel with DPCD mode enabled and a 0 brightness level set.So, reverse the order we write the DPCD registers when enabling the panel backlight so that we write the brightness value first, and enable the backlight second. This fix appears to be the final bit needed to get the backlight on the ThinkPad X1 Extreme 2nd Generation's AMOLED screen working.
Signed-off-by Lyude Paul <[email protected]>Reviewed-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +2
-1@@ -205,8 +205,9 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st } } +intel_dp_aux_set_backlight (conn_state, + connector->panel.backlight.level);set_aux_backlight_enable (intel_dp, true); -intel_dp_aux_set_backlight (conn_state, connector->panel.backlight.level); }static void intel_dp_aux_disable_backlight (const struct drm_connector_state *old_conn_state)From patchwork Fri Nov 22 23:16:02 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [4/5] drm/i915: Auto detect DPCD backlight support by default
From: Lyude Paul <[email protected]>
X-Patchwork-Id: 342165
Message-Id: <[email protected]>
To: [email protected]
Cc: David Airlie <[email protected]>, [email protected],
[email protected]
Date: Fri, 22 Nov 2019 18:16:02 -0500Turns out we actually already have some companies, such as Lenovo, shipping machines with AMOLED screens that don't allow controlling the backlight through the usual PWM interface and only allow controlling it through the standard EDP DPCD interface. One example of one of these laptops is the X1 Extreme 2nd Generation.
Since we've got systems that need this turned on by default now to have backlight controls working out of the box, let's start auto-detecting it for systems by default based on what the VBT tells us. We do this by changing the default value for the
enable_dpcd_backlightmodule param from 0 to -1.Signed-off-by Lyude Paul <[email protected]>Reviewed-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_params.c +1
-1@@ -172,7 +172,7 @@ i915_param_named_unsafe(inject_probe_failure, uint, 0400,i915_param_named (enable_dpcd_backlight, int,0600 ,"Enable support for DPCD backlight control" -"(-1=use per-VBT LFP backlight type setting, 0=disabled [default], 1=enabled)" ); +"(-1=use per-VBT LFP backlight type setting [default], 0=disabled, 1=enabled)" );#if IS_ENABLED (CONFIG_DRM_I915_GVT ) i915_param_named(enable_gvt, bool, 0400,drivers/gpu/drm/i915/i915_params.h +1
-1@@ -64,7 +64,7 @@ struct drm_printer; param(int, reset, 3) \ param(unsigned int, inject_probe_failure, 0) \ param(int, fastboot, -1) \ - param(int, enable_dpcd_backlight, 0) \ + param(int, enable_dpcd_backlight, -1) \ param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \ param(unsigned long, fake_lmem_start, 0) \/* leave bools at the end to not create holes */ \From patchwork Fri Nov 22 23:16:03 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel
From: Lyude Paul <[email protected]>
X-Patchwork-Id: 342166
Message-Id: <[email protected]>
To: [email protected]
Cc: David Airlie <[email protected]>, [email protected],
[email protected], Maxime Ripard <[email protected]>
Date: Fri, 22 Nov 2019 18:16:03 -0500Annoyingly, the VBT on the ThinkPad X1 Extreme 2nd Gen indicates that the system uses plain PWM based backlight controls, when in reality the only backlight controls that work are the standard VESA eDP DPCD backlight controls.
Honestly, this makes me wonder how many other systems have these issues or lie about this in their VBT. Not sure we have any good way of finding out until panels like this become more common place in the laptop market. For now, just add a DRM DP quirk to indicate that this panel is telling the truth and is being a good LCD.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376
Signed-off-by Lyude Paul <[email protected]>Acked-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_dp_helper.c | 4 ++++ drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++++-- include/drm/drm_dp_helper.h | 8 ++++++++ 3 files changed, 20 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_dp_helper.c +4
-0@@ -1155,6 +1155,10 @@ static const struct dpcd_quirk dpcd_quirk_list[] = { { OUI(0x00, 0x10, 0xfa), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PSR) },/* CH7511 seems to leave SINK_COUNT zeroed */ { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) }, +/* Optional 4K AMOLED panel in the ThinkPad X1 Extreme 2nd Generation +* only supports DPCD backlight controls, despite advertising otherwise +*/ + { OUI(0xba, 0x41, 0x59), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT) }, };#undef OUIdrivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +8
-2@@ -325,11 +325,17 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)int intel_dp_aux_init_backlight_funcs (struct intel_connector *intel_connector) {struct intel_panel *panel = &intel_connector->panel; -struct drm_i915_private *dev_priv =to_i915 (intel_connector->base.dev); +struct intel_dp *intel_dp = +enc_to_intel_dp (&intel_connector->encoder->base); +struct drm_i915_private *dev_priv = +to_i915 (intel_connector->base.dev);if (i915_modparams.enable_dpcd_backlight ==0 || (i915_modparams.enable_dpcd_backlight ==-1 && - dev_priv->vbt.backlight.type !=INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE )) + dev_priv->vbt.backlight.type != +INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE && + !drm_dp_has_quirk (&intel_dp->desc, +DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT )))return -ENODEV ;if (!intel_dp_aux_display_control_capable (intel_connector))include/drm/drm_dp_helper.h +1
-0@@ -1520,6 +1520,14 @@ enum drm_dp_quirk {* The driver should ignore SINK_COUNT during detection. */ DP_DPCD_QUIRK_NO_SINK_COUNT, +/**
include/drm/drm_dp_helper.h enum drm_dp_quirk { · line 1533
Quoted 10 lines
include/drm/drm_dp_helper.h +7
-0+* @DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT: +* +* The device is telling the truth when it says that it uses DPCD +* backlight controls, even if the system's firmware disagrees. +* The driver should honor the DPCD backlight capabilities advertised. +*/ + DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT, };/**
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/5 drm/i915: Assume 100% brightness when not in DPCD control mode
In reply to Lyude PaulCurrently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed in the first place.
This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd Generation, where the default value in these registers is always 0 on boot despite the fact the panel runs at max brightness by default. Getting the initial brightness value correct here is important as well, since the panel on this laptop doesn't behave well if it's ever put into DPCD control mode while the brightness level is programmed to 0.
So, let's fix this by checking what the current backlight control mode is before reading the brightness level. If it's in DPCD control mode, we return the programmed brightness level. Otherwise we assume 100% brightness and return the highest possible brightness level. This also prevents us from accidentally programming a brightness level of 0.
This is one of the many fixes that gets backlight controls working on the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen.
--- .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +15 -0
@@ -59,8 +59,23 @@ static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) {struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base);u8 read_val[2 ] = {0x0 }; +u8 control_reg;u16 level =0 ; +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_EDP_DISPLAY_CONTROL_REGISTER , + &control_reg) !=1 ) { +DRM_DEBUG_KMS ("Failed to read the DPCD register 0x%x\n" , +DP_EDP_DISPLAY_CONTROL_REGISTER ); +return 0 ; + } + +/* +* If we're not in DPCD control mode yet, the programmed brightness +* value is meaningless and we should assume max brightness +*/ +if (!(control_reg &DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD )) +return connector->panel.backlight.max; +if (drm_dp_dpcd_read (&intel_dp->aux,DP_EDP_BACKLIGHT_BRIGHTNESS_MSB , &read_val,sizeof (read_val)) <0 ) { DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: [PATCH 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode
Quoted 32 lines · Lyude Paul
Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed in the first place.
This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd Generation, where the default value in these registers is always 0 on boot despite the fact the panel runs at max brightness by default. Getting the initial brightness value correct here is important as well, since the panel on this laptop doesn't behave well if it's ever put into DPCD control mode while the brightness level is programmed to 0.
So, let's fix this by checking what the current backlight control mode is before reading the brightness level. If it's in DPCD control mode, we return the programmed brightness level. Otherwise we assume 100% brightness and return the highest possible brightness level. This also prevents us from accidentally programming a brightness level of 0.
This is one of the many fixes that gets backlight controls working on the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen.
Signed-off-by Lyude Paul <[email protected]>--- .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +0
-0
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) · line 65
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +2
-0@@ -59,8 +59,23 @@ static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) {struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base);u8 read_val[2 ] = {0x0 }; +u8 control_reg;u16 level =0 ; + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER,
Shouldn't that be DP_EDP_BACKLIGHT_MODE_SET_REGISTER instead?
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) · line 77
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +12
-0+ &control_reg) != 1) { +DRM_DEBUG_KMS ("Failed to read the DPCD register 0x%x\n" , +DP_EDP_DISPLAY_CONTROL_REGISTER ); +return 0 ; + } + +/* +* If we're not in DPCD control mode yet, the programmed brightness +* value is meaningless and we should assume max brightness +*/ +if (!(control_reg &DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD )) +return connector->panel.backlight.max;
It's not just a bit, I think you need to check (control_reg & mask) == value.
BR,
Jani.
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +1
-0+if (drm_dp_dpcd_read (&intel_dp->aux,DP_EDP_BACKLIGHT_BRIGHTNESS_MSB , &read_val,sizeof (read_val)) <0 ) { DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/1 drm/i915: Assume 100% brightness when not in DPCD control mode
Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed in the first place.
This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd Generation, where the default value in these registers is always 0 on boot despite the fact the panel runs at max brightness by default. Getting the initial brightness value correct here is important as well, since the panel on this laptop doesn't behave well if it's ever put into DPCD control mode while the brightness level is programmed to 0.
So, let's fix this by checking what the current backlight control mode is before reading the brightness level. If it's in DPCD control mode, we return the programmed brightness level. Otherwise we assume 100% brightness and return the highest possible brightness level. This also prevents us from accidentally programming a brightness level of 0.
This is one of the many fixes that gets backlight controls working on the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen.
Changes since v1:
* s/DP_EDP_DISPLAY_CONTROL_REGISTER/DP_EDP_BACKLIGHT_MODE_SET_REGISTER/
- Jani
--- .../drm/i915/display/intel_dp_aux_backlight.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +17 -0
@@ -59,8 +59,25 @@ static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) {struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base);u8 read_val[2 ] = {0x0 }; +u8 mode_reg;u16 level =0 ; +if (drm_dp_dpcd_readb (&intel_dp->aux, +DP_EDP_BACKLIGHT_MODE_SET_REGISTER , + &mode_reg) !=1 ) { +DRM_DEBUG_KMS ("Failed to read the DPCD register 0x%x\n" , +DP_EDP_BACKLIGHT_MODE_SET_REGISTER ); +return 0 ; + } + +/* +* If we're not in DPCD control mode yet, the programmed brightness +* value is meaningless and we should assume max brightness +*/ +if ((mode_reg &DP_EDP_BACKLIGHT_CONTROL_MODE_MASK ) != +DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD ) +return connector->panel.backlight.max; +if (drm_dp_dpcd_read (&intel_dp->aux,DP_EDP_BACKLIGHT_BRIGHTNESS_MSB , &read_val,sizeof (read_val)) <0 ) { DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
Signature · 6 lines
2.23.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [v2] drm/i915: Assume 100% brightness when not in DPCD control mode
Quoted 52 lines · Lyude Paul
Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed in the first place.
This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd Generation, where the default value in these registers is always 0 on boot despite the fact the panel runs at max brightness by default. Getting the initial brightness value correct here is important as well, since the panel on this laptop doesn't behave well if it's ever put into DPCD control mode while the brightness level is programmed to 0.
So, let's fix this by checking what the current backlight control mode is before reading the brightness level. If it's in DPCD control mode, we return the programmed brightness level. Otherwise we assume 100% brightness and return the highest possible brightness level. This also prevents us from accidentally programming a brightness level of 0.
This is one of the many fixes that gets backlight controls working on the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen.
Changes since v1:
* s/DP_EDP_DISPLAY_CONTROL_REGISTER/DP_EDP_BACKLIGHT_MODE_SET_REGISTER/
- JaniSigned-off-by Lyude Paul <[email protected]>--- .../drm/i915/display/intel_dp_aux_backlight.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +10
-0@@ -59,8 +59,25 @@ static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) {struct intel_dp *intel_dp =enc_to_intel_dp (&connector->encoder->base);u8 read_val[2 ] = {0x0 }; +u8 mode_reg;u16 level =0 ; +if (drm_dp_dpcd_readb (&intel_dp->aux, +DP_EDP_BACKLIGHT_MODE_SET_REGISTER , + &mode_reg) !=1 ) { +DRM_DEBUG_KMS ("Failed to read the DPCD register 0x%x\n" , +DP_EDP_BACKLIGHT_MODE_SET_REGISTER ); +return 0 ; + } + +/*
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) · line 83
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +7
-0+* If we're not in DPCD control mode yet, the programmed brightness +* value is meaningless and we should assume max brightness +*/ +if ((mode_reg &DP_EDP_BACKLIGHT_CONTROL_MODE_MASK ) != +DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD ) +return connector->panel.backlight.max; +if (drm_dp_dpcd_read (&intel_dp->aux,DP_EDP_BACKLIGHT_BRIGHTNESS_MSB , &read_val,sizeof (read_val)) <0 ) { DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
PATCH 3/5 drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight()
In reply to Lyude PaulFor eDP panels, it appears it's expected that so long as the panel is in DPCD control mode that the brightness value is never set to 0. Instead, if the desired effect is to set the panel's backlight to 0 we're expected to simply turn off the backlight through the DP_EDP_DISPLAY_CONTROL_REGISTER.
We already do the latter correctly in intel_dp_aux_disable_backlight(). But, we make the mistake of writing the DPCD registers in the wrong order when enabling the backlight in intel_dp_aux_enable_backlight() since we currently enable the backlight through DP_EDP_DISPLAY_CONTROL_REGISTER before writing the brightness level. On the X1 Extreme 2nd Generation, this appears to have the potential of confusing the panel in such a way that further attempts to set the brightness don't actually change the backlight as expected and leave it off. Presumably, this happens because the incorrect register writing order briefly leaves the panel with DPCD mode enabled and a 0 brightness level set.
So, reverse the order we write the DPCD registers when enabling the panel backlight so that we write the brightness value first, and enable the backlight second. This fix appears to be the final bit needed to get the backlight on the ThinkPad X1 Extreme 2nd Generation's AMOLED screen working.
--- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +2 -1
@@ -205,8 +205,9 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st } } +intel_dp_aux_set_backlight (conn_state, + connector->panel.backlight.level);set_aux_backlight_enable (intel_dp, true); -intel_dp_aux_set_backlight (conn_state, connector->panel.backlight.level); }static void intel_dp_aux_disable_backlight (const struct drm_connector_state *old_conn_state)
Signature · 1 line
2.21.0
Re: [PATCH 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight()
Quoted 18 lines · Lyude Paul
For eDP panels, it appears it's expected that so long as the panel is in DPCD control mode that the brightness value is never set to 0. Instead, if the desired effect is to set the panel's backlight to 0 we're expected to simply turn off the backlight through the
DP_EDP_DISPLAY_CONTROL_REGISTER.We already do the latter correctly in
intel_dp_aux_disable_backlight(). But, we make the mistake of writing the DPCD registers in the wrong order when enabling the backlight inintel_dp_aux_enable_backlight()since we currently enable the backlight throughDP_EDP_DISPLAY_CONTROL_REGISTERbefore writing the brightness level. On the X1 Extreme 2nd Generation, this appears to have the potential of confusing the panel in such a way that further attempts to set the brightness don't actually change the backlight as expected and leave it off. Presumably, this happens because the incorrect register writing order briefly leaves the panel with DPCD mode enabled and a 0 brightness level set.
Quoted 7 lines
So, reverse the order we write the DPCD registers when enabling the panel backlight so that we write the brightness value first, and enable the backlight second. This fix appears to be the final bit needed to get the backlight on the ThinkPad X1 Extreme 2nd Generation's AMOLED screen working.
Signed-off-by Lyude Paul <[email protected]>
Quoted 19 lines
--- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +2
-1@@ -205,8 +205,9 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st } } +intel_dp_aux_set_backlight (conn_state, + connector->panel.backlight.level);set_aux_backlight_enable (intel_dp, true); -intel_dp_aux_set_backlight (conn_state, connector->panel.backlight.level); }static void intel_dp_aux_disable_backlight (const struct drm_connector_state *old_conn_state)
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight()
In reply to Lyude PaulQuoted 36 lines · Lyude Paul
For eDP panels, it appears it's expected that so long as the panel is in DPCD control mode that the brightness value is never set to 0. Instead, if the desired effect is to set the panel's backlight to 0 we're expected to simply turn off the backlight through the
DP_EDP_DISPLAY_CONTROL_REGISTER.We already do the latter correctly in
intel_dp_aux_disable_backlight(). But, we make the mistake of writing the DPCD registers in the wrong order when enabling the backlight inintel_dp_aux_enable_backlight()since we currently enable the backlight throughDP_EDP_DISPLAY_CONTROL_REGISTERbefore writing the brightness level. On the X1 Extreme 2nd Generation, this appears to have the potential of confusing the panel in such a way that further attempts to set the brightness don't actually change the backlight as expected and leave it off. Presumably, this happens because the incorrect register writing order briefly leaves the panel with DPCD mode enabled and a 0 brightness level set.So, reverse the order we write the DPCD registers when enabling the panel backlight so that we write the brightness value first, and enable the backlight second. This fix appears to be the final bit needed to get the backlight on the ThinkPad X1 Extreme 2nd Generation's AMOLED screen working.
Signed-off-by Lyude Paul <[email protected]>Reviewed-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +0
-0
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st · line 213
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +2
-1@@ -205,8 +205,9 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st } } +intel_dp_aux_set_backlight (conn_state, + connector->panel.backlight.level);set_aux_backlight_enable (intel_dp, true); -intel_dp_aux_set_backlight (conn_state, connector->panel.backlight.level); }static void intel_dp_aux_disable_backlight (const struct drm_connector_state *old_conn_state)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/5 drm/i915: Auto detect DPCD backlight support by default
In reply to Lyude PaulTurns out we actually already have some companies, such as Lenovo, shipping machines with AMOLED screens that don't allow controlling the backlight through the usual PWM interface and only allow controlling it through the standard EDP DPCD interface. One example of one of these laptops is the X1 Extreme 2nd Generation.
Since we've got systems that need this turned on by default now to have backlight controls working out of the box, let's start auto-detecting it for systems by default based on what the VBT tells us. We do this by changing the default value for the enable_dpcd_backlight module param from 0 to -1.
--- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_params.c +1 -1
@@ -172,7 +172,7 @@ i915_param_named_unsafe(inject_probe_failure, uint, 0400,i915_param_named (enable_dpcd_backlight, int,0600 ,"Enable support for DPCD backlight control" -"(-1=use per-VBT LFP backlight type setting, 0=disabled [default], 1=enabled)" ); +"(-1=use per-VBT LFP backlight type setting [default], 0=disabled, 1=enabled)" );#if IS_ENABLED (CONFIG_DRM_I915_GVT ) i915_param_named(enable_gvt, bool, 0400,
drivers/gpu/drm/i915/i915_params.h +1 -1
@@ -64,7 +64,7 @@ struct drm_printer; param(int, reset, 3) \ param(unsigned int, inject_probe_failure, 0) \ param(int, fastboot, -1) \ - param(int, enable_dpcd_backlight, 0) \ + param(int, enable_dpcd_backlight, -1) \ param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \ param(unsigned long, fake_lmem_start, 0) \/* leave bools at the end to not create holes */ \
Signature · 6 lines
2.21.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/5] drm/i915: Auto detect DPCD backlight support by default
Quoted 6 lines · Lyude Paul
Turns out we actually already have some companies, such as Lenovo, shipping machines with AMOLED screens that don't allow controlling the backlight through the usual PWM interface and only allow controlling it through the standard EDP DPCD interface. One example of one of these laptops is the X1 Extreme 2nd Generation.
Quoted 7 lines
Since we've got systems that need this turned on by default now to have backlight controls working out of the box, let's start auto-detecting it for systems by default based on what the VBT tells us. We do this by changing the default value for the
enable_dpcd_backlightmodule param from 0 to -1.Signed-off-by Lyude Paul <[email protected]>
Quoted 31 lines
--- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_params.c +1
-1@@ -172,7 +172,7 @@ i915_param_named_unsafe(inject_probe_failure, uint, 0400,i915_param_named (enable_dpcd_backlight, int,0600 ,"Enable support for DPCD backlight control" -"(-1=use per-VBT LFP backlight type setting, 0=disabled [default], 1=enabled)" ); +"(-1=use per-VBT LFP backlight type setting [default], 0=disabled, 1=enabled)" );#if IS_ENABLED (CONFIG_DRM_I915_GVT ) i915_param_named(enable_gvt, bool, 0400,drivers/gpu/drm/i915/i915_params.h +1
-1@@ -64,7 +64,7 @@ struct drm_printer; param(int, reset, 3) \ param(unsigned int, inject_probe_failure, 0) \ param(int, fastboot, -1) \ - param(int, enable_dpcd_backlight, 0) \ + param(int, enable_dpcd_backlight, -1) \ param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \ param(unsigned long, fake_lmem_start, 0) \/* leave bools at the end to not create holes */ \
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [4/5] drm/i915: Auto detect DPCD backlight support by default
In reply to Lyude PaulQuoted 38 lines · Lyude Paul
Turns out we actually already have some companies, such as Lenovo, shipping machines with AMOLED screens that don't allow controlling the backlight through the usual PWM interface and only allow controlling it through the standard EDP DPCD interface. One example of one of these laptops is the X1 Extreme 2nd Generation.
Since we've got systems that need this turned on by default now to have backlight controls working out of the box, let's start auto-detecting it for systems by default based on what the VBT tells us. We do this by changing the default value for the
enable_dpcd_backlightmodule param from 0 to -1.Signed-off-by Lyude Paul <[email protected]>Reviewed-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_params.c +1
-1@@ -172,7 +172,7 @@ i915_param_named_unsafe(inject_probe_failure, uint, 0400,i915_param_named (enable_dpcd_backlight, int,0600 ,"Enable support for DPCD backlight control" -"(-1=use per-VBT LFP backlight type setting, 0=disabled [default], 1=enabled)" ); +"(-1=use per-VBT LFP backlight type setting [default], 0=disabled, 1=enabled)" );#if IS_ENABLED (CONFIG_DRM_I915_GVT ) i915_param_named(enable_gvt, bool, 0400,drivers/gpu/drm/i915/i915_params.h +0
-0
drivers/gpu/drm/i915/i915_params.h struct drm_printer; · line 70
Quoted 8 lines
drivers/gpu/drm/i915/i915_params.h +1
-1@@ -64,7 +64,7 @@ struct drm_printer; param(int, reset, 3) \ param(unsigned int, inject_probe_failure, 0) \ param(int, fastboot, -1) \ - param(int, enable_dpcd_backlight, 0) \ + param(int, enable_dpcd_backlight, -1) \ param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \ param(unsigned long, fake_lmem_start, 0) \/* leave bools at the end to not create holes */ \
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 5/5 drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel
In reply to Lyude PaulAnnoyingly, the VBT on the ThinkPad X1 Extreme 2nd Gen indicates that the system uses plain PWM based backlight controls, when in reality the only backlight controls that work are the standard VESA eDP DPCD backlight controls.
Honestly, this makes me wonder how many other systems have these issues or lie about this in their VBT. Not sure we have any good way of finding out until panels like this become more common place in the laptop market. For now, just add a DRM DP quirk to indicate that this panel is telling the truth and is being a good LCD.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376
--- drivers/gpu/drm/drm_dp_helper.c | 4 ++++ drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++++-- include/drm/drm_dp_helper.h | 8 ++++++++ 3 files changed, 20 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_dp_helper.c +4 -0
@@ -1155,6 +1155,10 @@ static const struct dpcd_quirk dpcd_quirk_list[] = { { OUI(0x00, 0x10, 0xfa), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PSR) },/* CH7511 seems to leave SINK_COUNT zeroed */ { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) }, +/* Optional 4K AMOLED panel in the ThinkPad X1 Extreme 2nd Generation +* only supports DPCD backlight controls, despite advertising otherwise +*/ + { OUI(0xba, 0x41, 0x59), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT) }, };#undef OUI
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +8 -2
@@ -325,11 +325,17 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)int intel_dp_aux_init_backlight_funcs (struct intel_connector *intel_connector) {struct intel_panel *panel = &intel_connector->panel; -struct drm_i915_private *dev_priv =to_i915 (intel_connector->base.dev); +struct intel_dp *intel_dp = +enc_to_intel_dp (&intel_connector->encoder->base); +struct drm_i915_private *dev_priv = +to_i915 (intel_connector->base.dev);if (i915_modparams.enable_dpcd_backlight ==0 || (i915_modparams.enable_dpcd_backlight ==-1 && - dev_priv->vbt.backlight.type !=INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE )) + dev_priv->vbt.backlight.type != +INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE && + !drm_dp_has_quirk (&intel_dp->desc, +DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT )))return -ENODEV ;if (!intel_dp_aux_display_control_capable (intel_connector))
include/drm/drm_dp_helper.h +8 -0
@@ -1520,6 +1520,14 @@ enum drm_dp_quirk {* The driver should ignore SINK_COUNT during detection. */ DP_DPCD_QUIRK_NO_SINK_COUNT , +/** +* @DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT: +* +* The device is telling the truth when it says that it uses DPCD +* backlight controls, even if the system's firmware disagrees. +* The driver should honor the DPCD backlight capabilities advertised. +*/ + DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT, };/**
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel
Quoted 5 lines · Lyude Paul
Annoyingly, the VBT on the ThinkPad X1 Extreme 2nd Gen indicates that the system uses plain PWM based backlight controls, when in reality the only backlight controls that work are the standard VESA eDP DPCD backlight controls.
Quoted 8 lines
Honestly, this makes me wonder how many other systems have these issues or lie about this in their VBT. Not sure we have any good way of finding out until panels like this become more common place in the laptop market. For now, just add a DRM DP quirk to indicate that this panel is telling the truth and is being a good LCD.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376
Signed-off-by Lyude Paul <[email protected]>
Quoted 64 lines
--- drivers/gpu/drm/drm_dp_helper.c | 4 ++++ drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++++-- include/drm/drm_dp_helper.h | 8 ++++++++ 3 files changed, 20 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_dp_helper.c +4
-0@@ -1155,6 +1155,10 @@ static const struct dpcd_quirk dpcd_quirk_list[] = { { OUI(0x00, 0x10, 0xfa), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PSR) },/* CH7511 seems to leave SINK_COUNT zeroed */ { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) }, +/* Optional 4K AMOLED panel in the ThinkPad X1 Extreme 2nd Generation +* only supports DPCD backlight controls, despite advertising otherwise +*/ + { OUI(0xba, 0x41, 0x59), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT) }, };#undef OUIdrivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +8
-2@@ -325,11 +325,17 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)int intel_dp_aux_init_backlight_funcs (struct intel_connector *intel_connector) {struct intel_panel *panel = &intel_connector->panel; -struct drm_i915_private *dev_priv =to_i915 (intel_connector->base.dev); +struct intel_dp *intel_dp = +enc_to_intel_dp (&intel_connector->encoder->base); +struct drm_i915_private *dev_priv = +to_i915 (intel_connector->base.dev);if (i915_modparams.enable_dpcd_backlight ==0 || (i915_modparams.enable_dpcd_backlight ==-1 && - dev_priv->vbt.backlight.type !=INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE )) + dev_priv->vbt.backlight.type != +INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE && + !drm_dp_has_quirk (&intel_dp->desc, +DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT )))return -ENODEV ;if (!intel_dp_aux_display_control_capable (intel_connector))include/drm/drm_dp_helper.h +8
-0@@ -1520,6 +1520,14 @@ enum drm_dp_quirk {* The driver should ignore SINK_COUNT during detection. */ DP_DPCD_QUIRK_NO_SINK_COUNT , +/** +* @DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT: +* +* The device is telling the truth when it says that it uses DPCD +* backlight controls, even if the system's firmware disagrees. +* The driver should honor the DPCD backlight capabilities advertised. +*/ + DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT, };/**
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: eDP DPCD aux backlight fixes
URL : https://patchwork.freedesktop.org/series/69914/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7409 -> Patchwork_15403
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/index.html
Known issues
------------
Here are the changes found in Patchwork_15403 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([fdo#108511])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-skl-6770hq/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-skl-6770hq/igt@[email protected]
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#111407])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-kbl-7500u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [PASS][7] -> [FAIL][8] ([fdo#103167])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-icl-u3/igt@[email protected]
- fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10] ([fdo#102614])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-hsw-peppy/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-hsw-peppy/igt@[email protected]
- fi-icl-u2: [PASS][11] -> [FAIL][12] ([fdo#103167])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-icl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][13] ([fdo#112261]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-skl-lmem/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-skl-lmem/igt@[email protected]
* igt@kms_addfb_basic@addfb25-y-tiled:
- fi-icl-dsi: [DMESG-WARN][15] ([fdo#106107]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-icl-dsi/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-icl-dsi/igt@[email protected]
#### Warnings ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][17] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][18] ([fdo#103558] / [fdo#105602]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][19] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][20] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +5 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/fi-kbl-x1275/igt@[email protected]
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
Participating hosts (50 -> 44)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7409 -> Patchwork_15403
CI-20190529: 20190529
CI_DRM_7409: a00b5b72443d01a635ab02f55c589aa42ca04bcc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5301: 3fa72891269b16943e6511166aeebee094206791 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15403: 2890f9ef7a6e69bd968e6f874009a9639c7598af @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2890f9ef7a6e drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel 96f4ce1ac903 drm/i915: Auto detect DPCD backlight support by default e92e8537fe75 drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() 815c34f4936a drm/i915: Assume 100% brightness when not in DPCD control mode 0b03faf574f2 drm/i915: Fix eDP DPCD aux max backlight calculations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: eDP DPCD aux backlight fixes
URL : https://patchwork.freedesktop.org/series/69914/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7409_full -> Patchwork_15403_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15403_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb3/igt@[email protected]
* igt@gem_ctx_switch@all-light:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([fdo#111672])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb6/igt@[email protected]
* igt@gem_eio@suspend:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111850])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb8/igt@[email protected]
* igt@gem_exec_basic@basic-vcs1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112080]) +9 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +17 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +10 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@smoketest-all:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111855])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb9/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb6/igt@[email protected]
* igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive:
- shard-iclb: [PASS][15] -> [TIMEOUT][16] ([fdo#112068 ])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb5/igt@[email protected]
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-hsw: [PASS][17] -> [TIMEOUT][18] ([fdo#112068 ])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-hsw7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-hsw1/igt@[email protected]
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#112068 ])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb4/igt@[email protected]
- shard-kbl: [PASS][21] -> [INCOMPLETE][22] ([fdo#103665] / [fdo#112068 ])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-kbl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-kbl1/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [PASS][23] -> [DMESG-WARN][24] ([fdo#111870]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-snb4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-snb7/igt@[email protected]
- shard-hsw: [PASS][25] -> [DMESG-WARN][26] ([fdo#111870])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-hsw4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-hsw4/igt@[email protected]
* igt@gem_workarounds@suspend-resume:
- shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([fdo#111832] / [fdo#111850]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb3/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb7/igt@[email protected]
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [PASS][29] -> [DMESG-FAIL][30] ([fdo#111991])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-hsw1/igt@i915_selftest@live_hangcheck.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-hsw5/igt@i915_selftest@live_hangcheck.html
- shard-snb: [PASS][31] -> [INCOMPLETE][32] ([fdo#105411])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-snb2/igt@i915_selftest@live_hangcheck.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-snb6/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([fdo#108566])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-apl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-apl4/igt@[email protected]
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][35] -> [DMESG-WARN][36] ([fdo#106107])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-skl8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-skl9/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [PASS][37] -> [FAIL][38] ([fdo#106509] / [fdo#107409])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-glk8/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-glk2/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#105363])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-skl8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-skl10/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][41] -> [FAIL][42] ([fdo#103167]) +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
- shard-tglb: [PASS][43] -> [FAIL][44] ([fdo#103167])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb5/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb7/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][45] -> [DMESG-WARN][46] ([fdo#108566]) +7 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-kbl3/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-kbl6/igt@[email protected]
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109441])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_setmode@basic:
- shard-skl: [PASS][49] -> [FAIL][50] ([fdo#99912])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-skl9/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-skl6/igt@[email protected]
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][51] ([fdo#112080]) -> [PASS][52] +17 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb2/igt@[email protected]
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54] +7 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-kbl7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-kbl7/igt@[email protected]
- shard-tglb: [INCOMPLETE][55] ([fdo#111832]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb8/igt@[email protected]
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][57] ([fdo#109276] / [fdo#112080]) -> [PASS][58] +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb3/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb1/igt@[email protected]
* igt@gem_ctx_switch@all-heavy:
- shard-tglb: [INCOMPLETE][59] ([fdo#111998]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb9/igt@[email protected]
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [SKIP][61] ([fdo#109276]) -> [PASS][62] +20 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb1/igt@[email protected]
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][63] ([fdo#112146]) -> [PASS][64] +7 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][65] ([fdo#111870]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-snb2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-snb2/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-apl1/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-apl3/igt@[email protected]
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][69] ([fdo#111795 ]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb3/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb1/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][71] ([fdo#111830 ]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb2/igt@[email protected]
* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-skl: [INCOMPLETE][73] ([fdo#112347]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-skl9/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-skl8/igt@[email protected]
* igt@kms_color@pipe-b-ctm-0-5:
- shard-skl: [DMESG-WARN][75] ([fdo#106107]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-skl8/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-skl4/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][77] ([fdo#105767]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-hsw5/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-hsw4/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [INCOMPLETE][79] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb4/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb9/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [FAIL][81] ([fdo#105363]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-glk5/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-glk5/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][83] ([fdo#103540]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-hsw4/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-hsw4/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate:
- shard-glk: [FAIL][85] ([fdo#100368]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-glk4/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-glk4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglb: [FAIL][87] ([fdo#103167]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb8/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: [FAIL][89] ([fdo#103167]) -> [PASS][90] +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][91] ([fdo#108341]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb1/igt@kms_psr@no_drrs.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb4/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][93] ([fdo#109441]) -> [PASS][94] +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-tglb: [INCOMPLETE][95] ([fdo#111832] / [fdo#111850]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb4/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb2/igt@[email protected]
* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- shard-tglb: [INCOMPLETE][97] ([fdo#111850]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb2/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb3/igt@[email protected]
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][99] ([fdo#111329]) -> [SKIP][100] ([fdo#109276] / [fdo#112080])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-iclb1/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-iclb8/igt@[email protected]
* igt@gem_ctx_isolation@vcs2-dirty-switch:
- shard-tglb: [SKIP][101] ([fdo#112080]) -> [SKIP][102] ([fdo#111912] / [fdo#112080])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb9/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb5/igt@[email protected]
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][103] ([fdo#105411]) -> [DMESG-WARN][104] ([fdo# 112000 ] / [fdo#111781])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-snb1/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-snb4/igt@[email protected]
* igt@gem_exec_schedule@deep-bsd1:
- shard-tglb: [FAIL][105] ([fdo#111646]) -> [INCOMPLETE][106] ([fdo#111671])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb9/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb5/igt@[email protected]
* igt@gem_exec_schedule@deep-bsd2:
- shard-tglb: [INCOMPLETE][107] ([fdo#111671]) -> [FAIL][108] ([fdo#111646]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7409/shard-tglb8/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/shard-tglb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [FAIL][109] ([fdo#103167]) -> [INCOM
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15403/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev2)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: eDP DPCD aux backlight fixes (rev2)
URL : https://patchwork.freedesktop.org/series/69914/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7479 -> Patchwork_15572
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/index.html
Known issues
------------
Here are the changes found in Patchwork_15572 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-4770: [PASS][1] -> [DMESG-FAIL][2] ([fdo#111692])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/fi-hsw-4770/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][3] -> [INCOMPLETE][4] ([i915#694])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][5] ([i915#683]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/fi-hsw-4770r/igt@i915_selftest@live_blt.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][7] ([i915#62] / [i915#92]) -> [DMESG-WARN][8] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/fi-kbl-x1275/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/fi-kbl-x1275/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-icl-u2: [DMESG-WARN][9] ([i915#289]) -> [DMESG-WARN][10] ([i915#109] / [i915#289])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/fi-icl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/fi-icl-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/fi-kbl-x1275/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111692]: https://bugs.freedesktop.org/show_bug.cgi?id=111692
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#683]: https://gitlab.freedesktop.org/drm/intel/issues/683
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 45)
------------------------------
Missing (7): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7479 -> Patchwork_15572
CI-20190529: 20190529
CI_DRM_7479: 973ac65a9fc84bab12ce15d7053bcf3fdb1c3943 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5323: b0f877d06a78b9c38ed246be2537a0453b6c214f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15572: 64e2d00e22135a505ffd97e57c419db424a817b7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
64e2d00e2213 drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel 8a0b2301c6bd drm/i915: Auto detect DPCD backlight support by default 11dd57991f1b drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() 75be7701eeea drm/i915: Assume 100% brightness when not in DPCD control mode da70586e114b drm/i915: Fix eDP DPCD aux max backlight calculations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: eDP DPCD aux backlight fixes (rev2)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: eDP DPCD aux backlight fixes (rev2)
URL : https://patchwork.freedesktop.org/series/69914/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7479_full -> Patchwork_15572_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15572_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_15572_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15572_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- shard-skl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl8/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-skl: NOTRUN -> [TIMEOUT][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl3/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_15572_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [PASS][4] -> [DMESG-WARN][5] ([i915#180])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-apl6/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-apl4/igt@[email protected]
* igt@gem_exec_parallel@vecs0-fds:
- shard-hsw: [PASS][6] -> [FAIL][7] ([i915#676])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-hsw2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-hsw1/igt@[email protected]
* igt@kms_busy@basic-modeset-pipe-b:
- shard-hsw: [PASS][8] -> [INCOMPLETE][9] ([i915#61])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-hsw1/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-hsw2/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][10] -> [INCOMPLETE][11] ([i915#221])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl9/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl9/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([i915#123]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [PASS][14] -> [INCOMPLETE][15] ([i915#69])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl2/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl2/igt@[email protected]
* igt@kms_setmode@basic:
- shard-apl: [PASS][16] -> [FAIL][17] ([i915#31])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-apl4/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-apl7/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_parallel@vcs0-contexts:
- shard-hsw: [TIMEOUT][18] ([i915#676]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-hsw6/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-hsw1/igt@[email protected]
* {igt@gem_exec_parse_blt@bb-start-far}:
- shard-glk: [TIMEOUT][20] ([fdo#112271]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-glk1/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-glk8/igt@[email protected]
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][22] ([i915#644]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-apl2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-apl8/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][24] ([i915#180]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-apl4/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-apl7/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [DMESG-WARN][26] ([fdo#111870]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-snb4/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-snb4/igt@[email protected]
* igt@i915_selftest@live_active:
- shard-apl: [DMESG-FAIL][28] ([i915#666]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-apl4/igt@i915_selftest@live_active.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-apl7/igt@i915_selftest@live_active.html
* igt@kms_color@pipe-a-ctm-0-25:
- shard-skl: [DMESG-WARN][30] ([i915#109]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl1/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
- shard-skl: [INCOMPLETE][32] -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl5/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][34] ([i915#79]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl8/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl5/igt@[email protected]
- shard-glk: [FAIL][36] ([i915#79]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-glk5/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-glk4/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-skl: [TIMEOUT][38] -> [PASS][39] +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl6/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][40] ([fdo#108145]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-skl6/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-skl4/igt@[email protected]
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][42] ([i915#444] / [i915#502]) -> [INCOMPLETE][43] ([i915#82])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-snb6/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-snb2/igt@[email protected]
* igt@gem_exec_parallel@vecs0-contexts:
- shard-hsw: [TIMEOUT][44] ([i915#676]) -> [FAIL][45] ([i915#676])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7479/shard-hsw1/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/shard-hsw5/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444
[i915#502]: https://gitlab.freedesktop.org/drm/intel/issues/502
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#666]: https://gitlab.freedesktop.org/drm/intel/issues/666
[i915#676]: https://gitlab.freedesktop.org/drm/intel/issues/676
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
Participating hosts (10 -> 11)
------------------------------
Additional (1): pig-skl-6260u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7479 -> Patchwork_15572
CI-20190529: 20190529
CI_DRM_7479: 973ac65a9fc84bab12ce15d7053bcf3fdb1c3943 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5323: b0f877d06a78b9c38ed246be2537a0453b6c214f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15572: 64e2d00e22135a505ffd97e57c419db424a817b7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15572/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: eDP DPCD aux backlight fixes (rev3)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: eDP DPCD aux backlight fixes (rev3)
URL : https://patchwork.freedesktop.org/series/69914/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7485 -> Patchwork_15589
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15589 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_15589, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15589:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live_gt_pm:
- {fi-tgl-guc}: NOTRUN -> [DMESG-FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-tgl-guc/igt@i915_selftest@live_gt_pm.html
* igt@kms_chamelium@dp-hpd-fast:
- {fi-tgl-guc}: NOTRUN -> [SKIP][4] +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-tgl-guc/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_15589 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][5] -> [DMESG-FAIL][6] ([i915#683])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-ivb-3770/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-ivb-3770/igt@i915_selftest@live_blt.html
- fi-hsw-4770r: [PASS][7] -> [DMESG-FAIL][8] ([i915#683])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-hsw-4770r/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [PASS][9] -> [INCOMPLETE][10] ([i915#694])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [PASS][11] -> [DMESG-WARN][12] ([IGT#4] / [i915#263])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-icl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-icl-u2/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-guc: [PASS][13] -> [FAIL][14] ([i915#49])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-icl-guc/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-icl-guc/igt@[email protected]
#### Possible fixes ####
* igt@gem_sync@basic-each:
- {fi-tgl-guc}: [INCOMPLETE][15] ([i915#707]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-tgl-guc/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-tgl-guc/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [DMESG-WARN][17] ([i915#592]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-skl-6770hq/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-skl-6770hq/igt@[email protected]
* igt@i915_selftest@live_blt:
- fi-byt-n2820: [DMESG-FAIL][19] -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-byt-n2820/igt@i915_selftest@live_blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-byt-n2820/igt@i915_selftest@live_blt.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [FAIL][21] ([i915#49]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-icl-u3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-icl-u3/igt@[email protected]
- fi-icl-u2: [FAIL][23] ([i915#49]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-icl-u2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-icl-u2/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][25] ([fdo#107139] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([fdo#107139] / [i915#62] / [i915#92])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-kbl-x1275/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-kbl-x1275/igt@[email protected]
* igt@kms_busy@basic-flip-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][27] ([i915#62] / [i915#92]) -> [DMESG-WARN][28] ([i915#62] / [i915#92] / [i915#95]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-kbl-x1275/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][29] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][30] ([i915#62] / [i915#92]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7485/fi-kbl-x1275/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
[i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#592]: https://gitlab.freedesktop.org/drm/intel/issues/592
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#683]: https://gitlab.freedesktop.org/drm/intel/issues/683
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
[i915#710]: https://gitlab.freedesktop.org/drm/intel/issues/710
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (54 -> 47)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7485 -> Patchwork_15589
CI-20190529: 20190529
CI_DRM_7485: e0c1226aa69dcd3c47a7bb2bc0ae2be417f9e14e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5330: 2be94c2fba1cf9b6a3c1df093fa7289b1635b6fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15589: dcf3f0e7af7d9a2a6d4af826f20a617e5ec6d4e7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dcf3f0e7af7d drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel 9ff4fbff1a5d drm/i915: Auto detect DPCD backlight support by default a440f531fcbf drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() 51ea76df0c38 drm/i915: Assume 100% brightness when not in DPCD control mode 7946eee50821 drm/i915: Fix eDP DPCD aux max backlight calculations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15589/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev4)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: eDP DPCD aux backlight fixes (rev4)
URL : https://patchwork.freedesktop.org/series/69914/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7486 -> Patchwork_15598
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/index.html
Known issues
------------
Here are the changes found in Patchwork_15598 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([i915#178])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-skl-6770hq/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-skl-6770hq/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-bsw-nick: [DMESG-FAIL][3] ([i915#563]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-bsw-nick/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-bsw-nick/igt@i915_selftest@live_blt.html
- fi-hsw-4770r: [DMESG-FAIL][5] ([i915#683]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-hsw-4770r/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [INCOMPLETE][7] ([i915#45]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][9] ([i915#44]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-hsw-peppy/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-hsw-peppy/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +5 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-kbl-x1275/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-kbl-x1275/igt@[email protected]
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][13] ([i915#683]) -> [DMESG-FAIL][14] ([i915#563])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-hsw-4770/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7486/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#683]: https://gitlab.freedesktop.org/drm/intel/issues/683
[i915#710]: https://gitlab.freedesktop.org/drm/intel/issues/710
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (53 -> 45)
------------------------------
Additional (1): fi-cfl-8109u
Missing (9): fi-ilk-m540 fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7486 -> Patchwork_15598
CI-20190529: 20190529
CI_DRM_7486: 8bd05bdd30fdd1b56307b780ab0f0e8de878c75a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5331: dad473697b2e6bb5c45d7fec533b20d5dbe4fa17 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15598: 2c6f51e3d14c71c00ae477ac65c986d0d45f33f4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2c6f51e3d14c drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel 93ec963da888 drm/i915: Auto detect DPCD backlight support by default 565369ded2b2 drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() 34f566f53d36 drm/i915: Assume 100% brightness when not in DPCD control mode d2e02bc8948c drm/i915: Fix eDP DPCD aux max backlight calculations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15598/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx