fs/direct-io.c: include fs/internal.h for missing prototype
PATCH 1/1 fs/direct-io.c: include fs/internal.h for missing prototype
From: Eric Biggers <[email protected]>
Include fs/internal.h to address the following 'sparse' warning:
fs/direct-io.c:591:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static?
---
Hi Andrew, please consider applying this straightforward cleanup. This has been sent to Al four times with no response.
fs/direct-io.c | 2 ++ 1 file changed, 2 insertions(+)
fs/direct-io.c +2 -0
@@ -39,6 +39,8 @@#include <linux/atomic.h> #include <linux/prefetch.h> +#include "internal.h" +/* * How many user pages to map in one call to get_user_pages(). This determines * the size of a structure in the slab cache
Signature · 1 line
2.24.0.393.g34dc348eaf-goog
Quoted 7 lines · Eric Biggers
From: Eric Biggers <[email protected]>
Include
fs/internal.hto address the following 'sparse' warning:
fs/direct-io.c:591:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static?Signed-off-by Eric Biggers <[email protected]>
Makes sense. You can add:
Honza
Quoted 24 lines
---
Hi Andrew, please consider applying this straightforward cleanup. This has been sent to Al four times with no response.
fs/direct-io.c | 2 ++ 1 file changed, 2 insertions(+)fs/direct-io.c +2
-0@@ -39,6 +39,8 @@#include <linux/atomic.h> #include <linux/prefetch.h> +#include "internal.h" +/* * How many user pages to map in one call to get_user_pages(). This determines * the size of a structure in the slab cache Signature · 1 line
2.24.0.393.g34dc348eaf-goog
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR