at24: move write-protect pin handling to nvmem core
Subsystems (5)
v2 cover at24: move write-protect pin handling to nvmem core
The write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.
Instead of modifying all the drivers to check this pin, make the nvmem subsystem check if the write-protect GPIO being passed through the nvmem_config or defined in the device tree and pull it low whenever writing to the memory.
This patchset:
- adds support for the write-protect pin split into two parts. The first patch modifies modifies the relevant binding document, while the second modifies the nvmem code to pull the write-protect GPIO low (if present) during write operations.
- removes support for the write-protect pin split into two parts. The first patch modifies the relevant binding document to remove the wp-gpio, while the second removes the relevant code in the at24 driver.
Changes since v1:
-Add an explenation on how the wp-gpios works -keep reference to the wp-gpios in the at24 binding
Khouloud Touil (4):
dt-bindings: nvmem: new optional property write-protect-gpios
nvmem: add support for the write-protect pin
dt-bindings: at24: remove the optional property write-protect-gpios
eeprom: at24: remove the write-protect pin support
.../devicetree/bindings/eeprom/at24.yaml | 6 +----- .../devicetree/bindings/nvmem/nvmem.yaml | 9 +++++++++ drivers/misc/eeprom/at24.c | 9 --------- drivers/nvmem/core.c | 19 +++++++++++++++++-- drivers/nvmem/nvmem.h | 2 ++ include/linux/nvmem-provider.h | 3 +++ 6 files changed, 32 insertions(+), 16 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/4 dt-bindings: nvmem: new optional property write-protect-gpios
Several memories have a write-protect pin, that when pulled high, it blocks the write operation.
On some boards, this pin is connected to a GPIO and pulled high by default, which forces the user to manually change its state before writing.
Instead of modifying all the memory drivers to check this pin, make the NVMEM subsystem check if the write-protect GPIO being passed through the nvmem_config or defined in the device tree and pull it low whenever writing to the memory.
Add a new optional property to the device tree binding document, which allows to specify the GPIO line to which the write-protect pin is connected.
--- Documentation/devicetree/bindings/nvmem/nvmem.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)
Documentation/devicetree/bindings/nvmem/nvmem.yaml +9 -0
@@ -34,6 +34,14 @@ properties: description: Mark the provider as read only. + wp-gpios: + description: + GPIO to which the write-protect pin of the chip is connected. + The write-protect GPIO is asserted, when it's driven high + (logical '1') to block the write operation. It's deasserted, + when it's driven low (logical '0') to allow writing. + maxItems: 1 + patternProperties: "^.*@[0-9a-f]+$": type: object
@@ -66,6 +74,7 @@ examples: qfprom: eeprom@700000 { #address-cells = <1>; #size-cells = <1>; + wp-gpios = <&gpio1 3 0>; /* ... */
Signature · 1 line
2.17.1
Re: [PATCH v2 1/4] dt-bindings: nvmem: new optional property write-protect-gpios
Documentation/devicetree/bindings/nvmem/nvmem.yaml properties: · line 43
Quoted 7 lines · Khouloud Touil
Documentation/devicetree/bindings/nvmem/nvmem.yaml +7
-0+ wp-gpios: + description: + GPIO to which the write-protect pin of the chip is connected. + The write-protect GPIO is asserted, when it's driven high + (logical '1') to block the write operation. It's deasserted, + when it's driven low (logical '0') to allow writing. + maxItems: 1
OK I guess we can't get it less convoluted. This section is consistent.
Documentation/devicetree/bindings/nvmem/nvmem.yaml examples: · line 77
Quoted 8 lines
patternProperties:
"^.*@[0-9a-f]+$": type: objectDocumentation/devicetree/bindings/nvmem/nvmem.yaml +1
-0@@ -66,6 +74,7 @@ examples: qfprom: eeprom@700000 { #address-cells = <1>; #size-cells = <1>; + wp-gpios = <&gpio1 3 0>;
In the example please use the include for GPIO:
#include <dt-bindings/gpio/gpio.h>
wp-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>;
You can just put the #include directive right before the example, it should work fine.
Yours,
Linus Walleij
Re: [PATCH v2 1/4] dt-bindings: nvmem: new optional property write-protect-gpios
Quoted 24 lines · Linus Walleij
Documentation/devicetree/bindings/nvmem/nvmem.yaml properties: · line 43
Quoted 7 lines · Khouloud Touil
Documentation/devicetree/bindings/nvmem/nvmem.yaml +7
-0+ wp-gpios: + description: + GPIO to which the write-protect pin of the chip is connected. + The write-protect GPIO is asserted, when it's driven high + (logical '1') to block the write operation. It's deasserted, + when it's driven low (logical '0') to allow writing. + maxItems: 1OK I guess we can't get it less convoluted. This section is consistent.
Documentation/devicetree/bindings/nvmem/nvmem.yaml examples: · line 77
Quoted 8 lines
patternProperties:
"^.*@[0-9a-f]+$": type: objectDocumentation/devicetree/bindings/nvmem/nvmem.yaml +1
-0@@ -66,6 +74,7 @@ examples: qfprom: eeprom@700000 { #address-cells = <1>; #size-cells = <1>; + wp-gpios = <&gpio1 3 0>;In the example please use the include for GPIO:
Quoted 6 lines
#include <
dt-bindings/gpio/gpio.h>wp-gpios = <&gpio1 3
GPIO_ACTIVE_HIGH>;You can just put the #include directive right before the example, it should work fine.
Yes sure will fix that.
Thanks for your reviews.
Best regards,
Khouloud
Quoted 3 lines
Yours,
Linus Walleij
PATCH v2 2/4 nvmem: add support for the write-protect pin
In reply to Khouloud TouilThe write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.
Instead of modifying all the memory drivers to check this pin, make the NVMEM subsystem check if the write-protect GPIO being passed through the nvmem_config or defined in the device tree and pull it low whenever writing to the memory.
There was a suggestion for introducing the gpiodesc from pdata, but as pdata is already removed it could be replaced by adding it to nvmem_config.
Reference: https://lists.96boards.org/pipermail/dev/2018-August/001056.html
--- drivers/nvmem/core.c | 19 +++++++++++++++++-- drivers/nvmem/nvmem.h | 2 ++ include/linux/nvmem-provider.h | 3 +++ 3 files changed, 22 insertions(+), 2 deletions(-)
drivers/nvmem/core.c +17 -2
@@ -15,6 +15,7 @@#include <linux/module.h> #include <linux/nvmem-consumer.h> #include <linux/nvmem-provider.h> +#include <linux/gpio/consumer.h> #include <linux/of.h> #include <linux/slab.h> #include "nvmem.h"
@@ -54,8 +55,14 @@ static int nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset,static int nvmem_reg_write (struct nvmem_device *nvmem,unsigned int offset,void *val,size_t bytes) { -if (nvmem->reg_write) -return nvmem->reg_write (nvmem->priv, offset, val, bytes); +int ret; + +if (nvmem->reg_write) { +gpiod_set_value_cansleep (nvmem->wp_gpio,0 ); + ret = nvmem->reg_write (nvmem->priv, offset, val, bytes); +gpiod_set_value_cansleep (nvmem->wp_gpio,1 ); +return ret; + }return -EINVAL ; }
@@ -338,6 +345,14 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)kfree (nvmem);return ERR_PTR (rval); } +if (config->wp_gpio) + nvmem->wp_gpio = config->wp_gpio; +else + nvmem->wp_gpio =gpiod_get_optional (config->dev,"wp" , +GPIOD_OUT_HIGH ); +if (IS_ERR (nvmem->wp_gpio)) +return PTR_ERR (nvmem->wp_gpio); +kref_init (&nvmem->refcnt);INIT_LIST_HEAD (&nvmem->cells);
drivers/nvmem/nvmem.h +2 -0
@@ -9,6 +9,7 @@#include <linux/list.h> #include <linux/nvmem-consumer.h> #include <linux/nvmem-provider.h> +#include <linux/gpio/consumer.h> struct nvmem_device {struct module *owner;
@@ -26,6 +27,7 @@ struct nvmem_device {struct list_head cells;nvmem_reg_read_t reg_read;nvmem_reg_write_t reg_write; +struct gpio_desc *wp_gpio;void *priv; };
include/linux/nvmem-provider.h +3 -0
@@ -11,6 +11,7 @@#include <linux/err.h> #include <linux/errno.h> +#include <linux/gpio/consumer.h> struct nvmem_device ;struct nvmem_cell_info ;
@@ -45,6 +46,7 @@ enum nvmem_type {* @word_size: Minimum read/write access granularity. * @stride: Minimum read/write access stride. * @priv: User context passed to read/write callbacks. +* @wp-gpio: Write protect pin * * Note: A default "nvmem<id>" name will be assigned to the device if * no name is specified in its configuration. In such case "<id>" is
@@ -58,6 +60,7 @@ struct nvmem_config {const char *name;int id;struct module *owner; +struct gpio_desc *wp_gpio;const struct nvmem_cell_info *cells;int ncells;enum nvmem_type type;
Signature · 1 line
2.17.1
Re: [PATCH v2 2/4] nvmem: add support for the write-protect pin
Quoted 8 lines · Khouloud Touil
The write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.
Instead of modifying all the memory drivers to check this pin, make the NVMEM subsystem check if the write-protect GPIO being passed through the
nvmem_configor defined in the device tree and pull it low whenever writing to the memory.
Quoted 7 lines
There was a suggestion for introducing the gpiodesc from pdata, but as pdata is already removed it could be replaced by adding it to
nvmem_config.Reference: https://lists.96boards.org/pipermail/dev/2018-August/001056.html
Signed-off-by Khouloud Touil <[email protected]>
This is consistent IMO, we just specify that WP is active high as in "when it is high, it actively protects against writing", so:
Yours,
Linus Walleij
Re: [PATCH v2 2/4] nvmem: add support for the write-protect pin
In reply to Khouloud Touildrivers/nvmem/core.c
Quoted 22 lines · Khouloud Touil
The write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.
Instead of modifying all the memory drivers to check this pin, make the NVMEM subsystem check if the write-protect GPIO being passed through the
nvmem_configor defined in the device tree and pull it low whenever writing to the memory.There was a suggestion for introducing the gpiodesc from pdata, but as pdata is already removed it could be replaced by adding it to
nvmem_config.Reference: https://lists.96boards.org/pipermail/dev/2018-August/001056.html
Signed-off-by Khouloud Touil <[email protected]>--- drivers/nvmem/core.c | 19 +++++++++++++++++-- drivers/nvmem/nvmem.h | 2 ++ include/linux/nvmem-provider.h | 3 +++ 3 files changed, 22 insertions(+), 2 deletions(-)drivers/nvmem/core.c +0
-0
PATCH v2 3/4 dt-bindings: at24: remove the optional property write-protect-gpios
In reply to Khouloud TouilNVMEM framework is an interface for the at24 EEPROMs as well as for other drivers, instead of passing the wp-gpios over the different drivers each time, it would be better to pass it over the NVMEM subsystem once and for all.
Removing the optional property form the device tree binding document.
--- Documentation/devicetree/bindings/eeprom/at24.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
Documentation/devicetree/bindings/eeprom/at24.yaml +1 -5
@@ -145,10 +145,7 @@ properties: over reads to the next slave address. Please consult the manual of your device. - wp-gpios: - description: - GPIO to which the write-protect pin of the chip is connected. - maxItems: 1 + wp-gpios: true address-width: allOf:
@@ -181,7 +178,6 @@ examples: compatible = "microchip,24c32", "atmel,24c32"; reg = <0x52>; pagesize = <32>; - wp-gpios = <&gpio1 3 0>; num-addresses = <8>; }; };
Signature · 1 line
2.17.1
Re: [PATCH v2 3/4] dt-bindings: at24: remove the optional property write-protect-gpios
Quoted 6 lines · Khouloud Touil
NVMEM framework is an interface for the at24 EEPROMs as well as for other drivers, instead of passing the wp-gpios over the different drivers each time, it would be better to pass it over the NVMEM subsystem once and for all.
Removing the optional property form the device tree binding document.
You're not really removing it just referencing it from elsewhere.
Quoted 1 line
Signed-off-by Khouloud Touil <[email protected]>
Yours,
Linus Walleij
PATCH v2 4/4 eeprom: at24: remove the write-protect pin support
In reply to Khouloud TouilNVMEM framework is an interface for the at24 EEPROMs as well as for other drivers, instead of passing the wp-gpios over the different drivers each time, it would be better to pass it over the NVMEM subsystem once and for all.
Removing the support for the write-protect pin after adding it to the NVMEM subsystem.
--- drivers/misc/eeprom/at24.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/misc/eeprom/at24.c +0 -9
@@ -22,7 +22,6 @@#include <linux/nvmem-provider.h> #include <linux/regmap.h> #include <linux/pm_runtime.h> -#include <linux/gpio/consumer.h> /* Address pointer is 16 bit. */ #define AT24_FLAG_ADDR16 BIT(7)
@@ -89,8 +88,6 @@ struct at24_data {struct nvmem_device *nvmem; -struct gpio_desc *wp_gpio; -/* * Some chips tie up multiple I2C addresses; dummy devices reserve * them for us, and we'll use them with SMBus calls.
@@ -457,12 +454,10 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count)* from this host, but not from other I2C masters. */ mutex_lock (&at24->lock); -gpiod_set_value_cansleep (at24->wp_gpio,0 );while (count) { ret =at24_regmap_write (at24, buf, off, count);if (ret <0 ) { -gpiod_set_value_cansleep (at24->wp_gpio,1 );mutex_unlock (&at24->lock);pm_runtime_put (dev);return ret;
@@ -472,7 +467,6 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count) count -= ret; } -gpiod_set_value_cansleep (at24->wp_gpio,1 );mutex_unlock (&at24->lock);pm_runtime_put (dev);
@@ -662,9 +656,6 @@ static int at24_probe(struct i2c_client *client) at24->client[0 ].client = client; at24->client[0 ].regmap = regmap; - at24->wp_gpio =devm_gpiod_get_optional (dev,"wp" ,GPIOD_OUT_HIGH ); -if (IS_ERR (at24->wp_gpio)) -return PTR_ERR (at24->wp_gpio); writable = !(flags &AT24_FLAG_READONLY );if (writable) {
Signature · 1 line
2.17.1
Re: [PATCH v2 4/4] eeprom: at24: remove the write-protect pin support
Quoted 9 lines · Khouloud Touil
NVMEM framework is an interface for the at24 EEPROMs as well as for other drivers, instead of passing the wp-gpios over the different drivers each time, it would be better to pass it over the NVMEM subsystem once and for all.
Removing the support for the write-protect pin after adding it to the NVMEM subsystem.
Signed-off-by Khouloud Touil <[email protected]>
I wonder if this needs to be in the same patch that adds it to the NVMEM subsystem, so as to avoid both code paths being taken between the two patches (bisectability..)
However that is not the biggest thing in the universe and I'm no bisectability-perfectionist, so:
Yours,
Linus Walleij
Re: [PATCH v2 4/4] eeprom: at24: remove the write-protect pin support
pon., 16 gru 2019 o 09:13 Linus Walleij <[email protected]> napisał(a):
Quoted 17 lines · Khouloud Touil
Quoted 10 lines
NVMEM framework is an interface for the at24 EEPROMs as well as for other drivers, instead of passing the wp-gpios over the different drivers each time, it would be better to pass it over the NVMEM subsystem once and for all.
Removing the support for the write-protect pin after adding it to the NVMEM subsystem.
Signed-off-by Khouloud Touil <[email protected]>I wonder if this needs to be in the same patch that adds it to the NVMEM subsystem, so as to avoid both code paths being taken between the two patches (bisectability..)
Quoted 6 lines
However that is not the biggest thing in the universe and I'm no bisectability-perfectionist, so:
Reviewed-by Linus Walleij <[email protected]>Yours,
Linus Walleij
AFAIK Khouloud tested it and it's bisectable thanks to using the optional gpiod_get() variant.
Best regards,
Bartosz Golaszewski
Quoted 24 lines · Khouloud Touil
The write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.
Instead of modifying all the drivers to check this pin, make the nvmem subsystem check if the write-protect GPIO being passed through the
nvmem_configor defined in the device tree and pull it low whenever writing to the memory.This patchset:
- adds support for the write-protect pin split into two parts. The first patch modifies modifies the relevant binding document, while the second modifies the nvmem code to pull the write-protect GPIO low (if present) during write operations.
- removes support for the write-protect pin split into two parts. The first patch modifies the relevant binding document to remove the wp-gpio, while the second removes the relevant code in the at24 driver.
Changes since v1:
(quoted diff) +0
-2-Add an explenation on how the wp-gpios works -keep reference to the wp-gpios in the at24 binding
Quoted 6 lines
Khouloud Touil (4):
dt-bindings: nvmem: new optional property write-protect-gpios
nvmem: add support for the write-protect pin
dt-bindings: at24: remove the optional property write-protect-gpios
eeprom: at24: remove the write-protect pin support
Thanks Khouloud for this patchset,
I can take this via nvmem tree once we get an ack on dt bindings from DT maintainers.
--srini
Quoted 8 lines
.../devicetree/bindings/eeprom/at24.yaml | 6 +----- .../devicetree/bindings/nvmem/nvmem.yaml | 9 +++++++++ drivers/misc/eeprom/at24.c | 9 --------- drivers/nvmem/core.c | 19 +++++++++++++++++-- drivers/nvmem/nvmem.h | 2 ++ include/linux/nvmem-provider.h | 3 +++ 6 files changed, 32 insertions(+), 16 deletions(-)
czw., 19 gru 2019 o 11:51 Srinivas Kandagatla
<[email protected]> napisał(a):
Quoted 37 lines · Khouloud Touil
Quoted 24 lines
The write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.
Instead of modifying all the drivers to check this pin, make the nvmem subsystem check if the write-protect GPIO being passed through the
nvmem_configor defined in the device tree and pull it low whenever writing to the memory.This patchset:
- adds support for the write-protect pin split into two parts. The first patch modifies modifies the relevant binding document, while the second modifies the nvmem code to pull the write-protect GPIO low (if present) during write operations.
- removes support for the write-protect pin split into two parts. The first patch modifies the relevant binding document to remove the wp-gpio, while the second removes the relevant code in the at24 driver.
Changes since v1:
(quoted diff) +0
-2-Add an explenation on how the wp-gpios works -keep reference to the wp-gpios in the at24 bindingQuoted 6 lines
Khouloud Touil (4):
dt-bindings: nvmem: new optional property write-protect-gpios
nvmem: add support for the write-protect pin
dt-bindings: at24: remove the optional property write-protect-gpios
eeprom: at24: remove the write-protect pin supportThanks Khouloud for this patchset,
Quoted 3 lines
I can take this via nvmem tree once we get an ack on dt bindings from DT maintainers.
Hi Srinivas,
this will conflict with my at24 tree for this release - can you put those patches (once they're fine) into an immutable branch for me to merge in?
Bart
Quoted 10 lines
--srini
Quoted 8 lines
.../devicetree/bindings/eeprom/at24.yaml | 6 +----- .../devicetree/bindings/nvmem/nvmem.yaml | 9 +++++++++ drivers/misc/eeprom/at24.c | 9 --------- drivers/nvmem/core.c | 19 +++++++++++++++++-- drivers/nvmem/nvmem.h | 2 ++ include/linux/nvmem-provider.h | 3 +++ 6 files changed, 32 insertions(+), 16 deletions(-)
Quoted 43 lines · Bartosz Golaszewski
czw., 19 gru 2019 o 11:51 Srinivas Kandagatla
<[email protected]> napisał(a):Quoted 37 lines · Khouloud Touil
Quoted 24 lines
The write-protect pin handling looks like a standard property that could benefit other users if available in the core nvmem framework.
Instead of modifying all the drivers to check this pin, make the nvmem subsystem check if the write-protect GPIO being passed through the
nvmem_configor defined in the device tree and pull it low whenever writing to the memory.This patchset:
- adds support for the write-protect pin split into two parts. The first patch modifies modifies the relevant binding document, while the second modifies the nvmem code to pull the write-protect GPIO low (if present) during write operations.
- removes support for the write-protect pin split into two parts. The first patch modifies the relevant binding document to remove the wp-gpio, while the second removes the relevant code in the at24 driver.
Changes since v1:
(quoted diff) +0
-2-Add an explenation on how the wp-gpios works -keep reference to the wp-gpios in the at24 bindingQuoted 6 lines
Khouloud Touil (4):
dt-bindings: nvmem: new optional property write-protect-gpios
nvmem: add support for the write-protect pin
dt-bindings: at24: remove the optional property write-protect-gpios
eeprom: at24: remove the write-protect pin supportThanks Khouloud for this patchset,
Quoted 3 lines
I can take this via nvmem tree once we get an ack on dt bindings from DT maintainers.
Quoted 5 lines
Hi Srinivas,
this will conflict with my at24 tree for this release - can you put those patches (once they're fine) into an immutable branch for me to merge in?
I can ack nvmem core patch so that you can take it directly via at24 tree if thats okay.
-srini
Quoted 13 lines
Bart
Quoted 10 lines
--srini
Quoted 8 lines
.../devicetree/bindings/eeprom/at24.yaml | 6 +----- .../devicetree/bindings/nvmem/nvmem.yaml | 9 +++++++++ drivers/misc/eeprom/at24.c | 9 --------- drivers/nvmem/core.c | 19 +++++++++++++++++-- drivers/nvmem/nvmem.h | 2 ++ include/linux/nvmem-provider.h | 3 +++ 6 files changed, 32 insertions(+), 16 deletions(-)
czw., 19 gru 2019 o 11:56 Srinivas Kandagatla
<[email protected]> napisał(a):
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Thanks Khouloud for this patchset,
I can take this via nvmem tree once we get an ack on dt bindings from DT maintainers.
Quoted 9 lines
Quoted 5 lines
Hi Srinivas,
this will conflict with my at24 tree for this release - can you put those patches (once they're fine) into an immutable branch for me to merge in?
I can ack nvmem core patch so that you can take it directly via at24 tree if thats okay.
Sure, even better!
Bart