Skip to contentSkip to conversation

Xen missing prompt log when exec-sp=off

PATCH In review Jin Nan Wang 2 participants 2 messages Dec 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 Xen missing prompt log when exec-sp=off

Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg.

At default, xen will tell "VMX: Disabling executable EPT suerpages due to CVE-2018-12207". When user add 'ept=exec-sp=off' on command-line. The prompt is disappeared. This can give users the illusion that the feature is turned on.

---
 xen/arch/x86/hvm/vmx/vmx.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
xen/arch/x86/hvm/vmx/vmx.c +5 -5
index 7970ba93e1..9dcb100210 100644
@@ -2495,14 +2495,14 @@ const struct hvm_function_table * __init start_vmx(void)
     {
         bool cpu_has_bug_pschange_mc = has_if_pschange_mc();
 
+        /* Default to non-executable superpages on vulnerable hardware. */
         if ( opt_ept_exec_sp == -1 )
-        {
-            /* Default to non-executable superpages on vulnerable hardware. */
             opt_ept_exec_sp = !cpu_has_bug_pschange_mc;
 
-            if ( cpu_has_bug_pschange_mc )
-                printk("VMX: Disabling executable EPT superpages due to CVE-2018-12207\n");
-        }
+        if ( opt_ept_exec_sp )
+            printk("VMX: Enable executable EPT superpages\n");
+        else 
+            printk("VMX: Disabling executable EPT superpages due to CVE-2018-12207\n");
 
         vmx_function_table.hap_supported = 1;
         vmx_function_table.altp2m_supported = 1;
Signature · 7 lines
2.24.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 7 lines · Jin Nan Wang

Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg.

At default, xen will tell "VMX: Disabling executable EPT suerpages due to CVE-2018-12207". When user add 'ept=exec-sp=off' on command-line. The prompt is disappeared. This can give users the illusion that the feature is turned on.

I don't think this is sufficient reason to alter the current logic. And btw - may I ask that you don't submit several versions a day without even settling the prior discussion?

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel