Xen missing prompt log when exec-sp=off
PATCH v3 1/1 Xen missing prompt log when exec-sp=off
Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg.
--- xen/arch/x86/hvm/vmx/vmx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
xen/arch/x86/hvm/vmx/vmx.c +5 -5
@@ -2495,14 +2495,14 @@ const struct hvm_function_table * __init start_vmx(void) {bool cpu_has_bug_pschange_mc =has_if_pschange_mc (); +/* Default to non-executable superpages on vulnerable hardware. */ if ( opt_ept_exec_sp ==-1 ) - { -/* Default to non-executable superpages on vulnerable hardware. */ opt_ept_exec_sp = !cpu_has_bug_pschange_mc; -if ( cpu_has_bug_pschange_mc ) -printk ("VMX: Disabling executable EPT superpages due to CVE-2018-12207\n" ); - } +if ( opt_ept_exec_sp ) +printk ("VMX: Enable executable EPT superpages\n" ); +else +printk ("VMX: Disabling executable EPT superpages due to CVE-2018-12207\n" ); vmx_function_table.hap_supported =1 ; vmx_function_table.altp2m_supported =1 ;
Signature · 7 lines
2.24.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 2 lines · Jin Nan Wang
Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg.
Thanks for fixing the style issue, but submitting v3 without addressing the question on the "why" etc given on v2 isn't overly helpful.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 6 lines · Jan Beulich
Quoted 2 lines · Jin Nan Wang
Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg.
Thanks for fixing the style issue, but submitting v3 without addressing the question on the "why" etc given on v2 isn't overly helpful.
I agree that "why" needs answering. I wrote the code this way for a reason, because the enabled case is not interesting.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel