Skip to contentSkip to conversation

drivers: Add Tiger Lake hardware IDs to support acpi,

PATCH Superseded Gayatri Kammela 4 participants 11 messages Dec 13, 2019 – Dec 16, 2019

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover drivers: Add Tiger Lake hardware IDs to support acpi,

Hi,

Tiger Lake supports devices whose hardware IDs are changed for various drivers. Hence, add the new hardware IDs.

Patch 1: Add Tiger Lake support to DPTF driver Patch 2: Add Tiger Lake support to fan driver Patch 3: Add Tiger Lake support to Intel's HID driver Patch 4: Add Tiger Lake support to thermal driver

Changes since v1:
1) Maintain the readability by adding hardware IDs in a sorted order

Gayatri Kammela (4):
acpi: dptf: Add new Tiger Lake hardware IDs to support DPTF drivers in
acpi
acpi: fan: Add new Tiger Lake hardware ID to support fan driver in
acpi
platform/x86: intel-hid: Add new Tiger Lake hardware ID to support HID
driver
thermal: int340x_thermal: Add new Tiger Lake hardware IDs to support
thermal driver

 drivers/acpi/dptf/dptf_power.c                          | 1 +
 drivers/acpi/dptf/int340x_thermal.c                     | 4 ++++
 drivers/acpi/fan.c                                      | 1 +
 drivers/platform/x86/intel-hid.c                        | 1 +
 drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 1 +
 drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 1 +
 6 files changed, 9 insertions(+)
Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/4 acpi: dptf: Add new Tiger Lake hardware IDs to support DPTF drivers in acpi

Tiger Lake has new unique hardware IDs that are needed to support DPTF drivers. Hence, add them.

Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/acpi/dptf/dptf_power.c      | 1 +
 drivers/acpi/dptf/int340x_thermal.c | 4 ++++
 2 files changed, 5 insertions(+)
drivers/acpi/dptf/dptf_power.c +1 -0
index eb58fc475a03..387f27ef3368 100644
@@ -97,6 +97,7 @@ static int dptf_power_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id int3407_device_ids[] = {
+	{"INT1047", 0},
 	{"INT3407", 0},
 	{"", 0},
 };
drivers/acpi/dptf/int340x_thermal.c +4 -0
index 5c7a90186e3c..1ec7b6900662 100644
@@ -13,6 +13,10 @@
 
 #define INT3401_DEVICE 0X01
 static const struct acpi_device_id int340x_thermal_device_ids[] = {
+	{"INT1040"},
+	{"INT1043"},
+	{"INT1044"},
+	{"INT1047"},
 	{"INT3400"},
 	{"INT3401", INT3401_DEVICE},
 	{"INT3402"},
Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 2/4 acpi: fan: Add new Tiger Lake hardware ID to support fan driver in acpi

In reply to Gayatri Kammela

Tiger Lake has a new unique hardware ID to support fan driver. Hence, add it.

Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/acpi/fan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/fan.c +1 -0
index 816b0803f7fb..13708fb48038 100644
@@ -25,6 +25,7 @@ static int acpi_fan_remove(struct platform_device *pdev);
 
 static const struct acpi_device_id fan_device_ids[] = {
 	{"PNP0C0B", 0},
+	{"INT1044", 0},
 	{"INT3404", 0},
 	{"", 0},
 };
Signature · 1 line
2.17.1
#3 lore raw

Re: [PATCH v2 2/4] acpi: fan: Add new Tiger Lake hardware ID to support fan driver in acpi

Quoted 17 lines · Gayatri Kammela

Tiger Lake has a new unique hardware ID to support fan driver. Hence, add it.

Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/acpi/fan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/fan.c +0 -0
index 816b0803f7fb..13708fb48038 100644

drivers/acpi/fan.c static int acpi_fan_remove(struct platform_device *pdev); · line 28

Quoted 4 lines
drivers/acpi/fan.c +1 -0
@@ -25,6 +25,7 @@ static int acpi_fan_remove(struct platform_device *pdev);
 
 static const struct acpi_device_id fan_device_ids[] = {
        {"PNP0C0B", 0},
+       {"INT1044", 0},

This has to go into device_pm.c:acpi_dev_pm_attach() too, see commit

b9ea0bae260f ACPI: PM: Avoid attaching ACPI PM domain to certain devices

Quoted 4 lines
drivers/acpi/fan.c +0 -1
        {"INT3404", 0},
        {"", 0},
 };
--
#4 lore raw

RE: [PATCH v2 2/4] acpi: fan: Add new Tiger Lake hardware ID to support fan driver in acpi

Quoted 18 lines
Quoted 18 lines

Tiger Lake has a new unique hardware ID to support fan driver. Hence, add it.

Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/acpi/fan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/fan.c index renamed from drivers/acpi/fan.c +0 -0

816b0803f7fb..13708fb48038 100644

drivers/acpi/fan.c +0 -0
@@ -25,6 +25,7 @@ static int acpi_fan_remove(struct platform_device
 *pdev);
 
Quoted 7 lines

drivers/acpi/fan.c static int acpi_fan_remove(struct platform_device *pdev); · line 28

Quoted 3 lines
drivers/acpi/fan.c +1 -0
 static const struct acpi_device_id fan_device_ids[] = {
        {"PNP0C0B", 0},
+       {"INT1044", 0},

This has to go into device_pm.c:acpi_dev_pm_attach() too, see commit

b9ea0bae260f ACPI: PM: Avoid attaching ACPI PM domain to certain devices

Thanks Rafael! I will add it and send v3.

Quoted 5 lines
Quoted 5 lines
drivers/acpi/fan.c +0 -0
        {"INT3404", 0},
        {"", 0},

};
--

#5 lore raw

PATCH v2 3/4 platform/x86: intel-hid: Add new Tiger Lake hardware ID to support HID driver

In reply to Gayatri Kammela

Tiger Lake has a new unique hardware ID to support Intel's HID event filter driver. Hence, add it.

Cc Zhang Rui <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/platform/x86/intel-hid.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/intel-hid.c +1 -0
index ef6d4bd77b1a..43d590250228 100644
@@ -19,6 +19,7 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Alex Hung");
 
 static const struct acpi_device_id intel_hid_ids[] = {
+	{"INT1051", 0},
 	{"INT33D5", 0},
 	{"", 0},
 };
Signature · 1 line
2.17.1
Acked-by on v2 3/4
#6 lore raw

Re: [PATCH v2 3/4] platform/x86: intel-hid: Add new Tiger Lake hardware ID to support HID driver

Quoted 3 lines · Gayatri Kammela

Tiger Lake has a new unique hardware ID to support Intel's HID event filter driver. Hence, add it.

Quoted 23 lines
Cc Zhang Rui <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/platform/x86/intel-hid.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/intel-hid.c +1 -0
index ef6d4bd77b1a..43d590250228 100644
@@ -19,6 +19,7 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Alex Hung");
 
 static const struct acpi_device_id intel_hid_ids[] = {
+	{"INT1051", 0},
 	{"INT33D5", 0},
 	{"", 0},
 };
Signature · 1 line
2.17.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw

RE: [PATCH v2 3/4] platform/x86: intel-hid: Add new Tiger Lake hardware ID to support HID driver

Quoted 7 lines · Gayatri Kammela
Quoted 3 lines

Tiger Lake has a new unique hardware ID to support Intel's HID event filter driver. Hence, add it.

Thanks Andy!

#8 lore raw

PATCH v2 4/4 thermal: int340x_thermal: Add new Tiger Lake hardware IDs to support thermal driver

In reply to Gayatri Kammela

Tiger Lake has a new unique hardware IDs to support thermal driver. Hence, add them.

Cc Andy Shevchenko <[email protected]>
Cc Zhang rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 1 +
 drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 1 +
 2 files changed, 2 insertions(+)
drivers/thermal/intel/int340x_thermal/int3400_thermal.c +1 -0
index 3517883b5cdb..efae0c02d898 100644
@@ -369,6 +369,7 @@ static int int3400_thermal_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id int3400_thermal_match[] = {
+	{"INT1040", 0},
 	{"INT3400", 0},
 	{}
 };
drivers/thermal/intel/int340x_thermal/int3403_thermal.c +1 -0
index a7bbd8584ae2..aeece1e136a5 100644
@@ -282,6 +282,7 @@ static int int3403_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id int3403_device_ids[] = {
+	{"INT1043", 0},
 	{"INT3403", 0},
 	{"", 0},
 };
Signature · 1 line
2.17.1
Reviewed-by on v2 4/4
#9 lore raw

Re: [PATCH v2 4/4] thermal: int340x_thermal: Add new Tiger Lake hardware IDs to support thermal driver

Quoted 7 lines · Gayatri Kammela

Tiger Lake has a new unique hardware IDs to support thermal driver. Hence, add them.

Cc Andy Shevchenko <[email protected]>
Cc Zhang rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
Quoted 33 lines
---
 drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 1 +
 drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 1 +
 2 files changed, 2 insertions(+)
drivers/thermal/intel/int340x_thermal/int3400_thermal.c +1 -0
index 3517883b5cdb..efae0c02d898 100644
@@ -369,6 +369,7 @@ static int int3400_thermal_remove(struct
 platform_device *pdev)
 }
 
 static const struct acpi_device_id int3400_thermal_match[] = {
+	{"INT1040", 0},
 	{"INT3400", 0},
 	{}

};

drivers/thermal/intel/int340x_thermal/int3403_thermal.c +1 -0
index a7bbd8584ae2..aeece1e136a5 100644
@@ -282,6 +282,7 @@ static int int3403_remove(struct platform_device
 *pdev)
 }
 
 static const struct acpi_device_id int3403_device_ids[] = {
+	{"INT1043", 0},
 	{"INT3403", 0},
 	{"", 0},

};

#10 lore raw

RE: [PATCH v2 4/4] thermal: int340x_thermal: Add new Tiger Lake hardware IDs to support thermal driver

Quoted 9 lines · Gayatri Kammela
Quoted 7 lines

Tiger Lake has a new unique hardware IDs to support thermal driver. Hence, add them.

Cc Andy Shevchenko <[email protected]>
Cc Zhang rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>

Thanks Srinivas!