tps6105x add devicetree and leds support
Subsystems (3)
v6 cover tps6105x add devicetree and leds support
v5 -> v6:
Dan Murphy's suggestions:
- s/mfd/MFD/
- s/led/LED/
- Added copyright message
- fixed regmap_update_bits alignment
- added a comment to clarify that fwnode / devicetree support is optional, and device_get_next_child_node() returning NULL is supported
Lee Jones's suggestions:
- removed 'Tree:' line from commit message
- changed over to relative paths
v4 -> v5:
Added Jacek Anaszewski's Acked-by tag on both patches. Added Rob Herring's Reviewed-by tag on devicetree patch. Lee Jones:
- tweaked commit message s/led/LED/
- use relative paths in Devicetree binding docs, line up ':'s
v3 -> v4:
Removed tps6105 mfd patch - it was accepted (Mark Brown).
Use the new LED registration API - suggested by Jacek Anaszewski.
Updated led dt bindings to document function, color usage.
v2 -> v3:
Removed tps6105x regulator patch - it was accepted (Mark Brown).
Removed devicetree/platdata bindings for tps6105x led naming. I can test only with a 4.19 vendor kernel, which does not have the latest led naming infrastructure (function/color). Drop devicetree/ fwnode/pdata led naming in favour of hard-coding to "tps6105x::torch", so the patch can be tested by me, yet remains acceptable to upstream.
v1 -> v2:
Select chip operational mode by looking at subnode name, _not_ its compatible property. Suggested by Mark Brown.
I needed led operation for this mfd chip, so I added a very simple driver for this.
My platform (arm imx6q) is devicetree-based, so I added optional devicetree support for this chip and its sub-drivers.
Sven Van Asbroeck (2):
leds: tps6105x: add driver for MFD chip LED mode
dt-bindings: mfd: update TI tps6105x chip bindings
.../devicetree/bindings/mfd/tps6105x.txt | 47 +++++++++- drivers/leds/Kconfig | 10 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-tps6105x.c | 89 +++++++++++++++++++ 4 files changed, 146 insertions(+), 1 deletion(-) create mode 100644 drivers/leds/leds-tps6105x.c
Signature · 1 line
2.17.1
PATCH v6 1/2 leds: tps6105x: add driver for MFD chip LED mode
This driver adds support for the LED operational mode of the tps6105x MFD device.
--- drivers/leds/Kconfig | 10 ++++ drivers/leds/Makefile | 1 + drivers/leds/leds-tps6105x.c | 89 ++++++++++++++++++++++++++++++++++++ 3 files changed, 100 insertions(+) create mode 100644 drivers/leds/leds-tps6105x.c
drivers/leds/Kconfig +10 -0
@@ -836,6 +836,16 @@ config LEDS_LM36274 Say Y to enable the LM36274 LED driver for TI LMU devices. This supports the LED device LM36274. +config LEDS_TPS6105X + tristate "LED support for TI TPS6105X" + depends on LEDS_CLASS + depends on TPS6105X + default y if TPS6105X + help + This driver supports TPS61050/TPS61052 LED chips. + It is a single boost converter primarily for white LEDs and + audio amplifiers. + comment "LED Triggers" source "drivers/leds/trigger/Kconfig"
drivers/leds/Makefile +1 -0
@@ -85,6 +85,7 @@ obj-$(CONFIG_LEDS_LM3601X) += leds-lm3601x.o obj-$(CONFIG_LEDS_TI_LMU_COMMON) += leds-ti-lmu-common.o obj-$(CONFIG_LEDS_LM3697) += leds-lm3697.o obj-$(CONFIG_LEDS_LM36274) += leds-lm36274.o +obj-$(CONFIG_LEDS_TPS6105X) += leds-tps6105x.o # LED SPI Drivers obj-$(CONFIG_LEDS_CR0014114) += leds-cr0014114.o
drivers/leds/leds-tps6105x.c new file +89 -0
89 lines not on this page · raw message
Signature · 1 line
2.17.1
Pavel Machek
AppliedRe: [PATCH v6 1/2] leds: tps6105x: add driver for MFD chip LED mode
Quoted 5 lines · Sven Van Asbroeck
This driver adds support for the LED operational mode of the tps6105x MFD device.
Acked-by Jacek Anaszewski <[email protected]>Signed-off-by Sven Van Asbroeck <[email protected]>
Thanks, applied both patches.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH v6 2/2 dt-bindings: mfd: update TI tps6105x chip bindings
In reply to Sven Van AsbroeckThe driver has been extended to optionally get its operational mode, regulator init data and LED naming from the devicetree.
--- .../devicetree/bindings/mfd/tps6105x.txt | 47 ++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/tps6105x.txt +46 -1
@@ -7,11 +7,56 @@ Required properties: - compatible: "ti,tps61050" or "ti,tps61052" - reg: Specifies the I2C slave address -Example: +Optional sub-node: + +This subnode selects the chip's operational mode. +There can be at most one single available subnode. + +- regulator: presence of this sub-node puts the chip in regulator mode. + see ../regulator/regulator.yaml + +- led: presence of this sub-node puts the chip in led mode. + Optional properties: + - function : see ../leds/common.txt + - color : see ../leds/common.txt + - label : see ../leds/common.txt + (deprecated) + +Example (GPIO operation only): + +i2c0 { + tps61052@33 { + compatible = "ti,tps61052"; + reg = <0x33>; + }; +}; + +Example (GPIO + regulator operation): i2c0 { tps61052@33 { compatible = "ti,tps61052"; reg = <0x33>; + + regulator { + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; + }; +}; + +Example (GPIO + led operation): + +#include <dt-bindings/leds/common.h> + +i2c0 { + tps61052@33 { + compatible = "ti,tps61052"; + reg = <0x33>; + + led { + color = <LED_COLOR_ID_WHITE>; + }; }; };
Signature · 1 line
2.17.1
Re: [PATCH v6 2/2] dt-bindings: mfd: update TI tps6105x chip bindings
Quoted 9 lines · Sven Van Asbroeck
The driver has been extended to optionally get its operational mode, regulator init data and LED naming from the devicetree.
Acked-by Jacek Anaszewski <[email protected]>Reviewed-by Rob Herring <[email protected]>Signed-off-by Sven Van Asbroeck <[email protected]>--- .../devicetree/bindings/mfd/tps6105x.txt | 47 ++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-)
For my own reference:
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog