Skip to content

tps6105x add devicetree and leds support

Sven Van Asbroeck linux-devicetree linux-leds lkml 6 versions – Applied

Status from this message: Thanks, applied both patches.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 2 repliesApplied
  2. v52 patches 3 repliesSuperseded
  3. v42 patches 9 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches3 repliesSuperseded
v24 patches16 repliesSuperseded
v14 patches6 repliesSuperseded

Changes in v6 from the cover letter

Dan Murphy's suggestions:
- s/mfd/MFD/
- s/led/LED/
- Added copyright message
- fixed regmap_update_bits alignment
- added a comment to clarify that fwnode / devicetree support is optional, and device_get_next_child_node() returning NULL is supported
Lee Jones's suggestions:
- removed 'Tree:' line from commit message
- changed over to relative paths

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/2leds: tps6105x: add driver for MFD chip LED modedrivers/leds/Kconfig drivers/leds/Makefile drivers/leds/leds-tps6105x.c+100 -01 reply
2/2dt-bindings: mfd: update TI tps6105x chip bindingsDocumentation/devicetree/bindings/mfd/tps6105x.txt+46 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJacek AnaszewskiRob HerringLee Jones
1/2A-b
2/2A-b R-b Acked-for-MFD-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/2] tps6105x add devicetree and leds support

v5 -> v6:
Dan Murphy's suggestions:
- s/mfd/MFD/
- s/led/LED/
- Added copyright message
- fixed regmap_update_bits alignment
- added a comment to clarify that fwnode / devicetree support is optional, and device_get_next_child_node() returning NULL is supported
Lee Jones's suggestions:
- removed 'Tree:' line from commit message
- changed over to relative paths

v4 -> v5:
Added Jacek Anaszewski's Acked-by tag on both patches. Added Rob Herring's Reviewed-by tag on devicetree patch. Lee Jones:
- tweaked commit message s/led/LED/
- use relative paths in Devicetree binding docs, line up ':'s

v3 -> v4:
Removed tps6105 mfd patch - it was accepted (Mark Brown).

Use the new LED registration API - suggested by Jacek Anaszewski.

Updated led dt bindings to document function, color usage.

v2 -> v3:
Removed tps6105x regulator patch - it was accepted (Mark Brown).

Removed devicetree/platdata bindings for tps6105x led naming. I can test only with a 4.19 vendor kernel, which does not have the latest led naming infrastructure (function/color). Drop devicetree/ fwnode/pdata led naming in favour of hard-coding to "tps6105x::torch", so the patch can be tested by me, yet remains acceptable to upstream.

v1 -> v2:
Select chip operational mode by looking at subnode name, _not_ its compatible property. Suggested by Mark Brown.

I needed led operation for this mfd chip, so I added a very simple driver for this.

My platform (arm imx6q) is devicetree-based, so I added optional devicetree support for this chip and its sub-drivers.

Sven Van Asbroeck (2):
leds: tps6105x: add driver for MFD chip LED mode
dt-bindings: mfd: update TI tps6105x chip bindings

 .../devicetree/bindings/mfd/tps6105x.txt      | 47 +++++++++-
 drivers/leds/Kconfig                          | 10 +++
 drivers/leds/Makefile                         |  1 +
 drivers/leds/leds-tps6105x.c                  | 89 +++++++++++++++++++
 4 files changed, 146 insertions(+), 1 deletion(-)
 create mode 100644 drivers/leds/leds-tps6105x.c
Signature · 1 line
2.17.1