dt-bindings: Add vendor prefix for Xinpeng Technology
Subsystems (4)
PATCH v3 1/3 dt-bindings: Add vendor prefix for Xinpeng Technology
From: Heiko Stuebner <[email protected]>
Shenzhen Xinpeng Technology Co., Ltd produces for example display panels.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1056,6 +1056,8 @@ patternProperties: description: Extreme Engineering Solutions (X-ES) "^xillybus,.*": description: Xillybus Ltd. + "^xinpeng,.*": + description: Shenzhen Xinpeng Technology Co., Ltd "^xlnx,.*": description: Xilinx "^xunlong,.*":
Signature · 6 lines
2.24.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v3 2/3 dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272
From: Heiko Stuebner <[email protected]>
The XPP055C272 is a 5.5" 720x1280 DSI display.
changes in v2:
- add size info into binding title (Sam)
- add more required properties (Sam)
--- .../display/panel/xinpeng,xpp055c272.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +48 -0
@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel + +maintainers: + - Heiko Stuebner <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: xinpeng,xpp055c272 + reg: true + backlight: true + port: true + reset-gpios: true + iovcc-supply: + description: regulator that supplies the iovcc voltage + vci-supply: + description: regulator that supplies the vci voltage + +required: + - compatible + - reg + - backlight + - iovcc-supply + - vci-supply + +additionalProperties: false + +examples: + - | + dsi@ff450000 { + panel@0 { + compatible = "xinpeng,xpp055c272"; + reg = <0>; + backlight = <&backlight>; + iovcc-supply = <&vcc_1v8>; + vci-supply = <&vcc3v3_lcd>; + }; + }; + +...
Signature · 1 line
2.24.0
Re: [PATCH v3 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272
Hi,
Quoted 21 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
The XPP055C272 is a 5.5" 720x1280 DSI display.
changes in v2:
- add size info into binding title (Sam)
- add more required properties (Sam)Signed-off-by Heiko Stuebner <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- .../display/panel/xinpeng,xpp055c272.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yamlDocumentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +0
-0
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +4
-0@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#
The ID doesn't match the file name.
Did you run dt_bindings_check?
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +6
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel + +maintainers: + - Heiko Stuebner <[email protected]>
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 20
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +10
-0+ +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: xinpeng,xpp055c272 + reg: true + backlight: true + port: true
What is the port supposed to be doing?
Quoted 18 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +18
-0+ reset-gpios: true + iovcc-supply: + description: regulator that supplies the iovcc voltage + vci-supply: + description: regulator that supplies the vci voltage + +required: + - compatible + - reg + - backlight + - iovcc-supply + - vci-supply + +additionalProperties: false + +examples: + - | + dsi@ff450000 {
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 48
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +10
-0+ panel@0 { + compatible = "xinpeng,xpp055c272"; + reg = <0>; + backlight = <&backlight>; + iovcc-supply = <&vcc_1v8>; + vci-supply = <&vcc3v3_lcd>; + }; + }; + +...
Thanks!
Maxime
Re: [PATCH v3 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272
Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
Quoted 31 lines
Hi,
Quoted 21 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
The XPP055C272 is a 5.5" 720x1280 DSI display.
changes in v2:
- add size info into binding title (Sam)
- add more required properties (Sam)Signed-off-by Heiko Stuebner <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- .../display/panel/xinpeng,xpp055c272.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yamlDocumentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +0
-0Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +4
-0@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#The ID doesn't match the file name.
Quoted 1 line
Did you run
dt_bindings_check?
Thanks for that pointer ... I did run dtbs_check on the binding and was sooo happy to not find any panel errors in the pages of other dt errors but till now didn't realize that there's also a dtbinding_check.
Will keep that in mind for future bindings - and of course fix things in the next version.
Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +10
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel + +maintainers: + - Heiko Stuebner <[email protected]> + +allOf: + - $ref: panel-common.yaml# +
Quoted 8 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 20
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +6
-0+properties: + compatible: + const: xinpeng,xpp055c272 + reg: true + backlight: true + port: trueWhat is the port supposed to be doing?
Hooking the display up to the dsi controller. But you're right, works without port as well with these single-dsi displays.
I just remember needing one for the Gru-Scarlet display that needed to connect to two dsi controllers.
So I'll drop the port node here and from my board devicetree.
Thanks for the review
Heiko
Quoted 24 lines
Quoted 24 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +23
-0+ reset-gpios: true + iovcc-supply: + description: regulator that supplies the iovcc voltage + vci-supply: + description: regulator that supplies the vci voltage + +required: + - compatible + - reg + - backlight + - iovcc-supply + - vci-supply + +additionalProperties: false + +examples: + - | + dsi@ff450000 { + panel@0 { + compatible = "xinpeng,xpp055c272"; + reg = <0>; + backlight = <&backlight>; + iovcc-supply = <&vcc_1v8>;
Quoted 9 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 48
Quoted 5 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +5
-0+ vci-supply = <&vcc3v3_lcd>; + }; + }; + +...Thanks!
Maxime
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272
Quoted 32 lines · Heiko Stübner
Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
Quoted 31 lines
Hi,
Quoted 21 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
The XPP055C272 is a 5.5" 720x1280 DSI display.
changes in v2:
- add size info into binding title (Sam)
- add more required properties (Sam)Signed-off-by Heiko Stuebner <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- .../display/panel/xinpeng,xpp055c272.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yamlDocumentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +0
-0Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +4
-0@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#The ID doesn't match the file name.
Quoted 5 lines
Quoted 1 line
Did you run
dt_bindings_check?Thanks for that pointer ... I did run
dtbs_checkon the binding and was sooo happy to not find any panel errors in the pages of other dt errors but till now didn't realize that there's also adtbinding_check.
dt_bindings_check is a sanity check on the bindings themselves. dtbs_check is using those bindings to check the device trees.
dtbs_check used to have a dependency on dt_bindings_check, but it got removed recently.
Maxime
Quoted 24 lines
Will keep that in mind for future bindings - and of course fix things in the next version.
Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +10
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel + +maintainers: + - Heiko Stuebner <[email protected]> + +allOf: + - $ref: panel-common.yaml# +Quoted 8 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 20
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +6
-0+properties: + compatible: + const: xinpeng,xpp055c272 + reg: true + backlight: true + port: trueWhat is the port supposed to be doing?
Quoted 7 lines
Hooking the display up to the dsi controller. But you're right, works without port as well with these single-dsi displays.
I just remember needing one for the Gru-Scarlet display that needed to connect to two dsi controllers.
So I'll drop the port node here and from my board devicetree.
It's not really what I meant though :)
If it's needed then we should definitely have it, but we should document our expectations here: is it the input port ? output? in which case do we want to use it since it's optional, etc.
Maxime
Re: [PATCH v3 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272
Hi Maxime,
Am Dienstag, 17. Dezember 2019, 17:01:22 CET schrieb Maxime Ripard:
Quoted 78 lines · Heiko Stübner
Quoted 32 lines
Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
Quoted 31 lines
Hi,
Quoted 21 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
The XPP055C272 is a 5.5" 720x1280 DSI display.
changes in v2:
- add size info into binding title (Sam)
- add more required properties (Sam)Signed-off-by Heiko Stuebner <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- .../display/panel/xinpeng,xpp055c272.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yamlDocumentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +0
-0Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +4
-0@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#The ID doesn't match the file name.
Quoted 5 lines
Quoted 1 line
Did you run
dt_bindings_check?Thanks for that pointer ... I did run
dtbs_checkon the binding and was sooo happy to not find any panel errors in the pages of other dt errors but till now didn't realize that there's also adtbinding_check.
dt_bindings_checkis a sanity check on the bindings themselves.dtbs_checkis using those bindings to check the device trees.
dtbs_checkused to have a dependency ondt_bindings_check, but it got removed recently.Maxime
Quoted 30 lines
Will keep that in mind for future bindings - and of course fix things in the next version.
Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +10
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel + +maintainers: + - Heiko Stuebner <[email protected]> + +allOf: + - $ref: panel-common.yaml# +Quoted 8 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml line 20
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml new file +6
-0+properties: + compatible: + const: xinpeng,xpp055c272 + reg: true + backlight: true + port: trueWhat is the port supposed to be doing?
Hooking the display up to the dsi controller. But you're right, works without port as well with these single-dsi displays.
I just remember needing one for the Gru-Scarlet display that needed to connect to two dsi controllers.
Quoted 7 lines
Quoted 1 line
So I'll drop the port node here and from my board devicetree.
It's not really what I meant though :)
If it's needed then we should definitely have it, but we should document our expectations here: is it the input port ? output? in which case do we want to use it since it's optional, etc.
The port was actually unnecessary. As far as I understand dsi stuff, the common case is the panel as subnode of the dsi controller and the controller then finding the display itself automatically.
If you look at
"drm/bridge/synopsys: dsi: use mipi_dsi_device to find panel or bridge" [0]
I just sent, you'll see that the dw-mipi-dsi used drm_of_find_panel_or_bridge to find its panel/bridge thus requiring port connections in all cases where it had the dsi-device available already, so wouldn't need to use ports for it.
Or I'm completely wrong and port usage is better, we'll see :-D
Heiko
[0] https://patchwork.freedesktop.org/patch/345666/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v3 3/3 drm/panel: add panel driver for Xinpeng XPP055C272 panels
In reply to Heiko StuebnerFrom: Heiko Stuebner <[email protected]>
Base on the somewhat similar Rocktech driver but adapted for panel-specific init of the XPP055C272.
changes in v3:
- remove wrong negative sync flags from display-mode to fix a display artifact of the output getting move a tiny bit to the right
changes in v2:
- move to drm-panel-internal backlight handling (Sam)
- adapt to changes that happened to drm_panel structs+functions (Sam)
- sort includes (Sam)
- drop unnecessary DRV_NAME constant (Sam)
- do mipi_dsi_dcs_exit_sleep_mode and mipi_dsi_dcs_set_display_on in panel prepare (not init_sequence) to keep symmetric (Sam)
--- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-xinpeng-xpp055c272.c | 400 ++++++++++++++++++ 3 files changed, 411 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c
drivers/gpu/drm/panel/Kconfig +10 -0
@@ -355,4 +355,14 @@ config DRM_PANEL_TRULY_NT35597_WQXGA help Say Y here if you want to enable support for Truly NT35597 WQXGA Dual DSI Video Mode panel + +config DRM_PANEL_XINPENG_XPP055C272 + tristate "Xinpeng XPP055C272 panel driver" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for the Xinpeng + XPP055C272 controller for 720x1280 LCD panels with MIPI/RGB/SPI + system interfaces. endmenu
drivers/gpu/drm/panel/Makefile +1 -0
@@ -38,3 +38,4 @@ obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o obj-$(CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA) += panel-truly-nt35597.o +obj-$(CONFIG_DRM_PANEL_XINPENG_XPP055C272) += panel-xinpeng-xpp055c272.o
drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c new file +400 -0
400 lines not on this page · raw message
Signature · 6 lines
2.24.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel