ath11k: fix pdev when invoking ath11k_wmi_send_twt_enable_cmd()
PATCH v2 1/2 ath11k: fix pdev when invoking ath11k_wmi_send_twt_enable_cmd()
From: Pradeep Kumar Chitrapu <[email protected]>
The code currently uses the wrong pdev id when enabling TWT. Fix this by using the correct ones.
--- drivers/net/wireless/ath/ath11k/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/mac.c +2 -2
@@ -1917,9 +1917,9 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,if (changed &BSS_CHANGED_TWT ) {if (info->twt_requester || info->twt_responder) -ath11k_wmi_send_twt_enable_cmd (ar, ar->pdev_idx); +ath11k_wmi_send_twt_enable_cmd (ar, ar->pdev->pdev_id);else -ath11k_wmi_send_twt_disable_cmd (ar, ar->pdev_idx); +ath11k_wmi_send_twt_disable_cmd (ar, ar->pdev->pdev_id);if (vif->type ==NL80211_IFTYPE_AP )ath11k_debugfs_twt (arvif, info->twt_requester); }
Signature · 7 lines
2.20.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH v2 2/2 ath11k: set the BA buffer size to 256 when HE is enabled
From: Pradeep Kumar Chitrapu <[email protected]>
This patch sets the correct BA buffer size when we are in HE mode. Without this change we are not able to receive 256 bitmapped BA frames.
--- drivers/net/wireless/ath/ath11k/mac.c | 14 ++++++++++++++ drivers/net/wireless/ath/ath11k/wmi.h | 2 ++ 2 files changed, 16 insertions(+)
drivers/net/wireless/ath/ath11k/mac.c +14 -0
@@ -1758,6 +1758,20 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,if (ret)ath11k_warn (ar->ab,"failed to update bcn template: %d\n" , ret); + +if (vif->bss_conf.he_support) { + ret =ath11k_wmi_vdev_set_param_cmd (ar, arvif->vdev_id, +WMI_VDEV_PARAM_BA_MODE , +WMI_BA_MODE_BUFFER_SIZE_256 ); +if (ret) +ath11k_warn (ar->ab, +"failed to set BA BUFFER SIZE 256 for vdev: %d\n" , + arvif->vdev_id); +else +ath11k_dbg (ar->ab,ATH11K_DBG_MAC , +"Set BA BUFFER SIZE 256 for VDEV: %d\n" , + arvif->vdev_id); + } }if (changed & (BSS_CHANGED_BEACON_INFO |BSS_CHANGED_BEACON )) {
drivers/net/wireless/ath/ath11k/wmi.h +2 -0
@@ -54,6 +54,7 @@ struct wmi_tlv {#define WLAN_SCAN_PARAMS_MAX_BSSID 4#define WLAN_SCAN_PARAMS_MAX_IE_LEN 256 +#define WMI_BA_MODE_BUFFER_SIZE_256 3/* * HW mode config type replicated from FW header * @WMI_HOST_HW_MODE_SINGLE: Only one PHY is active.
@@ -1004,6 +1005,7 @@ enum wmi_tlv_vdev_param {WMI_VDEV_PARAM_HE_RANGE_EXT ,WMI_VDEV_PARAM_ENABLE_BCAST_PROBE_RESPONSE ,WMI_VDEV_PARAM_FILS_MAX_CHANNEL_GUARD_TIME , +WMI_VDEV_PARAM_BA_MODE =0x7e ,WMI_VDEV_PARAM_SET_HE_SOUNDING_MODE =0x87 ,WMI_VDEV_PARAM_PROTOTYPE =0x8000 , WMI_VDEV_PARAM_BSS_COLOR,
Signature · 7 lines
2.20.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 7 lines · John Crispin
The code currently uses the wrong pdev id when enabling TWT. Fix this by using the correct ones.
Fixes e65a616f4e74 ("ath11k: add TWT support")Signed-off-by John Crispin <[email protected]>Signed-off-by Pradeep Kumar Chitrapu <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
485add35771b ath11k: fix pdev when invoking ath11k_wmi_send_twt_enable_cmd() aacb46223e08 ath11k: set the BA buffer size to 256 when HE is enabled
Signature · 8 lines
https://patchwork.kernel.org/patch/11290725/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 7 lines · John Crispin
The code currently uses the wrong pdev id when enabling TWT. Fix this by using the correct ones.
Fixes e65a616f4e74 ("ath11k: add TWT support")Signed-off-by John Crispin <[email protected]>Signed-off-by Pradeep Kumar Chitrapu <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
485add35771b ath11k: fix pdev when invoking ath11k_wmi_send_twt_enable_cmd() aacb46223e08 ath11k: set the BA buffer size to 256 when HE is enabled
Signature · 3 lines
https://patchwork.kernel.org/patch/11290725/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 8 lines · John Crispin
From: Pradeep Kumar Chitrapu <[email protected]>
The code currently uses the wrong pdev id when enabling TWT. Fix this by using the correct ones.
Fixes e65a616f4e74 ("ath11k: add TWT support")Signed-off-by John Crispin <[email protected]>Signed-off-by Pradeep Kumar Chitrapu <[email protected]>
I noticed only after I applied this, but the s-o-b line is in wrong order. Pradeep, being the author, should have his s-o-b line first.
Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches