Skip to contentSkip to conversation

ASoC: max98090: Remove empty suspend function

PATCH In review Mark Brown 2 participants 3 messages Dec 18, 2019 – Dec 19, 2019

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 ASoC: max98090: Remove empty suspend function

The suspend function is empty so can be removed.

---
 sound/soc/codecs/max98090.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
sound/soc/codecs/max98090.c +1 -6
index da23810f958e..68271042f586 100644
@@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)
 
 	return 0;
 }
-
-static int max98090_suspend(struct device *dev)
-{
-	return 0;
-}
 #endif
 
 static const struct dev_pm_ops max98090_pm = {
-	SET_RUNTIME_PM_OPS(max98090_runtime_suspend,
+	SET_RUNTIME_PM_OPS(NULL,
 		max98090_runtime_resume, NULL)
 	SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
 };
Signature · 6 lines
2.20.1

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#1 lore raw
Quoted 17 lines · Mark Brown

The suspend function is empty so can be removed.

---
 sound/soc/codecs/max98090.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
sound/soc/codecs/max98090.c +0 -1
index da23810f958e..68271042f586 100644
@@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)
 
        return 0;
 }
-

sound/soc/codecs/max98090.c static int max98090_resume(struct device *dev) · line 2845

Quoted 10 lines
sound/soc/codecs/max98090.c +1 -5
-static int max98090_suspend(struct device *dev)
-{
-       return 0;
-}
 #endif
 
 static const struct dev_pm_ops max98090_pm = {
-       SET_RUNTIME_PM_OPS(max98090_runtime_suspend,
+       SET_RUNTIME_PM_OPS(NULL,
                max98090_runtime_resume, NULL)

You replaced the wrong "_suspend".

sound/soc/codecs/max98090.c static int max98090_resume(struct device *dev) · line 2846

Quoted 1 line
sound/soc/codecs/max98090.c +0 -0
        SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)

This is which you should replace to NULL.
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel