ASoC: max98090: Remove empty suspend function
Mark Brown
maintainerPATCH 1/1 ASoC: max98090: Remove empty suspend function
The suspend function is empty so can be removed.
--- sound/soc/codecs/max98090.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
sound/soc/codecs/max98090.c +1 -6
@@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)return 0 ; } - -static int max98090_suspend (struct device *dev) -{ -return 0 ; -}#endif static const struct dev_pm_ops max98090_pm = { - SET_RUNTIME_PM_OPS(max98090_runtime_suspend, + SET_RUNTIME_PM_OPS(NULL, max98090_runtime_resume, NULL)SET_SYSTEM_SLEEP_PM_OPS (max98090_suspend, max98090_resume) };
Signature · 6 lines
2.20.1 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 17 lines · Mark Brown
The suspend function is empty so can be removed.
Signed-off-by Mark Brown <[email protected]>--- sound/soc/codecs/max98090.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)sound/soc/codecs/max98090.c +0
-1@@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)return 0 ; } -
sound/soc/codecs/max98090.c static int max98090_resume(struct device *dev) · line 2845
Quoted 10 lines
sound/soc/codecs/max98090.c +1
-5-static int max98090_suspend (struct device *dev) -{ -return 0 ; -}#endif static const struct dev_pm_ops max98090_pm = { -SET_RUNTIME_PM_OPS (max98090_runtime_suspend, +SET_RUNTIME_PM_OPS (NULL , max98090_runtime_resume,NULL )
You replaced the wrong "_suspend".
sound/soc/codecs/max98090.c static int max98090_resume(struct device *dev) · line 2846
Quoted 1 line
sound/soc/codecs/max98090.c +0
-0SET_SYSTEM_SLEEP_PM_OPS (max98090_suspend, max98090_resume)
This is which you should replace to NULL.
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
maintainerQuoted 4 lines · Tzung-Bi Shih
Quoted 1 line · Mark Brown
SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)This is which you should replace to NULL.
Ugh, so I did - thanks.
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel