eal: improve user notification for too low memzone segments
PATCH 1/1 eal: improve user notification for too low memzone segments
In case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.
--- lib/librte_eal/common/eal_common_memzone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/common/eal_common_memzone.c +1 -1
@@ -71,7 +71,7 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,/* no more room in config */ if (arr->count >= arr->len) { -RTE_LOG (ERR ,EAL ,"%s(): No more room in config\n" , __func__); +RTE_LOG (ERR ,EAL ,"%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n" , __func__); rte_errno =ENOSPC ;return NULL ; }
Signature · 1 line
2.17.1
Including Anatoly as maintainer for lib/librte_eal/common/eal_common_mem*
Quoted 34 lines
-----Original Message-----
From: Trybula, ArturX <[email protected]>
Sent: Monday, December 16, 2019 3:44 PM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]; Dybkowski, AdamX <[email protected]>; Danilewicz, MarcinX <[email protected]>; Trybula, ArturX <[email protected]>; [email protected]
Subject: [PATCH] eal: improve user notification for too low memzone segmentsIn case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.
Signed-off-by Artur Trybula <[email protected]>--- lib/librte_eal/common/eal_common_memzone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_eal/common/eal_common_memzone.c +1
-1@@ -71,7 +71,7 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,/* no more room in config */ if (arr->count >= arr->len) { -RTE_LOG (ERR ,EAL ,"%s(): No more room in config\n" , __func__); +RTE_LOG (ERR ,EAL ,"%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n", __func__); rte_errno =ENOSPC ;return NULL ;}
--
2.17.1
v2 cover eal: user notification improvement
In reply to Artur Trybulav2:
- fixed coding style issue
Artur Trybula (1):
eal: improve user notification for too low memzone segments
lib/librte_eal/common/eal_common_memzone.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
PATCH v2 1/1 eal: improve user notification for too low memzone segments
In case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.
--- lib/librte_eal/common/eal_common_memzone.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
lib/librte_eal/common/eal_common_memzone.c +3 -1
@@ -71,7 +71,9 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,/* no more room in config */ if (arr->count >= arr->len) { -RTE_LOG (ERR ,EAL ,"%s(): No more room in config\n" , __func__); +RTE_LOG (ERR ,EAL , +"%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n" , + __func__); rte_errno =ENOSPC ;return NULL ; }
Signature · 1 line
2.17.1
Quoted 6 lines · Artur Trybula
In case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.
Signed-off-by Artur Trybula <[email protected]>---
Signature · 2 lines
Thanks, Anatoly
Thomas Monjalon
Applied14/01/2020 11:40, Burakov, Anatoly:
Quoted 8 lines · Artur Trybula
Quoted 5 lines
In case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.
Signed-off-by Artur Trybula <[email protected]>Acked-by Anatoly Burakov <[email protected]>
Applied, thanks