Skip to contentSkip to conversation

eal: improve user notification for too low memzone segments

PATCH Superseded Artur Trybula 4 participants 6 messages Dec 16, 2019 – Jan 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal: improve user notification for too low memzone segments

In case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.

---
 lib/librte_eal/common/eal_common_memzone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/common/eal_common_memzone.c +1 -1
index 99b8d6531..c1acbbb3c 100644
@@ -71,7 +71,7 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
 
 	/* no more room in config */
 	if (arr->count >= arr->len) {
-		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
+		RTE_LOG(ERR, EAL, "%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n", __func__);
 		rte_errno = ENOSPC;
 		return NULL;
 	}
Signature · 1 line
2.17.1
#1 lore raw

Including Anatoly as maintainer for lib/librte_eal/common/eal_common_mem*

Quoted 34 lines

-----Original Message-----
From: Trybula, ArturX <[email protected]>
Sent: Monday, December 16, 2019 3:44 PM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]; Dybkowski, AdamX <[email protected]>; Danilewicz, MarcinX <[email protected]>; Trybula, ArturX <[email protected]>; [email protected]
Subject: [PATCH] eal: improve user notification for too low memzone segments

In case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.

---
 lib/librte_eal/common/eal_common_memzone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/common/eal_common_memzone.c +1 -1
index 99b8d6531..c1acbbb3c 100644
@@ -71,7 +71,7 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
 
 	/* no more room in config */
 	if (arr->count >= arr->len) {
-		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
+		RTE_LOG(ERR, EAL, "%s(): Number of requested memzone segments exceeds
 RTE_MAX_MEMZONE\n", __func__);
 		rte_errno = ENOSPC;
 		return NULL;

}
--
2.17.1

#2 lore raw

v2 cover eal: user notification improvement

In reply to Artur Trybula

v2:
- fixed coding style issue

Artur Trybula (1):
eal: improve user notification for too low memzone segments

 lib/librte_eal/common/eal_common_memzone.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
#3 lore raw

PATCH v2 1/1 eal: improve user notification for too low memzone segments

In case of too low number of memzone segements user notification was misleading. This patch improves the description by providing better explanation about the cause.

---
 lib/librte_eal/common/eal_common_memzone.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
lib/librte_eal/common/eal_common_memzone.c +3 -1
index 99b8d6531..86f61369b 100644
@@ -71,7 +71,9 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
 
 	/* no more room in config */
 	if (arr->count >= arr->len) {
-		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
+		RTE_LOG(ERR, EAL,
+		"%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n",
+			__func__);
 		rte_errno = ENOSPC;
 		return NULL;
 	}
Signature · 1 line
2.17.1