Skip to contentSkip to conversation

Add GPU & Video Clock controller driver for SC7180

PATCH Applied Taniya Das 4 participants 21 messages Nov 15, 2019 – Dec 27, 2019

Subsystems (4)
lore
Share & tools
lore

Taniya Das

author
#0 lore raw

v2 cover Add GPU & Video Clock controller driver for SC7180

[v2]
* Split Fabia code cleanup and calibration code.
* Few cleanups for GPU/Video CC are
* header file inclusion, const for pll vco table.
* removal of always enabled clock from gpucc.
* compatibles added in sorted order.
* move from core_initcall to subsys_initcall().
* cleanup clk_parent_data for clocks to be provided from DT.

[v1]
* Fabia PLLs could fail latching in the case where the PLL is not calibrated, so add support to calibrate in prepare clock ops.

* Add driver support for Graphics clock controller for SC7180 and also update device tree bindings for the various clocks supported in the clock controller.

* Add driver support for Video clock controller for SC7180 and also update device tree bindings for the various clocks supported in the clock controller.

Taniya Das (8):
clk: qcom: alpha-pll: Remove useless read from set rate
clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration
dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings
dt-bindings: clock: Introduce QCOM Graphics clock bindings
clk: qcom: Add graphics clock controller driver for SC7180
dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock
bindings
dt-bindings: clock: Introduce QCOM Video clock bindings
clk: qcom: Add video clock controller driver for SC7180

 .../devicetree/bindings/clock/qcom,gpucc.txt       |  24 --
 .../devicetree/bindings/clock/qcom,gpucc.yaml      |  70 ++++++
 .../devicetree/bindings/clock/qcom,videocc.txt     |  18 --
 .../devicetree/bindings/clock/qcom,videocc.yaml    |  62 +++++
 drivers/clk/qcom/Kconfig                           |  16 ++
 drivers/clk/qcom/Makefile                          |   2 +
 drivers/clk/qcom/clk-alpha-pll.c                   |  83 ++++++-
 drivers/clk/qcom/clk-alpha-pll.h                   |   4 +
 drivers/clk/qcom/gpucc-sc7180.c                    | 266 +++++++++++++++++++++
 drivers/clk/qcom/videocc-sc7180.c                  | 259 ++++++++++++++++++++
 include/dt-bindings/clock/qcom,gpucc-sc7180.h      |  21 ++
 include/dt-bindings/clock/qcom,videocc-sc7180.h    |  23 ++
 12 files changed, 800 insertions(+), 48 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/qcom,videocc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,videocc.yaml
 create mode 100644 drivers/clk/qcom/gpucc-sc7180.c
 create mode 100644 drivers/clk/qcom/videocc-sc7180.c
 create mode 100644 include/dt-bindings/clock/qcom,gpucc-sc7180.h
 create mode 100644 include/dt-bindings/clock/qcom,videocc-sc7180.h

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

author
#1 lore raw

PATCH v2 1/8 clk: qcom: alpha-pll: Remove useless read from set rate

PLL_MODE read in fabia set rate is not required, thus remove the same.

---
 drivers/clk/qcom/clk-alpha-pll.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/clk/qcom/clk-alpha-pll.c +1 -6
index 055318f..e39034d 100644
@@ -1141,14 +1141,9 @@ static int alpha_pll_fabia_set_rate(struct clk_hw *hw, unsigned long rate,
 						unsigned long prate)
 {
 	struct clk_alpha_pll *pll = to_clk_alpha_pll(hw);
-	u32 val, l, alpha_width = pll_alpha_width(pll);
+	u32 l, alpha_width = pll_alpha_width(pll);
 	u64 a;
 	unsigned long rrate;
-	int ret = 0;
-
-	ret = regmap_read(pll->clkr.regmap, PLL_MODE(pll), &val);
-	if (ret)
-		return ret;
 
 	rrate = alpha_pll_round_rate(rate, prate, &l, &a, alpha_width);
 

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

maintainer Applied
#2 lore raw

Re: [PATCH v2 1/8] clk: qcom: alpha-pll: Remove useless read from set rate

Quoting Taniya Das (2019-11-15 02:04:57)

Quoted 4 lines

PLL_MODE read in fabia set rate is not required, thus remove the same.

---

Applied to clk-next

author
#3 lore raw

PATCH v2 2/8 clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration

In reply to Taniya Das

In the cases where the PLL is not calibrated the PLL could fail to lock. Add support for prepare ops which would take care of the same.

Fabia PLL user/test control registers might required to be configured, so add support for configuring them.

---
 drivers/clk/qcom/clk-alpha-pll.c | 76 ++++++++++++++++++++++++++++++++++++++++
 drivers/clk/qcom/clk-alpha-pll.h |  4 +++
 2 files changed, 80 insertions(+)
drivers/clk/qcom/clk-alpha-pll.c +76 -0
index e39034d..15ddcfe 100644
@@ -1024,6 +1024,25 @@ void clk_fabia_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap,
 		regmap_write(regmap, PLL_CONFIG_CTL(pll),
 						config->config_ctl_val);
 
+	if (config->config_ctl_hi_val)
+		regmap_write(regmap, PLL_CONFIG_CTL_U(pll),
+						config->config_ctl_hi_val);
+
+	if (config->user_ctl_val)
+		regmap_write(regmap, PLL_USER_CTL(pll), config->user_ctl_val);
+
+	if (config->user_ctl_hi_val)
+		regmap_write(regmap, PLL_USER_CTL_U(pll),
+						config->user_ctl_hi_val);
+
+	if (config->test_ctl_val)
+		regmap_write(regmap, PLL_TEST_CTL(pll),
+						config->test_ctl_val);
+
+	if (config->test_ctl_hi_val)
+		regmap_write(regmap, PLL_TEST_CTL_U(pll),
+						config->test_ctl_hi_val);
+
 	if (config->post_div_mask) {
 		mask = config->post_div_mask;
 		val = config->post_div_val;
@@ -1162,7 +1181,64 @@ static int alpha_pll_fabia_set_rate(struct clk_hw *hw, unsigned long rate,
 	return __clk_alpha_pll_update_latch(pll);
 }
 
+static int alpha_pll_fabia_prepare(struct clk_hw *hw)
+{
+	struct clk_alpha_pll *pll = to_clk_alpha_pll(hw);
+	const struct pll_vco *vco;
+	struct clk_hw *parent_hw;
+	unsigned long cal_freq, rrate;
+	u32 cal_l, val, alpha_width = pll_alpha_width(pll);
+	u64 a;
+	int ret;
+
+	/* Check if calibration needs to be done i.e. PLL is in reset */
+	ret = regmap_read(pll->clkr.regmap, PLL_MODE(pll), &val);
+	if (ret)
+		return ret;
+
+	/* Return early if calibration is not needed. */
+	if (val & PLL_RESET_N)
+		return 0;
+
+	vco = alpha_pll_find_vco(pll, clk_hw_get_rate(hw));
+	if (!vco) {
+		pr_err("alpha pll: not in a valid vco range\n");
+		return -EINVAL;
+	}
+
+	cal_freq = DIV_ROUND_CLOSEST((pll->vco_table[0].min_freq +
+				pll->vco_table[0].max_freq) * 54, 100);
+
+	parent_hw = clk_hw_get_parent(hw);
+	if (!parent_hw)
+		return -EINVAL;
+
+	rrate = alpha_pll_round_rate(cal_freq, clk_hw_get_rate(parent_hw),
+					&cal_l, &a, alpha_width);
+	/*
+	 * Due to a limited number of bits for fractional rate programming, the
+	 * rounded up rate could be marginally higher than the requested rate.
+	 */
+	if (rrate > (cal_freq + FABIA_PLL_RATE_MARGIN) || rrate < cal_freq)
+		return -EINVAL;
+
+	/* Setup PLL for calibration frequency */
+	regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l);
+
+	/* Bringup the PLL at calibration frequency */
+	ret = clk_alpha_pll_enable(hw);
+	if (ret) {
+		pr_err("alpha pll calibration failed\n");
+		return ret;
+	}
+
+	clk_alpha_pll_disable(hw);
+
+	return 0;
+}
+
 const struct clk_ops clk_alpha_pll_fabia_ops = {
+	.prepare = alpha_pll_fabia_prepare,
 	.enable = alpha_pll_fabia_enable,
 	.disable = alpha_pll_fabia_disable,
 	.is_enabled = clk_alpha_pll_is_enabled,
drivers/clk/qcom/clk-alpha-pll.h +4 -0
index 15f27f4..b03eea0 100644
@@ -94,6 +94,10 @@ struct alpha_pll_config {
 	u32 alpha_hi;
 	u32 config_ctl_val;
 	u32 config_ctl_hi_val;
+	u32 user_ctl_val;
+	u32 user_ctl_hi_val;
+	u32 test_ctl_val;
+	u32 test_ctl_hi_val;
 	u32 main_output_mask;
 	u32 aux_output_mask;
 	u32 aux2_output_mask;

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

maintainer Applied
#4 lore raw

Re: [PATCH v2 2/8] clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration

Quoting Taniya Das (2019-11-15 02:04:58)

Quoted 8 lines

In the cases where the PLL is not calibrated the PLL could fail to lock. Add support for prepare ops which would take care of the same.

Fabia PLL user/test control registers might required to be configured, so add support for configuring them.

---

Applied to clk-next

author
#5 lore raw

PATCH v2 3/8 dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings

In reply to Taniya Das

The GPUCC clock provider have a bunch of generic properties that are needed in a device tree. Add a YAML schemas for those.

---
 .../devicetree/bindings/clock/qcom,gpucc.txt       | 24 --------
 .../devicetree/bindings/clock/qcom,gpucc.yaml      | 69 ++++++++++++++++++++++
 2 files changed, 69 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
Documentation/devicetree/bindings/clock/qcom,gpucc.txt deleted +0 -24
deleted file mode 100644
index 269afe8a..0000000
@@ -1,24 +0,0 @@
-Qualcomm Graphics Clock & Reset Controller Binding
---------------------------------------------------
-
-Required properties :
-- compatible : shall contain "qcom,sdm845-gpucc" or "qcom,msm8998-gpucc"
-- reg : shall contain base register location and length
-- #clock-cells : from common clock binding, shall contain 1
-- #reset-cells : from common reset binding, shall contain 1
-- #power-domain-cells : from generic power domain binding, shall contain 1
-- clocks : shall contain the XO clock
-	   shall contain the gpll0 out main clock (msm8998)
-- clock-names : shall be "xo"
-		shall be "gpll0" (msm8998)
-
-Example:
-	gpucc: clock-controller@5090000 {
-		compatible = "qcom,sdm845-gpucc";
-		reg = <0x5090000 0x9000>;
-		#clock-cells = <1>;
-		#reset-cells = <1>;
-		#power-domain-cells = <1>;
-		clocks = <&rpmhcc RPMH_CXO_CLK>;
-		clock-names = "xo";
-	};
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +69 -0

69 lines not on this page · raw message

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

#6 lore raw

Re: [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings

Quoted 65 lines · Taniya Das

The GPUCC clock provider have a bunch of generic properties that are needed in a device tree. Add a YAML schemas for those.

---
 .../devicetree/bindings/clock/qcom,gpucc.txt       | 24 --------
 .../devicetree/bindings/clock/qcom,gpucc.yaml      | 69 ++++++++++++++++++++++
 2 files changed, 69 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
Documentation/devicetree/bindings/clock/qcom,gpucc.txt deleted +0 -24
deleted file mode 100644
index 269afe8a..0000000
@@ -1,24 +0,0 @@
-Qualcomm Graphics Clock & Reset Controller Binding
---------------------------------------------------
-
-Required properties :
-- compatible : shall contain "qcom,sdm845-gpucc" or "qcom,msm8998-gpucc"
-- reg : shall contain base register location and length
-- #clock-cells : from common clock binding, shall contain 1
-- #reset-cells : from common reset binding, shall contain 1
-- #power-domain-cells : from generic power domain binding, shall contain 1
-- clocks : shall contain the XO clock
-          shall contain the gpll0 out main clock (msm8998)
-- clock-names : shall be "xo"
-               shall be "gpll0" (msm8998)
-
-Example:
-       gpucc: clock-controller@5090000 {
-               compatible = "qcom,sdm845-gpucc";
-               reg = <0x5090000 0x9000>;
-               #clock-cells = <1>;
-               #reset-cells = <1>;
-               #power-domain-cells = <1>;
-               clocks = <&rpmhcc RPMH_CXO_CLK>;
-               clock-names = "xo";
-       };
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +17 -0
new file mode 100644
index 0000000..c2d6243
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bindings/clock/qcom,gpucc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Graphics Clock & Reset Controller Binding
+
+maintainers:
+  - Taniya Das <[email protected]>
+
+description: |
+  Qualcomm grpahics clock control module which supports the clocks, resets and
+  power domains.
+
+properties:
+  compatible:

Documentation/devicetree/bindings/clock/qcom,gpucc.yaml line 27

Quoted 10 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +10 -0
+    enum:
+      - qcom,msm8998-gpucc
+      - qcom,sdm845-gpucc
+
+  clocks:
+    minItems: 1
+    maxItems: 2
+    items:
+      - description: Board XO source
+      - description: GPLL0 source from GCC

This is not an accurate conversion. GPLL0 was not valid for 845, and is required for 8998.

Quoted 46 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +42 -1
+
+  clock-names:
+    minItems: 1
+    maxItems: 2
+    items:
+      - const: xo
+      - const: gpll0
+
+  '#clock-cells':
+    const: 1
+
+  '#reset-cells':
+    const: 1
+
+  '#power-domain-cells':
+    const: 1
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - '#clock-cells'
+  - '#reset-cells'
+  - '#power-domain-cells'
+
+examples:
+  # Example of GPUCC with clock node properties for SDM845:
+  - |
+    clock-controller@5090000 {
+      compatible = "qcom,sdm845-gpucc";
+      reg = <0x5090000 0x9000>;
+      clocks = <&rpmhcc 0>, <&gcc 32>;
+      clock-names = "xo", "gpll0";
+      #clock-cells = <1>;
+      #reset-cells = <1>;
+      #power-domain-cells = <1>;
+     };
+...
--

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

maintainer
#7 lore raw

Re: [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings

Quoting Jeffrey Hugo (2019-11-15 07:11:01)

Quoted 29 lines · Taniya Das
Quoted 28 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +22 -0
new file mode 100644
index 0000000..c2d6243
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bindings/clock/qcom,gpucc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Graphics Clock & Reset Controller Binding
+
+maintainers:
+  - Taniya Das <[email protected]>
+
+description: |
+  Qualcomm grpahics clock control module which supports the clocks, resets and
+  power domains.
+
+properties:
+  compatible:
+    enum:
+      - qcom,msm8998-gpucc
+      - qcom,sdm845-gpucc
+
+  clocks:
Quoted 8 lines

Documentation/devicetree/bindings/clock/qcom,gpucc.yaml line 27

Quoted 5 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +5 -0
+    minItems: 1
+    maxItems: 2
+    items:
+      - description: Board XO source
+      - description: GPLL0 source from GCC

This is not an accurate conversion. GPLL0 was not valid for 845, and is required for 8998.

Thanks for checking Jeff.

It looks like on 845 there are two gpll0 clocks going to gpucc. From gpu_cc_parent_map_0:

	"gcc_gpu_gpll0_clk_src",
	"gcc_gpu_gpll0_div_clk_src",
author
#8 lore raw

Re: [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings

Quoted 39 lines · Stephen Boyd

Quoting Jeffrey Hugo (2019-11-15 07:11:01)

Quoted 29 lines · Taniya Das
Quoted 28 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +22 -0
new file mode 100644
index 0000000..c2d6243
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bindings/clock/qcom,gpucc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Graphics Clock & Reset Controller Binding
+
+maintainers:
+  - Taniya Das <[email protected]>
+
+description: |
+  Qualcomm grpahics clock control module which supports the clocks, resets and
+  power domains.
+
+properties:
+  compatible:
+    enum:
+      - qcom,msm8998-gpucc
+      - qcom,sdm845-gpucc
+
+  clocks:
Quoted 8 lines

Documentation/devicetree/bindings/clock/qcom,gpucc.yaml line 27

Quoted 5 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +5 -0
+    minItems: 1
+    maxItems: 2
+    items:
+      - description: Board XO source
+      - description: GPLL0 source from GCC

This is not an accurate conversion. GPLL0 was not valid for 845, and is required for 8998.

Quoted 8 lines

Thanks for checking Jeff.

It looks like on 845 there are two gpll0 clocks going to gpucc. From gpu_cc_parent_map_0:

	"gcc_gpu_gpll0_clk_src",
	"gcc_gpu_gpll0_div_clk_src",

There are branches of GPLL0 which would be connected to most external CCs. It is upto to the external CCs to either use them to source a frequency or not.

Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--
maintainer
#9 lore raw

Re: [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings

Quoting Taniya Das (2019-11-26 20:06:49)

Quoted 20 lines · Stephen Boyd
Quoted 17 lines

Quoting Jeffrey Hugo (2019-11-15 07:11:01)

Quoted 10 lines · Taniya Das

Documentation/devicetree/bindings/clock/qcom,gpucc.yaml line 27

Quoted 6 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +1 -0
new file mode 100644
index 0000000..c2d6243
+      - description: GPLL0 source from GCC

This is not an accurate conversion. GPLL0 was not valid for 845, and is required for 8998.

Thanks for checking Jeff.

It looks like on 845 there are two gpll0 clocks going to gpucc. From gpu_cc_parent_map_0:

Quoted 7 lines
Quoted 3 lines
      "gcc_gpu_gpll0_clk_src",
      "gcc_gpu_gpll0_div_clk_src",

There are branches of GPLL0 which would be connected to most external CCs. It is upto to the external CCs to either use them to source a frequency or not.

Yes, they can decide to use them or not, but they really do go to the CCs so the DT should describe that.

author
#10 lore raw

Re: [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings

Hello Stephen,

Quoted 25 lines · Stephen Boyd

Quoting Taniya Das (2019-11-26 20:06:49)

Quoted 24 lines · Stephen Boyd
Quoted 20 lines

Quoting Jeffrey Hugo (2019-11-15 07:11:01)

Quoted 10 lines · Taniya Das

Documentation/devicetree/bindings/clock/qcom,gpucc.yaml line 27

Quoted 6 lines
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml new file +1 -0
new file mode 100644
index 0000000..c2d6243
+      - description: GPLL0 source from GCC

This is not an accurate conversion. GPLL0 was not valid for 845, and is required for 8998.

Thanks for checking Jeff.

It looks like on 845 there are two gpll0 clocks going to gpucc. From gpu_cc_parent_map_0:

       "gcc_gpu_gpll0_clk_src",
       "gcc_gpu_gpll0_div_clk_src",
Quoted 7 lines
Quoted 3 lines

There are branches of GPLL0 which would be connected to most external CCs. It is upto to the external CCs to either use them to source a frequency or not.

Yes, they can decide to use them or not, but they really do go to the CCs so the DT should describe that.

Documentation is updated with both the GPLL0 branches now.

Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--
author
#11 lore raw

PATCH v2 4/8 dt-bindings: clock: Introduce QCOM Graphics clock bindings

In reply to Taniya Das

Add device tree bindings for graphics clock controller for Qualcomm Technology Inc's SC7180 SoCs.

---
 .../devicetree/bindings/clock/qcom,gpucc.yaml       |  1 +
 include/dt-bindings/clock/qcom,gpucc-sc7180.h       | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 include/dt-bindings/clock/qcom,gpucc-sc7180.h
Documentation/devicetree/bindings/clock/qcom,gpucc.yaml +1 -0
index c2d6243..7486368 100644
@@ -17,6 +17,7 @@ properties:
   compatible:
     enum:
       - qcom,msm8998-gpucc
+      - qcom,sc7180-gpucc
       - qcom,sdm845-gpucc
 
   clocks:
include/dt-bindings/clock/qcom,gpucc-sc7180.h new file +21 -0
new file mode 100644
index 0000000..0e4643b
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_CLK_QCOM_GPU_CC_SC7180_H
+#define _DT_BINDINGS_CLK_QCOM_GPU_CC_SC7180_H
+
+#define GPU_CC_PLL1			0
+#define GPU_CC_AHB_CLK			1
+#define GPU_CC_CRC_AHB_CLK		2
+#define GPU_CC_CX_GMU_CLK		3
+#define GPU_CC_CX_SNOC_DVM_CLK		4
+#define GPU_CC_CXO_AON_CLK		5
+#define GPU_CC_CXO_CLK			6
+#define GPU_CC_GMU_CLK_SRC		7
+
+/* CAM_CC GDSCRs */
+#define CX_GDSC				0
+
+#endif

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

author
#12 lore raw

PATCH v2 5/8 clk: qcom: Add graphics clock controller driver for SC7180

In reply to Taniya Das

Add support for the graphics clock controller found on SC7180 based devices. This would allow graphics drivers to probe and control their clocks.

---
 drivers/clk/qcom/Kconfig        |   8 ++
 drivers/clk/qcom/Makefile       |   1 +
 drivers/clk/qcom/gpucc-sc7180.c | 266 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 275 insertions(+)
 create mode 100644 drivers/clk/qcom/gpucc-sc7180.c
drivers/clk/qcom/Kconfig +8 -0
index 3b33ef1..e648a60 100644
@@ -245,6 +245,14 @@ config SC_GCC_7180
 	  Say Y if you want to use peripheral devices such as UART, SPI,
 	  I2C, USB, UFS, SDCC, etc.
 
+config SC_GPUCC_7180
+	tristate "SC7180 Graphics Clock Controller"
+	select SC_GCC_7180
+	help
+	  Support for the graphics clock controller on SC7180 devices.
+	  Say Y if you want to support graphics controller devices and
+	  functionality such as 3D graphics.
+
 config SDM_CAMCC_845
 	tristate "SDM845 Camera Clock Controller"
 	select SDM_GCC_845
drivers/clk/qcom/Makefile +1 -0
index d899661..5477482 100644
@@ -46,6 +46,7 @@ obj-$(CONFIG_QCS_GCC_404) += gcc-qcs404.o
 obj-$(CONFIG_QCS_Q6SSTOP_404) += q6sstop-qcs404.o
 obj-$(CONFIG_QCS_TURING_404) += turingcc-qcs404.o
 obj-$(CONFIG_SC_GCC_7180) += gcc-sc7180.o
+obj-$(CONFIG_SC_GPUCC_7180) += gpucc-sc7180.o
 obj-$(CONFIG_SDM_CAMCC_845) += camcc-sdm845.o
 obj-$(CONFIG_SDM_DISPCC_845) += dispcc-sdm845.o
 obj-$(CONFIG_SDM_GCC_660) += gcc-sdm660.o
drivers/clk/qcom/gpucc-sc7180.c new file +266 -0

266 lines not on this page · raw message

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

author
#13 lore raw

PATCH v2 6/8 dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings

In reply to Taniya Das

The VIDEOCC clock provider have a bunch of generic properties that are needed in a device tree. Add a YAML schemas for those.

---
 .../devicetree/bindings/clock/qcom,videocc.txt     | 18 -------
 .../devicetree/bindings/clock/qcom,videocc.yaml    | 61 ++++++++++++++++++++++
 2 files changed, 61 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/qcom,videocc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,videocc.yaml
Documentation/devicetree/bindings/clock/qcom,videocc.txt deleted +0 -18
deleted file mode 100644
index 8a8622c..0000000
@@ -1,18 +0,0 @@
-Qualcomm Video Clock & Reset Controller Binding
------------------------------------------------
-
-Required properties :
-- compatible : shall contain "qcom,sdm845-videocc"
-- reg : shall contain base register location and length
-- #clock-cells : from common clock binding, shall contain 1.
-- #power-domain-cells : from generic power domain binding, shall contain 1.
-- #reset-cells : from common reset binding, shall contain 1.
-
-Example:
-	videocc: clock-controller@ab00000 {
-		compatible = "qcom,sdm845-videocc";
-		reg = <0xab00000 0x10000>;
-		#clock-cells = <1>;
-		#power-domain-cells = <1>;
-		#reset-cells = <1>;
-	};
Documentation/devicetree/bindings/clock/qcom,videocc.yaml new file +61 -0

61 lines not on this page · raw message

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

author
#14 lore raw

PATCH v2 7/8 dt-bindings: clock: Introduce QCOM Video clock bindings

In reply to Taniya Das

Add device tree bindings for video clock controller for Qualcomm Technology Inc's SC7180 SoCs.

---
 .../devicetree/bindings/clock/qcom,videocc.yaml    |  1 +
 include/dt-bindings/clock/qcom,videocc-sc7180.h    | 23 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 include/dt-bindings/clock/qcom,videocc-sc7180.h
Documentation/devicetree/bindings/clock/qcom,videocc.yaml +1 -0
index fc3fcca..43cfc89 100644
@@ -16,6 +16,7 @@ description: |
 properties:
   compatible:
     enum:
+      - qcom,sc7180-videocc
       - qcom,sdm845-videocc
 
   clocks:
include/dt-bindings/clock/qcom,videocc-sc7180.h new file +23 -0
new file mode 100644
index 0000000..7acaf13
@@ -0,0 +1,23 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_CLK_QCOM_VIDEO_CC_SC7180_H
+#define _DT_BINDINGS_CLK_QCOM_VIDEO_CC_SC7180_H
+
+/* VIDEO_CC clocks */
+#define VIDEO_PLL0				0
+#define VIDEO_CC_VCODEC0_AXI_CLK		1
+#define VIDEO_CC_VCODEC0_CORE_CLK		2
+#define VIDEO_CC_VENUS_AHB_CLK			3
+#define VIDEO_CC_VENUS_CLK_SRC			4
+#define VIDEO_CC_VENUS_CTL_AXI_CLK		5
+#define VIDEO_CC_VENUS_CTL_CORE_CLK		6
+#define VIDEO_CC_XO_CLK				7
+
+/* VIDEO_CC GDSCRs */
+#define VENUS_GDSC				0
+#define VCODEC0_GDSC				1
+
+#endif

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

maintainer Reviewed-by on v2 7/8
#15 lore raw

Re: [PATCH v2 7/8] dt-bindings: clock: Introduce QCOM Video clock bindings

Quoted 9 lines · Taniya Das

Add device tree bindings for video clock controller for Qualcomm Technology Inc's SC7180 SoCs.

---
 .../devicetree/bindings/clock/qcom,videocc.yaml    |  1 +
 include/dt-bindings/clock/qcom,videocc-sc7180.h    | 23 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 include/dt-bindings/clock/qcom,videocc-sc7180.h

Again, subject is misleading and needs SC7180 in it.

author
#16 lore raw

PATCH v2 8/8 clk: qcom: Add video clock controller driver for SC7180

In reply to Taniya Das

Add support for the video clock controller found on SC7180 based devices. This would allow video drivers to probe and control their clocks.

---
 drivers/clk/qcom/Kconfig          |   8 ++
 drivers/clk/qcom/Makefile         |   1 +
 drivers/clk/qcom/videocc-sc7180.c | 259 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 268 insertions(+)
 create mode 100644 drivers/clk/qcom/videocc-sc7180.c
drivers/clk/qcom/Kconfig +8 -0
index e648a60..cf21d5c 100644
@@ -253,6 +253,14 @@ config SC_GPUCC_7180
 	  Say Y if you want to support graphics controller devices and
 	  functionality such as 3D graphics.
 
+config SC_VIDEOCC_7180
+	tristate "SC7180 Video Clock Controller"
+	select SC_GCC_7180
+	help
+	  Support for the video clock controller on SC7180 devices.
+	  Say Y if you want to support video devices and functionality such as
+	  video encode and decode.
+
 config SDM_CAMCC_845
 	tristate "SDM845 Camera Clock Controller"
 	select SDM_GCC_845
drivers/clk/qcom/Makefile +1 -0
index 5477482..4cdd08f 100644
@@ -47,6 +47,7 @@ obj-$(CONFIG_QCS_Q6SSTOP_404) += q6sstop-qcs404.o
 obj-$(CONFIG_QCS_TURING_404) += turingcc-qcs404.o
 obj-$(CONFIG_SC_GCC_7180) += gcc-sc7180.o
 obj-$(CONFIG_SC_GPUCC_7180) += gpucc-sc7180.o
+obj-$(CONFIG_SC_VIDEOCC_7180) += videocc-sc7180.o
 obj-$(CONFIG_SDM_CAMCC_845) += camcc-sdm845.o
 obj-$(CONFIG_SDM_DISPCC_845) += dispcc-sdm845.o
 obj-$(CONFIG_SDM_GCC_660) += gcc-sdm660.o
drivers/clk/qcom/videocc-sc7180.c new file +259 -0

259 lines not on this page · raw message

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

maintainer
#17 lore raw

Re: [PATCH v2 8/8] clk: qcom: Add video clock controller driver for SC7180

Quoting Taniya Das (2019-11-15 02:05:04)

Quoted 11 lines
drivers/clk/qcom/videocc-sc7180.c new file +5 -0
new file mode 100644
index 0000000..0c60986
@@ -0,0 +1,259 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+

[...]

Quoted 8 lines
drivers/clk/qcom/videocc-sc7180.c new file +8 -0
+
+static int video_cc_sc7180_probe(struct platform_device *pdev)
+{
+       struct regmap *regmap;
+       struct alpha_pll_config video_pll0_config = {};
+
+       regmap = qcom_cc_map(pdev, &video_cc_sc7180_desc);
+       if (IS_ERR(regmap))

drivers/clk/qcom/videocc-sc7180.c line 232

Quoted 10 lines
drivers/clk/qcom/videocc-sc7180.c new file +10 -0
+               return PTR_ERR(regmap);
+
+       video_pll0_config.l = 0x1f;
+       video_pll0_config.alpha = 0x4000;
+       video_pll0_config.user_ctl_val = 0x00000001;
+       video_pll0_config.user_ctl_hi_val = 0x00004805;
+
+       clk_fabia_pll_configure(&video_pll0, regmap, &video_pll0_config);
+
+       /* video_cc_xo_clk */

Please say what's happening to video_cc_xo_clk.

Quoted 12 lines
drivers/clk/qcom/videocc-sc7180.c new file +12 -0
+       regmap_update_bits(regmap, 0x984, 0x1, 0x1);
+
+       return qcom_cc_really_probe(pdev, &video_cc_sc7180_desc, regmap);
+}
+
+static struct platform_driver video_cc_sc7180_driver = {
+       .probe = video_cc_sc7180_probe,
+       .driver = {
+               .name = "sc7180-videocc",
+               .of_match_table = video_cc_sc7180_match_table,
+       },
+};
author
#18 lore raw

Re: [PATCH v2 8/8] clk: qcom: Add video clock controller driver for SC7180

Hello Stephen,

Quoted 1 line · Stephen Boyd

Quoting Taniya Das (2019-11-15 02:05:04)

      clk_fabia_pll_configure(&video_pll0, regmap, &video_pll0_config);
Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+       /* video_cc_xo_clk */

Please say what's happening to video_cc_xo_clk.

Updated the next patch set with comment.

Quoted 2 lines
Quoted 2 lines
(quoted diff) +2 -0
+       regmap_update_bits(regmap, 0x984, 0x1, 0x1);
+
Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--
maintainer
#19 lore raw
In reply to Taniya Das

Quoting Taniya Das (2019-11-15 02:04:56)

Quoted 8 lines

[v2]
* Split Fabia code cleanup and calibration code.
* Few cleanups for GPU/Video CC are
* header file inclusion, const for pll vco table.
* removal of always enabled clock from gpucc.
* compatibles added in sorted order.
* move from core_initcall to subsys_initcall().
* cleanup clk_parent_data for clocks to be provided from DT.

Can you please resend with comments addressed?

author
#20 lore raw
Quoted 10 lines · Stephen Boyd

Quoting Taniya Das (2019-11-15 02:04:56)

Quoted 8 lines

[v2]
* Split Fabia code cleanup and calibration code.
* Few cleanups for GPU/Video CC are
* header file inclusion, const for pll vco table.
* removal of always enabled clock from gpucc.
* compatibles added in sorted order.
* move from core_initcall to subsys_initcall().
* cleanup clk_parent_data for clocks to be provided from DT.

Quoted 2 lines

Can you please resend with comments addressed?

Next patches are submitted for review.

Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--