pinctrl: sunrisepoint: Add missing Interrupt Status register offset
Subsystems (4)
PATCH 1/1 pinctrl: sunrisepoint: Add missing Interrupt Status register offset
Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status offset") removes default interrupt status offset of GPIO controllers, with previous commits explicitly providing the previously default offsets. However, the is_offset value in SPTH_COMMUNITY is missing, preventing related irq from being properly detected and handled.
--- drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/intel/pinctrl-sunrisepoint.c +1 -0
@@ -49,6 +49,7 @@ .padown_offset = SPT_PAD_OWN, \ .padcfglock_offset = SPT_PADCFGLOCK, \ .hostown_offset = SPT_HOSTSW_OWN, \ + .is_offset = SPT_GPI_IS, \ .ie_offset = SPT_GPI_IE, \ .pin_base = (s), \ .npins = ((e) - (s) + 1), \
Signature · 1 line
2.24.0
Quoted 10 lines · Boyan Ding
Commit
179e5a6114cc("pinctrl: intel: Remove default Interrupt Status offset") removes default interrupt status offset of GPIO controllers, with previous commits explicitly providing the previously default offsets. However, theis_offsetvalue inSPTH_COMMUNITYis missing, preventing related irq from being properly detected and handled.Fixes f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")Signed-off-by Boyan Ding <[email protected]>
Quoted 6 lines · Boyan Ding
Commit
179e5a6114cc("pinctrl: intel: Remove default Interrupt Status offset") removes default interrupt status offset of GPIO controllers, with previous commits explicitly providing the previously default offsets. However, theis_offsetvalue inSPTH_COMMUNITYis missing, preventing related irq from being properly detected and handled.
Pushed to my review and testing queue, thanks!
Quoted 23 lines
Fixes f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")Signed-off-by Boyan Ding <[email protected]>--- drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 1 + 1 file changed, 1 insertion(+)drivers/pinctrl/intel/pinctrl-sunrisepoint.c +1
-0@@ -49,6 +49,7 @@ .padown_offset = SPT_PAD_OWN, \ .padcfglock_offset = SPT_PADCFGLOCK, \ .hostown_offset = SPT_HOSTSW_OWN, \ + .is_offset = SPT_GPI_IS, \ .ie_offset = SPT_GPI_IE, \ .pin_base = (s), \ .npins = ((e) - (s) + 1), \Signature · 1 line
2.24.0
Signature · 2 lines
With Best Regards, Andy Shevchenko