Skip to contentSkip to conversation

pinctrl: sunrisepoint: Add missing Interrupt Status register offset

PATCH In review Boyan Ding 3 participants 3 messages Jan 1, 2020 – Jan 8, 2020

Subsystems (4)
lore
Share & tools
lore

Boyan Ding

author
#0 lore raw

PATCH 1/1 pinctrl: sunrisepoint: Add missing Interrupt Status register offset

Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status offset") removes default interrupt status offset of GPIO controllers, with previous commits explicitly providing the previously default offsets. However, the is_offset value in SPTH_COMMUNITY is missing, preventing related irq from being properly detected and handled.

Fixes f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")
---
 drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/intel/pinctrl-sunrisepoint.c +1 -0
index 44d7f50bbc82..d936e7aa74c4 100644
@@ -49,6 +49,7 @@
 		.padown_offset = SPT_PAD_OWN,		\
 		.padcfglock_offset = SPT_PADCFGLOCK,	\
 		.hostown_offset = SPT_HOSTSW_OWN,	\
+		.is_offset = SPT_GPI_IS,		\
 		.ie_offset = SPT_GPI_IE,		\
 		.pin_base = (s),			\
 		.npins = ((e) - (s) + 1),		\
Signature · 1 line
2.24.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Boyan Ding

Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status offset") removes default interrupt status offset of GPIO controllers, with previous commits explicitly providing the previously default offsets. However, the is_offset value in SPTH_COMMUNITY is missing, preventing related irq from being properly detected and handled.

Fixes f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")
#2 lore raw
In reply to Boyan Ding
Quoted 6 lines · Boyan Ding

Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status offset") removes default interrupt status offset of GPIO controllers, with previous commits explicitly providing the previously default offsets. However, the is_offset value in SPTH_COMMUNITY is missing, preventing related irq from being properly detected and handled.

Pushed to my review and testing queue, thanks!

Quoted 23 lines
Fixes f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")
---
 drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/intel/pinctrl-sunrisepoint.c +1 -0
index 44d7f50bbc82..d936e7aa74c4 100644
@@ -49,6 +49,7 @@
 		.padown_offset = SPT_PAD_OWN,		\
 		.padcfglock_offset = SPT_PADCFGLOCK,	\
 		.hostown_offset = SPT_HOSTSW_OWN,	\
+		.is_offset = SPT_GPI_IS,		\
 		.ie_offset = SPT_GPI_IE,		\
 		.pin_base = (s),			\
 		.npins = ((e) - (s) + 1),		\
Signature · 1 line
2.24.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko