readmirror feature (sysfs and in-memory only approach)
v2 cover readmirror feature (sysfs and in-memory only approach)
v2:
Mainly fixes the fs_devices::readmirror declaration type from atomic_t to u8. (Thanks Josef).
v1:
As of now we use only %pid method to read stripped mirrored data. So application's process id determines the stripe id to be read. This type of routing typically helps in a system with many small independent applications tying to read random data. On the other hand the %pid based read IO distribution policy is inefficient if there is a single application trying to read large data as because the overall disk bandwidth would remains under utilized.
One type of readmirror policy isn't good enough and other choices are routing the IO based on device's waitqueue or manual when we have a read-preferred device or a readmirror policy based on the target storage caching. So this patch-set introduces a framework where we could add more readmirror policies.
This policy is a filesystem wide policy as of now, and though the readmirror policy at the subvolume level is a novel approach as it provides maximum flexibility in the data center, but as of now its not practical to implement such a granularity as you can't really ensure reflinked extents will be read from the stripe of its desire and so there will be more limitations and it can be assessed separately.
The approach in this patch-set is sys interface with in-memory policy. And does not add any new readmirror type in this set, which can be add once we are ok with the framework. Also the default policy remains %pid.
Previous works:
----------------------------------------------------------------------
There were few RFCs [1] before, mainly to figure out storage (or in memory only) for the readmirror policy and the interface needed.
[1]
https://www.mail-archive.com/[email protected]/msg86368.html
https://lore.kernel.org/linux-btrfs/[email protected]/
https://lore.kernel.org/linux-btrfs/[email protected]/
https://patchwork.kernel.org/cover/10859213/
Mount -o:
In the first trial it was attempted to use the mount -o option to carry the readmirror policy, this is good for debugging which can make sure even the mount thread metadata tree blocks are read from the disk desired. It was very effective in testing radi1/raid10 write-holes.
Extended attribute:
As extended attribute is associated with the inode, to implement this there is bit of extended attribute abuse or else makes it mandatory to mount the rootid 5. Its messy unless readmirror policy is applied at the subvol level which is not possible as of now.
An item type:
The proposed patch was to create an item to hold the readmirror policy, it makes sense when compared to the abusive extended attribute approach but introduces a new item and so no backward compatibility.
-----------------------------------------------------------------------
Anand Jain (3):
btrfs: add readmirror type framework
btrfs: sysfs, add readmirror kobject
btrfs: sysfs, create by_pid readmirror attribute
fs/btrfs/sysfs.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/volumes.c | 16 +++++++++++- fs/btrfs/volumes.h | 9 +++++++ 3 files changed, 98 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.3.1
PATCH v2 1/3 btrfs: add readmirror type framework
As of now we use %pid method to read stripped mirrored data. So application's process id determines the stripe id to be read. This type of read IO routing typically helps in a system with many small independent applications tying to read random data. On the other hand the %pid based read IO distribution policy is inefficient if there is a single application trying to read large data and the overall disk bandwidth remains under utilized.
So this patch introduces a framework where we could add more readmirror policies, such as routing the IO based on device's wait-queue or manual when we have a read-preferred device or a policy based on the target storage caching.
---
v2: Declare fs_devices::readmirror as u8 instead of atomic_t
A small change in comment and change log wordings.
fs/btrfs/volumes.c | 16 +++++++++++++++- fs/btrfs/volumes.h | 8 ++++++++ 2 files changed, 23 insertions(+), 1 deletion(-)
fs/btrfs/volumes.c +15 -1
@@ -1162,6 +1162,8 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices, fs_devices->opened =1 ; fs_devices->latest_bdev = latest_dev->bdev; fs_devices->total_rw_bytes =0 ; +/* Set the default readmirror policy */ + fs_devices->readmirror =BTRFS_READMIRROR_DEFAULT ; out:return ret; }
@@ -5300,7 +5302,19 @@ static int find_live_mirror(struct btrfs_fs_info *fs_info, else num_stripes = map->num_stripes; - preferred_mirror = first + current->pid % num_stripes; +switch (fs_info->fs_devices->readmirror) { +case BTRFS_READMIRROR_BY_PID : + preferred_mirror = first + current->pid % num_stripes; +break ; +default : +/* +* Shouln't happen, just warn and use by_pid instead of failing. +*/ +btrfs_warn_rl (fs_info, +"unknown readmirror type %u, fallback to by_pid" , + fs_info->fs_devices->readmirror); + preferred_mirror = first + current->pid % num_stripes; + }if (dev_replace_is_ongoing && fs_info->dev_replace.cont_reading_from_srcdev_mode ==
fs/btrfs/volumes.h +8 -0
@@ -209,6 +209,12 @@ struct btrfs_device {BTRFS_DEVICE_GETSET_FUNCS (disk_total_bytes);BTRFS_DEVICE_GETSET_FUNCS (bytes_used); +/* readmirror_policy types */ +#define BTRFS_READMIRROR_DEFAULT BTRFS_READMIRROR_BY_PID +enum btrfs_readmirror_policy_type { +BTRFS_READMIRROR_BY_PID , +}; +struct btrfs_fs_devices {u8 fsid[BTRFS_FSID_SIZE ];/* FS specific uuid */ u8 metadata_uuid[BTRFS_FSID_SIZE ];
@@ -260,6 +266,8 @@ struct btrfs_fs_devices {struct kobject *devices_kobj;struct kobject *devinfo_kobj;struct completion kobj_unregister; + +u8 readmirror; };#define BTRFS_BIO_INLINE_CSUM_SIZE 64
Signature · 1 line
1.8.3.1
Re: [PATCH v2 1/3] btrfs: add readmirror type framework
Quoted 74 lines · Anand Jain
As of now we use %pid method to read stripped mirrored data. So application's process id determines the stripe id to be read. This type of read IO routing typically helps in a system with many small independent applications tying to read random data. On the other hand the %pid based read IO distribution policy is inefficient if there is a single application trying to read large data and the overall disk bandwidth remains under utilized.
So this patch introduces a framework where we could add more readmirror policies, such as routing the IO based on device's wait-queue or manual when we have a read-preferred device or a policy based on the target storage caching.
Signed-off-by Anand Jain <[email protected]>---
v2: Declarefs_devices::readmirroras u8 instead ofatomic_t
A small change in comment and change log wordings.fs/btrfs/volumes.c | 16 +++++++++++++++- fs/btrfs/volumes.h | 8 ++++++++ 2 files changed, 23 insertions(+), 1 deletion(-)fs/btrfs/volumes.c +15
-1@@ -1162,6 +1162,8 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices, fs_devices->opened =1 ; fs_devices->latest_bdev = latest_dev->bdev; fs_devices->total_rw_bytes =0 ; +/* Set the default readmirror policy */ + fs_devices->readmirror =BTRFS_READMIRROR_DEFAULT ; out:return ret; }@@ -5300,7 +5302,19 @@ static int find_live_mirror(struct btrfs_fs_info *fs_info, else num_stripes = map->num_stripes; - preferred_mirror = first + current->pid % num_stripes; +switch (fs_info->fs_devices->readmirror) { +case BTRFS_READMIRROR_BY_PID : + preferred_mirror = first + current->pid % num_stripes; +break ; +default : +/* +* Shouln't happen, just warn and use by_pid instead of failing. +*/ +btrfs_warn_rl (fs_info, +"unknown readmirror type %u, fallback to by_pid" , + fs_info->fs_devices->readmirror); + preferred_mirror = first + current->pid % num_stripes; + }if (dev_replace_is_ongoing && fs_info->dev_replace.cont_reading_from_srcdev_mode ==fs/btrfs/volumes.h +6
-0@@ -209,6 +209,12 @@ struct btrfs_device {BTRFS_DEVICE_GETSET_FUNCS (disk_total_bytes);BTRFS_DEVICE_GETSET_FUNCS (bytes_used); +/* readmirror_policy types */ +#define BTRFS_READMIRROR_DEFAULT BTRFS_READMIRROR_BY_PID +enum btrfs_readmirror_policy_type { +BTRFS_READMIRROR_BY_PID , +}; +struct btrfs_fs_devices {u8 fsid[BTRFS_FSID_SIZE ];/* FS specific uuid */ u8 metadata_uuid[BTRFS_FSID_SIZE ];
fs/btrfs/volumes.h struct btrfs_fs_devices { · line 270
Quoted 5 lines
fs/btrfs/volumes.h +2
-0@@ -260,6 +266,8 @@ struct btrfs_fs_devices {struct kobject *devices_kobj;struct kobject *devinfo_kobj;struct completion kobj_unregister; + +u8 readmirror;
The only valid values for this are the enum, so make this
enum btrfs_readmirror_policy_type readmirror;
Thanks,
Josef
Re: [PATCH v2 1/3] btrfs: add readmirror type framework
Quoted 82 lines · Josef Bacik
Quoted 73 lines · Anand Jain
As of now we use %pid method to read stripped mirrored data. So application's process id determines the stripe id to be read. This type of read IO routing typically helps in a system with many small independent applications tying to read random data. On the other hand the %pid based read IO distribution policy is inefficient if there is a single application trying to read large data and the overall disk bandwidth remains under utilized.
So this patch introduces a framework where we could add more readmirror policies, such as routing the IO based on device's wait-queue or manual when we have a read-preferred device or a policy based on the target storage caching.
Signed-off-by Anand Jain <[email protected]>---
v2: Declarefs_devices::readmirroras u8 instead ofatomic_tA small change in comment and change log wordings.
fs/btrfs/volumes.c| 16 +++++++++++++++-
fs/btrfs/volumes.h| 8 ++++++++2 files changed, 23 insertions(+), 1 deletion(-)fs/btrfs/volumes.c +2
-0@@ -1162,6 +1162,8 @@ static int open_fs_devices(structbtrfs_fs_devices *fs_devices, fs_devices->opened = 1; fs_devices->latest_bdev = latest_dev->bdev; fs_devices->total_rw_bytes = 0; + /* Set the default readmirror policy */ + fs_devices->readmirror = BTRFS_READMIRROR_DEFAULT;out:
return ret;
}fs/btrfs/volumes.c +0
-0@@ -5300,7 +5302,19 @@ static int find_live_mirror(struct btrfs_fs_info *fs_info,else
num_stripes=map->num_stripes;
-preferred_mirror= first +current->pid%num_stripes;
+ switch (fs_info->fs_devices->readmirror) {
+ caseBTRFS_READMIRROR_BY_PID:
+preferred_mirror= first +current->pid%num_stripes; + break;
+ default:
+ /*
+ * Shouln't happen, just warn and useby_pidinstead of failing. + */
+ btrfs_warn_rl(fs_info,
+ "unknown readmirror type %u, fallback toby_pid", +fs_info->fs_devices->readmirror);
+preferred_mirror= first +current->pid%num_stripes; + }
if (dev_replace_is_ongoing&&fs_info->dev_replace.cont_reading_from_srcdev_mode==fs/btrfs/volumes.h +6
-0@@ -209,6 +209,12 @@ struct btrfs_device { BTRFS_DEVICE_GETSET_FUNCS(disk_total_bytes); BTRFS_DEVICE_GETSET_FUNCS(bytes_used); +/* readmirror_policy types */ +#define BTRFS_READMIRROR_DEFAULT BTRFS_READMIRROR_BY_PID +enum btrfs_readmirror_policy_type { + BTRFS_READMIRROR_BY_PID, +}; + struct btrfs_fs_devices {u8 fsid[BTRFS_FSID_SIZE]; /* FS specific uuid */ u8 metadata_uuid[BTRFS_FSID_SIZE];
fs/btrfs/volumes.h struct btrfs_fs_devices { · line 270
Quoted 5 lines
fs/btrfs/volumes.h +2
-0@@ -260,6 +266,8 @@ struct btrfs_fs_devices { struct kobject *devices_kobj; struct kobject *devinfo_kobj; struct completion kobj_unregister; + + u8 readmirror;The only valid values for this are the enum, so make this
Quoted 1 line
enum
btrfs_readmirror_policy_typereadmirror;
Oh. Ok.
Thanks, Anand
Quoted 3 lines
Thanks,
Josef
Re: [PATCH v2 1/3] btrfs: add readmirror type framework
In reply to Anand JainQuoted 8 lines · Anand Jain
As of now we use %pid method to read stripped mirrored data. So application's process id determines the stripe id to be read. This type of read IO routing typically helps in a system with many small independent applications tying to read random data. On the other hand the %pid based read IO distribution policy is inefficient if there is a single application trying to read large data and the overall disk bandwidth remains under utilized.
Quoted 4 lines
So this patch introduces a framework where we could add more readmirror policies, such as routing the IO based on device's wait-queue or manual when we have a read-preferred device or a policy based on the target storage caching.
I think the idea is good but that it would be cleaner if the tunable was named read_policy rather than readmirror as it's more obvious that it contains a policy tunable.
Do you envisage allowing more than one policy to be active for a filesystem? If not, what about using the same structure as the CPU frequency and block IO schedulers with the format
#cat /sys/block/sda/queue/scheduler
noop [deadline] cfq
Such that btrfs would (eventually) have something like
#cat /sys/fs/btrfs/UUID/read_policyby_pid [user_defined_device] by_shortest_queue
And the policy would be changed by echo'ing the new policy name to the read_policy kobject.
Steve
Re: [PATCH v2 1/3] btrfs: add readmirror type framework
Quoted 9 lines · Steven Davies
Quoted 8 lines · Anand Jain
As of now we use %pid method to read stripped mirrored data. So application's process id determines the stripe id to be read. This type of read IO routing typically helps in a system with many small independent applications tying to read random data. On the other hand the %pid based read IO distribution policy is inefficient if there is a single application trying to read large data and the overall disk bandwidth remains under utilized.
Quoted 6 lines
Quoted 4 lines
So this patch introduces a framework where we could add more readmirror policies, such as routing the IO based on device's wait-queue or manual when we have a read-preferred device or a policy based on the target storage caching.
I think the idea is good but that it would be cleaner if the tunable was named
read_policyrather than readmirror as it's more obvious that it contains a policy tunable.
Um. 'read_policy' sounds good, but I hope it is clear enough to indicate that we are talking about read for only mirrored-chunks. Will rename to read_policy.
Quoted 10 lines
Do you envisage allowing more than one policy to be active for a filesystem? If not, what about using the same structure as the CPU frequency and block IO schedulers with the format
#cat
/sys/block/sda/queue/scheduler
noop [deadline] cfqSuch that btrfs would (eventually) have something like
#cat
/sys/fs/btrfs/UUID/read_policyby_pid[user_defined_device]by_shortest_queue
And in case of user_defined_device, the device for the read shall be specified in
cat /sys/fs/btrfs/UUID/devinfo/<devid>/read_preferred
0 = unset, 1 = set.
(devinfo patches are in the ML [1] open for comment)
[1]
[PATCH v3 4/4] btrfs: sysfs, add devid/dev_state kobject and attribute
Quoted 1 line
And the policy would be changed by echo'ing the new policy name to the
read_policykobject.
I like this approach, will change it to use this format.
Thanks, Anand
Quoted 1 line
Steve
Re: [PATCH v2 1/3] btrfs: add readmirror type framework
Quoted 8 lines · Anand Jain
Quoted 7 lines · Steven Davies
Quoted 4 lines · Anand Jain
So this patch introduces a framework where we could add more readmirror policies, such as routing the IO based on device's wait-queue or manual when we have a read-preferred device or a policy based on the target storage caching.
Quoted 5 lines
Quoted 1 line
I think the idea is good but that it would be cleaner if the tunable was named
read_policyrather than readmirror as it's more obvious that it contains a policy tunable.Um. '
read_policy' sounds good, but I hope it is clear enough to indicate that we are talking about read for only mirrored-chunks. Will rename toread_policy.
I think it would be obvious that the policy will only apply to mirrored chunks; after all, you can only read a chunk from a device that contains it.
Quoted 14 lines
Quoted 10 lines
Do you envisage allowing more than one policy to be active for a filesystem? If not, what about using the same structure as the CPU frequency and block IO schedulers with the format
#cat
/sys/block/sda/queue/scheduler
noop [deadline] cfqSuch that btrfs would (eventually) have something like
#cat
/sys/fs/btrfs/UUID/read_policyby_pid[user_defined_device]by_shortest_queueAnd in case of
user_defined_device, the device for the read shall be specified in
Quoted 7 lines
cat /sys/fs/btrfs/UUID/devinfo/<devid>/read_preferred
0 = unset, 1 = set.
(devinfo patches are in the ML [1] open for comment)
[1]
[PATCH v3 4/4] btrfs: sysfs, add devid/dev_state kobject and attribute
I remember seeing that patch and I think the approach is logical.
Steve
PATCH v3 1/3 btrfs: add readmirror type framework
In reply to Anand JainAs of now we use %pid method to read stripped mirrored data, so application's process id determines the stripe id to be read. This type of read IO routing typically helps in a system with many small independent applications tying to read random data. On the other hand the %pid based read IO distribution policy is inefficient if there is a single application trying to read large data as the overall disk bandwidth remains under utilized.
So this patch introduces a framework where we could add more readmirror policies, such as IO routing based on device's wait-queue or manual when we have a read-preferred device or a policy based on the target storage caching.
---
v3: Declare fs_devices::readmirror as enum btrfs_readmirror_policy_type
v2: Declare fs_devices::readmirror as u8 instead of atomic_t
A small change in comment and change log wordings.
fs/btrfs/volumes.c | 16 +++++++++++++++- fs/btrfs/volumes.h | 8 ++++++++ 2 files changed, 23 insertions(+), 1 deletion(-)
fs/btrfs/volumes.c +15 -1
@@ -1162,6 +1162,8 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices, fs_devices->opened =1 ; fs_devices->latest_bdev = latest_dev->bdev; fs_devices->total_rw_bytes =0 ; +/* Set the default readmirror policy */ + fs_devices->readmirror =BTRFS_READMIRROR_DEFAULT ; out:return ret; }
@@ -5300,7 +5302,19 @@ static int find_live_mirror(struct btrfs_fs_info *fs_info, else num_stripes = map->num_stripes; - preferred_mirror = first + current->pid % num_stripes; +switch (fs_info->fs_devices->readmirror) { +case BTRFS_READMIRROR_BY_PID : + preferred_mirror = first + current->pid % num_stripes; +break ; +default : +/* +* Shouln't happen, just warn and use by_pid instead of failing. +*/ +btrfs_warn_rl (fs_info, +"unknown readmirror type %u, fallback to by_pid" , + fs_info->fs_devices->readmirror); + preferred_mirror = first + current->pid % num_stripes; + }if (dev_replace_is_ongoing && fs_info->dev_replace.cont_reading_from_srcdev_mode ==
fs/btrfs/volumes.h +8 -0
@@ -209,6 +209,12 @@ BTRFS_DEVICE_GETSET_FUNCS(total_bytes);BTRFS_DEVICE_GETSET_FUNCS (disk_total_bytes);BTRFS_DEVICE_GETSET_FUNCS (bytes_used); +/* readmirror_policy types */ +#define BTRFS_READMIRROR_DEFAULT BTRFS_READMIRROR_BY_PID +enum btrfs_readmirror_policy_type { +BTRFS_READMIRROR_BY_PID , +}; +struct btrfs_fs_devices {u8 fsid[BTRFS_FSID_SIZE ];/* FS specific uuid */ u8 metadata_uuid[BTRFS_FSID_SIZE ];
@@ -260,6 +266,8 @@ struct btrfs_fs_devices {struct kobject *devices_kobj;struct kobject *devinfo_kobj;struct completion kobj_unregister; + +enum btrfs_readmirror_policy_type readmirror; };#define BTRFS_BIO_INLINE_CSUM_SIZE 64
Signature · 1 line
2.23.0
PATCH v2 2/3 btrfs: sysfs, add readmirror kobject
In reply to Anand JainAdd
/sys/fs/btrfs/UUID/readmirror
kobject so that we can add readmirror policies as attributes under it.
---
v2: Fix compile error fs_info::readmirror_kobj member not found. As its
fix in v1 went into patch 3/3 instead it should be here.
fs/btrfs/sysfs.c | 22 ++++++++++++++++++++++ fs/btrfs/volumes.h | 1 + 2 files changed, 23 insertions(+)
fs/btrfs/sysfs.c +22 -0
@@ -355,6 +355,10 @@ static ssize_t supported_checksums_show(struct kobject *kobj,#endif +static const struct attribute *btrfs_readmirror_attrs[] = { +NULL , +}; +static ssize_t btrfs_show_u64 (u64 *value_ptr,spinlock_t *lock,char *buf) {u64 val;
@@ -772,6 +776,13 @@ void btrfs_sysfs_remove_mounted(struct btrfs_fs_info *fs_info) {btrfs_reset_fs_info_ptr (fs_info); +if (fs_info->fs_devices->readmirror_kobj) { +sysfs_remove_files (fs_info->fs_devices->readmirror_kobj, + btrfs_readmirror_attrs); +kobject_del (fs_info->fs_devices->readmirror_kobj); +kobject_put (fs_info->fs_devices->readmirror_kobj); + } +if (fs_info->space_info_kobj) {sysfs_remove_files (fs_info->space_info_kobj, allocation_attrs);kobject_del (fs_info->space_info_kobj);
@@ -1224,6 +1235,17 @@ int btrfs_sysfs_add_mounted(struct btrfs_fs_info *fs_info)if (error) goto failure; + fs_devs->readmirror_kobj =kobject_create_and_add ("readmirror" , + &fs_devs->fsid_kobj); +if (!fs_devs->readmirror_kobj) { + error = -ENOMEM ; + goto failure; + } + error =sysfs_create_files (fs_devs->readmirror_kobj, + btrfs_readmirror_attrs); +if (error) + goto failure; +return 0 ; failure:btrfs_sysfs_remove_mounted (fs_info);
fs/btrfs/volumes.h +1 -0
@@ -268,6 +268,7 @@ struct btrfs_fs_devices {struct completion kobj_unregister;u8 readmirror; +struct kobject *readmirror_kobj; };#define BTRFS_BIO_INLINE_CSUM_SIZE 64
Signature · 1 line
1.8.3.1
PATCH v2 3/3 btrfs: sysfs, create by_pid readmirror attribute
In reply to Anand JainAdd existing %pid based readmirror policy as an attribute
/sys/fs/btrfs/UUID/readmirror/by_pid
When read, this returns 0 or 1. 1 indicates currently active policy. When written with 1, it sets by_pid as the current active policy and when written 0 it resets to the default readmirror policy, which as of now is pid as well. For any other value returns EINVAL.
---
v2: fs_devs::readmirror is no more atomic_t so update accordingly.
fs/btrfs/sysfs.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+)
fs/btrfs/sysfs.c +52 -0
@@ -355,7 +355,59 @@ static ssize_t supported_checksums_show(struct kobject *kobj,#endif +#define readmirror_to_fs_devices (_kobj) to_fs_devs((_kobj)->parent) +/* +* Set the readmirror type to BTRFS_READMIRROR_BY_PID +*/ +static ssize_t btrfs_sysfs_readmirror_by_pid_store (struct kobject *kobj, +struct kobj_attribute *a, +const char *buf,size_t count) +{ +int ret; +unsigned long val; +struct btrfs_fs_devices *fs_devices; + + fs_devices =readmirror_to_fs_devices (kobj); + + ret =kstrtoul (skip_spaces (buf),0 , &val); +if (ret) +return ret; + +switch (val) { +case 0 : + fs_devices->readmirror =BTRFS_READMIRROR_DEFAULT ; +break ; +case 1 : + fs_devices->readmirror =BTRFS_READMIRROR_BY_PID ; +break ; +default : +return -EINVAL ; + } + +return count; +} + +static ssize_t btrfs_sysfs_readmirror_by_pid_show (struct kobject *kobj, +struct kobj_attribute *a, +char *buf) +{ +int val; +struct btrfs_fs_devices *fs_devices; + + fs_devices =readmirror_to_fs_devices (kobj); + +if (fs_devices->readmirror ==BTRFS_READMIRROR_BY_PID ) + val =1 ; +else + val =0 ; + +return snprintf (buf,PAGE_SIZE ,"%d\n" , val); +} +BTRFS_ATTR_RW (readmirror, by_pid, btrfs_sysfs_readmirror_by_pid_show, + btrfs_sysfs_readmirror_by_pid_store); +static const struct attribute *btrfs_readmirror_attrs[] = { +BTRFS_ATTR_PTR (readmirror, by_pid),NULL , };
Signature · 1 line
1.8.3.1